September 2023 - gerrit-log - lists.osmocom.org

[M] Change in osmo-ttcn3-hacks[master]: BTS_Tests: add TC_data_rtp_tch* for CSD
by laforge 04 Sep '23

04 Sep '23

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33072?usp=email ) Change subject: BTS_Tests: add TC_data_rtp_tch* for CSD ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33072?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9a0dc0fcf722f862d8dcf04660d4448662210f44 Gerrit-Change-Number: 33072 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 04 Sep 2023 20:21:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-ttcn3-hacks[master]: BTS_Tests: decouple payload generation from f_rtpem_activate()
by laforge 04 Sep '23

04 Sep '23

Attention is currently required from: fixeria, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34278?usp=email ) Change subject: BTS_Tests: decouple payload generation from f_rtpem_activate() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34278?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9e823c33b1dbbadd57bc63df25b8ddf368d76232 Gerrit-Change-Number: 34278 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 04 Sep 2023 20:21:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: BTS_Tests: f_rtpem_activate(): make RTP payload type configurable
by laforge 04 Sep '23

04 Sep '23

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34277?usp=email ) Change subject: BTS_Tests: f_rtpem_activate(): make RTP payload type configurable ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34277?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I84f576f578ffc48c8b5e545bc1700000eb693efb Gerrit-Change-Number: 34277 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 04 Sep 2023 20:21:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: library: RTP_Emulation: implement new RTPEM_MODE_LOOPBACK
by laforge 04 Sep '23

04 Sep '23

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34276?usp=email ) Change subject: library: RTP_Emulation: implement new RTPEM_MODE_LOOPBACK ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34276?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iee8f736e1eebc357fc997353ee4b629d24dc09e7 Gerrit-Change-Number: 34276 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 04 Sep 2023 20:21:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libosmo-sccp[master]: ipa: use LSBs of file descriptor as SLS in IPA->M3UA direction
by laforge 04 Sep '23

04 Sep '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/34264?usp=email ) Change subject: ipa: use LSBs of file descriptor as SLS in IPA->M3UA direction ...................................................................... ipa: use LSBs of file descriptor as SLS in IPA->M3UA direction when IPA/SCCPlite traffic traverses the osmo_ss7 stack, so far the SLS of the MTP3 label was always set to 0 (default initialization). However, in order to achieve a better distribution of signaling traffic in SS7 networks that actually utilize the SLS to select any links (or ASPs), it makes sense to use non-zero values. Instead of introducing some kind of new, configurable attribute for each ASP (IPA client connection), let's simply use the lower 4 bits of the file descriptor integer. Those file descriptors should have a roughly equal distribution, resulting in traffic (from multiple IPA clients) to be spread across the 4-bit SLS number space. Also, this mechanism ensures that traffic from one IPA client will always get the same SLS and hence routed the same way in any underlying CS7/SS7 network. Change-Id: Ice7bab997b84cfed00c7d6d780c70f4e9fac6002 Related: SYS#6543 --- M src/ipa.c M src/osmo_ss7.c M src/xua_internal.h 3 files changed, 35 insertions(+), 6 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved fixeria: Looks good to me, but someone else must approve diff --git a/src/ipa.c b/src/ipa.c index 8daa5e0..a77d331 100644 --- a/src/ipa.c +++ b/src/ipa.c @@ -211,7 +211,7 @@ return sccp_msg_out; } -static int ipa_rx_msg_sccp(struct osmo_ss7_asp *asp, struct msgb *msg) +static int ipa_rx_msg_sccp(struct osmo_ss7_asp *asp, struct msgb *msg, uint8_t sls) { int rc; struct m3ua_data_hdr data_hdr; @@ -276,6 +276,7 @@ data_hdr.si = MTP_SI_SCCP; data_hdr.opc = osmo_htonl(opc); data_hdr.dpc = osmo_htonl(dpc); + data_hdr.sls = sls; data_hdr.ni = as->inst->cfg.network_indicator; /* Create M3UA message in XUA structure */ xua = m3ua_xfer_from_data(&data_hdr, msgb_l2(msg), msgb_l2len(msg)); @@ -292,8 +293,9 @@ /*! \brief process M3UA message received from socket * \param[in] asp Application Server Process receiving \a msg * \param[in] msg received message buffer. Callee takes ownership! + * \param[in] sls The SLS (signaling link selector) field to use in the generated M3UA header * \returns 0 on success; negative on error */ -int ipa_rx_msg(struct osmo_ss7_asp *asp, struct msgb *msg) +int ipa_rx_msg(struct osmo_ss7_asp *asp, struct msgb *msg, uint8_t sls) { struct ipaccess_head *hh; int rc; @@ -309,7 +311,7 @@ rc = ipa_rx_msg_ccm(asp, msg); break; case IPAC_PROTO_SCCP: - rc = ipa_rx_msg_sccp(asp, msg); + rc = ipa_rx_msg_sccp(asp, msg, sls); break; default: rc = ss7_asp_rx_unknown(asp, hh->proto, msg); diff --git a/src/osmo_ss7.c b/src/osmo_ss7.c index b8124d1..440014a 100644 --- a/src/osmo_ss7.c +++ b/src/osmo_ss7.c @@ -2046,7 +2046,7 @@ } msg->dst = asp; - return ipa_rx_msg(asp, msg); + return ipa_rx_msg(asp, msg, ofd->fd & 0xf); } /* netif code tells us we can read something from the socket */ @@ -2194,7 +2194,7 @@ } msg->dst = asp; rate_ctr_inc2(asp->ctrg, SS7_ASP_CTR_PKT_RX_TOTAL); - return ipa_rx_msg(asp, msg); + return ipa_rx_msg(asp, msg, ofd->fd & 0xf); } static int xua_cli_read_cb(struct osmo_stream_cli *conn) diff --git a/src/xua_internal.h b/src/xua_internal.h index 26cb3fc..93f6140 100644 --- a/src/xua_internal.h +++ b/src/xua_internal.h @@ -116,7 +116,7 @@ const struct xua_msg_part *rctx_ie); int ipa_tx_xua_as(struct osmo_ss7_as *as, struct xua_msg *xua); -int ipa_rx_msg(struct osmo_ss7_asp *asp, struct msgb *msg); +int ipa_rx_msg(struct osmo_ss7_asp *asp, struct msgb *msg, uint8_t sls); int osmo_isup_party_parse(char *out_digits, const uint8_t *in, unsigned int in_num_bytes, bool odd); -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/34264?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Ice7bab997b84cfed00c7d6d780c70f4e9fac6002 Gerrit-Change-Number: 34264 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in libosmo-sccp[master]: m3ua: Add some TODO comments on where we fall short of our potential
by laforge 04 Sep '23

04 Sep '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/34273?usp=email ) Change subject: m3ua: Add some TODO comments on where we fall short of our potential ...................................................................... m3ua: Add some TODO comments on where we fall short of our potential Change-Id: I75d7b8f3fb6a06f6941b6dff4072287fdbb1d33e --- M src/m3ua.c M src/xua_as_fsm.c 2 files changed, 15 insertions(+), 2 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/m3ua.c b/src/m3ua.c index 85ac974..f4dbf76 100644 --- a/src/m3ua.c +++ b/src/m3ua.c @@ -462,9 +462,11 @@ return NULL; } - if (xua->hdr.msg_class == M3UA_MSGC_XFER) + if (xua->hdr.msg_class == M3UA_MSGC_XFER) { + /* TODO: M3UA RFC says that multiple different streams within the SCTP association + * *may* be used, for example, by using the SLS value. Not required but makes sense. */ msgb_sctp_stream(msg) = 1; - else + } else msgb_sctp_stream(msg) = 0; msgb_sctp_ppid(msg) = M3UA_PPID; diff --git a/src/xua_as_fsm.c b/src/xua_as_fsm.c index 2b16139..e239c74 100644 --- a/src/xua_as_fsm.c +++ b/src/xua_as_fsm.c @@ -158,6 +158,8 @@ asp = xua_as_select_asp_override(as); break; case OSMO_SS7_AS_TMOD_LOADSHARE: + /* TODO: actually use the SLS value to ensure same SLS goes through same ASP. Not + * strictly required by M3UA RFC, but would fit the overall principle. */ case OSMO_SS7_AS_TMOD_ROUNDROBIN: asp = xua_as_select_asp_roundrobin(as); break; -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/34273?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I75d7b8f3fb6a06f6941b6dff4072287fdbb1d33e Gerrit-Change-Number: 34273 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in libosmo-sccp[master]: m3ua: Add some TODO comments on where we fall short of our potential
by laforge 04 Sep '23

04 Sep '23

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/34273?usp=email ) Change subject: m3ua: Add some TODO comments on where we fall short of our potential ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/34273?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I75d7b8f3fb6a06f6941b6dff4072287fdbb1d33e Gerrit-Change-Number: 34273 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 04 Sep 2023 20:20:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: MME_Tests: remove unused timer variable
by laforge 04 Sep '23

04 Sep '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34279?usp=email ) Change subject: MME_Tests: remove unused timer variable ...................................................................... MME_Tests: remove unused timer variable The Timer T in TC_RIM_RAN_INF is not used, let's remove it. Related: OS#5760 Change-Id: I3d18cda38789e5a42536fd17b6641efa725f757b --- M mme/MME_Tests.ttcn 1 file changed, 12 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved pespin: Looks good to me, approved diff --git a/mme/MME_Tests.ttcn b/mme/MME_Tests.ttcn index 55cb021..2db5b01 100644 --- a/mme/MME_Tests.ttcn +++ b/mme/MME_Tests.ttcn @@ -932,8 +932,6 @@ f_s1ap_setup(0); f_init_gtp(id); - timer T := 3.0; - var ConnHdlrPars pars := f_init_pars(ue_idx := 0); var ConnHdlr vc_conn; vc_conn := f_start_handler_with_pars(refers(f_TC_RIM_RAN_INF), pars); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34279?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3d18cda38789e5a42536fd17b6641efa725f757b Gerrit-Change-Number: 34279 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[M] Change in osmo-ttcn3-hacks[master]: MME_Tests: add new testcase TC_s1ap_tau_unknown_guti
by laforge 04 Sep '23

04 Sep '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34281?usp=email ) Change subject: MME_Tests: add new testcase TC_s1ap_tau_unknown_guti ...................................................................... MME_Tests: add new testcase TC_s1ap_tau_unknown_guti A tracking area update that contains an OldGUTI (TMSI) that is unknown to the MME should be rejected. Related: OS#5760 Change-Id: I9306fea69ac930b9642528e2fd32a7091147081e --- M mme/MME_Tests.ttcn 1 file changed, 62 insertions(+), 0 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/mme/MME_Tests.ttcn b/mme/MME_Tests.ttcn index 2db5b01..104c3d2 100644 --- a/mme/MME_Tests.ttcn +++ b/mme/MME_Tests.ttcn @@ -964,11 +964,60 @@ } } +/* Tracking area update with a GUTI (TMSI) that is unknown to the MME. The MME is expected to reject this TAU + * request. */ +private function f_TC_tau_unknown_guti(ConnHdlrPars pars) runs on ConnHdlr { + + f_init_handler(pars); + var template (value) EPS_MobileIdentityV mi := ts_NAS_MobileId_IMSI(pars.ue_pars.imsi); + var template (value) S1AP_PDU tx; + var template (value) PDU_NAS_EPS nas_tau; + timer T := 5.0; + + var hexstring mcc_mnc := f_convert_plmn(g_pars.enb_pars[g_pars.mme_idx].global_enb_id.pLMNidentity); + var EPS_MobileIdentityLV old_guti := valueof(ts_EPS_MobileId_GUTI(mcc_mnc, '0001'O, '01'O, 'AABBCCDD'O)); + nas_tau := ts_PDU_NAS_EPS_TrackingAreaUpdateRequest(old_guti); + + tx := ts_S1AP_InitialUE(p_eNB_value := 0, p_nasPdu := enc_PDU_NAS_EPS(valueof(nas_tau)), + p_tAI := ts_enb_S1AP_TAI(g_pars.enb_pars[g_pars.mme_idx]), + p_eUTRAN_CGI := ts_enb_S1AP_CGI(g_pars.enb_pars[g_pars.mme_idx]), + p_rrcCause := mo_Signalling); + + S1AP.send(tx); + + T.start; + alt { + [] S1AP.receive(tr_PDU_NAS_EPS_TrackingAreaUpdateReject) { + setverdict(pass); + } + [] S1AP.receive { + setverdict(fail, "unexpected S1AP message from MME"); + } + [] T.timeout { + setverdict(fail, "no message from MME"); + } + } + +} +testcase TC_s1ap_tau_unknown_guti() runs on MTC_CT { + var charstring id := testcasename(); + + f_init_diameter(id); + f_init_s1ap(id, 4); + f_s1ap_setup(0); + + var ConnHdlrPars pars := f_init_pars(ue_idx := 0); + var ConnHdlr vc_conn; + vc_conn := f_start_handler_with_pars(refers(f_TC_tau_unknown_guti), pars); + vc_conn.done; +} + control { execute( TC_s1ap_setup_wrong_plmn() ); execute( TC_s1ap_setup_wrong_tac() ); execute( TC_s1ap_setup() ); execute( TC_s1ap_attach() ); + execute( TC_s1ap_tau_unknown_guti() ); execute( TC_gn_echo_request() ); execute( TC_RIM_RAN_INF() ); execute( TC_s1ap_reset() ); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34281?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9306fea69ac930b9642528e2fd32a7091147081e Gerrit-Change-Number: 34281 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-ttcn3-hacks[master]: NAS_Templates: add template for Tracking Area Update Reject
by laforge 04 Sep '23

04 Sep '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34280?usp=email ) Change subject: NAS_Templates: add template for Tracking Area Update Reject ...................................................................... NAS_Templates: add template for Tracking Area Update Reject Change-Id: Id64e8a28e47235766efbef6df0114c3024cc2f47 Related: OS#5760 --- M library/NAS_Templates.ttcn 1 file changed, 27 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/library/NAS_Templates.ttcn b/library/NAS_Templates.ttcn index 4b98ee8..45f5f8d 100644 --- a/library/NAS_Templates.ttcn +++ b/library/NAS_Templates.ttcn @@ -335,6 +335,23 @@ tSC := tSC } +/* 8.2.28 Tracking Area Update Reject */ +template (present) PDU_NAS_EPS +tr_PDU_NAS_EPS_TrackingAreaUpdateReject(template (present) EMM_CauseV cause := ?) := { + protocolDiscriminator := c_EPS_NAS_PD_EMM, + ePS_messages := { + ePS_MobilityManagement := { + pDU_NAS_EPS_TrackingAreaUpdateReject := { + securityHeaderType := c_EPS_SEC_NONE, + messageType := '01001011'B, + emmCause := cause, + t3346 := *, + extendedEmmCause := * + } + } + } +} + /* 8.2.29 Tracking Area Update Request */ template (value) PDU_NAS_EPS ts_PDU_NAS_EPS_TrackingAreaUpdateRequest(EPS_MobileIdentityLV old_guti) := { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34280?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id64e8a28e47235766efbef6df0114c3024cc2f47 Gerrit-Change-Number: 34280 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0