August 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmocom-bb[master]: l1gprs: Log slotmask when logging TBF

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34142 ) ( 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: l1gprs: Log slotmask when logging TBF ...................................................................... l1gprs: Log slotmask when logging TBF Change-Id: Ib96b01c591dbcc6aa9e0527e0be499ef8aee2863 --- M src/shared/l1gprs.c 1 file changed, 13 insertions(+), 4 deletions(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/shared/l1gprs.c b/src/shared/l1gprs.c index e4c1fc7..61b6eea 100644 --- a/src/shared/l1gprs.c +++ b/src/shared/l1gprs.c @@ -48,9 +48,9 @@ #define LOG_TBF_CFG_REQ_ARGS(req) \ (req)->tbf_ref, (req)->slotmask, ntohl((req)->start_fn) -#define LOG_TBF_FMT "%cL-TBF#%03d" +#define LOG_TBF_FMT "%cL-TBF#%03d(slotmask=0x%02x)" #define LOG_TBF_ARGS(tbf) \ - (tbf)->uplink ? 'U' : 'D', tbf->tbf_ref + (tbf)->uplink ? 'U' : 'D', (tbf)->tbf_ref, (tbf)->slotmask #define TDMA_FN_INVALID 0xffffffff @@ -548,7 +548,7 @@ tbf = l1gprs_find_tbf(gprs, true, req->tbf_ref); if (tbf == NULL) { LOGP_GPRS(gprs, LOGL_ERROR, "%s(): " LOG_TBF_FMT " not found\n", - __func__, 'U', req->tbf_ref); + __func__, 'U', req->tbf_ref, req->slotmask); return -ENOENT; } l1gprs_unregister_tbf(gprs, tbf); @@ -609,7 +609,7 @@ tbf = l1gprs_find_tbf(gprs, false, req->tbf_ref); if (tbf == NULL) { LOGP_GPRS(gprs, LOGL_ERROR, "%s(): " LOG_TBF_FMT " not found\n", - __func__, 'D', req->tbf_ref); + __func__, 'D', req->tbf_ref, req->slotmask); return -ENOENT; } l1gprs_unregister_tbf(gprs, tbf); -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34142 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ib96b01c591dbcc6aa9e0527e0be499ef8aee2863 Gerrit-Change-Number: 34142 Gerrit-PatchSet: 8 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 11 months

1
0
0 0

[S] Change in osmocom-bb[master]: layer23: modem: pass TBF starting time from CFG UL/DL TBF Req

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/33232 ) ( 8 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: layer23: modem: pass TBF starting time from CFG UL/DL TBF Req ...................................................................... layer23: modem: pass TBF starting time from CFG UL/DL TBF Req Change-Id: Iae53c6e704a5b868a265216d4cb48b1edc2d7e61 Depends: libosmo-gprs.git I27a7a896fe3839fa4f9b8cd9500c4ab7867bbaa0 Related: OS#5500 --- M src/host/layer23/src/modem/grr.c 1 file changed, 13 insertions(+), 2 deletions(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/host/layer23/src/modem/grr.c b/src/host/layer23/src/modem/grr.c index c6f2a32..7eec935 100644 --- a/src/host/layer23/src/modem/grr.c +++ b/src/host/layer23/src/modem/grr.c @@ -667,7 +667,7 @@ l1ctl_tx_gprs_ul_tbf_cfg_req(ms, lp->cfg_ul_tbf_req.ul_tbf_nr, lp->cfg_ul_tbf_req.ul_slotmask, - 0xffffffff /* TODO: start Fn */); + lp->cfg_ul_tbf_req.start_fn); break; } case GRR_EV_PDCH_DL_TBF_CFG_REQ: @@ -676,7 +676,7 @@ l1ctl_tx_gprs_dl_tbf_cfg_req(ms, lp->cfg_dl_tbf_req.dl_tbf_nr, lp->cfg_dl_tbf_req.dl_slotmask, - 0xffffffff, /* TODO: start Fn */ + lp->cfg_ul_tbf_req.start_fn, lp->cfg_dl_tbf_req.dl_tfi); break; } -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/33232 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Iae53c6e704a5b868a265216d4cb48b1edc2d7e61 Gerrit-Change-Number: 33232 Gerrit-PatchSet: 13 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 11 months

1
0
0 0

[L] Change in osmocom-bb[master]: l1gprs: implement TBF starting time support

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/33223 ) Change subject: l1gprs: implement TBF starting time support ...................................................................... Patch Set 13: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/33223 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I174e3c43d2f4c828a528710b284e62c9bb794122 Gerrit-Change-Number: 33223 Gerrit-PatchSet: 13 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilirator(a)gmail.com> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <axilirator(a)gmail.com> Gerrit-Comment-Date: Thu, 24 Aug 2023 14:29:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 11 months

1
0
0 0

[S] Change in osmocom-bb[master]: layer23: modem: Pass fn from lapdm to L1CTL-CCCH_DATA.ind

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34133 ) Change subject: layer23: modem: Pass fn from lapdm to L1CTL-CCCH_DATA.ind ...................................................................... Patch Set 9: Code-Review+2 (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmocom-bb/+/34133/comment/8bb698ce_21b53c75 PS9, Line 9: Change-Id: I7a9f31ae363fe7de019ff1a906f3978ff3074036 `Related: libosmocore.git Icabc3759c47b0f7cfe61f1b7a96f08f36714262e` -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34133 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I7a9f31ae363fe7de019ff1a906f3978ff3074036 Gerrit-Change-Number: 34133 Gerrit-PatchSet: 9 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 24 Aug 2023 14:20:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 11 months

1
0
0 0

[S] Change in libosmocore[master]: debian: depend on liburing-dev for debian >= 11

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34188 ) Change subject: debian: depend on liburing-dev for debian >= 11 ...................................................................... Patch Set 1: (1 comment) File debian/control: https://gerrit.osmocom.org/c/libosmocore/+/34188/comment/2b2aaeec_e97e68a4 PS1, Line 22: base-files (<< 11) | liburing-dev, > base-files is a package installed in all debian distributions and their derivatives, like ubuntu. […] Ok thanks for the explanation. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34188 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If7832baec0bddbe0bbbbfe07f77bba3deb328d5c Gerrit-Change-Number: 34188 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 24 Aug 2023 14:06:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 11 months

1
0
0 0

[S] Change in libosmocore[master]: debian: depend on liburing-dev for debian >= 11

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34188 ) Change subject: debian: depend on liburing-dev for debian >= 11 ...................................................................... Patch Set 1: (2 comments) File debian/control: https://gerrit.osmocom.org/c/libosmocore/+/34188/comment/d9e186e6_604bbd06 PS1, Line 22: base-files (<< 11) | liburing-dev, > what does this mean? base-files is a package installed in all debian distributions and their derivatives, like ubuntu. It has the version of the debian distribution, e.g. 12.4+deb12u1 currently on bookworm, and 12.3ubuntu2 on ubuntu 23.04. * https://packages.debian.org/search?suite=all&searchon=names&keywords=base-f… * https://packages.ubuntu.com/search?keywords=base%2Dfiles So what this means is: * require base-files with a version less than 11 (which is only possible on debian 10 and below, and there it is already installed so we are not pulling in another dependency) * otherwise require liburing-dev File debian/rules: https://gerrit.osmocom.org/c/libosmocore/+/34188/comment/a632262b_b1a3311f PS1, Line 36: base_ver="$$(dpkg -l base-files | grep "^ii" | awk '{print $$3}')"; \ > A quite convoluted way to find the version. Did you think about https://manpages.debian. […] This uses /etc/os-release and /usr/lib/os-release. In ubuntu this doesn't contain the debian version it is based on. In general I just wanted to check exactly for the same version of base-files as done in the debian/control file, so I did it like this. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34188 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If7832baec0bddbe0bbbbfe07f77bba3deb328d5c Gerrit-Change-Number: 34188 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 24 Aug 2023 14:03:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 11 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: PCUIF: use confirmation flag in struct gsm_pcu_if_pch

by pespin

Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34194 ) Change subject: PCUIF: use confirmation flag in struct gsm_pcu_if_pch ...................................................................... Patch Set 1: Code-Review-1 (1 comment) Patchset: PS1: Same as I said on the other patch: I'm not liking this approach. Keep the BTS/BSC decoding the message type to know what to do with it, and let the "confirm" variable be simply a bool on whether the BSC answers to the PCU when it schedules/transmits it. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34194 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7017ca20ca7e0b77d0f363121e4f17280e39e8ac Gerrit-Change-Number: 34194 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 24 Aug 2023 14:00:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 11 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: GTP_Templates: fix wrong function name

by pespin

Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34193 ) Change subject: GTP_Templates: fix wrong function name ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34193 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4235bc727bf8e71d1ef4a43c830706b6e1c826c9 Gerrit-Change-Number: 34193 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 24 Aug 2023 13:59:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 11 months

1
0
0 0

[S] Change in osmo-pcu[master]: pcuif_proto: add confirmation flag to struct gsm_pcu_if_pch

by pespin

Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/34190 ) Change subject: pcuif_proto: add confirmation flag to struct gsm_pcu_if_pch ...................................................................... Patch Set 1: Code-Review-1 (1 comment) Patchset: PS1: Same as I said on the other patch: I'm not liking this approach. Keep the BTS/BSC decoding the message type to know what to do with it, and let the "confirm" variable be simply a bool on whether the BSC answers to the PCU when it schedules/transmits it. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/34190 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ia202862aafc1f0cb6601574ef61eb9155de11f04 Gerrit-Change-Number: 34190 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 24 Aug 2023 13:59:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 11 months

1
0
0 0

[S] Change in osmo-bsc[master]: pcuif_proto: use confirmation flag in struct gsm_pcu_if_pch

by pespin

Attention is currently required from: osmith, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34192 ) Change subject: pcuif_proto: use confirmation flag in struct gsm_pcu_if_pch ...................................................................... Patch Set 1: Code-Review-1 (2 comments) Patchset: PS1: Same as I said on the other patch: I'm not liking this approach. Keep the BSC decoding the message type to know what to do with it, and let the "confirm" variable be simply a bool on whether the BSC answers to the PCU when it schedules/transmits it. File src/osmo-bsc/pcu_sock.c: https://gerrit.osmocom.org/c/osmo-bsc/+/34192/comment/b9284b7d_4e084523 PS1, Line 552: if (pch->confirmed_imm_ass) > * What happens if using a newer osmo-bsc with an older osmo-pcu which does not send the field? (see […] @osmith this should not be a problem since there's a PCUIF version bump 10->11. But yes, it would be nice to have such sort of information in the commit message ;) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/34192 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I3d2842626b7e8325860ea3160c7d900d39e953a0 Gerrit-Change-Number: 34192 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 24 Aug 2023 13:58:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 11 months

1
0
0 0

2025

2024

2023

2022

gerrit-log August 2023