June 2023 - gerrit-log - lists.osmocom.org

[S] Change in pysim[master]: pySim/apdu/ts_31_102.py: Add Rel17 5G NSWO context for GET IDENTITY
by fixeria 06 Jun '23

06 Jun '23

Attention is currently required from: laforge, dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/33211 ) Change subject: pySim/apdu/ts_31_102.py: Add Rel17 5G NSWO context for GET IDENTITY ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/33211 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I6ce5848ca4cf04430be7767e9cb2d18f4c5a5531 Gerrit-Change-Number: 33211 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 06 Jun 2023 20:39:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in pysim[master]: ts_102221: Add "resume_uicc" command
by fixeria 06 Jun '23

06 Jun '23

Attention is currently required from: laforge, dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/33210 ) Change subject: ts_102221: Add "resume_uicc" command ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/33210 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I3322fde74f680e77954e1d3e18a32ef5662759f2 Gerrit-Change-Number: 33210 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 06 Jun 2023 20:39:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in pysim[master]: Move "suspend_uicc" command from pySim-shell to ts_102_221.py
by fixeria 06 Jun '23

06 Jun '23

Attention is currently required from: laforge, dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/33209 ) Change subject: Move "suspend_uicc" command from pySim-shell to ts_102_221.py ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/33209 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I574348951f06b749aeff986589186110580328bc Gerrit-Change-Number: 33209 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 06 Jun 2023 20:37:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in pysim[master]: ts_31_102: fix typo
by fixeria 06 Jun '23

06 Jun '23

Attention is currently required from: dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/33213 ) Change subject: ts_31_102: fix typo ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/33213 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ic8f93a55b974984472356f48518da91c6a521409 Gerrit-Change-Number: 33213 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 06 Jun 2023 20:36:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in pysim[master]: ts_31_102: fix typo
by pespin 06 Jun '23

06 Jun '23

Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/33213 ) Change subject: ts_31_102: fix typo ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/33213 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ic8f93a55b974984472356f48518da91c6a521409 Gerrit-Change-Number: 33213 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 06 Jun 2023 17:56:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in pysim[master]: ts_31_102: fix typo
by dexter 06 Jun '23

06 Jun '23

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/33213 ) Change subject: ts_31_102: fix typo ...................................................................... ts_31_102: fix typo Change-Id: Ic8f93a55b974984472356f48518da91c6a521409 --- M pySim/ts_31_102.py 1 file changed, 10 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/13/33213/1 diff --git a/pySim/ts_31_102.py b/pySim/ts_31_102.py index 14e7cae..342ea87 100644 --- a/pySim/ts_31_102.py +++ b/pySim/ts_31_102.py @@ -1655,7 +1655,7 @@ This emulates a terminal (modem/phone) having received a SMS with a PID of 'SMS for the SIM card'. You can use this command in the context of testing OTA related features - without a modem/phone or a cellular netwokr.""" + without a modem/phone or a cellular network.""" tpdu_ie = SMS_TPDU() tpdu_ie.from_bytes(h2b(opts.TPDU)) dev_ids = DeviceIdentities( -- To view, visit https://gerrit.osmocom.org/c/pysim/+/33213 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ic8f93a55b974984472356f48518da91c6a521409 Gerrit-Change-Number: 33213 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in pysim[master]: pySim-shell: Unregister TS 102 222 commands during 'equip'
by laforge 06 Jun '23

06 Jun '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/33207 ) Change subject: pySim-shell: Unregister TS 102 222 commands during 'equip' ...................................................................... pySim-shell: Unregister TS 102 222 commands during 'equip' This avoids error messages about re-registering the same TS 102 222 commands during executing the 'equip' command. Change-Id: I3567247fe84e928e3ef404c07eff8250ef04dfe9 --- M pySim-shell.py 1 file changed, 13 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/pySim-shell.py b/pySim-shell.py index fc825ef..d6d9a64 100755 --- a/pySim-shell.py +++ b/pySim-shell.py @@ -204,7 +204,7 @@ if self.rs: lchan = self.rs.lchan[0] lchan.unregister_cmds(self) - for cmds in [Iso7816Commands, PySimCommands]: + for cmds in [Iso7816Commands, Ts102222Commands, PySimCommands]: cmd_set = self.find_commandsets(cmds) if cmd_set: self.unregister_command_set(cmd_set[0]) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/33207 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I3567247fe84e928e3ef404c07eff8250ef04dfe9 Gerrit-Change-Number: 33207 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 0

[S] Change in pysim[master]: Fix result parsing of "suspend_uicc"
by laforge 06 Jun '23

06 Jun '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/33208 ) Change subject: Fix result parsing of "suspend_uicc" ...................................................................... Fix result parsing of "suspend_uicc" prior to this patch, the suspend_uicc command would always cause a python exception as a list of integers was returned by decode_duration rather than a single integer (that can be used with %u format string). Change-Id: I981e9d46607193176b28cb574564e6da546501ba --- M pySim/commands.py 1 file changed, 13 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/pySim/commands.py b/pySim/commands.py index b0f8b39..6acdb2e 100644 --- a/pySim/commands.py +++ b/pySim/commands.py @@ -610,7 +610,7 @@ def decode_duration(enc: Hexstr) -> int: time_unit = enc[:2] - length = h2i(enc[2:4]) + length = h2i(enc[2:4])[0] if time_unit == '04': return length * 10*24*60*60 elif time_unit == '03': -- To view, visit https://gerrit.osmocom.org/c/pysim/+/33208 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I981e9d46607193176b28cb574564e6da546501ba Gerrit-Change-Number: 33208 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 0

[S] Change in pysim[master]: pySim-shell: Unregister TS 102 222 commands during 'equip'
by laforge 06 Jun '23

06 Jun '23

Attention is currently required from: dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/33207 ) Change subject: pySim-shell: Unregister TS 102 222 commands during 'equip' ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/33207 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I3567247fe84e928e3ef404c07eff8250ef04dfe9 Gerrit-Change-Number: 33207 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 06 Jun 2023 16:26:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in pysim[master]: Fix result parsing of "suspend_uicc"
by laforge 06 Jun '23

06 Jun '23

Attention is currently required from: dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/33208 ) Change subject: Fix result parsing of "suspend_uicc" ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/33208 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I981e9d46607193176b28cb574564e6da546501ba Gerrit-Change-Number: 33208 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 06 Jun 2023 16:26:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0