Attention is currently required from: dexter.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/33210 )
Change subject: ts_102221: Add "resume_uicc" command
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://gerrit.osmocom.org/c/pysim/+/33210/comment/a21529c1_706fc990
PS2, Line 15: between SUSPEND and RESUME by TS 102 221 Section 11.1.22.3.2
> Maybe adding this note to the command output makes sense since users might expect this to work.
Ack
Patchset:
PS2:
> I have tried this out and it does not work (as the commit message mentioned) but the I cannot see an […]
A power cycle is definitely required as per the specs.
The way how I tested successfully on SJA5 is:
* use the resume_uicc command from pySim-shell
* remove the card from the reader slot
* stop pySim-shell
* re-insert the card
* start some other "raw apdu shell" like cyberflex-shell by henryk ploetz
* manually issue the resume uicc APDU from that shell (8076010008 + token)
* see the card respond with SW 9000
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/33210
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I3322fde74f680e77954e1d3e18a32ef5662759f2
Gerrit-Change-Number: 33210
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 07 Jun 2023 09:10:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: laforge.
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/33210 )
Change subject: ts_102221: Add "resume_uicc" command
......................................................................
Patch Set 2: Code-Review+1
(2 comments)
Commit Message:
https://gerrit.osmocom.org/c/pysim/+/33210/comment/111fbefe_406dec7a
PS2, Line 15: between SUSPEND and RESUME by TS 102 221 Section 11.1.22.3.2
Maybe adding this note to the command output makes sense since users might expect this to work.
Patchset:
PS2:
I have tried this out and it does not work (as the commit message mentioned) but the I cannot see any non permitted commands between suspend and resume (I guess the RETRIEVE DATA after suspend is permitted since it is used to get the token.)
pySIM-shell (MF)> suspend_uicc
Negotiated Duration: 86400 secs, Token: 18902089c6e3026e, SW: 9000
I get the following on pcscd:
04127018 [139824061212416] APDU: 80 76 00 00 04 01 01 03 01
00007676 [139824061212416] SW: 61 0A
00000310 [139824061212416] APDU: 80 C0 00 00 0A
00002647 [139824061212416] SW: 02 18 18 90 20 89 C6 E3 02 6E 90 00
Then when I try to resume:
pySIM-shell (MF)> resume_uicc 18902089c6e3026e
EXCEPTION of type 'SwMatchError' occurred with message: 'SW match failed! Expected 9000 and got 6fff: Checking errors - The interpretation of this status word is command dependent'
To enable full traceback, run the following command: 'set debug true'
I get the following on pcsdc:
13094679 [139824061212416] APDU: 80 76 01 00 08 18 90 20 89 C6 E3 02 6E
00003212 [139824061212416] SW: 6F FF
Or is resume only possible when power was shut down after suspend?
(I have tested with sysmo-usim-sja5)
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/33210
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I3322fde74f680e77954e1d3e18a32ef5662759f2
Gerrit-Change-Number: 33210
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Wed, 07 Jun 2023 08:37:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
dexter has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/33213 )
Change subject: ts_31_102: fix typo
......................................................................
ts_31_102: fix typo
Change-Id: Ic8f93a55b974984472356f48518da91c6a521409
---
M pySim/ts_31_102.py
1 file changed, 10 insertions(+), 1 deletion(-)
Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, approved
fixeria: Looks good to me, but someone else must approve
diff --git a/pySim/ts_31_102.py b/pySim/ts_31_102.py
index 14e7cae..342ea87 100644
--- a/pySim/ts_31_102.py
+++ b/pySim/ts_31_102.py
@@ -1655,7 +1655,7 @@
This emulates a terminal (modem/phone) having received a SMS
with a PID of 'SMS for the SIM card'. You can use this
command in the context of testing OTA related features
- without a modem/phone or a cellular netwokr."""
+ without a modem/phone or a cellular network."""
tpdu_ie = SMS_TPDU()
tpdu_ie.from_bytes(h2b(opts.TPDU))
dev_ids = DeviceIdentities(
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/33213
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ic8f93a55b974984472356f48518da91c6a521409
Gerrit-Change-Number: 33213
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: merged
Attention is currently required from: neels.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-hnbgw/+/33173
to look at the new patch set (#4).
Change subject: cnpool: add context_map_cnlink_lost() handling
......................................................................
cnpool: add context_map_cnlink_lost() handling
When proper RANAP RESET handling is in place [1], a specific CN link may
be detected to be disconnected or reconnected at any point.
[1] Id3eefdea889a736fd5957b80280fa45b9547b792
When that happens, all related context maps should disconnect RUA and
SCCP links immediately. Add the context map side of this, so that
context_map_cnlink_lost() is ready to be dispatched in [1].
Related: SYS#6412
Change-Id: Ic0a6fcfb747dc093528ca2bd12a269ad390d465c
---
M include/osmocom/hnbgw/context_map.h
M src/osmo-hnbgw/context_map.c
M src/osmo-hnbgw/context_map_sccp.c
3 files changed, 37 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/73/33173/4
--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/33173
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: Ic0a6fcfb747dc093528ca2bd12a269ad390d465c
Gerrit-Change-Number: 33173
Gerrit-PatchSet: 4
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: neels.
Hello Jenkins Builder, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-hnbgw/+/33174
to look at the new patch set (#4).
Change subject: add ranap_domain_name()
......................................................................
add ranap_domain_name()
As simple as it may seem, turning the RANAP CS/PS domain indicator to a
string so far is cumbersome. It is usually only CS or PS, but to be
accurate we should also expect invalid values. After the umpteenth
switch statement breaking up otherwise trivial code, I decided that yes,
after all, a value_string[] is a good idea even for just two enum values
that have only two-letter names.
Callers will follow in upcoming patches.
Related: SYS#6412
Change-Id: Ib3c5d772ccea8c854eec007de5c996d1b6640bc0
---
M include/osmocom/hnbgw/hnbgw.h
M src/osmo-hnbgw/hnbgw.c
M src/osmo-hnbgw/hnbgw_rua.c
3 files changed, 32 insertions(+), 13 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/74/33174/4
--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/33174
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: Ib3c5d772ccea8c854eec007de5c996d1b6640bc0
Gerrit-Change-Number: 33174
Gerrit-PatchSet: 4
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: neels.
Hello Jenkins Builder, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-hnbgw/+/33176
to look at the new patch set (#4).
Change subject: use cnlink state in cnpool decisions
......................................................................
use cnlink state in cnpool decisions
Change-Id: I28490a4a27bcda8fd689db8b8652e451103e3a9d
---
M src/osmo-hnbgw/hnbgw_cn.c
1 file changed, 11 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/76/33176/4
--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/33176
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: I28490a4a27bcda8fd689db8b8652e451103e3a9d
Gerrit-Change-Number: 33176
Gerrit-PatchSet: 4
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-MessageType: newpatchset