May 2023 - gerrit-log - lists.osmocom.org

[M] Change in osmocom-bb[master]: layer23: modem: Forward Paging Request Type 2/2 to rlcmac layer

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32973 ) Change subject: layer23: modem: Forward Paging Request Type 2/2 to rlcmac layer ...................................................................... Patch Set 3: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32973 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Iee4b5ee5e1e5874b550dd8536b095bf0b5eeb8f4 Gerrit-Change-Number: 32973 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 24 May 2023 17:23:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[M] Change in libosmo-gprs[master]: rlcmac: Add APIs to decode P1/P2 Rest Octets

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/32972 ) Change subject: rlcmac: Add APIs to decode P1/P2 Rest Octets ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I plan to merge up to here around tomorrow if no reviews are received. -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/32972 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I59c6723d969880a4481e3b86a172d59f0edeb1e4 Gerrit-Change-Number: 32972 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 24 May 2023 17:22:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[L] Change in libosmocore[master]: ASCI: Add IE transcoding according to 3GPP TS 48.008

by fixeria

Attention is currently required from: jolly. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32931 ) Change subject: ASCI: Add IE transcoding according to 3GPP TS 48.008 ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: I find it weird that all functions `assert()` all their pointer arguments. Looks overdefensive. Other than that, the patch looks good to me. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32931 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic1fc714bb04228a7f32e9925811e21c8efc610bd Gerrit-Change-Number: 32931 Gerrit-PatchSet: 4 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Wed, 24 May 2023 17:19:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[S] Change in osmo-bts[master]: trx, HR1 codec: change UL PHY output format to TS 101 318

by falconia

Attention is currently required from: fixeria, dexter. falconia has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32969 ) Change subject: trx, HR1 codec: change UL PHY output format to TS 101 318 ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Keep in mind that the output format of osmo-bts-trx must not change. […] Right now I am setting the default to RFC 5993 for all BTS models - but I now see that your comment also applies in reverse: existing sysmoBTS deployments will suddenly switch from TS 101 318 to RFC 5993, which can be just as bad. Therefore, I am now thinking that the default should be per BTS model, matching legacy behavior: default to RFC 5993 on osmo-bts-trx or TS 101 318 on all other models. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32969 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I41bce6226964975cb85aea89e4c0f9e11e4929b8 Gerrit-Change-Number: 32969 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 24 May 2023 17:14:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[M] Change in libosmo-gprs[master]: rlcmac: Submit GMMRR-PAGE.ind upon rx of Paging Request Type 1/2

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/32985 ) Change subject: rlcmac: Submit GMMRR-PAGE.ind upon rx of Paging Request Type 1/2 ...................................................................... rlcmac: Submit GMMRR-PAGE.ind upon rx of Paging Request Type 1/2 Change-Id: I64db4277b5c54870a258d63c554f470011bcc989 --- M include/osmocom/gprs/rlcmac/rlcmac_private.h M src/rlcmac/rlcmac.c M src/rlcmac/rlcmac_prim.c 3 files changed, 243 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/85/32985/1 diff --git a/include/osmocom/gprs/rlcmac/rlcmac_private.h b/include/osmocom/gprs/rlcmac/rlcmac_private.h index e73d23e..5b09a4a 100644 --- a/include/osmocom/gprs/rlcmac/rlcmac_private.h +++ b/include/osmocom/gprs/rlcmac/rlcmac_private.h @@ -86,9 +86,13 @@ /* rlcmac.c */ struct gprs_rlcmac_entity *gprs_rlcmac_find_entity_by_tlli(uint32_t tlli); +struct gprs_rlcmac_entity *gprs_rlcmac_find_entity_by_ptmsi(uint32_t ptmsi); +struct gprs_rlcmac_entity *gprs_rlcmac_find_entity_by_imsi(const char *imsi); struct gprs_rlcmac_dl_tbf *gprs_rlcmac_find_dl_tbf_by_tfi(uint8_t dl_tfi); struct gprs_rlcmac_ul_tbf *gprs_rlcmac_find_ul_tbf_by_tfi(uint8_t ul_tfi); int gprs_rlcmac_handle_ccch_imm_ass(const struct gsm48_imm_ass *ia, uint32_t fn); +int gprs_rlcmac_handle_ccch_pag_req_1(struct gsm48_paging1 *pag); +int gprs_rlcmac_handle_ccch_pag_req_2(struct gsm48_paging2 *pag); int gprs_rlcmac_handle_bcch_si13(const struct gsm48_system_information_type_13 *si13); int gprs_rlcmac_handle_gprs_dl_block(const struct osmo_gprs_rlcmac_prim *rlcmac_prim, enum gprs_rlcmac_coding_scheme cs); diff --git a/src/rlcmac/rlcmac.c b/src/rlcmac/rlcmac.c index 00b45ff..1fea6a5 100644 --- a/src/rlcmac/rlcmac.c +++ b/src/rlcmac/rlcmac.c @@ -134,7 +134,6 @@ struct gprs_rlcmac_entity *gprs_rlcmac_find_entity_by_tlli(uint32_t tlli) { struct gprs_rlcmac_entity *gre; - llist_for_each_entry(gre, &g_rlcmac_ctx->gre_list, entry) { if (gre->tlli == tlli) return gre; @@ -142,6 +141,26 @@ return NULL; } +struct gprs_rlcmac_entity *gprs_rlcmac_find_entity_by_ptmsi(uint32_t ptmsi) +{ + struct gprs_rlcmac_entity *gre; + llist_for_each_entry(gre, &g_rlcmac_ctx->gre_list, entry) { + if (gre->ptmsi == ptmsi) + return gre; + } + return NULL; +} + +struct gprs_rlcmac_entity *gprs_rlcmac_find_entity_by_imsi(const char *imsi) +{ + struct gprs_rlcmac_entity *gre; + llist_for_each_entry(gre, &g_rlcmac_ctx->gre_list, entry) { + if (strncmp(gre->imsi, imsi, ARRAY_SIZE(gre->imsi)) == 0) + return gre; + } + return NULL; +} + struct gprs_rlcmac_dl_tbf *gprs_rlcmac_find_dl_tbf_by_tfi(uint8_t dl_tfi) { struct gprs_rlcmac_entity *gre; @@ -304,6 +323,210 @@ return rc; } + +/* TS 44.018 3.3.2.1.1: +* It is used when sending paging information to a mobile station in packet idle mode, if PCCCH is not present in the cell. +* If the mobile station in packet idle mode is identified by its IMSI, it shall parse the message for a corresponding Packet +* Page Indication field: +* - if the Packet Page Indication field indicates a packet paging procedure, the mobile station shall proceed as +* specified in sub-clause 3.5.1.2. +* 3.5.1.2 "On receipt of a packet paging request": +* On the receipt of a paging request message, the RR sublayer of addressed mobile station indicates the receipt of a +* paging request to the MM sublayer, see 3GPP TS 24.007. +*/ +/* TS 44.018 9.1.22 "Paging request type 1" */ +int gprs_rlcmac_handle_ccch_pag_req_1(struct gsm48_paging1 *pag) +{ + uint8_t len; + uint8_t *buf = pag->data; + int rc; + struct osmo_mobile_identity mi1 = {}; /* GSM_MI_TYPE_NONE */ + struct osmo_mobile_identity mi2 = {}; /* GSM_MI_TYPE_NONE */ + P1_Rest_Octets_t p1ro = {}; + unsigned p1_rest_oct_len; + struct osmo_gprs_rlcmac_prim *rlcmac_prim; + struct gprs_rlcmac_entity *gre; + + LOGRLCMAC(LOGL_INFO, "Rx Paging Request Type 1\n"); + + if (GSM_MACBLOCK_LEN < sizeof(*pag)) + return -EBADMSG; + + /* The L2 pseudo length of this message is the sum of lengths of all + * information elements present in the message except the P1 Rest Octets and L2 + * Pseudo Length information elements. */ + if (pag->l2_plen == GSM_MACBLOCK_LEN - sizeof(pag->l2_plen)) { + /* no P1 Rest Octets => no Packet Page Indication => Discard */ + return 0; + } + + if (GSM_MACBLOCK_LEN < sizeof(*pag) + 1) + return -EBADMSG; + len = *buf; + buf++; + + if (GSM_MACBLOCK_LEN < sizeof(*pag) + 1 + len) + return -EBADMSG; + + if ((rc = osmo_mobile_identity_decode(&mi1, buf, len, false)) < 0) + return rc; + buf += len; + + if (GSM_MACBLOCK_LEN < (buf - (uint8_t *)pag) + 1) { + /* No MI2 and no P1 Rest Octets => no Packet Page Indication => Discard */ + return 0; + } + + if (*buf == GSM48_IE_MOBILE_ID) { + buf++; + if (GSM_MACBLOCK_LEN < (buf - (uint8_t *)pag) + 1) + return -EBADMSG; + len = *buf; + buf++; + if (GSM_MACBLOCK_LEN < (buf - (uint8_t *)pag) + len) + return -EBADMSG; + if ((rc = osmo_mobile_identity_decode(&mi2, buf, len, false)) < 0) + return rc; + buf += len; + } + + p1_rest_oct_len = GSM_MACBLOCK_LEN - (buf - (uint8_t *)pag); + if (p1_rest_oct_len == 0) { + /*No P1 Rest Octets => no Packet Page Indication => Discard */ + return 0; + } + + rc = osmo_gprs_rlcmac_decode_p1ro(&p1ro, buf, p1_rest_oct_len); + if (rc != 0) { + LOGRLCMAC(LOGL_ERROR, "Failed to parse P1 Rest Octets\n"); + return rc; + } + + if (p1ro.Packet_Page_Indication_1 == 1) { /* for GPRS*/ + switch (mi1.type) { + case GSM_MI_TYPE_IMSI: + if ((gre = gprs_rlcmac_find_entity_by_imsi(mi1.imsi))) { + /* TS 24.007 C.13: Submit GMMRR-PAGE.ind: */ + rlcmac_prim = gprs_rlcmac_prim_alloc_gmmrr_page_ind(gre->tlli); + rc = gprs_rlcmac_prim_call_up_cb(rlcmac_prim); + } + break; + case GSM_MI_TYPE_TMSI: + if ((gre = gprs_rlcmac_find_entity_by_ptmsi(mi1.tmsi))) { + /* TS 24.007 C.13: Submit GMMRR-PAGE.ind: */ + rlcmac_prim = gprs_rlcmac_prim_alloc_gmmrr_page_ind(gre->tlli); + rc = gprs_rlcmac_prim_call_up_cb(rlcmac_prim); + } + break; + default: + return -EINVAL; + } + } + + if (p1ro.Packet_Page_Indication_2 == 1) { /* for GPRS*/ + switch (mi2.type) { + case GSM_MI_TYPE_IMSI: + if ((gre = gprs_rlcmac_find_entity_by_imsi(mi2.imsi))) { + /* TS 24.007 C.13: Submit GMMRR-PAGE.ind: */ + rlcmac_prim = gprs_rlcmac_prim_alloc_gmmrr_page_ind(gre->tlli); + rc = gprs_rlcmac_prim_call_up_cb(rlcmac_prim); + } + break; + case GSM_MI_TYPE_TMSI: + if ((gre = gprs_rlcmac_find_entity_by_ptmsi(mi2.tmsi))) { + /* TS 24.007 C.13: Submit GMMRR-PAGE.ind: */ + rlcmac_prim = gprs_rlcmac_prim_alloc_gmmrr_page_ind(gre->tlli); + rc = gprs_rlcmac_prim_call_up_cb(rlcmac_prim); + } + break; + default: + return -EINVAL; + } + } + + return rc; +} + +/* TS 44.018 9.1.23 "Paging request type 2" */ +int gprs_rlcmac_handle_ccch_pag_req_2(struct gsm48_paging2 *pag) +{ + uint8_t len; + uint8_t *buf = pag->data; + int rc; + struct osmo_mobile_identity mi3 = {}; /* GSM_MI_TYPE_NONE */ + P2_Rest_Octets_t p2ro = {}; + unsigned p2_rest_oct_len; + struct osmo_gprs_rlcmac_prim *rlcmac_prim; + struct gprs_rlcmac_entity *gre; + + LOGRLCMAC(LOGL_INFO, "Rx Paging Request Type 2\n"); + + if (GSM_MACBLOCK_LEN < sizeof(*pag)) + return -EBADMSG; + + /* The L2 pseudo length of this message is the sum of lengths of all + * information elements present in the message except the P1 Rest Octets and L2 + * Pseudo Length information elements. */ + if (pag->l2_plen == GSM_MACBLOCK_LEN - sizeof(pag->l2_plen)) { + /* no P2 Rest Octets => no Packet Page Indication => Discard */ + return 0; + } + + if (GSM_MACBLOCK_LEN < (buf - (uint8_t *)pag) + 1) + return -EBADMSG; + + /* No MI3 => Discard */ + if (*buf != GSM48_IE_MOBILE_ID) + return 0; + + buf++; + if (GSM_MACBLOCK_LEN < (buf - (uint8_t *)pag) + 1) + return -EBADMSG; + len = *buf; + buf++; + if (GSM_MACBLOCK_LEN < (buf - (uint8_t *)pag) + len) + return -EBADMSG; + if ((rc = osmo_mobile_identity_decode(&mi3, buf, len, false)) < 0) + return rc; + buf += len; + + p2_rest_oct_len = GSM_MACBLOCK_LEN - (buf - (uint8_t *)pag); + if (p2_rest_oct_len == 0) { + /*No P1 Rest Octets => no Packet Page Indication => Discard */ + return 0; + } + + rc = osmo_gprs_rlcmac_decode_p2ro(&p2ro, buf, p2_rest_oct_len); + if (rc != 0) { + LOGRLCMAC(LOGL_ERROR, "Failed to parse P2 Rest Octets\n"); + return rc; + } + + if (p2ro.Packet_Page_Indication_3 != 1) /* NOT for GPRS*/ + return 0; + + switch (mi3.type) { + case GSM_MI_TYPE_IMSI: + if ((gre = gprs_rlcmac_find_entity_by_imsi(mi3.imsi))) { + /* TS 24.007 C.13: Submit GMMRR-PAGE.ind: */ + rlcmac_prim = gprs_rlcmac_prim_alloc_gmmrr_page_ind(gre->tlli); + rc = gprs_rlcmac_prim_call_up_cb(rlcmac_prim); + } + break; + case GSM_MI_TYPE_TMSI: + if ((gre = gprs_rlcmac_find_entity_by_ptmsi(mi3.tmsi))) { + /* TS 24.007 C.13: Submit GMMRR-PAGE.ind: */ + rlcmac_prim = gprs_rlcmac_prim_alloc_gmmrr_page_ind(gre->tlli); + rc = gprs_rlcmac_prim_call_up_cb(rlcmac_prim); + } + break; + default: + return -EINVAL; + } + + return rc; +} + int gprs_rlcmac_handle_bcch_si13(const struct gsm48_system_information_type_13 *si13) { int rc; diff --git a/src/rlcmac/rlcmac_prim.c b/src/rlcmac/rlcmac_prim.c index 6e2285b..35e804c 100644 --- a/src/rlcmac/rlcmac_prim.c +++ b/src/rlcmac/rlcmac_prim.c @@ -559,7 +559,6 @@ static int rlcmac_prim_handle_l1ctl_ccch_data_ind(struct osmo_gprs_rlcmac_prim *rlcmac_prim) { - /* TODO: check if it's IMM_ASS: */ int rc; switch (rlcmac_prim->l1ctl.ccch_data_ind.data[2]) { @@ -567,6 +566,12 @@ rc = gprs_rlcmac_handle_ccch_imm_ass((struct gsm48_imm_ass *)rlcmac_prim->l1ctl.ccch_data_ind.data, rlcmac_prim->l1ctl.ccch_data_ind.fn); break; + case GSM48_MT_RR_PAG_REQ_1: + rc = gprs_rlcmac_handle_ccch_pag_req_1((struct gsm48_paging1 *)rlcmac_prim->l1ctl.ccch_data_ind.data); + break; + case GSM48_MT_RR_PAG_REQ_2: + rc = gprs_rlcmac_handle_ccch_pag_req_2((struct gsm48_paging2 *)rlcmac_prim->l1ctl.ccch_data_ind.data); + break; case GSM48_MT_RR_SYSINFO_13: rc = gprs_rlcmac_handle_bcch_si13((struct gsm48_system_information_type_13 *)rlcmac_prim->l1ctl.ccch_data_ind.data); break; -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/32985 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I64db4277b5c54870a258d63c554f470011bcc989 Gerrit-Change-Number: 32985 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 1 month

1
0
0 0

[L] Change in libosmocore[master]: ASCI: Add 3GPP TS 44.068 and 44.069 protocol definitions

by fixeria

Attention is currently required from: jolly, dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32930 ) Change subject: ASCI: Add 3GPP TS 44.068 and 44.069 protocol definitions ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32930 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I3554cea47e714c8fca18c3e9c0e6e80695915a90 Gerrit-Change-Number: 32930 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 24 May 2023 17:07:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[M] Change in osmo-bts[master]: l1sap: Accept RFC5993 and TS 101.318 HR GSM payload

by falconia

Attention is currently required from: dexter. falconia has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32630 ) Change subject: l1sap: Accept RFC5993 and TS 101.318 HR GSM payload ...................................................................... Patch Set 5: Code-Review-2 (1 comment) File src/common/l1sap.c: https://gerrit.osmocom.org/c/osmo-bts/+/32630/comment/3c8d11fb_98741917 PS5, Line 1960: /* Since we already verified the payload in rtppayload_validate_hr(), we may trust that the payload length is : * correct according to either RFC 5993 or TS 101 318. */ Huge problem with this logic: your added function is called from l1sap_rtp_rx_cb(), which executes *before* rtppayload_validate_*() functions - the latter are called from l1sap_tch_rts_ind() on the receiving end of the queue being written to by l1sap_rtp_rx_cb(). Therefore, if this patch were to be merged, the OSMO_ASSERT(0) just below will cause the BTS to crash as soon as even one invalid RTP packet is received. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32630 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I9419b40c1171876879d41aba4f51c93e8ef5673c Gerrit-Change-Number: 32630 Gerrit-PatchSet: 5 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 24 May 2023 17:06:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[M] Change in osmocom-bb[master]: layer23: Support setting P-TMSI in test sim

by pespin

pespin has abandoned this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32739 ) Change subject: layer23: Support setting P-TMSI in test sim ...................................................................... Abandoned abandonned, better implemented in other patches -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32739 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I77d28534bd21327fbbec8f1544238703558245cb Gerrit-Change-Number: 32739 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: abandon

2 years, 1 month

1
0
0 0

[M] Change in osmocom-bb[master]: layer23: modem: Submit GMMRR-PAGE.ind upon rx of Paging Request Type ...

by pespin

Attention is currently required from: pespin, fixeria. Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/32973 to look at the new patch set (#2). Change subject: layer23: modem: Submit GMMRR-PAGE.ind upon rx of Paging Request Type 1/2/3 ...................................................................... layer23: modem: Submit GMMRR-PAGE.ind upon rx of Paging Request Type 1/2/3 Change-Id: Iee4b5ee5e1e5874b550dd8536b095bf0b5eeb8f4 --- M src/host/layer23/src/modem/grr.c 1 file changed, 245 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/73/32973/2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32973 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Iee4b5ee5e1e5874b550dd8536b095bf0b5eeb8f4 Gerrit-Change-Number: 32973 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 1 month

1
0
0 0

[S] Change in libosmo-gprs[master]: gmm: Provide rlcmac with IMSI & PTMSI information

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/32984 ) Change subject: gmm: Provide rlcmac with IMSI & PTMSI information ...................................................................... gmm: Provide rlcmac with IMSI & PTMSI information This information will be needed once the GRR layer starts listening for paging requests, which identify MS by either PTMSI or IMSI. Change-Id: I3a0c4a57c3d624c3ebb40ae2cc0c96626ccc2c99 --- M include/osmocom/gprs/gmm/gmm_prim.h M include/osmocom/gprs/rlcmac/gre.h M include/osmocom/gprs/rlcmac/rlcmac_prim.h M src/gmm/gmm.c M src/rlcmac/gre.c M src/rlcmac/rlcmac_prim.c 6 files changed, 30 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/84/32984/1 diff --git a/include/osmocom/gprs/gmm/gmm_prim.h b/include/osmocom/gprs/gmm/gmm_prim.h index 4b8657f..b774ef8 100644 --- a/include/osmocom/gprs/gmm/gmm_prim.h +++ b/include/osmocom/gprs/gmm/gmm_prim.h @@ -185,6 +185,8 @@ /* OSMO_GPRS_GMM_GMMRR_ASSIGN | Req */ struct { uint32_t new_tlli; + uint32_t ptmsi; + char imsi[OSMO_IMSI_BUF_SIZE]; } assign_req; /* OSMO_GPRS_GMM_GMMRR_PAGE | Ind */ struct { diff --git a/include/osmocom/gprs/rlcmac/gre.h b/include/osmocom/gprs/rlcmac/gre.h index 358d0aa..3afeadc 100644 --- a/include/osmocom/gprs/rlcmac/gre.h +++ b/include/osmocom/gprs/rlcmac/gre.h @@ -12,6 +12,10 @@ struct llist_head entry; /* item in (struct gprs_rlcmac_ctx)->gre_list */ uint32_t tlli; + /* Used to match paging requests coming from CS domain: */ + uint32_t ptmsi; + char imsi[OSMO_IMSI_BUF_SIZE]; + struct gprs_rlcmac_llc_queue *llc_queue; /* Manage TBF Starting Time delay during TBF assignment: */ diff --git a/include/osmocom/gprs/rlcmac/rlcmac_prim.h b/include/osmocom/gprs/rlcmac/rlcmac_prim.h index c44de22..fa1ee52 100644 --- a/include/osmocom/gprs/rlcmac/rlcmac_prim.h +++ b/include/osmocom/gprs/rlcmac/rlcmac_prim.h @@ -91,6 +91,8 @@ /* OSMO_GPRS_RLCMAC_GMMRR_ASSIGN | Req */ struct { uint32_t new_tlli; + uint32_t ptmsi; + char imsi[OSMO_IMSI_BUF_SIZE]; } assign_req; /* OSMO_GPRS_RLCMAC_GMMRR_PAGE | Ind */ struct { diff --git a/src/gmm/gmm.c b/src/gmm/gmm.c index 38ebc98..2a97837 100644 --- a/src/gmm/gmm.c +++ b/src/gmm/gmm.c @@ -459,6 +459,8 @@ int rc; gmm_prim_tx = gprs_gmm_prim_alloc_gmmrr_assign_req(gmme->old_tlli, gmme->tlli); + gmm_prim_tx->gmmrr.assign_req.ptmsi = gmme->ptmsi; + OSMO_STRLCPY_ARRAY(gmm_prim_tx->gmmrr.assign_req.imsi, gmme->imsi); rc = gprs_gmm_prim_call_down_cb(gmm_prim_tx); return rc; diff --git a/src/rlcmac/gre.c b/src/rlcmac/gre.c index fe18a43..e728695 100644 --- a/src/rlcmac/gre.c +++ b/src/rlcmac/gre.c @@ -56,6 +56,7 @@ goto err_free_gre; gre->tlli = tlli; + gre->ptmsi = GSM_RESERVED_TMSI; llist_add_tail(&gre->entry, &g_rlcmac_ctx->gre_list); return gre; diff --git a/src/rlcmac/rlcmac_prim.c b/src/rlcmac/rlcmac_prim.c index 7337647..6e2285b 100644 --- a/src/rlcmac/rlcmac_prim.c +++ b/src/rlcmac/rlcmac_prim.c @@ -426,6 +426,8 @@ goto free_ret; } gprs_rlcmac_entity_free(gre); + gre = NULL; + goto free_ret; } else { /* Case "update", both old_tlli and new_tlli are valid */ gre = gprs_rlcmac_find_entity_by_tlli(old_tlli); @@ -438,6 +440,11 @@ gre->tlli = new_tlli; } + /* cache/update knowledge about this GMME's PTMSI and IMSI. It will be + * needed later on to match paging requests: */ + gre->ptmsi = rlcmac_prim->gmmrr.assign_req.ptmsi; + OSMO_STRLCPY_ARRAY(gre->imsi, rlcmac_prim->gmmrr.assign_req.imsi); + free_ret: msgb_free(rlcmac_prim->oph.msg); return rc; -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/32984 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I3a0c4a57c3d624c3ebb40ae2cc0c96626ccc2c99 Gerrit-Change-Number: 32984 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 1 month

1
0
0 0

2025

2024

2023

2022

gerrit-log May 2023