May 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-bts[master]: trx, HR1 codec: change UL PHY output format to TS 101 318

by dexter

Attention is currently required from: falconia, fixeria. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32969 ) Change subject: trx, HR1 codec: change UL PHY output format to TS 101 318 ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Keep in mind that the output format of osmo-bts-trx must not change. There are deployments out there that might cease to work when the format is suddenly TS 101.318 (So when the patch with the VTY setting is applied, the default still must be RFC5993) -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32969 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I41bce6226964975cb85aea89e4c0f9e11e4929b8 Gerrit-Change-Number: 32969 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 24 May 2023 16:14:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[S] Change in libosmo-gprs[master]: gmm: Implement GMMR-PAGE.ind

by pespin

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-gprs/+/32982 to look at the new patch set (#2). Change subject: gmm: Implement GMMR-PAGE.ind ...................................................................... gmm: Implement GMMR-PAGE.ind Submit an LLGM-TRIGGER.req as described in TS 24.007 C.13. Change-Id: Iba77b4a5280ce08f099f4e15934fa92d4ba8ba10 --- M src/gmm/gmm_prim.c 1 file changed, 33 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/82/32982/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/32982 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Iba77b4a5280ce08f099f4e15934fa92d4ba8ba10 Gerrit-Change-Number: 32982 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

2 years, 1 month

1
0
0 0

[M] Change in libosmo-gprs[master]: llc: Implement LLGM-TRIGGER.req

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/32983 ) Change subject: llc: Implement LLGM-TRIGGER.req ...................................................................... llc: Implement LLGM-TRIGGER.req Change-Id: Id1af5912f407fe055a59a4bb217936307697975f --- M include/osmocom/gprs/llc/llc_prim.h M include/osmocom/gprs/llc/llc_private.h M src/llc/llc.c M src/llc/llc_llgmm.c 4 files changed, 95 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/83/32983/1 diff --git a/include/osmocom/gprs/llc/llc_prim.h b/include/osmocom/gprs/llc/llc_prim.h index 904e9fa..175ede4 100644 --- a/include/osmocom/gprs/llc/llc_prim.h +++ b/include/osmocom/gprs/llc/llc_prim.h @@ -88,6 +88,16 @@ return get_value_string(osmo_gprs_llc_bssgp_prim_type_names, val); } +/* TS 04.64 Section 7.2.1.3 LLGMM-TRIGGER */ +/* 3GPP TS 24.008 2.1.2 "Cell Notification" is considered a different trigger + * type than Cell Update since lower layers behave different (tx LLC NULL vs UI + * frame). Furthermore, the one knowing about requirement to use one or the other + * is the upper layer (GMM), as well as the one responsible of READY timer. */ +enum osmo_gprs_llc_llgm_trigger_type { + OSMO_GPRS_LLC_LLGM_TRIGGER_CELL_UPDATE, + OSMO_GPRS_LLC_LLGM_TRIGGER_CELL_NOTIFICATION, + OSMO_GPRS_LLC_LLGM_TRIGGER_PAGE_RESP, +}; /* Parameters for OSMO_GPRS_LLC_LLGMM_* prims */ struct osmo_gprs_llc_llgmm_prim { @@ -104,7 +114,7 @@ } assign_req; /* OSMO_GPRS_LLC_LLGMM_TRIGGER | Req */ struct { - uint8_t cause; + uint8_t cause; /* enum osmo_gprs_llc_llgm_trigger_type */ } trigger_req; /* OSMO_GPRS_LLC_LLGMM_SUSPEND | Req */ struct { diff --git a/include/osmocom/gprs/llc/llc_private.h b/include/osmocom/gprs/llc/llc_private.h index ed68c7b..78e6e9f 100644 --- a/include/osmocom/gprs/llc/llc_private.h +++ b/include/osmocom/gprs/llc/llc_private.h @@ -323,6 +323,7 @@ int gprs_llc_lle_tx_xid_req(struct gprs_llc_lle *lle, uint8_t *l3par, unsigned int l3par_len); int gprs_llc_lle_tx_xid_resp(struct gprs_llc_lle *lle, uint8_t *l3par, unsigned int l3par_len); int gprs_llc_lle_tx_ui(struct gprs_llc_lle *lle, uint8_t *l3_pdu, size_t l3_pdu_len, bool encryptable); +int gprs_llc_lle_tx_null(const struct gprs_llc_lle *lle); /* llc_prim.c: */ struct osmo_gprs_llc_prim *gprs_llc_prim_alloc(enum osmo_gprs_llc_prim_sap sap, unsigned int type, diff --git a/src/llc/llc.c b/src/llc/llc.c index 4be7a9a..e0c7a39 100644 --- a/src/llc/llc.c +++ b/src/llc/llc.c @@ -292,6 +292,39 @@ return 0; } +/* 6.4.1.7 NULL command */ +int gprs_llc_lle_tx_null(const struct gprs_llc_lle *lle) +{ + int rc; + struct msgb *msg; + struct gprs_llc_pdu_decoded pdu_dec = { + .sapi = lle->sapi, + .fmt = OSMO_GPRS_LLC_FMT_U, + .func = OSMO_GPRS_LLC_FUNC_NULL, + .flags = 0 /* P=0 */, + }; + struct osmo_gprs_llc_prim *llc_prim; + + /* LLC payload is put directly below: */ + if (g_llc_ctx->location == OSMO_GPRS_LLC_LOCATION_SGSN) + llc_prim = gprs_llc_prim_alloc_bssgp_dl_unitdata_req(lle->llme->tlli, NULL, 0); + else + llc_prim = gprs_llc_prim_alloc_grr_unitdata_req(lle->llme->tlli, NULL, 0); + msg = llc_prim->oph.msg; + msg->l3h = msg->tail; + + rc = gprs_llc_pdu_encode(msg, &pdu_dec); + if (rc < 0) { + LOGLLC(LOGL_NOTICE, "Failed to encode U DM\n"); + msgb_free(msg); + return rc; + } + + /* Send BSSGP-DL-UNITDATA.req (SGSN) / GRR-UNITDATA.req (MS) */ + gprs_llc_prim_call_down_cb(llc_prim); + return 0; +} + /* Transmit a UI frame over the given SAPI: 'encryptable' indicates whether particular message can be encrypted according to 3GPP TS 24.008 § 4.7.1.2 diff --git a/src/llc/llc_llgmm.c b/src/llc/llc_llgmm.c index 7b09a69..973b698 100644 --- a/src/llc/llc_llgmm.c +++ b/src/llc/llc_llgmm.c @@ -274,6 +274,46 @@ return rc; } +/* 7.2.1.3 LLGMM-TRIGGER.req (SGSN):*/ +static int llc_prim_handle_llgm_trigger_req(struct osmo_gprs_llc_prim *llc_prim) +{ + struct gprs_llc_lle *lle; + int rc; + struct gprs_llc_llme *llme = gprs_llc_find_llme_by_tlli(llc_prim->llgmm.tlli); + + if (!llme) { + LOGLLC(LOGL_NOTICE, "Rx %s: Unknown TLLI 0x%08x\n", + osmo_gprs_llc_prim_name(llc_prim), llc_prim->llgmm.tlli); + rc = -ENOKEY; + goto ret_free; + } + LOGLLME(llme, LOGL_INFO, "%s\n", osmo_gprs_llc_prim_name(llc_prim)); + + lle = gprs_llc_llme_get_lle(llme, OSMO_GPRS_LLC_SAPI_GMM); + + /* "If there is a frame waiting to be transmitted in the MS, then this + * frame shall be transmitted on the corresponding SAPI or optionally a + * UI frame with no information field shall be transmitted on any SAPI. + * Otherwise if Cause indicates Cell Update and if Cell Notification is + * indicated by the SGSN (see 3GPP TS 24.008 [8a]), then a NULL frame + * with P=0 shall be transmitted on any SAPI." + */ + switch (llc_prim->llgmm.trigger_req.cause) { + case OSMO_GPRS_LLC_LLGM_TRIGGER_CELL_NOTIFICATION: + rc = gprs_llc_lle_tx_null(lle); + break; + case OSMO_GPRS_LLC_LLGM_TRIGGER_CELL_UPDATE: + case OSMO_GPRS_LLC_LLGM_TRIGGER_PAGE_RESP: + default: + rc = gprs_llc_lle_tx_ui(lle, NULL, 0, false); + break; + } + +ret_free: + msgb_free(llc_prim->oph.msg); + return rc; +} + /* 7.2.1.4 LLGMM-SUSPEND.req (MS/SGSN):*/ static int llc_prim_handle_llgm_suspend_req(struct osmo_gprs_llc_prim *llc_prim) { @@ -332,7 +372,7 @@ break; case OSMO_PRIM(OSMO_GPRS_LLC_LLGMM_TRIGGER, PRIM_OP_REQUEST): OSMO_ASSERT(g_llc_ctx->location == OSMO_GPRS_LLC_LOCATION_MS); - rc = gprs_llc_prim_handle_unsupported(llc_prim); + rc = llc_prim_handle_llgm_trigger_req(llc_prim); break; case OSMO_PRIM(OSMO_GPRS_LLC_LLGMM_SUSPEND, PRIM_OP_REQUEST): OSMO_ASSERT(g_llc_ctx->location == OSMO_GPRS_LLC_LOCATION_MS || -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/32983 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Id1af5912f407fe055a59a4bb217936307697975f Gerrit-Change-Number: 32983 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 1 month

1
0
0 0

[M] Change in osmo-bts[master]: all models, HR1 codec: select RTP output format via vty option

by dexter

Attention is currently required from: falconia, pespin. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32970 ) Change subject: all models, HR1 codec: select RTP output format via vty option ...................................................................... Patch Set 1: (1 comment) File src/common/vty.c: https://gerrit.osmocom.org/c/osmo-bts/+/32970/comment/d68ed8a2_04110204 PS1, Line 802: DEFUN(cfg_bts_rtp_hr_format, As far as I can see the bts->emit_hr_rfc5993 is checked on every l1sap_tch_ind. This means the VTY setting is immediately applied. So you can use EFUN_ATTR with CMD_ATTR_IMMEDIATE (see code below) (The attributes are used for auto generating documentation) -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32970 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I168191874a062429a57904511a1e89e3f588732e Gerrit-Change-Number: 32970 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: dexter <pmaier(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 24 May 2023 15:45:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[S] Change in libosmocore[master]: Add support for receiving Bter UI frames at lapdm.c

by dexter

Attention is currently required from: jolly. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32934 ) Change subject: Add support for receiving Bter UI frames at lapdm.c ...................................................................... Patch Set 5: Code-Review+1 (1 comment) File src/gsm/lapdm.c: https://gerrit.osmocom.org/c/libosmocore/+/32934/comment/20f00d69_35e74258 PS5, Line 730: if (LAPDm_ADDR_SHORT_L2(msg->l2h[2]) == 0x0) { cosmetic: Here you write 0x0, but there is also LAPDm_CTRL_U_BITS(msg->l2h[3]) == 0), which just uses 0 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32934 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If04115884743455c7bf2b2bc5f7e49e74b6ffb60 Gerrit-Change-Number: 32934 Gerrit-PatchSet: 5 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Wed, 24 May 2023 15:32:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[M] Change in ...osmo_dia2gsup[master]: Use GSUP APN as Service-Selection field

by daniel

Attention is currently required from: pespin, lynxis lazus. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/32514 ) Change subject: Use GSUP APN as Service-Selection field ...................................................................... Patch Set 4: Code-Review+1 (1 comment) Patchset: PS4: Works here -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/32514 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I2a0af5d785ce62968f6e3952602d92cb4f37e4ab Gerrit-Change-Number: 32514 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 24 May 2023 15:20:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[S] Change in libosmo-gprs[master]: llc: Implement GMMR-PAGE.ind

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/32982 ) Change subject: llc: Implement GMMR-PAGE.ind ...................................................................... llc: Implement GMMR-PAGE.ind Submit an LLGM-TRIGGER.req as described in TS 24.007 C.13. Change-Id: Iba77b4a5280ce08f099f4e15934fa92d4ba8ba10 --- M include/osmocom/gprs/llc/llc_prim.h M src/gmm/gmm_prim.c 2 files changed, 39 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/82/32982/1 diff --git a/include/osmocom/gprs/llc/llc_prim.h b/include/osmocom/gprs/llc/llc_prim.h index 904e9fa..2542563 100644 --- a/include/osmocom/gprs/llc/llc_prim.h +++ b/include/osmocom/gprs/llc/llc_prim.h @@ -88,6 +88,11 @@ return get_value_string(osmo_gprs_llc_bssgp_prim_type_names, val); } +/* TS 04.64 Section 7.2.1.3 LLGMM-TRIGGER */ +enum osmo_gprs_llc_llgm_trigger_type { + OSMO_GPRS_LLC_LLGM_TRIGGER_CELL_UPDATE, + OSMO_GPRS_LLC_LLGM_TRIGGER_PAGE_RESP, +}; /* Parameters for OSMO_GPRS_LLC_LLGMM_* prims */ struct osmo_gprs_llc_llgmm_prim { @@ -104,7 +109,7 @@ } assign_req; /* OSMO_GPRS_LLC_LLGMM_TRIGGER | Req */ struct { - uint8_t cause; + uint8_t cause; /* enum osmo_gprs_llc_llgm_trigger_type */ } trigger_req; /* OSMO_GPRS_LLC_LLGMM_SUSPEND | Req */ struct { diff --git a/src/gmm/gmm_prim.c b/src/gmm/gmm_prim.c index 34c9fe9..4b4b6e9 100644 --- a/src/gmm/gmm_prim.c +++ b/src/gmm/gmm_prim.c @@ -603,6 +603,27 @@ return rc; } +static int gprs_gmm_prim_handle_gmmrr_page_ind(struct osmo_gprs_gmm_prim *gmm_prim) +{ + struct osmo_gprs_llc_prim *llc_prim_tx; + int rc; + struct gprs_gmm_entity *gmme; + + if (!(gmme = gprs_gmm_find_gmme_by_tlli(gmm_prim->gmmrr.tlli))) { + LOGGMM(LOGL_NOTICE, "Rx %s: Unknown TLLI 0x%08x\n", + osmo_gprs_gmm_prim_name(gmm_prim), gmm_prim->gmmrr.tlli); + return -ENOENT; + } + + /* TS 24.007 C.13: restart READY timer, submit LLGM-TRIGGER.req */ + gprs_gmm_gmme_ready_timer_start(gmme); + + llc_prim_tx = osmo_gprs_llc_prim_alloc_llgm_trigger_req(gmme->tlli, OSMO_GPRS_LLC_LLGM_TRIGGER_PAGE_RESP); + + rc = gprs_gmm_prim_call_llc_down_cb(llc_prim_tx); + return rc; +} + static int gprs_gmm_prim_handle_gmmrr_llc_transmitted_ind(struct osmo_gprs_gmm_prim *gmm_prim) { struct gprs_gmm_entity *gmme = gprs_gmm_find_gmme_by_tlli(gmm_prim->gmmrr.tlli); @@ -620,8 +641,7 @@ int rc = 0; switch (OSMO_PRIM_HDR(&gmm_prim->oph)) { case OSMO_PRIM(OSMO_GPRS_GMM_GMMRR_PAGE, PRIM_OP_INDICATION): - rc = gprs_gmm_prim_handle_unsupported(gmm_prim); - rc = 1; + rc = gprs_gmm_prim_handle_gmmrr_page_ind(gmm_prim); break; case OSMO_PRIM(OSMO_GPRS_GMM_GMMRR_LLC_TRANSMITTED, PRIM_OP_INDICATION): rc = gprs_gmm_prim_handle_gmmrr_llc_transmitted_ind(gmm_prim); -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/32982 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Iba77b4a5280ce08f099f4e15934fa92d4ba8ba10 Gerrit-Change-Number: 32982 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 1 month

1
0
0 0

[S] Change in osmo-bts[master]: all models, HR1 codec: accept both TS101318 and RFC5993 formats

by pespin

Attention is currently required from: falconia, laforge, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32968 ) Change subject: all models, HR1 codec: accept both TS101318 and RFC5993 formats ...................................................................... Patch Set 1: (1 comment) File src/common/l1sap.c: https://gerrit.osmocom.org/c/osmo-bts/+/32968/comment/bf2621ec_381faba7 PS1, Line 1270: case GSM_HR_BYTES_RTP_RFC5993: > the question is: do we have any existing code that would require it? It's not really useful to think […] I'm not against this patch, I don't even know whether any of the existing backends is already using it. I'm just raising the concern to make sure we are all aligned. So fine with me. I'm also adding dexter as reviewer since he has been working on related topics now. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32968 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I702e26c3ad5b9d8347e73c6cd23efa38a3a3407e Gerrit-Change-Number: 32968 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 24 May 2023 14:29:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[S] Change in libosmocore[master]: Fix short L3 header of SI 10 at gsm_04_08.h

by pespin

Attention is currently required from: jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32936 ) Change subject: Fix short L3 header of SI 10 at gsm_04_08.h ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32936 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I1c3002716b08e31016cc6e623f8f8a413ef7916f Gerrit-Change-Number: 32936 Gerrit-PatchSet: 5 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Wed, 24 May 2023 14:26:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[S] Change in libosmocore[master]: Add short L3 header to gsm_04_08.h

by pespin

Attention is currently required from: jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32935 ) Change subject: Add short L3 header to gsm_04_08.h ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32935 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0eceb380e401e1f842edbaa92f4b4738703a031c Gerrit-Change-Number: 32935 Gerrit-PatchSet: 5 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Wed, 24 May 2023 14:26:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

2025

2024

2023

2022

gerrit-log May 2023