Attention is currently required from: fixeria, dexter.
falconia has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32969 )
Change subject: trx, HR1 codec: change UL PHY output format to TS 101 318
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Keep in mind that the output format of osmo-bts-trx must not change. […]
Right now I am setting the default to RFC 5993 for all BTS models - but I now see that your comment also applies in reverse: existing sysmoBTS deployments will suddenly switch from TS 101 318 to RFC 5993, which can be just as bad. Therefore, I am now thinking that the default should be per BTS model, matching legacy behavior: default to RFC 5993 on osmo-bts-trx or TS 101 318 on all other models.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bts/+/32969
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I41bce6226964975cb85aea89e4c0f9e11e4929b8
Gerrit-Change-Number: 32969
Gerrit-PatchSet: 1
Gerrit-Owner: falconia
falcon@freecalypso.org
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter
pmaier@sysmocom.de
Gerrit-Reviewer: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-CC: pespin
pespin@sysmocom.de
Gerrit-Attention: fixeria
vyanitskiy@sysmocom.de
Gerrit-Attention: dexter
pmaier@sysmocom.de
Gerrit-Comment-Date: Wed, 24 May 2023 17:14:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: dexter
pmaier@sysmocom.de
Gerrit-MessageType: comment