May 2023 - gerrit-log - lists.osmocom.org

[S] Change in pysim[master]: ts_31_102: Fix FID of EF.OPL5G (it's 4F08 instead of 6F08)

by fixeria

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/32980 ) Change subject: ts_31_102: Fix FID of EF.OPL5G (it's 4F08 instead of 6F08) ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/32980 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I68c7ad93dabd768d80ae629498aee29d7bab5542 Gerrit-Change-Number: 32980 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 25 May 2023 07:49:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[S] Change in pysim[master]: ts_31_102: Fix EF.NIA FID

by fixeria

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/32979 ) Change subject: ts_31_102: Fix EF.NIA FID ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/32979 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ib414d5b476666e276824266e33b341175a2ee05a Gerrit-Change-Number: 32979 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 25 May 2023 07:48:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[S] Change in pysim[master]: ts_51_011: Fix EF.Phase FID (it's 6FAE, not 6FA3)

by fixeria

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/32978 ) Change subject: ts_51_011: Fix EF.Phase FID (it's 6FAE, not 6FA3) ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/32978 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I11df83b17b8d6eaab309908cbee646c888abab0d Gerrit-Change-Number: 32978 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 25 May 2023 07:48:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[S] Change in pysim[master]: ts_51_011: Fix FID of EF.BCCH

by fixeria

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/32977 ) Change subject: ts_51_011: Fix FID of EF.BCCH ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/32977 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I9d90fa05a0f926f99a5d4832341cc8a9449df7ae Gerrit-Change-Number: 32977 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 25 May 2023 07:48:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[S] Change in libosmocore[master]: Add support for receiving Bter UI frames at lapdm.c

by Jenkins Builder

Attention is currently required from: jolly. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32934 ) Change subject: Add support for receiving Bter UI frames at lapdm.c ...................................................................... Patch Set 6: (2 comments) File src/gsm/lapdm.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7381): https://gerrit.osmocom.org/c/libosmocore/+/32934/comment/7094d6a6_f66bd9cf PS6, Line 735: && LAPDm_CTRL_is_U(msg->l2h[3]) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7381): https://gerrit.osmocom.org/c/libosmocore/+/32934/comment/dc942d60_ff2bf750 PS6, Line 736: && LAPDm_CTRL_U_BITS(msg->l2h[3]) == 0) { code indent should use tabs where possible -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32934 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If04115884743455c7bf2b2bc5f7e49e74b6ffb60 Gerrit-Change-Number: 32934 Gerrit-PatchSet: 6 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Thu, 25 May 2023 07:20:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[S] Change in libosmocore[master]: Add support for receiving Bter UI frames at lapdm.c

by jolly

Attention is currently required from: jolly. Hello Jenkins Builder, laforge, dexter, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/32934 to look at the new patch set (#6). Change subject: Add support for receiving Bter UI frames at lapdm.c ...................................................................... Add support for receiving Bter UI frames at lapdm.c Similar to support of sending Bter frame, the same rules apply when receiving them. Change-Id: If04115884743455c7bf2b2bc5f7e49e74b6ffb60 --- M src/gsm/lapdm.c 1 file changed, 35 insertions(+), 11 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/34/32934/6 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32934 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If04115884743455c7bf2b2bc5f7e49e74b6ffb60 Gerrit-Change-Number: 32934 Gerrit-PatchSet: 6 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-MessageType: newpatchset

2 years, 1 month

1
0
0 0

[S] Change in pysim[master]: ts_31_102: Add DF.SAIP support

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/32992 ) Change subject: ts_31_102: Add DF.SAIP support ...................................................................... ts_31_102: Add DF.SAIP support DF.SAIP (SIMalliance Interoperable Profile) is not part of 31.102, but something from the eSIM/eUICC universe of TCA (formerly known as SIMalliance). However, as 3GPP does not specify how/where the card stores the information required for SUCI calculation, the TCA/SIMalliance standard is the only standard there is. Some CardOS start to use this standard even for non-eSIM/eUICC use cases. Change-Id: Iffb65af335dfdbd7791fca9a0a6ad4b79814a57c --- M pySim/ts_31_102.py 1 file changed, 29 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/92/32992/1 diff --git a/pySim/ts_31_102.py b/pySim/ts_31_102.py index 77b8325..76f1358 100644 --- a/pySim/ts_31_102.py +++ b/pySim/ts_31_102.py @@ -1451,6 +1451,18 @@ self.add_files(files) +class DF_SAIP(CardDF): + """This is not really TS 31.102 but part of the eUICC Profile Package: Interoperable Format Technical + Specification as released by TCA (formerly SIMalliance)""" + def __init__(self, fid='5FD0', name='DF.SAIP', desc='SIMalliance Interoperable Profile', **kwargs): + super().__init__(fid=fid, name=name, desc=desc, **kwargs) + files = [ + # uses the same file format as DF.5GS/EF_SUCI_Calc_Info, but different FID + EF_SUCI_Calc_Info(fid='4f01') + ] + self.add_files(files) + + class ADF_USIM(CardADF): def __init__(self, aid='a0000000871002', name='ADF.USIM', fid=None, sfid=None, desc='USIM Application'): @@ -1576,6 +1588,7 @@ DF_USIM_5GS(service=[122, 123, 124, 125, 126, 127, 129, 130]), DF_SNPN(service=[143,146]), DF_5G_ProSe(service=139), + DF_SAIP(), ] self.add_files(files) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/32992 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Iffb65af335dfdbd7791fca9a0a6ad4b79814a57c Gerrit-Change-Number: 32992 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

2 years, 1 month

1
0
0 0

[L] Change in libosmocore[master]: ASCI: Add message definition and encoding according to 3GPP TS 48.008

by jolly

Attention is currently required from: pespin. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32932 ) Change subject: ASCI: Add message definition and encoding according to 3GPP TS 48.008 ...................................................................... Patch Set 5: (1 comment) File include/osmocom/gsm/gsm0808.h: https://gerrit.osmocom.org/c/libosmocore/+/32932/comment/dd882dce_f74262b7 PS5, Line 386: struct sockaddr_storage *aoip_transport_layer; > why did you change this to be a pointer? it doesn't match with most structures here and in general i […] It is the same way it was done in "struct gsm0808_handover_request". When not using a pointer, all users of that header file must have knowledge of struct sockaddr_storage and therefore must include sys/socket.h. This seems not be available on all system, so jenkins builder failed in the first place yesterday. I think this is not a problem. The structures are not stored somewhere. They are just used to encode/decode messages, so they are on stack memory until the transcoding is finished. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32932 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib94c64136c31ce4af67c314a8550d93946cc844f Gerrit-Change-Number: 32932 Gerrit-PatchSet: 5 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 25 May 2023 07:16:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[L] Change in osmo-hnbgw[master]: cnpool: allow separate cs7 for IuPS and IuCS

by neels

Attention is currently required from: pespin, msuraev. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/32323 ) Change subject: cnpool: allow separate cs7 for IuPS and IuCS ...................................................................... Patch Set 6: (1 comment) Patchset: PS5: > (i have no idea why this is marked resolved, unresolving now) there is a doc/examples/osmo-hnbgw-cs7.cfg that should show what is being changed -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/32323 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Iea1824f1c586723d989c80a909bae16bd2866e08 Gerrit-Change-Number: 32323 Gerrit-PatchSet: 6 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Thu, 25 May 2023 02:33:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[M] Change in osmo-hnbgw[master]: add separate cfg file only for VTY tests

by neels

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/32990 ) Change subject: add separate cfg file only for VTY tests ...................................................................... add separate cfg file only for VTY tests Instead of doc/examples/osmo-hnbgw.cfg, use a separate location tests/osmo-hnbgw-vty-test.cfg for VTY transcript tests, and add a bunch of SCCP address book entries that upcoming VTY tests will use. Declaring address book entries within transcript tests is possible, but cluttered with node 'exit' and VTY prompts -- these addresses are much easier to read and maintain in form of a cfg file. First user of these address book entries will be cnpool.vty in I5479eded786ec26062d49403a8be12967f113cdb Related: SYS#6412 Change-Id: Idcdf0e8660e8180fbe02282bc94e623ff89e848a --- M tests/Makefile.am A tests/osmo-hnbgw-vty-test.cfg 2 files changed, 63 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/90/32990/1 diff --git a/tests/Makefile.am b/tests/Makefile.am index 0225d7e..58d6592 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -24,6 +24,7 @@ testsuite.at \ $(srcdir)/package.m4 \ $(TESTSUITE) \ + osmo-hnbgw-vty-test.cfg \ osmo-hnbgw.vty \ $(NULL) @@ -53,7 +54,7 @@ osmo_verify_transcript_vty.py -v \ -n OsmoHNBGW -p 4261 \ -r "$(top_builddir)/src/osmo-hnbgw/osmo-hnbgw \ - -c $(top_srcdir)/doc/examples/osmo-hnbgw/osmo-hnbgw.cfg" \ + -c $(srcdir)/osmo-hnbgw-vty-test.cfg" \ $(U) $(srcdir)/$(VTY_TEST) check-local: atconfig $(TESTSUITE) diff --git a/tests/osmo-hnbgw-vty-test.cfg b/tests/osmo-hnbgw-vty-test.cfg new file mode 100644 index 0000000..6f9c0b6 --- /dev/null +++ b/tests/osmo-hnbgw-vty-test.cfg @@ -0,0 +1,40 @@ +log stderr + logging filter all 1 + logging color 1 + logging print level 1 + logging print category 1 + logging print category-hex 0 + logging print file basename last + logging print extended-timestamp 1 + logging level set-all notice + +# Define some cs7 address book entries to play with +cs7 instance 0 + sccp-address addr-msc0 + point-code 0.1.0 + sccp-address addr-msc2 + point-code 0.1.2 + sccp-address addr-sgsn3 + point-code 0.2.3 + sccp-address addr-sgsn4 + point-code 0.2.4 + +cs7 instance 1 + sccp-address addr-sgsn0 + point-code 1.2.0 + sccp-address addr-sgsn2 + point-code 1.2.2 + sccp-address addr-msc3 + point-code 1.1.3 + sccp-address addr-msc4 + point-code 1.1.4 + +hnbgw + iuh + local-ip 0.0.0.0 + hnbap-allow-tmsi 1 + mgw 0 + remote-ip 127.0.0.1 + local-port 2729 + remote-port 2427 + reset-endpoint rtpbridge/* -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/32990 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Idcdf0e8660e8180fbe02282bc94e623ff89e848a Gerrit-Change-Number: 32990 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 1 month

1
0
0 0

2025

2024

2023

2022

gerrit-log May 2023