May 2023 - gerrit-log - lists.osmocom.org

[M] Change in osmocom-bb[master]: trxcon/l1sched: rework burst buffer shifting for TCH/[FH]

by fixeria

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32921 ) Change subject: trxcon/l1sched: rework burst buffer shifting for TCH/[FH] ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32921 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Idb6e415f37f41b8ab92a3864962dac0a40c2fbaa Gerrit-Change-Number: 32921 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Mon, 29 May 2023 11:55:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[S] Change in osmo-bts[master]: measurement: suppress unsupported tch_mode warnings for CSD

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/33074 ) Change subject: measurement: suppress unsupported tch_mode warnings for CSD ...................................................................... measurement: suppress unsupported tch_mode warnings for CSD Change-Id: If6896b420d0fa50fa6622d24ef679ca65ef2dc50 Related: OS#1572 --- M src/common/measurement.c 1 file changed, 26 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/74/33074/1 diff --git a/src/common/measurement.c b/src/common/measurement.c index 459b586..6ecd797 100644 --- a/src/common/measurement.c +++ b/src/common/measurement.c @@ -72,7 +72,15 @@ /* No DTX allowed; SUB=FULL, therefore measurements at all frame numbers are * SUB */ return true; + case GSM48_CMODE_DATA_12k0: /* TCH/F9.6 */ + case GSM48_CMODE_DATA_6k0: /* TCH/F4.8 */ + /* FIXME: In case of data traffic channels TCH/F9.6 and TCH/F4.8 the + * RXQUAL_SUB report shall include measurements on the TDMA frames given + * in the table of subclause 8.3 only if L2 fill frames have been received + * as FACCH/F frames at the corresponding frame positions. */ default: + if (lchan->rsl_cmode == RSL_CMOD_SPD_DATA) + return false; LOGPLCFN(lchan, fn, DMEAS, LOGL_ERROR, "Unsupported lchan->tch_mode %u\n", lchan->tch_mode); break; } @@ -87,7 +95,15 @@ /* No DTX allowed; SUB=FULL, therefore measurements at all frame numbers are * SUB */ return true; + case GSM48_CMODE_DATA_6k0: /* TCH/H4.8 */ + case GSM48_CMODE_DATA_3k6: /* TCH/H2.4 */ + /* FIXME: In case of data traffic channels TCH/H4.8 and TCH/H2.4 the + * RXQUAL_SUB report shall include measurements on the TDMA frames given + * in the table of subclause 8.3 only if L2 fill frames have been received + * as FACCH/H frames at the corresponding frame positions. */ default: + if (lchan->rsl_cmode == RSL_CMOD_SPD_DATA) + return false; LOGPLCFN(lchan, fn, DMEAS, LOGL_ERROR, "Unsupported lchan->tch_mode %u\n", lchan->tch_mode); break; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/33074 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: If6896b420d0fa50fa6622d24ef679ca65ef2dc50 Gerrit-Change-Number: 33074 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 1 month

1
0
0 0

[S] Change in osmo-bts[master]: osmo-bts-trx: tch_dl_dequeue(): do not drop CSD frames

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/33073 ) Change subject: osmo-bts-trx: tch_dl_dequeue(): do not drop CSD frames ...................................................................... osmo-bts-trx: tch_dl_dequeue(): do not drop CSD frames Change-Id: I382b9994db01d58515c89c8de6250cd3239b8861 Related: OS#1572 --- M src/osmo-bts-trx/sched_lchan_tchf.c 1 file changed, 12 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/73/33073/1 diff --git a/src/osmo-bts-trx/sched_lchan_tchf.c b/src/osmo-bts-trx/sched_lchan_tchf.c index 230f57c..596912b 100644 --- a/src/osmo-bts-trx/sched_lchan_tchf.c +++ b/src/osmo-bts-trx/sched_lchan_tchf.c @@ -404,8 +404,8 @@ int8_t sti, cmi; bool amr_is_cmr; - if (rsl_cmode != RSL_CMOD_SPD_SPEECH) { - LOGL1SB(DL1P, LOGL_NOTICE, l1ts, br, "Dropping speech frame, " + if (OSMO_UNLIKELY(rsl_cmode == RSL_CMOD_SPD_SIGN)) { + LOGL1SB(DL1P, LOGL_NOTICE, l1ts, br, "Dropping a TCH frame, " "because we are not in speech mode\n"); goto free_bad_msg; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/33073 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I382b9994db01d58515c89c8de6250cd3239b8861 Gerrit-Change-Number: 33073 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 1 month

1
0
0 0

[S] Change in libosmo-gprs[master]: gmm: Implement rx GMM STATUS msg

by pespin

Attention is currently required from: laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-gprs/+/33001 to look at the new patch set (#4). Change subject: gmm: Implement rx GMM STATUS msg ...................................................................... gmm: Implement rx GMM STATUS msg Change-Id: I46719a3bf6d5e93e25f41f01f5c2ab889ff62803 --- M src/gmm/gmm.c 1 file changed, 29 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/01/33001/4 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/33001 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I46719a3bf6d5e93e25f41f01f5c2ab889ff62803 Gerrit-Change-Number: 33001 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

2 years, 1 month

1
0
0 0

[M] Change in libosmo-gprs[master]: gmm: Initial implementation of rx GMM Information msg

by pespin

Attention is currently required from: laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-gprs/+/33002 to look at the new patch set (#4). Change subject: gmm: Initial implementation of rx GMM Information msg ...................................................................... gmm: Initial implementation of rx GMM Information msg Basic implementation of gprs_gmm_decode_network_name() was cherry-picked from osmocom-bb 2dfa84e73dca455900e6522f61f5c610077783b7 decode_network_name(). Change-Id: I9b81f8f9113a95cc75666dac5ff9e315d0845fcb --- M include/osmocom/gprs/gmm/gmm_private.h M src/gmm/gmm.c M src/gmm/misc.c 3 files changed, 75 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/02/33002/4 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/33002 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I9b81f8f9113a95cc75666dac5ff9e315d0845fcb Gerrit-Change-Number: 33002 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

2 years, 1 month

1
0
0 0

[M] Change in libosmo-gprs[master]: gmm: Implement P-TMSI Reallocation Cmd/Compl

by pespin

Attention is currently required from: laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-gprs/+/32997 to look at the new patch set (#2). Change subject: gmm: Implement P-TMSI Reallocation Cmd/Compl ...................................................................... gmm: Implement P-TMSI Reallocation Cmd/Compl Change-Id: I1bf8bf5f4299db7b026fed2e2c21c07f15690942 --- M include/osmocom/gprs/gmm/gmm_pdu.h M src/gmm/gmm.c M src/gmm/gmm_pdu.c M tests/gmm/gmm_prim_test.c 4 files changed, 155 insertions(+), 14 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/97/32997/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/32997 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I1bf8bf5f4299db7b026fed2e2c21c07f15690942 Gerrit-Change-Number: 32997 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

2 years, 1 month

1
0
0 0

[M] Change in libosmo-gprs[master]: gmm: Tx Auth & Ciph Failure

by pespin

Attention is currently required from: laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-gprs/+/33053 to look at the new patch set (#3). Change subject: gmm: Tx Auth & Ciph Failure ...................................................................... gmm: Tx Auth & Ciph Failure Change-Id: I3ebb3dba20010e57f29dd5b8bbec457c2b08a8e1 --- M include/osmocom/gprs/gmm/gmm_pdu.h M include/osmocom/gprs/gmm/gmm_private.h M src/gmm/gmm.c M src/gmm/gmm_pdu.c M src/gmm/gmm_prim.c 5 files changed, 77 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/53/33053/3 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/33053 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I3ebb3dba20010e57f29dd5b8bbec457c2b08a8e1 Gerrit-Change-Number: 33053 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

2 years, 1 month

1
0
0 0

[S] Change in osmo-bsc[master]: fixup: contrib/jenkins: create workspace.tar.xz on error

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/33067 ) Change subject: fixup: contrib/jenkins: create workspace.tar.xz on error ...................................................................... fixup: contrib/jenkins: create workspace.tar.xz on error cat-testlogs.sh does "exit 1", so no workspace.tar.xz is created. Call this script after archiving the workspace. Change-Id: Ibcb842f32418e66a186d6b21bb5861cf4a0b7c4a Fixes: d33a66b779 "contrib/jenkins: create workspace.tar.xz on error" Related: OS#5665 --- M contrib/jenkins.sh 1 file changed, 15 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index f9d944a..ba453e9 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -8,14 +8,12 @@ # exit_tar_workspace() { - cat-testlogs.sh - if [ "$IS_MASTER_BUILD" = "1" ]; then tar -cJf "/tmp/workspace.tar.xz" "$base" mv /tmp/workspace.tar.xz "$base" fi - exit 1 + cat-testlogs.sh } if ! [ -x "$(command -v osmo-build-dep.sh)" ]; then -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/33067 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ibcb842f32418e66a186d6b21bb5861cf4a0b7c4a Gerrit-Change-Number: 33067 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 1 month

1
0
0 0

[S] Change in osmo-msc[master]: fixup: contrib/jenkins: create workspace.tar.xz on error

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33068 ) Change subject: fixup: contrib/jenkins: create workspace.tar.xz on error ...................................................................... fixup: contrib/jenkins: create workspace.tar.xz on error cat-testlogs.sh does "exit 1", so no workspace.tar.xz is created. Call this script after archiving the workspace. Change-Id: Ibcb842f32418e66a186d6b21bb5861cf4a0b7c4a Fixes: 799d972132 "contrib/jenkins: create workspace.tar.xz on error" Related: OS#5665 --- M contrib/jenkins.sh 1 file changed, 15 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index fc3eb12..c5161ef 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -14,14 +14,12 @@ fi exit_tar_workspace() { - cat-testlogs.sh - if [ "$IS_MASTER_BUILD" = "1" ]; then tar -cJf "/tmp/workspace.tar.xz" "$base" mv /tmp/workspace.tar.xz "$base" fi - exit 1 + cat-testlogs.sh } set -ex -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33068 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ibcb842f32418e66a186d6b21bb5861cf4a0b7c4a Gerrit-Change-Number: 33068 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 1 month

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: BTS_Tests: add TC_data_rtp_tch* for CSD

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33072 ) Change subject: BTS_Tests: add TC_data_rtp_tch* for CSD ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33072 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9a0dc0fcf722f862d8dcf04660d4448662210f44 Gerrit-Change-Number: 33072 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 29 May 2023 09:31:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

2025

2024

2023

2022

gerrit-log May 2023