Attention is currently required from: fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/33073 )
Change subject: osmo-bts-trx: tch_dl_dequeue(): do not drop CSD frames
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/33073
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I382b9994db01d58515c89c8de6250cd3239b8861
Gerrit-Change-Number: 33073
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 29 May 2023 14:15:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33071 )
Change subject: BTS_Tests: f_TC_speech_rtp(): run TCH and SACCH loops
......................................................................
BTS_Tests: f_TC_speech_rtp(): run TCH and SACCH loops
All testcases based on f_TC_speech_rtp() consist of two parts:
* In the first part we expect to receive a Downlink frame at the MS,
and, once received, we echo the received frame back to the BTS.
* In the second part we expect to receive an Uplink frame, the one
that was echoed back during the first part.
Let's keep echoing Downlink TCH frames while executing the second
part in order to reduce possibility of race conditions and keep
filling-up the Tx queue in the virtual MS (trxcon). Also keep
sending dummy Measurement Reports on SACCH.
Change-Id: Ifb69669b75df5b390d7056cefaf0ef1df69d9bd4
Related: OS#1572, OS#4396
---
M bts/BTS_Tests.ttcn
1 file changed, 25 insertions(+), 0 deletions(-)
Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn
index 8dcfb01..e715996 100644
--- a/bts/BTS_Tests.ttcn
+++ b/bts/BTS_Tests.ttcn
@@ -8270,11 +8270,14 @@
RTPEM_DATA.clear;
Tu.start(2.0);
alt {
+ [] as_l1_tch_loop();
+ [] as_l1_sacch();
[] RTPEM_DATA.receive(PDU_RTP:?) -> value rtp_pdu {
if (rtp_pdu.data != pl)
{ repeat; }
}
[] RTPEM_DATA.receive { repeat; }
+ [] L1CTL.receive { repeat; }
[] Tu.timeout {
setverdict(fail, "Timeout waiting for Uplink speech frames");
Misc_Helpers.f_shutdown(__BFILE__, __LINE__);
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33071
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ifb69669b75df5b390d7056cefaf0ef1df69d9bd4
Gerrit-Change-Number: 33071
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: merged
Attention is currently required from: fixeria.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33072 )
Change subject: BTS_Tests: add TC_data_rtp_tch* for CSD
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33072/comment/34ee8b5b_91ef…
PS1, Line 10: temporarily
all the code for the rate adaptation functions to go to proper AoIP RTP CSD format is already in libosmocore. is it worth to do something non-standard temporarily?
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33072
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I9a0dc0fcf722f862d8dcf04660d4448662210f44
Gerrit-Change-Number: 33072
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 29 May 2023 12:46:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: pespin.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/33075 )
Change subject: rlcmac: Avoid generating UL data if no data to be sent available
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/33075
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-gprs
Gerrit-Branch: master
Gerrit-Change-Id: I062aa9aea4f7d66a70ed53eae1c67780ddc3dca5
Gerrit-Change-Number: 33075
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 29 May 2023 12:46:48 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: pespin.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/33001 )
Change subject: gmm: Implement rx GMM STATUS msg
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
> btw, it might make sense to do all that kind of logging in a generic place before dispatching to ind […]
You can go even more generic than the "Rx foobar" and "msg_size check" by doing the tlv_parse in the generic part before dispatching to the per-message-type call-back.
we even have code somewhere that contains the information about which msg_type requies which mandatory IEs. See osmo_tlv_prot_def.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/33001
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-gprs
Gerrit-Branch: master
Gerrit-Change-Id: I46719a3bf6d5e93e25f41f01f5c2ab889ff62803
Gerrit-Change-Number: 33001
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 29 May 2023 12:45:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: comment
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/33075 )
Change subject: rlcmac: Avoid generating UL data if no data to be sent available
......................................................................
rlcmac: Avoid generating UL data if no data to be sent available
Dummy LLC commands only make sense in the network->MS direction, in
order to delay closing the DL TBF (3GPP TS 44.064 6.4.2.2). That code in
the MS is a leftover from porting code from osmo-pcu.
Change-Id: I062aa9aea4f7d66a70ed53eae1c67780ddc3dca5
---
M src/rlcmac/tbf_ul.c
1 file changed, 13 insertions(+), 7 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/75/33075/1
diff --git a/src/rlcmac/tbf_ul.c b/src/rlcmac/tbf_ul.c
index 40e993c..b38c750 100644
--- a/src/rlcmac/tbf_ul.c
+++ b/src/rlcmac/tbf_ul.c
@@ -589,13 +589,6 @@
gprs_rlcmac_rlc_ul_window_v_a(ul_tbf->ulw));
if (restart_bsn_cycle(ul_tbf))
return take_next_bsn(ul_tbf, bi, previous_bsn, may_combine);
- } else {
- /* Nothing left to send, create dummy LLC commands */
- LOGPTBFUL(ul_tbf, LOGL_DEBUG, "Sending new dummy block at BSN %d, CS=%s\n",
- gprs_rlcmac_rlc_ul_window_v_s(ul_tbf->ulw),
- gprs_rlcmac_mcs_name(tx_cs));
- bsn = create_new_bsn(ul_tbf, bi, tx_cs);
- /* Don't send a second block, so don't set cs_current_trans */
}
if (bsn < 0) {
--
To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/33075
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-gprs
Gerrit-Branch: master
Gerrit-Change-Id: I062aa9aea4f7d66a70ed53eae1c67780ddc3dca5
Gerrit-Change-Number: 33075
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: newchange
Attention is currently required from: pespin.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/33001 )
Change subject: gmm: Implement rx GMM STATUS msg
......................................................................
Patch Set 4:
(2 comments)
Patchset:
PS4:
btw, it might make sense to do all that kind of logging in a generic place before dispatching to individual functions. The message name could come from a value_string, and the size checks could come from a table/array indexed by msg_type. This would reduce a lot of boilerplate logging code in various places.
File src/gmm/gmm.c:
https://gerrit.osmocom.org/c/libosmo-gprs/+/33001/comment/468d984f_d9c78faf
PS4, Line 1232: GMM GMM
2x GMM?
--
To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/33001
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-gprs
Gerrit-Branch: master
Gerrit-Change-Id: I46719a3bf6d5e93e25f41f01f5c2ab889ff62803
Gerrit-Change-Number: 33001
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 29 May 2023 12:42:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment