Attention is currently required from: laforge.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/33053 )
Change subject: gmm: Tx Auth & Ciph Failure
......................................................................
Patch Set 2:
(1 comment)
File src/gmm/gmm.c:
https://gerrit.osmocom.org/c/libosmo-gprs/+/33053/comment/8c83b84f_d40f670d
PS2, Line 1261: GMM_CAUSE_ILLEGAL_MS
> are we sure about this cause? I only know this cause in the context of the HLR/AUC rejecting a MS on […]
I was unsure which code to pick here, so I just picked this one. I'll see if I can find one more fitting.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/33053
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-gprs
Gerrit-Branch: master
Gerrit-Change-Id: I3ebb3dba20010e57f29dd5b8bbec457c2b08a8e1
Gerrit-Change-Number: 33053
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Mon, 29 May 2023 08:53:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: comment
Attention is currently required from: laforge.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/32997 )
Change subject: gmm: Implement P-TMSI Reallocation Cmd/Compl
......................................................................
Patch Set 1:
(1 comment)
File src/gmm/gmm.c:
https://gerrit.osmocom.org/c/libosmo-gprs/+/32997/comment/8ab6452d_bed3c6df
PS1, Line 1074: IDENTITY
> I'm not sure how this comment relates to the code?
ACK this doesn't belong here, probably copy-paste typo when copying the function signature.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/32997
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-gprs
Gerrit-Branch: master
Gerrit-Change-Id: I1bf8bf5f4299db7b026fed2e2c21c07f15690942
Gerrit-Change-Number: 32997
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Mon, 29 May 2023 08:51:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: comment
falconia has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/33069 )
Change subject: trx TCH DL: transmit invalid speech frames instead of dummy FACCH
......................................................................
trx TCH DL: transmit invalid speech frames instead of dummy FACCH
In speech TCH operation, there will always be times when a speech frame
needs to be transmitted on the downlink, but there is no frame available
to transmit (gap in the incoming RTP stream), or the logic of DTXd says
that no frame shall be transmitted at this FN, but we are not doing
physical DTXd. Previous osmo-bts-trx code sent dummy FACCH during such
conditions, but this approach is bad for TCH/HS where we would like to
transmit good speech frames or speech frame gaps one 20 ms frame at a
time, rather than take out pairs of frames for dummy FACCH/H. Other
BTS models (sysmoBTS PHY) send out invalid speech frames with inverted
CRC3 under the conditions in question - do the same in osmo-bts-trx.
The present change modifies osmo-bts-trx TCH DL frame gap behavior
only for TCH/FS, TCH/HS and TCH/EFS; for all other channel modes,
including AMR speech, the previous behavior of sending dummy FACCH
is left unchanged.
Depends: Iade3310e16b906efb6892d28f474a0d15204e861 (libosmocore)
Change-Id: I78106802a0aa4af39859c75d29fe0e77037899fe
---
M src/osmo-bts-trx/sched_lchan_tchf.c
M src/osmo-bts-trx/sched_lchan_tchh.c
2 files changed, 55 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/69/33069/1
diff --git a/src/osmo-bts-trx/sched_lchan_tchf.c b/src/osmo-bts-trx/sched_lchan_tchf.c
index 0d0f52a..d7a8165 100644
--- a/src/osmo-bts-trx/sched_lchan_tchf.c
+++ b/src/osmo-bts-trx/sched_lchan_tchf.c
@@ -491,8 +491,22 @@
};
LOGL1SB(DL1P, LOGL_DEBUG, l1ts, br, "No TCH or FACCH prim for transmit.\n");
- gsm0503_tch_fr_encode(*bursts_p, dummy, sizeof(dummy), 1);
- chan_state->dl_facch_bursts = 8;
+ /* If the channel mode is TCH/FS or TCH/EFS, transmit a dummy
+ * speech frame with inverted CRC3, designed to induce a BFI
+ * condition in the MS receiver. In all other channel modes,
+ * transmit dummy FACCH like we always did before.
+ *
+ * FIXME: someone who knows AMR needs to look at this problem
+ * and decide what is the correct BTS Tx behavior for frame
+ * gaps in TCH/AFS.
+ */
+ if (tch_mode == GSM48_CMODE_SPEECH_V1 ||
+ tch_mode == GSM48_CMODE_SPEECH_EFR) {
+ gsm0503_tch_fr_encode(*bursts_p, NULL, 0, 1);
+ } else {
+ gsm0503_tch_fr_encode(*bursts_p, dummy, sizeof(dummy), 1);
+ chan_state->dl_facch_bursts = 8;
+ }
goto send_burst;
}
diff --git a/src/osmo-bts-trx/sched_lchan_tchh.c b/src/osmo-bts-trx/sched_lchan_tchh.c
index c6c2cd0..3d51493 100644
--- a/src/osmo-bts-trx/sched_lchan_tchh.c
+++ b/src/osmo-bts-trx/sched_lchan_tchh.c
@@ -404,6 +404,19 @@
};
LOGL1SB(DL1P, LOGL_INFO, l1ts, br, "No TCH or FACCH prim for transmit.\n");
+ /* If the channel mode is TCH/HS, transmit a dummy speech frame
+ * with inverted CRC3, designed to induce a BFI condition in
+ * the MS receiver. In all other channel modes, transmit
+ * dummy FACCH like we always did before.
+ *
+ * FIXME: someone who knows AMR needs to look at this problem
+ * and decide what is the correct BTS Tx behavior for frame
+ * gaps in TCH/AHS.
+ */
+ if (tch_mode == GSM48_CMODE_SPEECH_V1) {
+ gsm0503_tch_hr_encode(*bursts_p, NULL, 0);
+ goto send_burst;
+ }
/* FACCH/H can only be scheduled at specific TDMA offset */
if (!sched_tchh_dl_facch_map[br->fn % 26]) {
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/33069
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I78106802a0aa4af39859c75d29fe0e77037899fe
Gerrit-Change-Number: 33069
Gerrit-PatchSet: 1
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-MessageType: newchange
Attention is currently required from: laforge, pespin, lynxis lazus.
matanp has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/32712 )
Change subject: Add FPLMN read and program
......................................................................
Patch Set 6:
(1 comment)
File pysim-testdata/sysmoUSIM-SJS1.ok:
https://gerrit.osmocom.org/c/pysim/+/32712/comment/fbd00340_45447728
PS5, Line 108: 62f201 # MCC: 262 MNC: 010
> the fix is not mandatory before merging this commit. […]
The only solution I can see is changing `derive_mcc` and `derive_mnc` to return a 'str' instead of 'int' (thus preserving leading 0) - is it an acceptable solution?
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/32712
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I9ce8c1af691c28ea9ed69e7b5f03f0c02d1f029b
Gerrit-Change-Number: 32712
Gerrit-PatchSet: 6
Gerrit-Owner: matanp <matan1008(a)gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Sun, 28 May 2023 04:59:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>
Comment-In-Reply-To: matanp <matan1008(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: pespin, lynxis lazus, matanp.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/32712 )
Change subject: Add FPLMN read and program
......................................................................
Patch Set 6: Code-Review+1
(1 comment)
File pysim-testdata/sysmoUSIM-SJS1.ok:
https://gerrit.osmocom.org/c/pysim/+/32712/comment/d59fa256_bc5d50fb
PS5, Line 108: 62f201 # MCC: 262 MNC: 010
> Seems like a bug in `format_xplmn` (from utils), should I add a commit that fixes it before this com […]
the fix is not mandatory before merging this commit. but if you want to contribute a fix, please by all means submit it (whether before or afte r). Thanks
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/32712
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I9ce8c1af691c28ea9ed69e7b5f03f0c02d1f029b
Gerrit-Change-Number: 32712
Gerrit-PatchSet: 6
Gerrit-Owner: matanp <matan1008(a)gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Attention: matanp <matan1008(a)gmail.com>
Gerrit-Comment-Date: Sun, 28 May 2023 04:51:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>
Comment-In-Reply-To: matanp <matan1008(a)gmail.com>
Gerrit-MessageType: comment