May 2023 - gerrit-log - lists.osmocom.org

[M] Change in osmo-ttcn3-hacks[master]: BTS_Tests: add TC_data_rtp_tch* for CSD

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33072 ) Change subject: BTS_Tests: add TC_data_rtp_tch* for CSD ...................................................................... BTS_Tests: add TC_data_rtp_tch* for CSD As a quick hack, the new testcases are built upon f_TC_speech_rtp(). The RTP payloads are (temporarily) expected to contain CSD-modified frames with unpacked bits, e.g. 240 bytes (0x00/0x01) for TCH/F9.6. Change-Id: I9a0dc0fcf722f862d8dcf04660d4448662210f44 Related: osmo-bts.git I08ffbf8e79ce76a586d61f5463890c6e72a6d9b9 Related: osmocom-bb.git I0d7389a9a5f7019b9316ab1c0115797ff54a0e41 Related: OS#1572, OS#4396 --- M bts/BTS_Tests.ttcn M bts/expected-results.xml 2 files changed, 169 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/72/33072/1 diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn index e715996..9838d1d 100644 --- a/bts/BTS_Tests.ttcn +++ b/bts/BTS_Tests.ttcn @@ -2641,6 +2641,20 @@ payload_len := f_amrft_payload_len(amr_ft) + 2; hdr := enc_RTP_AMR_Hdr(valueof(ts_RTP_AMR_Hdr(amr_ft, amr_ft, '1'B))); } + case (tr_RSL_ChanMode_DATA(RSL_CHRT_TCH_F, (RSL_CMOD_CSD_T_14k4, RSL_CMOD_CSD_NT_14k5))) + { payload_len := 290; payload := ''O; pad := '01'O; } + case (tr_RSL_ChanMode_DATA(RSL_CHRT_TCH_F, (RSL_CMOD_CSD_T_9k6, RSL_CMOD_CSD_NT_12k0))) + { payload_len := 4 * 60; payload := ''O; pad := '01'O; } + case (tr_RSL_ChanMode_DATA(RSL_CHRT_TCH_F, (RSL_CMOD_CSD_T_4k8, RSL_CMOD_CSD_NT_6k0))) + { payload_len := 2 * 60; payload := ''O; pad := '01'O; } + case (tr_RSL_ChanMode_DATA(RSL_CHRT_TCH_H, (RSL_CMOD_CSD_T_4k8, RSL_CMOD_CSD_NT_6k0))) + { payload_len := 4 * 60; payload := ''O; pad := '01'O; } + case (tr_RSL_ChanMode_DATA(RSL_CHRT_TCH_F, (RSL_CMOD_CSD_T_2k4, RSL_CMOD_CSD_T_1k2, + RSL_CMOD_CSD_T_600, RSL_CMOD_CSD_T_1200_75))) + { payload_len := 2 * 36; payload := ''O; pad := '01'O; } + case (tr_RSL_ChanMode_DATA(RSL_CHRT_TCH_H, (RSL_CMOD_CSD_T_2k4, RSL_CMOD_CSD_T_1k2, + RSL_CMOD_CSD_T_600, RSL_CMOD_CSD_T_1200_75))) + { payload_len := 2 * 36; payload := ''O; pad := '01'O; } case else { setverdict(fail, "Unhandled RSL channel mode := ", g_pars.chan_mode); Misc_Helpers.f_shutdown(__BFILE__, __LINE__); @@ -8447,6 +8461,132 @@ Misc_Helpers.f_shutdown(__BFILE__, __LINE__); } +/* CSD channel tests */ +testcase TC_data_rtp_tchf144() runs on test_CT { + var ConnHdlr vc_conn; + var ConnHdlrPars pars; + + f_init(); + + /* TS1, TCH/F14.4 (14k5 radio interface rate), transparent service */ + pars := valueof(t_Pars(ts_RslChanNr_Bm(1), + ts_RSL_ChanMode_DATA(RSL_CHRT_TCH_F, RSL_CMOD_CSD_T_14k4))); + vc_conn := f_start_handler(refers(f_TC_speech_rtp), pars); + vc_conn.done; + + /* TS1, TCH/F14.4 (14k5 radio interface rate), non-transparent service */ + pars := valueof(t_Pars(ts_RslChanNr_Bm(1), + ts_RSL_ChanMode_DATA(RSL_CHRT_TCH_F, RSL_CMOD_CSD_NT_14k5))); + vc_conn := f_start_handler(refers(f_TC_speech_rtp), pars); + vc_conn.done; + + Misc_Helpers.f_shutdown(__BFILE__, __LINE__); +} + +testcase TC_data_rtp_tchf96() runs on test_CT { + var ConnHdlr vc_conn; + var ConnHdlrPars pars; + + f_init(); + + /* TS1, TCH/F9.6 (12k radio interface rate), transparent service */ + pars := valueof(t_Pars(ts_RslChanNr_Bm(1), + ts_RSL_ChanMode_DATA(RSL_CHRT_TCH_F, RSL_CMOD_CSD_T_9k6))); + vc_conn := f_start_handler(refers(f_TC_speech_rtp), pars); + vc_conn.done; + + /* TS1, TCH/F9.6 (12k radio interface rate), non-transparent service */ + pars := valueof(t_Pars(ts_RslChanNr_Bm(1), + ts_RSL_ChanMode_DATA(RSL_CHRT_TCH_F, RSL_CMOD_CSD_NT_12k0))); + vc_conn := f_start_handler(refers(f_TC_speech_rtp), pars); + vc_conn.done; + + Misc_Helpers.f_shutdown(__BFILE__, __LINE__); +} + +testcase TC_data_rtp_tchf48() runs on test_CT { + var ConnHdlr vc_conn; + var ConnHdlrPars pars; + + f_init(); + + /* TS1, TCH/F4.8 (6k radio interface rate), transparent service */ + pars := valueof(t_Pars(ts_RslChanNr_Bm(1), + ts_RSL_ChanMode_DATA(RSL_CHRT_TCH_F, RSL_CMOD_CSD_T_4k8))); + vc_conn := f_start_handler(refers(f_TC_speech_rtp), pars); + vc_conn.done; + + /* TS1, TCH/F4.8 (6k radio interface rate), non-transparent service */ + pars := valueof(t_Pars(ts_RslChanNr_Bm(1), + ts_RSL_ChanMode_DATA(RSL_CHRT_TCH_F, RSL_CMOD_CSD_NT_6k0))); + vc_conn := f_start_handler(refers(f_TC_speech_rtp), pars); + vc_conn.done; + + Misc_Helpers.f_shutdown(__BFILE__, __LINE__); +} + +testcase TC_data_rtp_tchh48() runs on test_CT { + var ConnHdlr vc_conn; + var ConnHdlrPars pars; + + f_init(); + + /* TS1, TCH/H4.8 (6k radio interface rate), transparent service */ + pars := valueof(t_Pars(ts_RslChanNr_Lm(5, 0), + ts_RSL_ChanMode_DATA(RSL_CHRT_TCH_H, RSL_CMOD_CSD_T_4k8))); + vc_conn := f_start_handler(refers(f_TC_speech_rtp), pars); + vc_conn.done; + + /* TS1, TCH/H4.8 (6k radio interface rate), non-transparent service */ + pars := valueof(t_Pars(ts_RslChanNr_Lm(5, 0), + ts_RSL_ChanMode_DATA(RSL_CHRT_TCH_H, RSL_CMOD_CSD_NT_6k0))); + vc_conn := f_start_handler(refers(f_TC_speech_rtp), pars); + vc_conn.done; + + Misc_Helpers.f_shutdown(__BFILE__, __LINE__); +} + +testcase TC_data_rtp_tchf24() runs on test_CT { + var ConnHdlr vc_conn; + var ConnHdlrPars pars; + + f_init(); + + /* TS1, TCH/F2.4 (3k6 radio interface rate), transparent services only */ + pars := valueof(t_Pars(ts_RslChanNr_Bm(1), + ts_RSL_ChanMode_DATA(RSL_CHRT_TCH_F, RSL_CMOD_CSD_T_2k4))); + vc_conn := f_start_handler(refers(f_TC_speech_rtp), pars); + vc_conn.done; + + pars := valueof(t_Pars(ts_RslChanNr_Bm(1), + ts_RSL_ChanMode_DATA(RSL_CHRT_TCH_F, RSL_CMOD_CSD_T_1k2))); + vc_conn := f_start_handler(refers(f_TC_speech_rtp), pars); + vc_conn.done; + + Misc_Helpers.f_shutdown(__BFILE__, __LINE__); +} + +testcase TC_data_rtp_tchh24() runs on test_CT { + var ConnHdlr vc_conn; + var ConnHdlrPars pars; + + f_init(); + + /* TS1, TCH/H2.4 (3k6 radio interface rate), transparent services only */ + pars := valueof(t_Pars(ts_RslChanNr_Lm(5, 0), + ts_RSL_ChanMode_DATA(RSL_CHRT_TCH_H, RSL_CMOD_CSD_T_2k4))); + vc_conn := f_start_handler(refers(f_TC_speech_rtp), pars); + vc_conn.done; + + pars := valueof(t_Pars(ts_RslChanNr_Lm(5, 0), + ts_RSL_ChanMode_DATA(RSL_CHRT_TCH_H, RSL_CMOD_CSD_T_1k2))); + vc_conn := f_start_handler(refers(f_TC_speech_rtp), pars); + vc_conn.done; + + Misc_Helpers.f_shutdown(__BFILE__, __LINE__); +} + + private function f_TC_early_immediate_assignment(charstring id) runs on ConnHdlr { var GsmFrameNumber fn; var ChannelDescription ch_desc; @@ -9047,6 +9187,13 @@ execute( TC_speech_osmux_tchf() ); execute( TC_speech_osmux_tchh() ); + execute( TC_data_rtp_tchf144() ); + execute( TC_data_rtp_tchf96() ); + execute( TC_data_rtp_tchf48() ); + execute( TC_data_rtp_tchh48() ); + execute( TC_data_rtp_tchf24() ); + execute( TC_data_rtp_tchh24() ); + execute( TC_early_immediate_assignment() ); execute( TC_acch_overpower_rxqual_thresh() ); diff --git a/bts/expected-results.xml b/bts/expected-results.xml index f559132..8f3ac5b 100644 --- a/bts/expected-results.xml +++ b/bts/expected-results.xml @@ -180,6 +180,12 @@ <testcase classname='BTS_Tests' name='TC_speech_rtp_tchh' time='MASKED'/> <testcase classname='BTS_Tests' name='TC_speech_osmux_tchf' time='MASKED'/> <testcase classname='BTS_Tests' name='TC_speech_osmux_tchh' time='MASKED'/> + <testcase classname='BTS_Tests' name='TC_data_rtp_tchf144' time='MASKED'/> + <testcase classname='BTS_Tests' name='TC_data_rtp_tchf96' time='MASKED'/> + <testcase classname='BTS_Tests' name='TC_data_rtp_tchf48' time='MASKED'/> + <testcase classname='BTS_Tests' name='TC_data_rtp_tchh48' time='MASKED'/> + <testcase classname='BTS_Tests' name='TC_data_rtp_tchf24' time='MASKED'/> + <testcase classname='BTS_Tests' name='TC_data_rtp_tchh24' time='MASKED'/> <testcase classname='BTS_Tests' name='TC_early_immediate_assignment' time='MASKED'/> <testcase classname='BTS_Tests' name='TC_acch_overpower_rxqual_thresh' time='MASKED'/> <testcase classname='BTS_Tests' name='TC_acch_overpower_rxqual_thresh_dtx' time='MASKED'/> -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33072 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9a0dc0fcf722f862d8dcf04660d4448662210f44 Gerrit-Change-Number: 33072 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 1 month

1
0
0 0

[L] Change in osmo-bts[master]: FR/HR/EFR TCH DL: implement DTX rules

by pespin

Attention is currently required from: falconia, fixeria, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32714 ) Change subject: FR/HR/EFR TCH DL: implement DTX rules ...................................................................... Patch Set 8: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32714 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I924ab21952dcf8bb03ba7ccef790474bf66fc9e5 Gerrit-Change-Number: 32714 Gerrit-PatchSet: 8 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 29 May 2023 09:19:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[M] Change in libosmo-gprs[master]: gmm: Tx Auth & Ciph Failure

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/33053 ) Change subject: gmm: Tx Auth & Ciph Failure ...................................................................... Patch Set 2: (1 comment) File src/gmm/gmm.c: https://gerrit.osmocom.org/c/libosmo-gprs/+/33053/comment/8c83b84f_d40f670d PS2, Line 1261: GMM_CAUSE_ILLEGAL_MS > are we sure about this cause? I only know this cause in the context of the HLR/AUC rejecting a MS on […] I was unsure which code to pick here, so I just picked this one. I'll see if I can find one more fitting. -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/33053 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I3ebb3dba20010e57f29dd5b8bbec457c2b08a8e1 Gerrit-Change-Number: 33053 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 29 May 2023 08:53:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[M] Change in libosmo-gprs[master]: gmm: Initial implementation of rx GMM Information msg

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/33002 ) Change subject: gmm: Initial implementation of rx GMM Information msg ...................................................................... Patch Set 3: (1 comment) File src/gmm/gmm.c: https://gerrit.osmocom.org/c/libosmo-gprs/+/33002/comment/b9f56a52_c7b89a1c PS3, Line 1259: RAU ACCEPT > INFO ? Ack -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/33002 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I9b81f8f9113a95cc75666dac5ff9e315d0845fcb Gerrit-Change-Number: 33002 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 29 May 2023 08:51:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[S] Change in libosmo-gprs[master]: gmm: Implement rx GMM STATUS msg

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/33001 ) Change subject: gmm: Implement rx GMM STATUS msg ...................................................................... Patch Set 3: (1 comment) File src/gmm/gmm.c: https://gerrit.osmocom.org/c/libosmo-gprs/+/33001/comment/3b16e94b_930ce7cd PS3, Line 1236: IDENTITY > STATUS ? Ack -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/33001 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I46719a3bf6d5e93e25f41f01f5c2ab889ff62803 Gerrit-Change-Number: 33001 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 29 May 2023 08:51:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[M] Change in libosmo-gprs[master]: gmm: Implement P-TMSI Reallocation Cmd/Compl

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/32997 ) Change subject: gmm: Implement P-TMSI Reallocation Cmd/Compl ...................................................................... Patch Set 1: (1 comment) File src/gmm/gmm.c: https://gerrit.osmocom.org/c/libosmo-gprs/+/32997/comment/8ab6452d_bed3c6df PS1, Line 1074: IDENTITY > I'm not sure how this comment relates to the code? ACK this doesn't belong here, probably copy-paste typo when copying the function signature. -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/32997 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I1bf8bf5f4299db7b026fed2e2c21c07f15690942 Gerrit-Change-Number: 32997 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 29 May 2023 08:51:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[S] Change in pysim[master]: setup.py: fix syntax errors (missing commas)

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/33070 ) Change subject: setup.py: fix syntax errors (missing commas) ...................................................................... setup.py: fix syntax errors (missing commas) Change-Id: Ia53a659ad9652d582e2bf4a039a3e18631435072 Fixes: 2b15e315 "setup: add missing pyyaml to setup.py and README.md" Fixes: 93aac3ab "pySim-shell: fix compatibility problem with cmd2 >= 2.0.0 (Settable)" --- M setup.py 1 file changed, 14 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/70/33070/1 diff --git a/setup.py b/setup.py index 4b39c63..d14ebc6 100644 --- a/setup.py +++ b/setup.py @@ -17,11 +17,11 @@ "construct >= 2.9.51", "bidict", "gsm0338", - "pyyaml >= 5.1" + "pyyaml >= 5.1", "termcolor", "colorlog", - "pycryptodome" - "packaging" + "pycryptodome", + "packaging", ], scripts=[ 'pySim-prog.py', -- To view, visit https://gerrit.osmocom.org/c/pysim/+/33070 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ia53a659ad9652d582e2bf4a039a3e18631435072 Gerrit-Change-Number: 33070 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 1 month

1
0
0 0

[M] Change in osmo-bts[master]: trx TCH DL: transmit invalid speech frames instead of dummy FACCH

by falconia

falconia has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/33069 ) Change subject: trx TCH DL: transmit invalid speech frames instead of dummy FACCH ...................................................................... trx TCH DL: transmit invalid speech frames instead of dummy FACCH In speech TCH operation, there will always be times when a speech frame needs to be transmitted on the downlink, but there is no frame available to transmit (gap in the incoming RTP stream), or the logic of DTXd says that no frame shall be transmitted at this FN, but we are not doing physical DTXd. Previous osmo-bts-trx code sent dummy FACCH during such conditions, but this approach is bad for TCH/HS where we would like to transmit good speech frames or speech frame gaps one 20 ms frame at a time, rather than take out pairs of frames for dummy FACCH/H. Other BTS models (sysmoBTS PHY) send out invalid speech frames with inverted CRC3 under the conditions in question - do the same in osmo-bts-trx. The present change modifies osmo-bts-trx TCH DL frame gap behavior only for TCH/FS, TCH/HS and TCH/EFS; for all other channel modes, including AMR speech, the previous behavior of sending dummy FACCH is left unchanged. Depends: Iade3310e16b906efb6892d28f474a0d15204e861 (libosmocore) Change-Id: I78106802a0aa4af39859c75d29fe0e77037899fe --- M src/osmo-bts-trx/sched_lchan_tchf.c M src/osmo-bts-trx/sched_lchan_tchh.c 2 files changed, 55 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/69/33069/1 diff --git a/src/osmo-bts-trx/sched_lchan_tchf.c b/src/osmo-bts-trx/sched_lchan_tchf.c index 0d0f52a..d7a8165 100644 --- a/src/osmo-bts-trx/sched_lchan_tchf.c +++ b/src/osmo-bts-trx/sched_lchan_tchf.c @@ -491,8 +491,22 @@ }; LOGL1SB(DL1P, LOGL_DEBUG, l1ts, br, "No TCH or FACCH prim for transmit.\n"); - gsm0503_tch_fr_encode(*bursts_p, dummy, sizeof(dummy), 1); - chan_state->dl_facch_bursts = 8; + /* If the channel mode is TCH/FS or TCH/EFS, transmit a dummy + * speech frame with inverted CRC3, designed to induce a BFI + * condition in the MS receiver. In all other channel modes, + * transmit dummy FACCH like we always did before. + * + * FIXME: someone who knows AMR needs to look at this problem + * and decide what is the correct BTS Tx behavior for frame + * gaps in TCH/AFS. + */ + if (tch_mode == GSM48_CMODE_SPEECH_V1 || + tch_mode == GSM48_CMODE_SPEECH_EFR) { + gsm0503_tch_fr_encode(*bursts_p, NULL, 0, 1); + } else { + gsm0503_tch_fr_encode(*bursts_p, dummy, sizeof(dummy), 1); + chan_state->dl_facch_bursts = 8; + } goto send_burst; } diff --git a/src/osmo-bts-trx/sched_lchan_tchh.c b/src/osmo-bts-trx/sched_lchan_tchh.c index c6c2cd0..3d51493 100644 --- a/src/osmo-bts-trx/sched_lchan_tchh.c +++ b/src/osmo-bts-trx/sched_lchan_tchh.c @@ -404,6 +404,19 @@ }; LOGL1SB(DL1P, LOGL_INFO, l1ts, br, "No TCH or FACCH prim for transmit.\n"); + /* If the channel mode is TCH/HS, transmit a dummy speech frame + * with inverted CRC3, designed to induce a BFI condition in + * the MS receiver. In all other channel modes, transmit + * dummy FACCH like we always did before. + * + * FIXME: someone who knows AMR needs to look at this problem + * and decide what is the correct BTS Tx behavior for frame + * gaps in TCH/AHS. + */ + if (tch_mode == GSM48_CMODE_SPEECH_V1) { + gsm0503_tch_hr_encode(*bursts_p, NULL, 0); + goto send_burst; + } /* FACCH/H can only be scheduled at specific TDMA offset */ if (!sched_tchh_dl_facch_map[br->fn % 26]) { -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/33069 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I78106802a0aa4af39859c75d29fe0e77037899fe Gerrit-Change-Number: 33069 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-MessageType: newchange

2 years, 1 month

1
0
0 0

[M] Change in pysim[master]: Add FPLMN read and program

by matanp

Attention is currently required from: laforge, pespin, lynxis lazus. matanp has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/32712 ) Change subject: Add FPLMN read and program ...................................................................... Patch Set 6: (1 comment) File pysim-testdata/sysmoUSIM-SJS1.ok: https://gerrit.osmocom.org/c/pysim/+/32712/comment/fbd00340_45447728 PS5, Line 108: 62f201 # MCC: 262 MNC: 010 > the fix is not mandatory before merging this commit. […] The only solution I can see is changing `derive_mcc` and `derive_mnc` to return a 'str' instead of 'int' (thus preserving leading 0) - is it an acceptable solution? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/32712 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I9ce8c1af691c28ea9ed69e7b5f03f0c02d1f029b Gerrit-Change-Number: 32712 Gerrit-PatchSet: 6 Gerrit-Owner: matanp <matan1008(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Sun, 28 May 2023 04:59:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu> Comment-In-Reply-To: matanp <matan1008(a)gmail.com> Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[M] Change in pysim[master]: Add FPLMN read and program

by laforge

Attention is currently required from: pespin, lynxis lazus, matanp. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/32712 ) Change subject: Add FPLMN read and program ...................................................................... Patch Set 6: Code-Review+1 (1 comment) File pysim-testdata/sysmoUSIM-SJS1.ok: https://gerrit.osmocom.org/c/pysim/+/32712/comment/d59fa256_bc5d50fb PS5, Line 108: 62f201 # MCC: 262 MNC: 010 > Seems like a bug in `format_xplmn` (from utils), should I add a commit that fixes it before this com […] the fix is not mandatory before merging this commit. but if you want to contribute a fix, please by all means submit it (whether before or afte r). Thanks -- To view, visit https://gerrit.osmocom.org/c/pysim/+/32712 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I9ce8c1af691c28ea9ed69e7b5f03f0c02d1f029b Gerrit-Change-Number: 32712 Gerrit-PatchSet: 6 Gerrit-Owner: matanp <matan1008(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: matanp <matan1008(a)gmail.com> Gerrit-Comment-Date: Sun, 28 May 2023 04:51:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu> Comment-In-Reply-To: matanp <matan1008(a)gmail.com> Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

2025

2024

2023

2022

gerrit-log May 2023