May 2023 - gerrit-log - lists.osmocom.org

[S] Change in libosmo-gprs[master]: gmm: Fix typo checking IE presence in Rx Attach Rej

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/33055 ) Change subject: gmm: Fix typo checking IE presence in Rx Attach Rej ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Patchset: PS2: [looks more like copy+paste rather than typo] -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/33055 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Ifaf653d89efd4ff4776e0e9b9e8dff625c4f9ebb Gerrit-Change-Number: 33055 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sun, 28 May 2023 04:37:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[M] Change in libosmo-gprs[master]: gmm: Initial implementation of T3166, rx Auth & Ciph Reject

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/33054 ) Change subject: gmm: Initial implementation of T3166, rx Auth & Ciph Reject ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/33054 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I2c24b968e90cf5ec71fa8a777ec57b407eec015f Gerrit-Change-Number: 33054 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sun, 28 May 2023 04:36:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[M] Change in libosmo-gprs[master]: gmm: Tx Auth & Ciph Failure

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/33053 ) Change subject: gmm: Tx Auth & Ciph Failure ...................................................................... Patch Set 2: (1 comment) File src/gmm/gmm.c: https://gerrit.osmocom.org/c/libosmo-gprs/+/33053/comment/2e41a951_5fbb6efe PS2, Line 1261: GMM_CAUSE_ILLEGAL_MS are we sure about this cause? I only know this cause in the context of the HLR/AUC rejecting a MS on a permanent basis. This part in the code looks more like some kind of temporary local error? -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/33053 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I3ebb3dba20010e57f29dd5b8bbec457c2b08a8e1 Gerrit-Change-Number: 33053 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sun, 28 May 2023 04:35:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[S] Change in libosmo-gprs[master]: gmm: Rename s/ciph_auth/auth_ciph/

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/33052 ) Change subject: gmm: Rename s/ciph_auth/auth_ciph/ ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/33052 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I02c7edede8db8dbe94e129529ad8fb03fe1b4089 Gerrit-Change-Number: 33052 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sun, 28 May 2023 04:33:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[M] Change in libosmo-gprs[master]: gmm: Initial implementation of rx GMM Information msg

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/33002 ) Change subject: gmm: Initial implementation of rx GMM Information msg ...................................................................... Patch Set 3: (1 comment) File src/gmm/gmm.c: https://gerrit.osmocom.org/c/libosmo-gprs/+/33002/comment/8bd00730_f731a668 PS3, Line 1259: RAU ACCEPT INFO ? -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/33002 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I9b81f8f9113a95cc75666dac5ff9e315d0845fcb Gerrit-Change-Number: 33002 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sun, 28 May 2023 04:33:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[S] Change in libosmo-gprs[master]: gmm: Implement rx GMM STATUS msg

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/33001 ) Change subject: gmm: Implement rx GMM STATUS msg ...................................................................... Patch Set 3: (1 comment) File src/gmm/gmm.c: https://gerrit.osmocom.org/c/libosmo-gprs/+/33001/comment/ea261015_41e0b960 PS3, Line 1236: IDENTITY STATUS ? -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/33001 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I46719a3bf6d5e93e25f41f01f5c2ab889ff62803 Gerrit-Change-Number: 33001 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sun, 28 May 2023 04:31:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[S] Change in libosmo-gprs[master]: gmm: Implement submitting GMMSM-RELEASE.ind when MS becomes detached

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/33000 ) Change subject: gmm: Implement submitting GMMSM-RELEASE.ind when MS becomes detached ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/33000 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I74176eba870b19b30666ab5deef5eb56f0f0fd83 Gerrit-Change-Number: 33000 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sun, 28 May 2023 04:31:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[S] Change in libosmo-gprs[master]: gmm: Stop READY timer upon receiving force_stdby IE

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/32998 ) Change subject: gmm: Stop READY timer upon receiving force_stdby IE ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/32998 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I44d0f69571f6425fef74a10602001aca4ecb5716 Gerrit-Change-Number: 32998 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sun, 28 May 2023 04:30:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[M] Change in libosmo-gprs[master]: gmm: Implement P-TMSI Reallocation Cmd/Compl

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/32997 ) Change subject: gmm: Implement P-TMSI Reallocation Cmd/Compl ...................................................................... Patch Set 1: (1 comment) File src/gmm/gmm.c: https://gerrit.osmocom.org/c/libosmo-gprs/+/32997/comment/150c5f0e_56a9edb0 PS1, Line 1074: IDENTITY I'm not sure how this comment relates to the code? -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/32997 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I1bf8bf5f4299db7b026fed2e2c21c07f15690942 Gerrit-Change-Number: 32997 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sun, 28 May 2023 04:30:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[L] Change in osmo-bts[master]: FR/HR/EFR TCH DL: implement DTX rules

by falconia

Attention is currently required from: laforge, pespin, fixeria, dexter. falconia has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32714 ) Change subject: FR/HR/EFR TCH DL: implement DTX rules ...................................................................... Patch Set 8: (2 comments) This change is ready for review. Commit Message: https://gerrit.osmocom.org/c/osmo-bts/+/32714/comment/15f8732c_13b74341 PS2, Line 8: > The new patchset has a reworded commit message - please review. The latest version explicitly refers to DTX and all 3 codecs in the one-line commit summary. File src/common/l1sap.c: https://gerrit.osmocom.org/c/osmo-bts/+/32714/comment/822fd6b6_5cd956b8 PS4, Line 1393: * until OS#5688 is resolved. */ > It looks like I need to change that comment and include a longer explanation of why I am not support […] OS#5688 is now solved on the BTS side, and the current version of the present patch supports all 3 codecs. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32714 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I924ab21952dcf8bb03ba7ccef790474bf66fc9e5 Gerrit-Change-Number: 32714 Gerrit-PatchSet: 8 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Sat, 27 May 2023 20:37:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: falconia <falcon(a)freecalypso.org> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

2025

2024

2023

2022

gerrit-log May 2023