Attention is currently required from: pespin.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/33053 )
Change subject: gmm: Tx Auth & Ciph Failure
......................................................................
Patch Set 2:
(1 comment)
File src/gmm/gmm.c:
https://gerrit.osmocom.org/c/libosmo-gprs/+/33053/comment/2e41a951_5fbb6efe
PS2, Line 1261: GMM_CAUSE_ILLEGAL_MS
are we sure about this cause? I only know this cause in the context of the HLR/AUC rejecting a MS on a permanent basis. This part in the code looks more like some kind of temporary local error?
--
To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/33053
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-gprs
Gerrit-Branch: master
Gerrit-Change-Id: I3ebb3dba20010e57f29dd5b8bbec457c2b08a8e1
Gerrit-Change-Number: 33053
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Sun, 28 May 2023 04:35:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: pespin.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/32997 )
Change subject: gmm: Implement P-TMSI Reallocation Cmd/Compl
......................................................................
Patch Set 1:
(1 comment)
File src/gmm/gmm.c:
https://gerrit.osmocom.org/c/libosmo-gprs/+/32997/comment/150c5f0e_56a9edb0
PS1, Line 1074: IDENTITY
I'm not sure how this comment relates to the code?
--
To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/32997
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-gprs
Gerrit-Branch: master
Gerrit-Change-Id: I1bf8bf5f4299db7b026fed2e2c21c07f15690942
Gerrit-Change-Number: 32997
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Sun, 28 May 2023 04:30:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: laforge, pespin, fixeria, dexter.
falconia has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32714 )
Change subject: FR/HR/EFR TCH DL: implement DTX rules
......................................................................
Patch Set 8:
(2 comments)
This change is ready for review.
Commit Message:
https://gerrit.osmocom.org/c/osmo-bts/+/32714/comment/15f8732c_13b74341
PS2, Line 8:
> The new patchset has a reworded commit message - please review.
The latest version explicitly refers to DTX and all 3 codecs in the one-line commit summary.
File src/common/l1sap.c:
https://gerrit.osmocom.org/c/osmo-bts/+/32714/comment/822fd6b6_5cd956b8
PS4, Line 1393: * until OS#5688 is resolved. */
> It looks like I need to change that comment and include a longer explanation of why I am not support […]
OS#5688 is now solved on the BTS side, and the current version of the present patch supports all 3 codecs.
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32714
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I924ab21952dcf8bb03ba7ccef790474bf66fc9e5
Gerrit-Change-Number: 32714
Gerrit-PatchSet: 8
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Sat, 27 May 2023 20:37:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: falconia <falcon(a)freecalypso.org>
Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>
Gerrit-MessageType: comment