May 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ci[master]: jobs/master: add workspace.tar.xz to artifacts

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/32938 ) Change subject: jobs/master: add workspace.tar.xz to artifacts ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/32938 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I40b738558b83efc9256e5d5c48ffce42ddce9a8a Gerrit-Change-Number: 32938 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 23 May 2023 14:26:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[S] Change in osmo-ci[master]: jobs/master-builds: add IS_MASTER_BUILD=1

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/32937 ) Change subject: jobs/master-builds: add IS_MASTER_BUILD=1 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/32937 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I6cd5f0383fcceaf77e5fa2f7441f9ae9aa8e8734 Gerrit-Change-Number: 32937 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 23 May 2023 14:26:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[S] Change in osmo-bsc[master]: contrib/jenkins: create workspace.tar.xz on error

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/32940 ) Change subject: contrib/jenkins: create workspace.tar.xz on error ...................................................................... contrib/jenkins: create workspace.tar.xz on error In order to figure out why we sometimes get a coredump in the jenkins master jobs, add a quick hack to get all relevant binaries on libraries on error. Related: OS#5665 Change-Id: I1439c06316edbe11f162c14774c2d507152b97a7 --- M contrib/jenkins.sh 1 file changed, 28 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/40/32940/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 4380f16..f9d944a 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -4,8 +4,20 @@ # environment variables: # * WITH_MANUALS: build manual PDFs if set to "1" # * PUBLISH: upload manuals after building if set to "1" (ignored without WITH_MANUALS = "1") +# * IS_MASTER_BUILD: set to 1 when running from master-builds (not gerrit-verifications) # +exit_tar_workspace() { + cat-testlogs.sh + + if [ "$IS_MASTER_BUILD" = "1" ]; then + tar -cJf "/tmp/workspace.tar.xz" "$base" + mv /tmp/workspace.tar.xz "$base" + fi + + exit 1 +} + if ! [ -x "$(command -v osmo-build-dep.sh)" ]; then echo "Error: We need to have scripts/osmo-deps.sh from http://git.osmocom.org/osmo-ci/ in PATH !" exit 2 @@ -68,11 +80,11 @@ ./configure --enable-sanitize --enable-external-tests --enable-werror $CONFIG $MAKE $PARALLEL_MAKE LD_LIBRARY_PATH="$inst/lib" $MAKE check \ - || cat-testlogs.sh + || exit_tar_workspace LD_LIBRARY_PATH="$inst/lib" \ DISTCHECK_CONFIGURE_FLAGS="--enable-vty-tests --enable-external-tests --enable-werror $CONFIG" \ $MAKE $PARALLEL_MAKE distcheck \ - || cat-testlogs.sh + || exit_tar_workspace if [ "$WITH_MANUALS" = "1" ] && [ "$PUBLISH" = "1" ]; then make -C "$base/doc/manuals" publish -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32940 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I1439c06316edbe11f162c14774c2d507152b97a7 Gerrit-Change-Number: 32940 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 1 month

1
0
0 0

[S] Change in osmo-msc[master]: contrib/jenkins: create workspace.tar.xz on error

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/32939 ) Change subject: contrib/jenkins: create workspace.tar.xz on error ...................................................................... contrib/jenkins: create workspace.tar.xz on error In order to figure out why we sometimes get a coredump in the jenkins master jobs, add a quick hack to get all relevant binaries on libraries on error. Related: OS#5665 Change-Id: If7b4eb050e2b3f763b5cfddf1a5b6a18bb41f46e --- M contrib/jenkins.sh 1 file changed, 27 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/39/32939/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 558b6dc..fc3eb12 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -5,6 +5,7 @@ # * IU: configure 3G support (values: "--enable-iu", "--disable-iu") # * WITH_MANUALS: build manual PDFs if set to "1" # * PUBLISH: upload manuals after building if set to "1" (ignored without WITH_MANUALS = "1") +# * IS_MASTER_BUILD: set to 1 when running from master-builds (not gerrit-verifications) # if ! [ -x "$(command -v osmo-build-dep.sh)" ]; then @@ -12,6 +13,16 @@ exit 2 fi +exit_tar_workspace() { + cat-testlogs.sh + + if [ "$IS_MASTER_BUILD" = "1" ]; then + tar -cJf "/tmp/workspace.tar.xz" "$base" + mv /tmp/workspace.tar.xz "$base" + fi + + exit 1 +} set -ex @@ -64,11 +75,11 @@ ./configure --enable-sanitize --enable-werror --enable-smpp $IU --enable-external-tests $CONFIG $MAKE $PARALLEL_MAKE LD_LIBRARY_PATH="$inst/lib" $MAKE check \ - || cat-testlogs.sh + || exit_tar_workspace LD_LIBRARY_PATH="$inst/lib" \ DISTCHECK_CONFIGURE_FLAGS="--enable-werror --enable-smpp $IU --enable-external-tests $CONFIG" \ $MAKE $PARALLEL_MAKE distcheck \ - || cat-testlogs.sh + || exit_tar_workspace if [ "$WITH_MANUALS" = "1" ] && [ "$PUBLISH" = "1" ]; then make -C "$base/doc/manuals" publish -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/32939 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: If7b4eb050e2b3f763b5cfddf1a5b6a18bb41f46e Gerrit-Change-Number: 32939 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 1 month

1
0
0 0

[S] Change in osmo-ci[master]: jobs/master-builds: add IS_MASTER_BUILD=1

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/32937 ) Change subject: jobs/master-builds: add IS_MASTER_BUILD=1 ...................................................................... jobs/master-builds: add IS_MASTER_BUILD=1 Related: OS#5665 Change-Id: I6cd5f0383fcceaf77e5fa2f7441f9ae9aa8e8734 --- M jobs/master-builds.yml 1 file changed, 12 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/37/32937/1 diff --git a/jobs/master-builds.yml b/jobs/master-builds.yml index c373ca7..6e76b9a 100644 --- a/jobs/master-builds.yml +++ b/jobs/master-builds.yml @@ -26,6 +26,7 @@ --cap-add SYS_PTRACE \ -e ASCIIDOC_WARNINGS_CHECK="1" \ -e HOME=/build \ + -e IS_MASTER_BUILD=1 \ -e JOB_NAME="$JOB_NAME" \ -e MAKE=make \ -e OSMOPY_DEBUG_TCP_SOCKETS="1" \ @@ -47,6 +48,7 @@ --cap-add SYS_PTRACE \ -e ASCIIDOC_WARNINGS_CHECK="1" \ -e HOME=/build \ + -e IS_MASTER_BUILD=1 \ -e JOB_NAME="$JOB_NAME" \ -e MAKE=make \ -e OSMOPY_DEBUG_TCP_SOCKETS="1" \ -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/32937 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I6cd5f0383fcceaf77e5fa2f7441f9ae9aa8e8734 Gerrit-Change-Number: 32937 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 1 month

1
0
0 0

[S] Change in osmo-ci[master]: jobs/master: add workspace.tar.xz to artifacts

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/32938 ) Change subject: jobs/master: add workspace.tar.xz to artifacts ...................................................................... jobs/master: add workspace.tar.xz to artifacts Upload workspace.tar.xz if it was created by osmo-bsc or osmo-msc, after the testsuite failed. This should help with figuring out why sometimes we get a coredump. Related: OS#5665 Change-Id: I40b738558b83efc9256e5d5c48ffce42ddce9a8a --- M jobs/master-builds.yml 1 file changed, 15 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/38/32938/1 diff --git a/jobs/master-builds.yml b/jobs/master-builds.yml index 6e76b9a..5e962e8 100644 --- a/jobs/master-builds.yml +++ b/jobs/master-builds.yml @@ -588,7 +588,7 @@ publishers: - archive: allow-empty: true - artifacts: '**/core, **/testsuite.log' + artifacts: '**/core, **/testsuite.log, **/workspace.tar.xz' - warnings: console-log-parsers: - 'GNU C Compiler 4 (gcc)' -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/32938 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I40b738558b83efc9256e5d5c48ffce42ddce9a8a Gerrit-Change-Number: 32938 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 1 month

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: MGCP_Test: fix TC_one_crcx_loopback_rtp_implicit

by dexter

dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32927 ) Change subject: MGCP_Test: fix TC_one_crcx_loopback_rtp_implicit ...................................................................... MGCP_Test: fix TC_one_crcx_loopback_rtp_implicit The testcase TC_one_crcx_loopback_rtp_implicit creates a loopback connection using CRCX but without SDP. It selects AMR using LCO. The MGW responds with an MDCX and acknowledges AMR with a payload type of 112, The TTCN3 testcase then sends AMR RTP packets with payload type 111, those are accepted and looped back but the payload type will be converted to 112 as negotiated in the CRCX response. However the TTCN3 test still expects 111 in the packets comming back from the MGW. This is obviously a wrong expectation and the testcase did only pass because Osmo-MGW was behaving incorrectly. To fix this let's just use 112 as payload type as payload type in this test. This is the recommended payload type number for AMR (3GPP TS 48.103, Table 5.4.2.2.1) and used by the MGW by default in case the call agent does not specify a different one in SDP. Change-Id: Idc370e9dc2e4954374fc7d07f7b117788028635a Related: OS#5461 --- M mgw/MGCP_Test.ttcn 1 file changed, 26 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/mgw/MGCP_Test.ttcn b/mgw/MGCP_Test.ttcn index 28b7103..0759006 100644 --- a/mgw/MGCP_Test.ttcn +++ b/mgw/MGCP_Test.ttcn @@ -1901,7 +1901,7 @@ var RtpemStats stats; f_init(ep); - flow := valueof(t_RtpFlow(local_ip, remote_ip, 111, "GSM-HR-08/8000/1")); + flow := valueof(t_RtpFlow(local_ip, remote_ip, 112, "GSM-HR-08/8000/1")); flow.em.portnr := 10000; f_flow_create(RTPEM[0], ep, call_id, "loopback", flow, one_phase := one_phase); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32927 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Idc370e9dc2e4954374fc7d07f7b117788028635a Gerrit-Change-Number: 32927 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 1 month

1
0
0 0

[L] Change in libosmocore[master]: ASCI: Add 3GPP TS 44.068 and 44.069 protocol definitions

by dexter

Attention is currently required from: jolly. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32930 ) Change subject: ASCI: Add 3GPP TS 44.068 and 44.069 protocol definitions ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File include/osmocom/gsm/protocol/gsm_44_068.h: https://gerrit.osmocom.org/c/libosmocore/+/32930/comment/2cb4d317_e304dcdb PS1, Line 123: we usually add a an inline function that returns the name using get_value_string for convenience. like gsm0808_lcls_status_name() in gsm0808.h -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32930 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I3554cea47e714c8fca18c3e9c0e6e80695915a90 Gerrit-Change-Number: 32930 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Tue, 23 May 2023 14:20:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[L] Change in libosmocore[master]: ASCI: Add IE transcoding according to 3GPP TS 48.008

by Jenkins Builder

Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32931 ) Change subject: ASCI: Add IE transcoding according to 3GPP TS 48.008 ...................................................................... Patch Set 1: (5 comments) File include/osmocom/gsm/gsm0808_utils.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7263): https://gerrit.osmocom.org/c/libosmocore/+/32931/comment/0b885944_2087ad07 PS1, Line 437: const struct gsm0808_cell_id_list_segment *ci); code indent should use tabs where possible File src/gsm/gsm0808_utils.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7263): https://gerrit.osmocom.org/c/libosmocore/+/32931/comment/301a1544_6c920b5c PS1, Line 2472: if (rc <= 0) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7263): https://gerrit.osmocom.org/c/libosmocore/+/32931/comment/c3bd6b63_240d5249 PS1, Line 2472: if (rc <= 0) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7263): https://gerrit.osmocom.org/c/libosmocore/+/32931/comment/9b0df538_8f70d7bd PS1, Line 2473: return rc; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7263): https://gerrit.osmocom.org/c/libosmocore/+/32931/comment/1d7a1111_db39990b PS1, Line 2473: return rc; please, no spaces at the start of a line -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32931 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic1fc714bb04228a7f32e9925811e21c8efc610bd Gerrit-Change-Number: 32931 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Tue, 23 May 2023 14:05:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[XL] Change in libosmocore[master]: ASCI: Add message definition and encoding according to 3GPP TS 48.008

by Jenkins Builder

Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32932 ) Change subject: ASCI: Add message definition and encoding according to 3GPP TS 48.008 ...................................................................... Patch Set 1: (1 comment) File src/gsm/gsm0808.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7261): https://gerrit.osmocom.org/c/libosmocore/+/32932/comment/423d1e55_9d8dfbfe PS1, Line 2154: * message type infromation in the specifications. */ 'infromation' may be misspelled - perhaps 'information'? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32932 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib94c64136c31ce4af67c314a8550d93946cc844f Gerrit-Change-Number: 32932 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Tue, 23 May 2023 14:05:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

2025

2024

2023

2022

gerrit-log May 2023