May 2023 - gerrit-log - lists.osmocom.org

[S] Change in ...osmo-python-tests[master]: setup.py: do not install scripts/{soap,ctrl2cgi}.py

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/python/osmo-python-tests/+/32928 ) Change subject: setup.py: do not install scripts/{soap,ctrl2cgi}.py ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/python/osmo-python-tests/+/32928 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: python/osmo-python-tests Gerrit-Branch: master Gerrit-Change-Id: Iffe8f752793127077f25df13167ccc5190e54ff6 Gerrit-Change-Number: 32928 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 23 May 2023 13:24:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[S] Change in ...osmo-python-tests[master]: setup.py: do not install scripts/{soap,ctrl2cgi}.py

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/python/osmo-python-tests/+/32928 ) Change subject: setup.py: do not install scripts/{soap,ctrl2cgi}.py ...................................................................... setup.py: do not install scripts/{soap,ctrl2cgi}.py These scripts have been deprecated and are not maintained anymore. Change-Id: Iffe8f752793127077f25df13167ccc5190e54ff6 --- M setup.py 1 file changed, 11 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/python/osmo-python-tests refs/changes/28/32928/1 diff --git a/setup.py b/setup.py index 301420a..3818dd7 100755 --- a/setup.py +++ b/setup.py @@ -25,8 +25,6 @@ "scripts/osmotestconfig.py", "scripts/osmo_ctrl.py", "scripts/osmo_rate_ctr2csv.py", - "scripts/soap.py", - "scripts/ctrl2cgi.py", "scripts/osmo_trap2cgi.py", "scripts/osmo_interact_vty.py", "scripts/osmo_interact_ctrl.py", -- To view, visit https://gerrit.osmocom.org/c/python/osmo-python-tests/+/32928 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: python/osmo-python-tests Gerrit-Branch: master Gerrit-Change-Id: Iffe8f752793127077f25df13167ccc5190e54ff6 Gerrit-Change-Number: 32928 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 1 month

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: MGCP_Test: fix TC_one_crcx_loopback_rtp_implicit

by fixeria

Attention is currently required from: dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32927 ) Change subject: MGCP_Test: fix TC_one_crcx_loopback_rtp_implicit ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32927 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Idc370e9dc2e4954374fc7d07f7b117788028635a Gerrit-Change-Number: 32927 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 23 May 2023 12:21:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[S] Change in osmo-mgw[master]: mgcp_codec: be sensitive about IuFP when checking codecs

by pespin

Attention is currently required from: fixeria, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/32926 ) Change subject: mgcp_codec: be sensitive about IuFP when checking codecs ...................................................................... Patch Set 1: (2 comments) File src/libosmo-mgcp/mgcp_codec.c: https://gerrit.osmocom.org/c/osmo-mgw/+/32926/comment/45b56767_fc09f8ce PS1, Line 336: /* In 3G IuUP AMR may be encapsulated in IuFP, this means even though the codec name and negotiated rate is "In 3G IuUP, AMR" (missing comma). https://gerrit.osmocom.org/c/osmo-mgw/+/32926/comment/c9a78260_20fb826c PS1, Line 344: if (!iufp && strcmp(codec_a->subtype_name, codec_b->subtype_name)) this may be cleaner with a goto to line 346, instead of insturdicing the "iufp" flag. As you prefer. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/32926 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I6bc1e6022efe21cb893ef213f3da35017960357d Gerrit-Change-Number: 32926 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 23 May 2023 12:18:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: MGCP_Test: fix TC_one_crcx_loopback_rtp_implicit

by pespin

Attention is currently required from: fixeria, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32927 ) Change subject: MGCP_Test: fix TC_one_crcx_loopback_rtp_implicit ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32927 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Idc370e9dc2e4954374fc7d07f7b117788028635a Gerrit-Change-Number: 32927 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 23 May 2023 12:12:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: MGCP_Test: fix TC_one_crcx_loopback_rtp_implicit

by dexter

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32927 ) Change subject: MGCP_Test: fix TC_one_crcx_loopback_rtp_implicit ...................................................................... MGCP_Test: fix TC_one_crcx_loopback_rtp_implicit The testcase TC_one_crcx_loopback_rtp_implicit creates a loopback connection using CRCX but without SDP. It selects AMR using LCO. The MGW responds with an MDCX and acknowledges AMR with a payload type of 112, The TTCN3 testcase then sends AMR RTP packets with payload type 111, those are accepted and looped back but the payload type will be converted to 112 as negotiated in the CRCX response. However the TTCN3 test still expects 111 in the packets comming back from the MGW. This is obviously a wrong expectation and the testcase did only pass because Osmo-MGW was behaving incorrectly. To fix this let's just use 112 as payload type as payload type in this test. This is the recommended payload type number for AMR (3GPP TS 48.103, Table 5.4.2.2.1) and used by the MGW by default in case the call agent does not specify a different one in SDP. Change-Id: Idc370e9dc2e4954374fc7d07f7b117788028635a Related: OS#5461 --- M mgw/MGCP_Test.ttcn 1 file changed, 26 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/27/32927/1 diff --git a/mgw/MGCP_Test.ttcn b/mgw/MGCP_Test.ttcn index 28b7103..0759006 100644 --- a/mgw/MGCP_Test.ttcn +++ b/mgw/MGCP_Test.ttcn @@ -1901,7 +1901,7 @@ var RtpemStats stats; f_init(ep); - flow := valueof(t_RtpFlow(local_ip, remote_ip, 111, "GSM-HR-08/8000/1")); + flow := valueof(t_RtpFlow(local_ip, remote_ip, 112, "GSM-HR-08/8000/1")); flow.em.portnr := 10000; f_flow_create(RTPEM[0], ep, call_id, "loopback", flow, one_phase := one_phase); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32927 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Idc370e9dc2e4954374fc7d07f7b117788028635a Gerrit-Change-Number: 32927 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 1 month

1
0
0 0

[S] Change in osmo-mgw[master]: mgcp_codec: be sensitive about IuFP when checking codecs

by dexter

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/32926 ) Change subject: mgcp_codec: be sensitive about IuFP when checking codecs ...................................................................... mgcp_codec: be sensitive about IuFP when checking codecs When two codecs are checked for convertibility we insist that subtype_name and rate are equal since normally when those are different, we assume a completely different codec that will require a transcoder, which we do not have yet. However when IuFP is used, the call agent will always negotiate IuFP as VND.3GPP.IUFP with a rate of 16000, even though the IuFP payloads contain regular AMR at a rate of 8000. This means that if we detect IuFP on one side of the call leg and AMR on the other side of the call leg, we must not insist on equal subtype_name and rate. This fixes the following TTCN3 testcases: MGCP_Test.TC_two_crcx_mdcx_and_iuup_rtp MGCP_Test.TC_two_crcx_mdcx_and_iuup_rtp_rfci_unordered Related: OS#5461 Change-Id: I6bc1e6022efe21cb893ef213f3da35017960357d --- M src/libosmo-mgcp/mgcp_codec.c 1 file changed, 40 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/26/32926/1 diff --git a/src/libosmo-mgcp/mgcp_codec.c b/src/libosmo-mgcp/mgcp_codec.c index 905795c..7bffef9 100644 --- a/src/libosmo-mgcp/mgcp_codec.c +++ b/src/libosmo-mgcp/mgcp_codec.c @@ -330,9 +330,20 @@ /* OsmoMGW currently has no ability to transcode from one codec to another. However OsmoMGW is still able to * translate between different payload formats as long as the encoded voice data itself does not change. * Therefore we must insist on equal codecs but still allow different payload formatting. */ - if (strcmp(codec_a->subtype_name, codec_b->subtype_name)) + + bool iufp = false; + + /* In 3G IuUP AMR may be encapsulated in IuFP, this means even though the codec name and negotiated rate is + * different, the formatting can still be converted by OsmoMGW. Therefore we won't insist on equal + * subtype_name and rate if we detect IuFP and AMR is used on the same tandem. */ + if (strcmp(codec_a->subtype_name, "AMR") == 0 && strcmp(codec_b->subtype_name, "VND.3GPP.IUFP") == 0) + iufp = true; + if (strcmp(codec_a->subtype_name, "VND.3GPP.IUFP") == 0 && strcmp(codec_b->subtype_name, "AMR") == 0) + iufp = true; + + if (!iufp && strcmp(codec_a->subtype_name, codec_b->subtype_name)) return false; - if (codec_a->rate != codec_b->rate) + if (!iufp && codec_a->rate != codec_b->rate) return false; if (codec_a->channels != codec_b->channels) return false; -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/32926 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I6bc1e6022efe21cb893ef213f3da35017960357d Gerrit-Change-Number: 32926 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 1 month

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: HLR_Tests: add testcase for multiple APNs in subscriber data

by pespin

Attention is currently required from: lynxis lazus. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32510 ) Change subject: HLR_Tests: add testcase for multiple APNs in subscriber data ...................................................................... Patch Set 6: (1 comment) File hlr/HLR_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32510/comment/eb01204a_6657… PS6, Line 1037: tr_GSUP_IE_APN('08'O & char2oct("internet")) > Can you write such function please ;)? Sure I can also write most of your patches, but that's not the point right? ;) -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32510 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8d0c08272bc239370e800d6014ab9c68087b8989 Gerrit-Change-Number: 32510 Gerrit-PatchSet: 6 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 23 May 2023 11:56:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: HLR_Tests: add testcase for multiple APNs in subscriber data

by lynxis lazus

Attention is currently required from: pespin. lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32510 ) Change subject: HLR_Tests: add testcase for multiple APNs in subscriber data ...................................................................... Patch Set 6: (1 comment) File hlr/HLR_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32510/comment/bb90ac54_e92b… PS2, Line 543: boolean return_isd := false) > Ah indeed that's not possible afaik. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32510 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8d0c08272bc239370e800d6014ab9c68087b8989 Gerrit-Change-Number: 32510 Gerrit-PatchSet: 6 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 23 May 2023 11:53:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: HLR_Tests: add testcase for multiple APNs in subscriber data

by lynxis lazus

Attention is currently required from: pespin. lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32510 ) Change subject: HLR_Tests: add testcase for multiple APNs in subscriber data ...................................................................... Patch Set 6: (1 comment) File hlr/HLR_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32510/comment/bb879c22_63ec… PS6, Line 1037: tr_GSUP_IE_APN('08'O & char2oct("internet")) > It makes it a lot more complicated. It is length encoded by dots. […] Can you write such function please ;)? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32510 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8d0c08272bc239370e800d6014ab9c68087b8989 Gerrit-Change-Number: 32510 Gerrit-PatchSet: 6 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 23 May 2023 11:53:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

2025

2024

2023

2022

gerrit-log May 2023