May 2023 - gerrit-log - lists.osmocom.org

[M] Change in libosmo-gprs[master]: gmmrr: Add new LLC_TRANSMITTED.ind

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/32905 ) Change subject: gmmrr: Add new LLC_TRANSMITTED.ind ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/32905 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I9fd4047cfae4a12ad3be41860032eeda263d3276 Gerrit-Change-Number: 32905 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 23 May 2023 15:09:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[L] Change in libosmocore[master]: ASCI: Add 3GPP TS 44.068 and 44.069 protocol definitions

by pespin

Attention is currently required from: jolly, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32930 ) Change subject: ASCI: Add 3GPP TS 44.068 and 44.069 protocol definitions ...................................................................... Patch Set 1: Code-Review-1 (3 comments) File include/osmocom/gsm/protocol/gsm_44_068.h: https://gerrit.osmocom.org/c/libosmocore/+/32930/comment/390285fe_aa935f5f PS1, Line 19: enum gcc_iei { missing osmo_ prefix in all definitions, in order to keep everything in the same namespace. (yes, I know old code in libosmocore doesn't do it). https://gerrit.osmocom.org/c/libosmocore/+/32930/comment/fad2f37d_739a3e61 PS1, Line 123: > we usually add a an inline function that returns the name using get_value_string for convenience. […] Ack File src/gsm/gsm44068.c: https://gerrit.osmocom.org/c/libosmocore/+/32930/comment/bc86e110_f0b2b020 PS1, Line 22: const struct value_string gcc_msg_type_names[] = { osmo_* and OSMO_* prefix missing everywhere. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32930 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I3554cea47e714c8fca18c3e9c0e6e80695915a90 Gerrit-Change-Number: 32930 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 23 May 2023 15:08:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[M] Change in libosmo-gprs[master]: llc: Add APIs to submit LLGM-trigger/suspend/resume.req primitives

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/32959 ) Change subject: llc: Add APIs to submit LLGM-trigger/suspend/resume.req primitives ...................................................................... llc: Add APIs to submit LLGM-trigger/suspend/resume.req primitives This commit also adds an initial implementation of LLGM-suspend/resume.req. Change-Id: I890c7a4ace6fb8ca362ec41bd18e9c229191a587 --- M include/osmocom/gprs/llc/llc_prim.h M include/osmocom/gprs/llc/llc_private.h M src/llc/llc_ll.c M src/llc/llc_llgmm.c 4 files changed, 98 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/59/32959/1 diff --git a/include/osmocom/gprs/llc/llc_prim.h b/include/osmocom/gprs/llc/llc_prim.h index d5a424d..904e9fa 100644 --- a/include/osmocom/gprs/llc/llc_prim.h +++ b/include/osmocom/gprs/llc/llc_prim.h @@ -300,6 +300,9 @@ /* Alloc primitive for LLGMM SAP: */ struct osmo_gprs_llc_prim *osmo_gprs_llc_prim_alloc_llgm_assign_req(uint32_t tlli); struct osmo_gprs_llc_prim *osmo_gprs_llc_prim_alloc_llgm_reset_req(uint32_t tlli); +struct osmo_gprs_llc_prim *osmo_gprs_llc_prim_alloc_llgm_trigger_req(uint32_t tlli, uint8_t cause); +struct osmo_gprs_llc_prim *osmo_gprs_llc_prim_alloc_llgm_suspend_req(uint32_t tlli); +struct osmo_gprs_llc_prim *osmo_gprs_llc_prim_alloc_llgm_resume_req(uint32_t tlli); /* Alloc primitive for LL SAP: */ struct osmo_gprs_llc_prim *osmo_gprs_llc_prim_alloc_ll_establish_req(uint32_t tlli, enum osmo_gprs_llc_sapi ll_sapi, diff --git a/include/osmocom/gprs/llc/llc_private.h b/include/osmocom/gprs/llc/llc_private.h index 994acd8..ed68c7b 100644 --- a/include/osmocom/gprs/llc/llc_private.h +++ b/include/osmocom/gprs/llc/llc_private.h @@ -254,6 +254,10 @@ /* Internal management */ uint32_t age_timestamp; + + /* TS 44.064 § C.2: "In addition, all states should observe the suspended + * operation (reception of LLGMM-SUSPEND-REQ) restrictions" */ + bool suspended; }; static inline struct gprs_llc_lle *gprs_llc_llme_get_lle(struct gprs_llc_llme *llme, diff --git a/src/llc/llc_ll.c b/src/llc/llc_ll.c index 43a0951..a13a7f5 100644 --- a/src/llc/llc_ll.c +++ b/src/llc/llc_ll.c @@ -277,9 +277,15 @@ lle = gprs_llc_llme_get_lle(llme, llc_prim->ll.sapi); } + if (lle->llme->suspended && llc_prim->ll.sapi != OSMO_GPRS_LLC_SAPI_GMM) { + LOGLLE(lle, LOGL_NOTICE, "Dropping frame to transmit, LLME is suspended\n"); + goto ret_free; + } + rc = gprs_llc_lle_tx_ui(lle, llc_prim->ll.l3_pdu, llc_prim->ll.l3_pdu_len, llc_prim->ll.unitdata_req.apply_gea); +ret_free: msgb_free(llc_prim->oph.msg); return rc; } diff --git a/src/llc/llc_llgmm.c b/src/llc/llc_llgmm.c index 5834041..7b09a69 100644 --- a/src/llc/llc_llgmm.c +++ b/src/llc/llc_llgmm.c @@ -100,7 +100,7 @@ return llc_prim; } -/* 7.2.1.2 LLGMM-RESET.cnf (SGSN):*/ +/* 7.2.1.2 LLGMM-RESET.cnf (SGSN): */ struct osmo_gprs_llc_prim *osmo_gprs_llc_prim_alloc_llgm_reset_cnf(uint32_t tlli) { struct osmo_gprs_llc_prim *llc_prim; @@ -109,6 +109,34 @@ return llc_prim; } +/* 7.2.1.3 LLGMM-TRIGGER.req (MS): */ +struct osmo_gprs_llc_prim *osmo_gprs_llc_prim_alloc_llgm_trigger_req(uint32_t tlli, uint8_t cause) +{ + struct osmo_gprs_llc_prim *llc_prim; + llc_prim = llc_prim_llgmm_alloc(OSMO_GPRS_LLC_LLGMM_TRIGGER, PRIM_OP_REQUEST, 0); + llc_prim->llgmm.tlli = tlli; + llc_prim->llgmm.trigger_req.cause = cause; + return llc_prim; +} + +/* 7.2.1.4 LLGMM-SUSPEND.req (MS/SGSN): */ +struct osmo_gprs_llc_prim *osmo_gprs_llc_prim_alloc_llgm_suspend_req(uint32_t tlli) +{ + struct osmo_gprs_llc_prim *llc_prim; + llc_prim = llc_prim_llgmm_alloc(OSMO_GPRS_LLC_LLGMM_SUSPEND, PRIM_OP_REQUEST, 0); + llc_prim->llgmm.tlli = tlli; + return llc_prim; +} + +/* 7.2.1.5 LLGMM-RESUME.req (MS/SGSN):*/ +struct osmo_gprs_llc_prim *osmo_gprs_llc_prim_alloc_llgm_resume_req(uint32_t tlli) +{ + struct osmo_gprs_llc_prim *llc_prim; + llc_prim = llc_prim_llgmm_alloc(OSMO_GPRS_LLC_LLGMM_RESUME, PRIM_OP_REQUEST, 0); + llc_prim->llgmm.tlli = tlli; + return llc_prim; +} + /******************************** * Handling from upper layers: ********************************/ @@ -246,6 +274,48 @@ return rc; } +/* 7.2.1.4 LLGMM-SUSPEND.req (MS/SGSN):*/ +static int llc_prim_handle_llgm_suspend_req(struct osmo_gprs_llc_prim *llc_prim) +{ + int rc = 0; + struct gprs_llc_llme *llme = gprs_llc_find_llme_by_tlli(llc_prim->llgmm.tlli); + + if (!llme) { + LOGLLC(LOGL_NOTICE, "Rx %s: Unknown TLLI 0x%08x\n", + osmo_gprs_llc_prim_name(llc_prim), llc_prim->llgmm.tlli); + rc = -ENOKEY; + goto ret_free; + } + LOGLLME(llme, LOGL_INFO, "%s\n", osmo_gprs_llc_prim_name(llc_prim)); + + llme->suspended = true; + +ret_free: + msgb_free(llc_prim->oph.msg); + return rc; +} + +/* 7.2.1.5 LLGMM-RESUME.req (MS/SGSN):*/ +static int llc_prim_handle_llgm_resume_req(struct osmo_gprs_llc_prim *llc_prim) +{ + int rc = 0; + struct gprs_llc_llme *llme = gprs_llc_find_llme_by_tlli(llc_prim->llgmm.tlli); + + if (!llme) { + LOGLLC(LOGL_NOTICE, "Rx %s: Unknown TLLI 0x%08x\n", + osmo_gprs_llc_prim_name(llc_prim), llc_prim->llgmm.tlli); + rc = -ENOKEY; + goto ret_free; + } + LOGLLME(llme, LOGL_INFO, "%s\n", osmo_gprs_llc_prim_name(llc_prim)); + + llme->suspended = false; + +ret_free: + msgb_free(llc_prim->oph.msg); + return rc; +} + /* LLC higher layers push LLC primitive down to LLC layer: */ int gprs_llc_prim_llgmm_upper_down(struct osmo_gprs_llc_prim *llc_prim) { @@ -267,12 +337,12 @@ case OSMO_PRIM(OSMO_GPRS_LLC_LLGMM_SUSPEND, PRIM_OP_REQUEST): OSMO_ASSERT(g_llc_ctx->location == OSMO_GPRS_LLC_LOCATION_MS || g_llc_ctx->location == OSMO_GPRS_LLC_LOCATION_SGSN); - rc = gprs_llc_prim_handle_unsupported(llc_prim); + rc = llc_prim_handle_llgm_suspend_req(llc_prim); break; case OSMO_PRIM(OSMO_GPRS_LLC_LLGMM_RESUME, PRIM_OP_REQUEST): OSMO_ASSERT(g_llc_ctx->location == OSMO_GPRS_LLC_LOCATION_MS || g_llc_ctx->location == OSMO_GPRS_LLC_LOCATION_SGSN); - rc = gprs_llc_prim_handle_unsupported(llc_prim); + rc = llc_prim_handle_llgm_resume_req(llc_prim); break; case OSMO_PRIM(OSMO_GPRS_LLC_LLGMM_IOV, PRIM_OP_REQUEST): OSMO_ASSERT(g_llc_ctx->location == OSMO_GPRS_LLC_LOCATION_SGSN); -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/32959 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I890c7a4ace6fb8ca362ec41bd18e9c229191a587 Gerrit-Change-Number: 32959 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 1 month

1
0
0 0

[L] Change in libosmo-gprs[master]: gmm: Implement periodic RAU procedure

by pespin

Attention is currently required from: dexter. Hello Jenkins Builder, dexter, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-gprs/+/32925 to look at the new patch set (#2). Change subject: gmm: Implement periodic RAU procedure ...................................................................... gmm: Implement periodic RAU procedure Related: OS#5501 Change-Id: Ie7cba8a2fe3b97bebc558c957cc1bcbe3cc81dbc --- M include/osmocom/gprs/gmm/gmm_ms_fsm.h M include/osmocom/gprs/gmm/gmm_pdu.h M include/osmocom/gprs/gmm/gmm_private.h M src/gmm/gmm.c M src/gmm/gmm_ms_fsm.c M src/gmm/gmm_pdu.c M tests/gmm/Makefile.am M tests/gmm/gmm_prim_test.c M tests/gmm/gmm_prim_test.err M tests/gmm/gmm_prim_test.ok 10 files changed, 571 insertions(+), 15 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/25/32925/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/32925 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Ie7cba8a2fe3b97bebc558c957cc1bcbe3cc81dbc Gerrit-Change-Number: 32925 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 1 month

1
0
0 0

[L] Change in libosmocore[master]: ASCI: Add 3GPP TS 44.068 and 44.069 protocol definitions

by fixeria

Attention is currently required from: jolly. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32930 ) Change subject: ASCI: Add 3GPP TS 44.068 and 44.069 protocol definitions ...................................................................... Patch Set 1: (1 comment) File src/gsm/libosmogsm.map: https://gerrit.osmocom.org/c/libosmocore/+/32930/comment/ab644932_c2c18b69 PS1, Line 474: gcc_msg_type_names; Ideally, all new symbols should be prefixed with `osmo_`. The `gsm/protocol` directory is a bit special and this rule is not really followed, but I would still suggest adding `gsm44068_` prefix or something like that to avoid naming conflicts. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32930 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I3554cea47e714c8fca18c3e9c0e6e80695915a90 Gerrit-Change-Number: 32930 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Tue, 23 May 2023 14:54:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[S] Change in osmo-trx[master]: ms: block burst q to upper layer

by dexter

Attention is currently required from: Hoernchen. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/32945 ) Change subject: ms: block burst q to upper layer ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-trx/+/32945/comment/554f4d87_9b6a297f PS1, Line 8: this might benefit from some detailed description. It is difficult to understand this without expert knowledge. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/32945 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Id0aad606a296b2885617013ce6637204357b13d7 Gerrit-Change-Number: 32945 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-CC: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Tue, 23 May 2023 14:50:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[L] Change in libosmo-gprs[master]: gmm: Implement periodic RAU procedure

by pespin

Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/32925 ) Change subject: gmm: Implement periodic RAU procedure ...................................................................... Patch Set 1: (1 comment) File src/gmm/gmm.c: https://gerrit.osmocom.org/c/libosmo-gprs/+/32925/comment/569b327b_9129b0b7 PS1, Line 1011: return -EINVAL; /* TODO: what to do on error? */ > Maybe add a comment about what happens at the moment? That's exactly what the comment is about, I didn't check yet, need sto be checked further in the future 😊 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/32925 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Ie7cba8a2fe3b97bebc558c957cc1bcbe3cc81dbc Gerrit-Change-Number: 32925 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 23 May 2023 14:49:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[S] Change in ...osmo-python-tests[master]: osmoutil: print return code in end_proc()

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/python/osmo-python-tests/+/32929 ) Change subject: osmoutil: print return code in end_proc() ...................................................................... osmoutil: print return code in end_proc() Change-Id: If11616be6e9afc85814fa0b494e231cc7530459c Related: OS#5665 --- M osmopy/osmoutil.py 1 file changed, 12 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified dexter: Looks good to me, approved diff --git a/osmopy/osmoutil.py b/osmopy/osmoutil.py index ec9c8c3..ecd88f2 100755 --- a/osmopy/osmoutil.py +++ b/osmopy/osmoutil.py @@ -68,7 +68,8 @@ print("Killed child process") elif waited_time > .002: print("Terminating took %.3fs" % waited_time) - proc.wait() + rc = proc.wait() + print("Process returned code: %d" % rc) """Add a directory to sys.path, try to import a config file.""" -- To view, visit https://gerrit.osmocom.org/c/python/osmo-python-tests/+/32929 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: python/osmo-python-tests Gerrit-Branch: master Gerrit-Change-Id: If11616be6e9afc85814fa0b494e231cc7530459c Gerrit-Change-Number: 32929 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 1 month

1
0
0 0

[S] Change in ...osmo-python-tests[master]: osmoutil: print return code in end_proc()

by dexter

Attention is currently required from: fixeria. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/python/osmo-python-tests/+/32929 ) Change subject: osmoutil: print return code in end_proc() ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: looks like a good idea. -- To view, visit https://gerrit.osmocom.org/c/python/osmo-python-tests/+/32929 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: python/osmo-python-tests Gerrit-Branch: master Gerrit-Change-Id: If11616be6e9afc85814fa0b494e231cc7530459c Gerrit-Change-Number: 32929 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 23 May 2023 14:44:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[L] Change in libosmo-gprs[master]: gmm: Implement periodic RAU procedure

by dexter

Attention is currently required from: pespin. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/32925 ) Change subject: gmm: Implement periodic RAU procedure ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/gmm/gmm.c: https://gerrit.osmocom.org/c/libosmo-gprs/+/32925/comment/ccd6c2a4_628eb0b6 PS1, Line 1011: return -EINVAL; /* TODO: what to do on error? */ Maybe add a comment about what happens at the moment? -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/32925 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Ie7cba8a2fe3b97bebc558c957cc1bcbe3cc81dbc Gerrit-Change-Number: 32925 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 23 May 2023 14:42:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

2025

2024

2023

2022

gerrit-log May 2023