dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32927 )

Change subject: MGCP_Test: fix TC_one_crcx_loopback_rtp_implicit ......................................................................

MGCP_Test: fix TC_one_crcx_loopback_rtp_implicit

The testcase TC_one_crcx_loopback_rtp_implicit creates a loopback connection using CRCX but without SDP. It selects AMR using LCO. The MGW responds with an MDCX and acknowledges AMR with a payload type of 112, The TTCN3 testcase then sends AMR RTP packets with payload type 111, those are accepted and looped back but the payload type will be converted to 112 as negotiated in the CRCX response. However the TTCN3 test still expects 111 in the packets comming back from the MGW. This is obviously a wrong expectation and the testcase did only pass because Osmo-MGW was behaving incorrectly.

To fix this let's just use 112 as payload type as payload type in this test. This is the recommended payload type number for AMR (3GPP TS 48.103, Table 5.4.2.2.1) and used by the MGW by default in case the call agent does not specify a different one in SDP.

Change-Id: Idc370e9dc2e4954374fc7d07f7b117788028635a Related: OS#5461 --- M mgw/MGCP_Test.ttcn 1 file changed, 26 insertions(+), 1 deletion(-)

Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved

diff --git a/mgw/MGCP_Test.ttcn b/mgw/MGCP_Test.ttcn index 28b7103..0759006 100644 --- a/mgw/MGCP_Test.ttcn +++ b/mgw/MGCP_Test.ttcn @@ -1901,7 +1901,7 @@ var RtpemStats stats;

f_init(ep); - flow := valueof(t_RtpFlow(local_ip, remote_ip, 111, "GSM-HR-08/8000/1")); + flow := valueof(t_RtpFlow(local_ip, remote_ip, 112, "GSM-HR-08/8000/1")); flow.em.portnr := 10000; f_flow_create(RTPEM[0], ep, call_id, "loopback", flow, one_phase := one_phase);