April 2023 - gerrit-log - lists.osmocom.org

[L] Change in osmo-ttcn3-hacks[master]: MGCP_Test: support multiple codecs
by pespin 13 Apr '23

13 Apr '23

Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32153 ) Change subject: MGCP_Test: support multiple codecs ...................................................................... Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32153 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8422313fccad1bfcee52c933f643068bebdaf2d5 Gerrit-Change-Number: 32153 Gerrit-PatchSet: 6 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 13 Apr 2023 14:23:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in osmo-ttcn3-hacks[master]: MGCP_Test: support multiple codecs
by dexter 13 Apr '23

13 Apr '23

Attention is currently required from: pespin. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32153 ) Change subject: MGCP_Test: support multiple codecs ...................................................................... Patch Set 6: (6 comments) File library/RTP_Emulation.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32153/comment/b09949c5_a18c… PS5, Line 393: if (ispresent(g_cfg.rx_payloads[i].fixed_payload)) { > if (not ispresent(g_cfg.rx_payloads[i].fixed_payload)) […] correct https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32153/comment/2ff9df69_66f0… PS5, Line 395: full_match := full_match + 1; > return; correct https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32153/comment/866f7838_c4bc… PS5, Line 396: } else { > "else" can be dropped after return; correct https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32153/comment/a647b7fd_1614… PS5, Line 397: payload_type_match := payload_type_match + 1; > g_stats_rtp.num_pkts_rx_err_payload := g_stats_rtp.num_pkts_rx_err_payload + 1; […] I think this is not right. We are looping through multiple sets of rx_payloads, we must go through all rx_payloads before we can say that there is no full match, so we must not return early here. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32153/comment/25c04928_b66c… PS5, Line 406: if (full_match > 0) { > This can now be dropped. correct https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32153/comment/80f73f10_be8c… PS5, Line 411: if (payload_type_match > 0) { > This can be dropped. Not really, we still must check this. If there was at least one matching payload type numbers, then we only increment num_pkts_rx_err_payload, otherwise we increment num_pkts_rx_err_payload and num_pkts_rx_err_pt -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32153 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8422313fccad1bfcee52c933f643068bebdaf2d5 Gerrit-Change-Number: 32153 Gerrit-PatchSet: 6 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 13 Apr 2023 14:21:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[L] Change in osmo-ttcn3-hacks[master]: MGCP_Test: support multiple codecs
by dexter 13 Apr '23

13 Apr '23

Attention is currently required from: pespin. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32153 to look at the new patch set (#6). Change subject: MGCP_Test: support multiple codecs ...................................................................... MGCP_Test: support multiple codecs At the moment The RTP emulation and MGCP_Test only allow to specify one codec and one set of RX/TX fixed payload octet strings to verify against. This is quite limiting since it might be necessary to test against different types and formats of payloads simultaneously in order to see if osmo-mgw converts or forwards them correctly. Let's extend this to support multiple codecs on MGCP/SDP level plus support for multiple RTP payloads on RTP emulation level. Related: OS#5461 Change-Id: I8422313fccad1bfcee52c933f643068bebdaf2d5 --- M bts/BTS_Tests.ttcn M hnodeb/HNBGW_ConnectionHandler.ttcn M library/RTP_Emulation.ttcn M mgw/MGCP_Test.ttcn 4 files changed, 211 insertions(+), 98 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/53/32153/6 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32153 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8422313fccad1bfcee52c933f643068bebdaf2d5 Gerrit-Change-Number: 32153 Gerrit-PatchSet: 6 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[M] Change in osmo-ttcn3-hacks[master]: MGCP_Test: add new testcases for oa/bwe conversion
by dexter 13 Apr '23

13 Apr '23

Attention is currently required from: dexter. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32220 to look at the new patch set (#2). Change subject: MGCP_Test: add new testcases for oa/bwe conversion ...................................................................... MGCP_Test: add new testcases for oa/bwe conversion The octet aligned to bandwith efficient conversion is currently only tested in scenarios where only one codec is assigned on both sides. However, there may be call agents that will assign bandwith efficient and octet aligned on one side for compatibility reasons. If this is the case, then OsmoMGW should always chose the format that requires no conversation. Related: OS#5461 Change-Id: I2b2d7ef7fb4fe31111aa8665c4d4295425502451 --- M mgw/MGCP_Test.ttcn 1 file changed, 71 insertions(+), 11 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/20/32220/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32220 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2b2d7ef7fb4fe31111aa8665c4d4295425502451 Gerrit-Change-Number: 32220 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-ttcn3-hacks[master]: MGCP_Test: fix typo
by dexter 13 Apr '23

13 Apr '23

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32292 ) Change subject: MGCP_Test: fix typo ...................................................................... MGCP_Test: fix typo Change-Id: I1c860acb60267a9b4d8049bf231c49f9c915923b --- M mgw/MGCP_Test.ttcn 1 file changed, 10 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/92/32292/1 diff --git a/mgw/MGCP_Test.ttcn b/mgw/MGCP_Test.ttcn index f9ab647..28b7103 100644 --- a/mgw/MGCP_Test.ttcn +++ b/mgw/MGCP_Test.ttcn @@ -2349,7 +2349,7 @@ } /* create two local RTP emulations; create two connections on MGW EP, see if - * exchanged data is converted between AMR octet-aligned and bandwith + * exchanged data is converted between AMR octet-aligned and bandwidth * efficient-mode */ function f_TC_amr_x_x_rtp_conversion(charstring fmtp0, octetstring pl0, charstring fmtp1a, octetstring pl1a, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32292 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1c860acb60267a9b4d8049bf231c49f9c915923b Gerrit-Change-Number: 32292 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-gsm-manuals[master]: sigtran: Update supported xUA Traffic modes
by pespin 13 Apr '23

13 Apr '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/32291 ) Change subject: sigtran: Update supported xUA Traffic modes ...................................................................... sigtran: Update supported xUA Traffic modes Related: SYS#6412 Change-Id: I22110440e23faa7facaa5bcd0d57b3a6ef24d4a7 --- M common/chapters/sigtran-osmocom.adoc 1 file changed, 11 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals refs/changes/91/32291/1 diff --git a/common/chapters/sigtran-osmocom.adoc b/common/chapters/sigtran-osmocom.adoc index 05cdedb..ddba669 100644 --- a/common/chapters/sigtran-osmocom.adoc +++ b/common/chapters/sigtran-osmocom.adoc @@ -345,7 +345,7 @@ |Description|More verbose description (for human user only) |Protocol|Protocol (M3UA, SUA, IPA) to be operated by this server |Routing Key|Routing Key (mostly Point Code) routed to this AS -|Traffic Mode|Theoretically Broadcast, Load-Balance. Currently only Override +|Traffic Mode|Broadcast, Loadshare or Override |Recovery Timeout|Duration of the AS T(r) recovery timer. During this time, outgoing messages are queued. If the AS is ACTIVE before timer expiration, the queue is drained. At -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/32291 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I22110440e23faa7facaa5bcd0d57b3a6ef24d4a7 Gerrit-Change-Number: 32291 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-mgw[master]: mgcp_network: do not deliver RTP packets with unpatched PT
by pespin 13 Apr '23

13 Apr '23

Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/32290 ) Change subject: mgcp_network: do not deliver RTP packets with unpatched PT ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-mgw/+/32290/comment/0014c358_270b099b PS1, Line 9: When a call leg is set up, then the call agent will also negoatiate a typo: negotiate -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/32290 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I013a24c1e0f853557257368cfab9192d4611aafa Gerrit-Change-Number: 32290 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 13 Apr 2023 13:47:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-mgw[master]: mgcp_vty: add warnings for deprecated config options
by pespin 13 Apr '23

13 Apr '23

Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/32238 ) Change subject: mgcp_vty: add warnings for deprecated config options ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/32238 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I182f6579930a4e5ed79c8eb87501578ce7e89c15 Gerrit-Change-Number: 32238 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 13 Apr 2023 13:46:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in osmo-mgw[master]: mgcp_codec: fix codec decision
by pespin 13 Apr '23

13 Apr '23

Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/32218 ) Change subject: mgcp_codec: fix codec decision ...................................................................... Patch Set 6: Code-Review+1 (1 comment) File src/libosmo-mgcp/mgcp_vty.c: https://gerrit.osmocom.org/c/osmo-mgw/+/32218/comment/4888bcf7_4234d095 PS4, Line 703: "allow-transcoding", "Allow transcoding\n") > I have added "vty_out(vty, "%% Deprecated 'allow-transcoding' config no longer has any effect%s", VT […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/32218 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I6c3291f825488e5d8ce136aeb18450156794aeb5 Gerrit-Change-Number: 32218 Gerrit-PatchSet: 6 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 13 Apr 2023 13:46:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-mgw[master]: mgcp_network: fix apidoc
by dexter 13 Apr '23

13 Apr '23

dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/32237 ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: mgcp_network: fix apidoc ...................................................................... mgcp_network: fix apidoc Change-Id: I358e21e9a9ab33beb07a9adfd4a53145aadb997d --- M src/libosmo-mgcp/mgcp_network.c 1 file changed, 12 insertions(+), 4 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve msuraev: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/libosmo-mgcp/mgcp_network.c b/src/libosmo-mgcp/mgcp_network.c index ce08dd4..ea1a699 100644 --- a/src/libosmo-mgcp/mgcp_network.c +++ b/src/libosmo-mgcp/mgcp_network.c @@ -1138,12 +1138,11 @@ /*! Send RTP/RTCP data to a specified destination connection. * \param[in] endp associated endpoint (for configuration, logging). * \param[in] is_rtp flag to specify if the packet is of type RTP or RTCP. - * \param[in] spoofed source address (set to NULL to disable). - * \param[in] buf buffer that contains the RTP/RTCP data. - * \param[in] len length of the buffer that contains the RTP/RTCP data. + * \param[in] addr spoofed source address (set to NULL to disable). + * \param[in] msg message buffer that contains the RTP/RTCP data. * \param[in] conn_src associated source connection. * \param[in] conn_dst associated destination connection. - * \returns 0 on success, -1 on ERROR. */ + * \returns 0 on success, negative on ERROR. */ int mgcp_send(struct mgcp_endpoint *endp, int is_rtp, struct osmo_sockaddr *addr, struct msgb *msg, struct mgcp_conn_rtp *conn_src, struct mgcp_conn_rtp *conn_dst) -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/32237 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I358e21e9a9ab33beb07a9adfd4a53145aadb997d Gerrit-Change-Number: 32237 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0