Attention is currently required from: pespin. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32153 ) Change subject: MGCP_Test: support multiple codecs ...................................................................... Patch Set 6: (6 comments) File library/RTP_Emulation.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32153/comment/b09949c5_a18c5... PS5, Line 393: if (ispresent(g_cfg.rx_payloads[i].fixed_payload)) {

if (not ispresent(g_cfg.rx_payloads[i].fixed_payload)) […] correct

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32153/comment/2ff9df69_66f00... PS5, Line 395: full_match := full_match + 1;

return; correct

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32153/comment/866f7838_c4bcc... PS5, Line 396: } else {

"else" can be dropped after return; correct

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32153/comment/a647b7fd_1614c... PS5, Line 397: payload_type_match := payload_type_match + 1;

g_stats_rtp.num_pkts_rx_err_payload := g_stats_rtp.num_pkts_rx_err_payload + 1; […] I think this is not right. We are looping through multiple sets of rx_payloads, we must go through all rx_payloads before we can say that there is no full match, so we must not return early here.

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32153/comment/25c04928_b66cf... PS5, Line 406: if (full_match > 0) {

This can now be dropped. correct

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32153/comment/80f73f10_be8c4... PS5, Line 411: if (payload_type_match > 0) {

This can be dropped. Not really, we still must check this. If there was at least one matching payload type numbers, then we only increment num_pkts_rx_err_payload, otherwise we increment num_pkts_rx_err_payload and num_pkts_rx_err_pt

-- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32153 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8422313fccad1bfcee52c933f643068bebdaf2d5 Gerrit-Change-Number: 32153 Gerrit-PatchSet: 6 Gerrit-Owner: dexter <pmaier@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Thu, 13 Apr 2023 14:21:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin@sysmocom.de> Gerrit-MessageType: comment