Attention is currently required from: pespin.

View Change

6 comments:

• File library/RTP_Emulation.ttcn:

  • Patch Set #5, Line 393: if (ispresent(g_cfg.rx_payloads[i].fixed_payload)) {

    if (not ispresent(g_cfg.rx_payloads[i].fixed_payload)) […]

    correct

  • Patch Set #5, Line 395: full_match := full_match + 1;

    return;

    correct

  • Patch Set #5, Line 396: } else {

    "else" can be dropped after return;

    correct

  • Patch Set #5, Line 397: payload_type_match := payload_type_match + 1;

    g_stats_rtp.num_pkts_rx_err_payload := g_stats_rtp.num_pkts_rx_err_payload + 1; […]

    I think this is not right. We are looping through multiple sets of rx_payloads, we must go through all rx_payloads before we can say that there is no full match, so we must not return early here.

  • Patch Set #5, Line 406: if (full_match > 0) {

    This can now be dropped.

    correct

  • Patch Set #5, Line 411: if (payload_type_match > 0) {

    This can be dropped.

    Not really, we still must check this. If there was at least one matching payload type numbers, then we only increment num_pkts_rx_err_payload, otherwise we increment num_pkts_rx_err_payload and num_pkts_rx_err_pt

To view, visit change 32153. To unsubscribe, or for help writing mail filters, visit settings.