April 2023 - gerrit-log - lists.osmocom.org

[L] Change in osmo-pcu[master]: ms: Rewrite MS release lifecycle

by pespin

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/32360 to look at the new patch set (#4). Change subject: ms: Rewrite MS release lifecycle ...................................................................... ms: Rewrite MS release lifecycle This commit changes lots of stuff in the MS release lifecycle, but there's no really good way to split this into patches which make sense, since all the chaos is intensively entangled. Get rid of the ms_callback complex mess, it is not needed at all. Previous MS release was strange due to the existance of previous ms_callback.idle concept and MS storage: the MS signalled when it went idle (no TBFs attached) and waited for somebody outside to free it, while then arming itself the release timer to release itself if it was not released by whoever. The new lifecycle follows an easier (expected) approach: Whenever all TBFs become detached from the MS and it becomes idle (use_count becomes 0), then it frees its reserved resources (TFI, etc.) and either: * frees itself immediatelly under certain conditions (release timeout configured = 0 or MS garbage with TLLI=GSM_RESERVED_TMSI) * Arms release_timer and frees itself when it triggers. If during release_timer the MS is required again (for instance because a new TBF with TLLI/IMSI of the MS is observed), then a TBF is attached to the MS and it is considered to become active again, hence the release_timer is stopped. OS#6002 Change-Id: Ibe5115bc15bb4d76026918adc1be79469c2f4839 --- M src/bts.cpp M src/gprs_ms.c M src/gprs_ms.h M tests/alloc/AllocTest.err M tests/alloc/AllocTest.ok M tests/app_info/AppInfoTest.err M tests/ms/MsTest.cpp M tests/ms/MsTest.err M tests/ms/MsTest.ok M tests/tbf/TbfTest.err M tests/ulc/PdchUlcTest.err 11 files changed, 388 insertions(+), 551 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/60/32360/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32360 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ibe5115bc15bb4d76026918adc1be79469c2f4839 Gerrit-Change-Number: 32360 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

2 years, 2 months

1
0
0 0

[S] Change in osmo-pcu[master]: ms: Increase log level when scheduling release timer

by pespin

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/32384 to look at the new patch set (#2). Change subject: ms: Increase log level when scheduling release timer ...................................................................... ms: Increase log level when scheduling release timer Change-Id: Ie470b5b0c7b01d91f4ad693e52afd51860d6da2d --- M src/gprs_ms.c M tests/ms/MsTest.err 2 files changed, 11 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/84/32384/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32384 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ie470b5b0c7b01d91f4ad693e52afd51860d6da2d Gerrit-Change-Number: 32384 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

2 years, 2 months

1
0
0 0

[S] Change in osmo-pcu[master]: dl_tbf: Set BandWidth timestamps to current time directly

by pespin

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/32382 to look at the new patch set (#3). Change subject: dl_tbf: Set BandWidth timestamps to current time directly ...................................................................... dl_tbf: Set BandWidth timestamps to current time directly Change-Id: I01654534aef5255c6d1c3ba0c553190a0319e8e1 --- M src/tbf_dl.cpp 1 file changed, 11 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/82/32382/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32382 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I01654534aef5255c6d1c3ba0c553190a0319e8e1 Gerrit-Change-Number: 32382 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

2 years, 2 months

1
0
0 0

[M] Change in osmo-pcu[master]: Add new log category 'ms'

by pespin

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/32383 to look at the new patch set (#4). Change subject: Add new log category 'ms' ...................................................................... Add new log category 'ms' This is useful to track the lifecycle of MS objects. The RLCMAC cateogry used so far in those log messages is too broad. Change-Id: Ib4ce88d0f7309ac77c064a94bb0d667e8dbc33dd --- M src/gprs_debug.c M src/gprs_debug.h M src/gprs_ms.c M tests/app_info/AppInfoTest.cpp M tests/ms/MsTest.cpp M tests/tbf/TbfTest.cpp M tests/ulc/PdchUlcTest.cpp 7 files changed, 50 insertions(+), 30 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/83/32383/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32383 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ib4ce88d0f7309ac77c064a94bb0d667e8dbc33dd Gerrit-Change-Number: 32383 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

2 years, 2 months

1
0
0 0

[S] Change in osmo-pcu[master]: meas: Improve logging formatting

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/32389 ) Change subject: meas: Improve logging formatting ...................................................................... meas: Improve logging formatting Change-Id: I15d66da3f41a9f14a542b96436d65a0581bbb45a --- M src/gprs_rlcmac_meas.cpp 1 file changed, 15 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/89/32389/1 diff --git a/src/gprs_rlcmac_meas.cpp b/src/gprs_rlcmac_meas.cpp index d14f405..a3d891c 100644 --- a/src/gprs_rlcmac_meas.cpp +++ b/src/gprs_rlcmac_meas.cpp @@ -124,8 +124,8 @@ if (!sum) return -EINVAL; - LOGP(DRLCMACMEAS, LOGL_DEBUG, "DL Loss of TLLI 0x%08x: Received: %4d " - "Lost: %4d Sum: %4d\n", tbf->tlli(), received, lost, sum); + LOGP(DRLCMACMEAS, LOGL_DEBUG, "%s DL Loss: Received: %4d Lost: %4d Sum: %4d\n", + tbf_name(dl_tbf_as_tbf_const(tbf)), received, lost, sum); tbf->m_bw.dl_loss_received += received; tbf->m_bw.dl_loss_lost += lost; @@ -154,9 +154,8 @@ if (!sum) return -EINVAL; - LOGP(DRLCMACMEAS, LOGL_DEBUG, "DL packet loss of IMSI=%s / TLLI=0x%08x: " - "%d%%\n", tbf->imsi(), tbf->tlli(), - tbf->m_bw.dl_loss_lost * 100 / sum); + LOGP(DRLCMACMEAS, LOGL_DEBUG, "%s DL packet loss: %d%%\n", + tbf_name(dl_tbf_as_tbf_const(tbf)), tbf->m_bw.dl_loss_lost * 100 / sum); return 0; } @@ -179,8 +178,8 @@ return 0; tbf->m_bw.dl_throughput = (tbf->m_bw.dl_bw_octets << 10) / ((elapsed.tv_sec << 10) + (elapsed.tv_nsec >> 20)); - LOGP(DRLCMACMEAS, LOGL_INFO, "DL Bandwitdh of IMSI=%s / TLLI=0x%08x: " - "%d KBits/s\n", tbf->imsi(), tbf->tlli(), tbf->m_bw.dl_throughput); + LOGP(DRLCMACMEAS, LOGL_INFO, "%s DL Bandwitdh: %d KBits/s\n", + tbf_name(dl_tbf_as_tbf_const(tbf)), tbf->m_bw.dl_throughput); /* reset bandwidth values timestamp */ memcpy(bw_tv, &now_tv, sizeof(*bw_tv)); -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32389 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I15d66da3f41a9f14a542b96436d65a0581bbb45a Gerrit-Change-Number: 32389 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 2 months

1
0
0 0

[S] Change in osmo-pcu[master]: tbf_dl: Avoid attempt scheduling DL ACK/NACK in TS != CTRL TS

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/32381 ) Change subject: tbf_dl: Avoid attempt scheduling DL ACK/NACK in TS != CTRL TS ...................................................................... tbf_dl: Avoid attempt scheduling DL ACK/NACK in TS != CTRL TS Change-Id: I80cddc80f23992fd86637980f9e2bfc00a50e04e --- M src/tbf_dl.cpp 1 file changed, 12 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/tbf_dl.cpp b/src/tbf_dl.cpp index f799cb0..ba0cee2 100644 --- a/src/tbf_dl.cpp +++ b/src/tbf_dl.cpp @@ -788,8 +788,9 @@ m_last_dl_poll_fn = fn; /* poll after POLL_ACK_AFTER_FRAMES frames, or when final block is tx or - * when last polled DL ACK/NACK was lost. */ - if (need_poll_for_dl_ack_nack()) { + * when last polled DL ACK/NACK was lost. Always do so in the control TS. */ + if (tbf_is_control_ts(dl_tbf_as_tbf(this), pdch) && + need_poll_for_dl_ack_nack()) { if (m_dl_ack_requested) { LOGPTBFDL(this, LOGL_DEBUG, "Scheduling Ack/Nack polling, because it was requested explicitly " -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32381 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I80cddc80f23992fd86637980f9e2bfc00a50e04e Gerrit-Change-Number: 32381 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 2 months

1
0
0 0

[S] Change in osmo-pcu[master]: tbf_dl: Avoid attempt scheduling DL ACK/NACK in TS != CTRL TS

by pespin

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/32381 ) Change subject: tbf_dl: Avoid attempt scheduling DL ACK/NACK in TS != CTRL TS ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32381 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I80cddc80f23992fd86637980f9e2bfc00a50e04e Gerrit-Change-Number: 32381 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 20 Apr 2023 14:11:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

[S] Change in libosmo-abis[master]: e1d: better initialize g_e1d with NULL.

by dexter

dexter has abandoned this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/32372 ) Change subject: e1d: better initialize g_e1d with NULL. ...................................................................... Abandoned not necessary -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/32372 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: If3b808e5489bf6a1f5fa4326d7b0277cc66d1334 Gerrit-Change-Number: 32372 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: abandon

2 years, 2 months

1
0
0 0

[S] Change in libosmo-abis[master]: e1d: set fd number back to 0 on failure

by dexter

dexter has abandoned this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/32371 ) Change subject: e1d: set fd number back to 0 on failure ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/32371 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ic49e93550f0cff1a30644408ef7dc0648be768df Gerrit-Change-Number: 32371 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: abandon

2 years, 2 months

1
0
0 0

[S] Change in libosmo-abis[master]: e1d: fix sourcecode formatting

by dexter

dexter has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/32352 ) Change subject: e1d: fix sourcecode formatting ...................................................................... e1d: fix sourcecode formatting Change-Id: I715e77849d771e05f8e7be82147c9168f9e8f86b --- M src/input/e1d.c 1 file changed, 19 insertions(+), 20 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/input/e1d.c b/src/input/e1d.c index 56fb5e5..1296b52 100644 --- a/src/input/e1d.c +++ b/src/input/e1d.c @@ -51,8 +51,7 @@ static int e1d_want_write(struct e1inp_ts *e1i_ts); -static int -handle_ts_sign_read(struct osmo_fd *bfd) +static int handle_ts_sign_read(struct osmo_fd *bfd) { struct e1inp_line *line = bfd->data; unsigned int ts_nr = bfd->priv_nr; @@ -75,8 +74,7 @@ return e1inp_rx_ts_lapd(e1i_ts, msg); } -static void -timeout_ts_sign_write(void *data) +static void timeout_ts_sign_write(void *data) { struct e1inp_ts *e1i_ts = (struct e1inp_ts *)data; @@ -84,8 +82,7 @@ e1d_want_write(e1i_ts); } -static int -handle_ts_sign_write(struct osmo_fd *bfd) +static int handle_ts_sign_write(struct osmo_fd *bfd) { struct e1inp_line *line = bfd->data; unsigned int ts_nr = bfd->priv_nr; @@ -115,8 +112,7 @@ #define D_TSX_ALLOC_SIZE (D_BCHAN_TX_GRAN) -static int -handle_ts_trau_write(struct osmo_fd *bfd) +static int handle_ts_trau_write(struct osmo_fd *bfd) { struct e1inp_line *line = bfd->data; unsigned int ts_nr = bfd->priv_nr; @@ -147,8 +143,7 @@ } -static int -handle_ts_trau_read(struct osmo_fd *bfd) +static int handle_ts_trau_read(struct osmo_fd *bfd) { struct e1inp_line *line = bfd->data; unsigned int ts_nr = bfd->priv_nr; @@ -305,8 +300,7 @@ return ret; } -static void -e1d_write_msg(struct msgb *msg, void *cbdata) +static void e1d_write_msg(struct msgb *msg, void *cbdata) { struct osmo_fd *bfd = cbdata; struct e1inp_line *line = bfd->data; @@ -320,8 +314,7 @@ LOGPITS(e1i_ts, DLMI, LOGL_NOTICE, "%s write failed %d\n", __func__, ret); } -static int -e1d_fd_cb(struct osmo_fd *bfd, unsigned int what) +static int e1d_fd_cb(struct osmo_fd *bfd, unsigned int what) { struct e1inp_line *line = bfd->data; unsigned int ts_nr = bfd->priv_nr; @@ -364,8 +357,7 @@ } -static int -e1d_want_write(struct e1inp_ts *e1i_ts) +static int e1d_want_write(struct e1inp_ts *e1i_ts) { /* We never include the DAHDI B-Channel FD into the writeset */ if (e1i_ts->type == E1INP_TS_TYPE_TRAU || @@ -379,8 +371,7 @@ return 0; } -static int -e1d_line_update(struct e1inp_line *line) +static int e1d_line_update(struct e1inp_line *line) { int ts; int ret; @@ -532,8 +523,7 @@ .line_update = e1d_line_update, }; -int -e1inp_e1d_init(void) +int e1inp_e1d_init(void) { /* register the driver with the core */ return e1inp_driver_register(&e1d_driver); -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/32352 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I715e77849d771e05f8e7be82147c9168f9e8f86b Gerrit-Change-Number: 32352 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 2 months

1
0
0 0

2025

2024

2023

2022

gerrit-log April 2023