March 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-bsc[master]: abis_nm: Only osmo-bts re-purposes the MANUF_ID for BTS feature flags
by laforge 26 Mar '23

26 Mar '23

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/32070 ) Change subject: abis_nm: Only osmo-bts re-purposes the MANUF_ID for BTS feature flags ...................................................................... Patch Set 2: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-bsc/+/32070/comment/00571747_65134172 PS1, Line 16: O#5959 > typo: OS# Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32070 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I76cee190dc1f074464df570cdfc3d38559f04846 Gerrit-Change-Number: 32070 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 26 Mar 2023 20:31:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-bsc[master]: abis_nm: Only osmo-bts re-purposes the MANUF_ID for BTS feature flags
by fixeria 26 Mar '23

26 Mar '23

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/32070 ) Change subject: abis_nm: Only osmo-bts re-purposes the MANUF_ID for BTS feature flags ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-bsc/+/32070/comment/f873c68e_94c66f9f PS1, Line 16: O#5959 > typo: OS# Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32070 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I76cee190dc1f074464df570cdfc3d38559f04846 Gerrit-Change-Number: 32070 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Sun, 26 Mar 2023 20:31:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-bsc[master]: timeslot_fsm: Avoid error messages about TS_EV_OML_READY not permitted
by laforge 26 Mar '23

26 Mar '23

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/32071 ) Change subject: timeslot_fsm: Avoid error messages about TS_EV_OML_READY not permitted ...................................................................... timeslot_fsm: Avoid error messages about TS_EV_OML_READY not permitted Change-Id: Idd1f541d66abbf2a1d136df42a6fe277eeb9482d Related: OS#5973 --- M src/osmo-bsc/timeslot_fsm.c 1 file changed, 16 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/71/32071/1 diff --git a/src/osmo-bsc/timeslot_fsm.c b/src/osmo-bsc/timeslot_fsm.c index c7f6130..feb56a5 100644 --- a/src/osmo-bsc/timeslot_fsm.c +++ b/src/osmo-bsc/timeslot_fsm.c @@ -377,6 +377,11 @@ struct gsm_bts_trx_ts *ts = ts_fi_ts(fi); switch (event) { + case TS_EV_OML_READY: + /* ignore. This happens during nanoBTS bring-up, when we get a bunch of state changed + * reports after RSL has come up. This triggers us to send OPSTART (again!) for each TS, + * which in turn means that we get an OPSTART_ACK which gets translated to OML_READY event. */ + break; case TS_EV_LCHAN_REQUESTED: { @@ -878,6 +883,7 @@ .onenter = ts_fsm_unused_onenter, .action = ts_fsm_unused, .in_event_mask = 0 + | S(TS_EV_OML_READY) | S(TS_EV_LCHAN_REQUESTED) | S(TS_EV_LCHAN_UNUSED) , -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32071 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Idd1f541d66abbf2a1d136df42a6fe277eeb9482d Gerrit-Change-Number: 32071 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-bsc[master]: abis_nm: Only osmo-bts re-purposes the MANUF_ID for BTS feature flags
by laforge 26 Mar '23

26 Mar '23

Attention is currently required from: laforge. Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/32070 to look at the new patch set (#2). Change subject: abis_nm: Only osmo-bts re-purposes the MANUF_ID for BTS feature flags ...................................................................... abis_nm: Only osmo-bts re-purposes the MANUF_ID for BTS feature flags The Manufacturer ID IE is normally used to indicate the [name of] the manufacturer. In case of ip.access nanoBTS it is, for example, "com.ipaccess". Osmocom decided to re-pupose this IE to indicate bts-specific feature flags. Stop interpreting the string "com.ipaccess" as feature bitmap. Change-Id: I76cee190dc1f074464df570cdfc3d38559f04846 Closes: OS#5959 --- M src/osmo-bsc/abis_nm.c 1 file changed, 24 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/70/32070/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32070 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I76cee190dc1f074464df570cdfc3d38559f04846 Gerrit-Change-Number: 32070 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

1 0

[L] Change in libosmocore[master]: tests/conv: separate test logic
by fixeria 26 Mar '23

26 Mar '23

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/1627 ) Change subject: tests/conv: separate test logic ...................................................................... Patch Set 4: (1 comment) File tests/conv/conv.c: https://gerrit.osmocom.org/c/libosmocore/+/1627/comment/a907af6c_d30d8cea PS4, Line 42: return -1; > I suppose we don't care too much about memleaks here, because it's the test main function anyways? C […] Yeah, it's tests. I would not be spending time fixing this. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/1627 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Idbdc7e19cb9b9a36cd1fccd621cd858e87530d98 Gerrit-Change-Number: 1627 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-CC: arehbein <arehbein(a)sysmocom.de> Gerrit-Comment-Date: Sun, 26 Mar 2023 20:11:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: arehbein <arehbein(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in ...osmo-python-tests[master]: scripts/osmotestconfig.py: Fix tests failing due to attempted copy on...
by arehbein 26 Mar '23

26 Mar '23

Attention is currently required from: neels, pespin. arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/python/osmo-python-tests/+/30980 ) Change subject: scripts/osmotestconfig.py: Fix tests failing due to attempted copy on socket files ...................................................................... Patch Set 5: (1 comment) Patchset: PS5: > Having each python app/file creating those specific files register them to be cleaned up, and not be […] In general, I'm always for fixing things the 'proper' way. But the way it looks, nobody is going to change those socket file names any time soon. And then, still, that alone still wouldn't break anything. Doing what you describe would take a lot more time vs. this which is a quick fix that doesn't complicate anything/could be built upon when writing a 'proper' fix (by replacing the string literal with whatever is passed by the respective test component) -- To view, visit https://gerrit.osmocom.org/c/python/osmo-python-tests/+/30980 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: python/osmo-python-tests Gerrit-Branch: master Gerrit-Change-Id: I3a3cc7ed135b60b97eb901cfc20fdcb924e4f664 Gerrit-Change-Number: 30980 Gerrit-PatchSet: 5 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sun, 26 Mar 2023 19:52:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[M] Change in osmo-bts[master]: DTXu: mark beginning of speech burst in RTP
by arehbein 26 Mar '23

26 Mar '23

Attention is currently required from: Max. arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/223 ) Change subject: DTXu: mark beginning of speech burst in RTP ...................................................................... Patch Set 2: (1 comment) File src/osmo-bts-sysmo/tch.c: https://gerrit.osmocom.org/c/osmo-bts/+/223/comment/b9b73b72_f5098332 PS2, Line 183: osmo_amr_rtp_dec(l1_payload, payload_len, &cmr, &cmi, &ft, &bfi, &sti); Coverity was reporting this as a dummy function that always returns `-1` from `osmo-bts/src/osmo-bts-omldummy/bts_model.c`; same for my compilation db. So the following lines (in some later change encapsulated in a function) produce random data. Do we care about this (or is the data currently not being used)? Coverity ID 272956 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/223 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I3dd70ad8ff94356e3c3cc5458255f6c23534783e Gerrit-Change-Number: 223 Gerrit-PatchSet: 2 Gerrit-Owner: Max <suraev(a)alumni.ntnu.no> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: arehbein <arehbein(a)sysmocom.de> Gerrit-Attention: Max <suraev(a)alumni.ntnu.no> Gerrit-Comment-Date: Sun, 26 Mar 2023 19:50:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in libosmocore[master]: tests/conv: separate test logic
by arehbein 26 Mar '23

26 Mar '23

Attention is currently required from: fixeria. arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/1627 ) Change subject: tests/conv: separate test logic ...................................................................... Patch Set 4: (1 comment) File tests/conv/conv.c: https://gerrit.osmocom.org/c/libosmocore/+/1627/comment/3b36aa63_b62c15f9 PS4, Line 42: return -1; I suppose we don't care too much about memleaks here, because it's the test main function anyways? Coverity created some reports for this file, I think we can ignore those but I thought I'd check just in case -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/1627 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Idbdc7e19cb9b9a36cd1fccd621cd858e87530d98 Gerrit-Change-Number: 1627 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-CC: arehbein <arehbein(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 26 Mar 2023 19:49:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in osmo-bts[master]: common: Make socket queue max. length configurable
by arehbein 26 Mar '23

26 Mar '23

Attention is currently required from: fixeria, pespin. arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31534 ) Change subject: common: Make socket queue max. length configurable ...................................................................... Patch Set 9: (3 comments) File src/common/vty.c: https://gerrit.osmocom.org/c/osmo-bts/+/31534/comment/664eab2a_669b51cc PS6, Line 993: bts->pcu.sock_wqueue_len_max < 1 > No need to check the value range here, libosmovty ensures that it's in the specified range. Done File tests/osmo-bts.vty: https://gerrit.osmocom.org/c/osmo-bts/+/31534/comment/93e6f3d2_b8320554 PS6, Line 228: help > I guess by ellipsis you mean https://www.compart.com/en/unicode/U+2026, a unicode character. […] ah now I see why you asked me about unicode. No, I really meant the three dots as separate signs, but yeah I'll check next time there's no visual difference between 'expected' and 'got', if maybe that symbol snuck in somehow and why/when. Edit: So I checked again, I didn't see any unicode ellipsis anywhere. Pretty sure by now that it was a whitespace issue (which would also explain why I only sometimes had that seemingly weird issue). Unfortunately, the diff output from `make check` doesn't highlight whitespace differences. https://gerrit.osmocom.org/c/osmo-bts/+/31534/comment/e2f9746c_d04e95e7 PS6, Line 271: help Description of the interactive help system : list Print command list : show Show running system information : write Write running configuration to memory, network, or terminal : exit Exit current mode and down to previous mode : > Same here, these commands are masked with '...' on purpose. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31534 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Id6ba6e4eadce9ce82ef2407f4e28346e7fe4abfa Gerrit-Change-Number: 31534 Gerrit-PatchSet: 9 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sun, 26 Mar 2023 19:45:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: arehbein <arehbein(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[M] Change in osmo-bts[master]: common: Make socket queue max. length configurable
by arehbein 26 Mar '23

26 Mar '23

Attention is currently required from: arehbein, pespin. Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/31534 to look at the new patch set (#9). Change subject: common: Make socket queue max. length configurable ...................................................................... common: Make socket queue max. length configurable Title refers to the maximum length of the osmo_wqueue used for the PCU socket connection. Related: OS#5774 Change-Id: Id6ba6e4eadce9ce82ef2407f4e28346e7fe4abfa --- M include/osmo-bts/bts.h M include/osmo-bts/pcu_if.h M src/common/bts.c M src/common/main.c M src/common/pcu_sock.c M src/common/vty.c M tests/osmo-bts.vty 7 files changed, 59 insertions(+), 25 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/34/31534/9 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31534 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Id6ba6e4eadce9ce82ef2407f4e28346e7fe4abfa Gerrit-Change-Number: 31534 Gerrit-PatchSet: 9 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0