Attention is currently required from: Max. arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/223 ) Change subject: DTXu: mark beginning of speech burst in RTP ...................................................................... Patch Set 2: (1 comment) File src/osmo-bts-sysmo/tch.c: https://gerrit.osmocom.org/c/osmo-bts/+/223/comment/b9b73b72_f5098332 PS2, Line 183: osmo_amr_rtp_dec(l1_payload, payload_len, &cmr, &cmi, &ft, &bfi, &sti); Coverity was reporting this as a dummy function that always returns `-1` from `osmo-bts/src/osmo-bts-omldummy/bts_model.c`; same for my compilation db. So the following lines (in some later change encapsulated in a function) produce random data. Do we care about this (or is the data currently not being used)? Coverity ID 272956 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/223 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I3dd70ad8ff94356e3c3cc5458255f6c23534783e Gerrit-Change-Number: 223 Gerrit-PatchSet: 2 Gerrit-Owner: Max <suraev@alumni.ntnu.no> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-CC: arehbein <arehbein@sysmocom.de> Gerrit-Attention: Max <suraev@alumni.ntnu.no> Gerrit-Comment-Date: Sun, 26 Mar 2023 19:50:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment