Attention is currently required from: fixeria, pespin. arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31534 ) Change subject: common: Make socket queue max. length configurable ...................................................................... Patch Set 9: (3 comments) File src/common/vty.c: https://gerrit.osmocom.org/c/osmo-bts/+/31534/comment/664eab2a_669b51cc PS6, Line 993: bts->pcu.sock_wqueue_len_max < 1

No need to check the value range here, libosmovty ensures that it's in the specified range. Done

File tests/osmo-bts.vty: https://gerrit.osmocom.org/c/osmo-bts/+/31534/comment/93e6f3d2_b8320554 PS6, Line 228: help

I guess by ellipsis you mean https://www.compart.com/en/unicode/U+2026, a unicode character. […] ah now I see why you asked me about unicode. No, I really meant the three dots as separate signs, but yeah I'll check next time there's no visual difference between 'expected' and 'got', if maybe that symbol snuck in somehow and why/when.

Edit: So I checked again, I didn't see any unicode ellipsis anywhere. Pretty sure by now that it was a whitespace issue (which would also explain why I only sometimes had that seemingly weird issue). Unfortunately, the diff output from `make check` doesn't highlight whitespace differences. https://gerrit.osmocom.org/c/osmo-bts/+/31534/comment/e2f9746c_d04e95e7 PS6, Line 271: help Description of the interactive help system : list Print command list : show Show running system information : write Write running configuration to memory, network, or terminal : exit Exit current mode and down to previous mode :

Same here, these commands are masked with '...' on purpose. Done

-- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31534 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Id6ba6e4eadce9ce82ef2407f4e28346e7fe4abfa Gerrit-Change-Number: 31534 Gerrit-PatchSet: 9 Gerrit-Owner: arehbein <arehbein@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Sun, 26 Mar 2023 19:45:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: arehbein <arehbein@sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de> Gerrit-MessageType: comment