March 2023 - gerrit-log - lists.osmocom.org

[M] Change in osmo-msc[master]: 3G: decapsulate IuUP to AMR at the MGW; allow 3G<-AMR->2G
by neels 25 Mar '23

25 Mar '23

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/32069 ) Change subject: 3G: decapsulate IuUP to AMR at the MGW; allow 3G<-AMR->2G ...................................................................... 3G: decapsulate IuUP to AMR at the MGW; allow 3G<-AMR->2G For all 3G calls, convert IuUP <-> plain AMR/RTP on the MSC's MGW hop. Get rid of the shim that was put in place to still send IuUP (VND.3GPP.IUFP) to the CN. So now, for all 3G voice, the IuUP gets decapsulated to plain AMR/RTP at the MSC's MGW hop. What is proven to work with this patch: successful voice call between 2G and 3G with these conditions: - a hNodeB that stubbornly accepts only 12k2 AMR; - a 2G BTS configured to use only TCH/F and only FR3 (AMR 12k2); We have not yet seen a call working for TCH/H HR3 <-> 3G, because of the hNodeB's limitation to 12k2. Future work we probably need: - properly request and negotiate AMR rates via SDP fmtp:mode-set. - request more RFCIs in our RANAP RAB Assignment requests (see I61e0e9e75e3239662846fd797532acdefa9f73dc). Solving this is not part of this patch. Related: SYS#5092 Change-Id: I386a6a426c318040b019ab5541689c67e94672a1 --- M src/libmsc/msc_a.c M tests/msc_vlr/msc_vlr_test_call.err 2 files changed, 95 insertions(+), 58 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/69/32069/1 diff --git a/src/libmsc/msc_a.c b/src/libmsc/msc_a.c index c022ee2..e8dc58b 100644 --- a/src/libmsc/msc_a.c +++ b/src/libmsc/msc_a.c @@ -1389,7 +1389,6 @@ struct rtp_stream *rtps_to_ran = msc_a->cc.call_leg ? msc_a->cc.call_leg->rtp[RTP_TO_RAN] : NULL; const struct gsm0808_speech_codec *codec_if_known = ac->assignment_complete.codec_present ? &ac->assignment_complete.codec : NULL; - const struct codec_mapping *codec_cn; if (!rtps_to_ran) { LOG_MSC_A(msc_a, LOGL_ERROR, "Rx Assignment Complete, but no RTP stream is set up\n"); @@ -1408,27 +1407,27 @@ } if (codec_if_known) { - if (ac->assignment_complete.codec_with_iuup) { - /* FUTURE: soon, we want to tell the MGW to decapsulate IuUP to plain AMR-FR/RTP. So far, - * continue to forward IuUP to the CN. - * - * ran_msg_iu now returns AMR-FR as the assigned codec. If we use that directly, that will - * instruct the MGW to decapsulate IuUP into plain RTP. Let's keep this change to an explicit - * patch, while various codecs patches are still being applied. - * - * So instruct MGW to forward IuUP to CN: - */ - codec_cn = codec_mapping_by_subtype_name("VND.3GPP.IUFP"); - OSMO_ASSERT(codec_cn); - } else { - codec_cn = codec_mapping_by_gsm0808_speech_codec_type(codec_if_known->type); - /* TODO: use codec_mapping_by_gsm0808_speech_codec() to also match on codec_if_known->cfg */ - if (!codec_cn) { - LOG_TRANS(cc_trans, LOGL_ERROR, "Unknown codec in Assignment Complete: %s\n", - gsm0808_speech_codec_type_name(codec_if_known->type)); - call_leg_release(msc_a->cc.call_leg); - return; - } + const struct codec_mapping *codec_cn; + /* For 2G: + * - The Assignment Complete has returned a specific codec (e.g. FR3 for AMR FR). + * - Set this codec at the MGW endpoint facing the RAN. + * - Also set this codec at the MGW endpoint facing the CN -- we require an exact match on both call + * legs. + * - TODO: be aware of transcoding that the MGW is capable of, e.g. AMR octet-aligned to AMR + * bandwidth-efficient... + * + * For 3G: + * - ran_infra->force_mgw_codecs_to_ran sets VND.3GPP.IUFP as single codec at the MGW towards RAN. + * - ran_msg_iu.c always returns FR3 (AMR FR) for the assigned codec. Set that at the MGW towards CN. + * - So the MGW decapsulates IuUP <-> AMR + */ + codec_cn = codec_mapping_by_gsm0808_speech_codec_type(codec_if_known->type); + /* TODO: use codec_mapping_by_gsm0808_speech_codec() to also match on codec_if_known->cfg */ + if (!codec_cn) { + LOG_TRANS(cc_trans, LOGL_ERROR, "Unknown codec in Assignment Complete: %s\n", + gsm0808_speech_codec_type_name(codec_if_known->type)); + call_leg_release(msc_a->cc.call_leg); + return; } /* Update RAN-side endpoint CI from Assignment result -- unless it is forced by the ran_infra, in which diff --git a/tests/msc_vlr/msc_vlr_test_call.err b/tests/msc_vlr/msc_vlr_test_call.err index 0fb396d..2a14f51 100644 --- a/tests/msc_vlr/msc_vlr_test_call.err +++ b/tests/msc_vlr/msc_vlr_test_call.err @@ -337,17 +337,18 @@ DIUCS msc_a(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ){MSC_A_ST_COMMUNICATING}: RAN decode: ASSIGNMENT_COMPLETE DCC rtp_stream(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ:trans-8:call-2147483649:RTP_TO_RAN:no-CI){UNINITIALIZED}: setting remote addr to 1.2.3.4:1234 DCC rtp_stream(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ:trans-8:call-2147483649:RTP_TO_RAN:no-CI:local-10-23-23-1-23:remote-1-2-3-4-1234){UNINITIALIZED}: Not committing: no MGW endpoint CI set up -DCC trans(CC:INITIATED IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ callref-0x80000001 tid-8) Assignment Complete: RAN: VND.3GPP.IUFP/16000#96, CN: VND.3GPP.IUFP/16000#96 -DCC trans(CC:INITIATED IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ callref-0x80000001 tid-8) codecs: 10.23.23.1:23{VND.3GPP.IUFP/16000#96} (from: assigned=VND.3GPP.IUFP/16000#96 MS={AMR:octet-align=1#112,GSM-EFR#110,GSM#3,GSM-HR-08#111} RAN={AMR:octet-align=1#112,AMR-WB/16000:octet-align=1#113}) -DMNCC trans(CC:INITIATED IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ callref-0x80000001 tid-8) tx MNCC_RTP_CREATE (RTP=10.23.23.1:23{VND.3GPP.IUFP/16000#96}) +DCC trans(CC:INITIATED IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ callref-0x80000001 tid-8) Assignment Complete: RAN: VND.3GPP.IUFP/16000#96, CN: AMR:octet-align=1#112 +DCC trans(CC:INITIATED IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ callref-0x80000001 tid-8) codecs: 10.23.23.1:23{AMR:octet-align=1#112} (from: assigned=AMR:octet-align=1#112 MS={AMR:octet-align=1#112,GSM-EFR#110,GSM#3,GSM-HR-08#111} RAN={AMR:octet-align=1#112,AMR-WB/16000:octet-align=1#113}) +DMNCC trans(CC:INITIATED IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ callref-0x80000001 tid-8) tx MNCC_RTP_CREATE (RTP=10.23.23.1:23{AMR:octet-align=1#112}) MSC --> MNCC: callref 0x80000001: MNCC_RTP_CREATE v=0 o=OsmoMSC 0 0 IN IP4 10.23.23.1 s=GSM Call c=IN IP4 10.23.23.1 t=0 0 -m=audio 23 RTP/AVP 96 -a=rtpmap:96 VND.3GPP.IUFP/16000 +m=audio 23 RTP/AVP 112 +a=rtpmap:112 AMR/8000 +a=fmtp:112 octet-align=1 a=ptime:20 - MNCC says that's fine @@ -836,7 +837,7 @@ DIUCS msc_a(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){MSC_A_ST_COMMUNICATING}: RAN decode: ASSIGNMENT_COMPLETE DCC rtp_stream(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP:trans-0:call-1059:RTP_TO_RAN:no-CI){UNINITIALIZED}: setting remote addr to 1.2.3.4:1234 DCC rtp_stream(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP:trans-0:call-1059:RTP_TO_RAN:no-CI:local-10-23-23-1-23:remote-1-2-3-4-1234){UNINITIALIZED}: Not committing: no MGW endpoint CI set up -DCC trans(CC:MO_TERM_CALL_CONF IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP callref-0x423 tid-0) Assignment Complete: RAN: VND.3GPP.IUFP/16000#96, CN: VND.3GPP.IUFP/16000#96 +DCC trans(CC:MO_TERM_CALL_CONF IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP callref-0x423 tid-0) Assignment Complete: RAN: VND.3GPP.IUFP/16000#96, CN: AMR:octet-align=1#112 DCC trans(CC:MO_TERM_CALL_CONF IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP callref-0x423 tid-0) Assignment complete, but still waiting for the CRCX OK on the CN side RTP - MNCC sends MNCC_RTP_CREATE, which first waits for the CN side RTP MSC <-- MNCC: callref 0x423: MNCC_RTP_CREATE @@ -848,16 +849,17 @@ DCC call_leg(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){ESTABLISHING}: Received Event CALL_LEG_EV_RTP_STREAM_ADDR_AVAILABLE DMSC msc_a(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){MSC_A_ST_COMMUNICATING}: Received Event MSC_EV_CALL_LEG_RTP_LOCAL_ADDR_AVAILABLE DIUCS msc_a(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){MSC_A_ST_COMMUNICATING}: MGW endpoint's RTP address available for the CI RTP_TO_CN: 10.23.23.1:23 (osmux=no:-2) -DCC trans(CC:MO_TERM_CALL_CONF IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP callref-0x423 tid-0) codecs: 10.23.23.1:23{VND.3GPP.IUFP/16000#96} (from: assigned=VND.3GPP.IUFP/16000#96 remote=10.23.23.1:23{AMR:octet-align=1#112} MS={AMR:octet-align=1#112,GSM-EFR#110,GSM#3,GSM-HR-08#111} RAN={AMR:octet-align=1#112,AMR-WB/16000:octet-align=1#113}) -DMNCC trans(CC:MO_TERM_CALL_CONF IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP callref-0x423 tid-0) tx MNCC_RTP_CREATE (RTP=10.23.23.1:23{VND.3GPP.IUFP/16000#96}) +DCC trans(CC:MO_TERM_CALL_CONF IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP callref-0x423 tid-0) codecs: 10.23.23.1:23{AMR:octet-align=1#112} (from: assigned=AMR:octet-align=1#112 remote=10.23.23.1:23{AMR:octet-align=1#112} MS={AMR:octet-align=1#112,GSM-EFR#110,GSM#3,GSM-HR-08#111} RAN={AMR:octet-align=1#112,AMR-WB/16000:octet-align=1#113}) +DMNCC trans(CC:MO_TERM_CALL_CONF IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP callref-0x423 tid-0) tx MNCC_RTP_CREATE (RTP=10.23.23.1:23{AMR:octet-align=1#112}) MSC --> MNCC: callref 0x423: MNCC_RTP_CREATE v=0 o=OsmoMSC 0 0 IN IP4 10.23.23.1 s=GSM Call c=IN IP4 10.23.23.1 t=0 0 -m=audio 23 RTP/AVP 96 -a=rtpmap:96 VND.3GPP.IUFP/16000 +m=audio 23 RTP/AVP 112 +a=rtpmap:112 AMR/8000 +a=fmtp:112 octet-align=1 a=ptime:20 - Total time passed: 1.000023 s @@ -869,16 +871,17 @@ DCC trans(CC:MO_TERM_CALL_CONF IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP callref-0x423 tid-0) stopping pending timer T310 DCC trans(CC:MO_TERM_CALL_CONF IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP callref-0x423 tid-0) starting timer T301 with 180 seconds DCC trans(CC:MO_TERM_CALL_CONF IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP callref-0x423 tid-0) new state MO_TERM_CALL_CONF -> CALL_RECEIVED -DCC trans(CC:CALL_RECEIVED IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP callref-0x423 tid-0) codecs: 10.23.23.1:23{VND.3GPP.IUFP/16000#96} (from: assigned=VND.3GPP.IUFP/16000#96 remote=10.23.23.1:23{AMR:octet-align=1#112} MS={AMR:octet-align=1#112,GSM-EFR#110,GSM#3,GSM-HR-08#111} RAN={AMR:octet-align=1#112,AMR-WB/16000:octet-align=1#113}) -DMNCC trans(CC:CALL_RECEIVED IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP callref-0x423 tid-0) tx MNCC_ALERT_IND (RTP=10.23.23.1:23{VND.3GPP.IUFP/16000#96}) +DCC trans(CC:CALL_RECEIVED IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP callref-0x423 tid-0) codecs: 10.23.23.1:23{AMR:octet-align=1#112} (from: assigned=AMR:octet-align=1#112 remote=10.23.23.1:23{AMR:octet-align=1#112} MS={AMR:octet-align=1#112,GSM-EFR#110,GSM#3,GSM-HR-08#111} RAN={AMR:octet-align=1#112,AMR-WB/16000:octet-align=1#113}) +DMNCC trans(CC:CALL_RECEIVED IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP callref-0x423 tid-0) tx MNCC_ALERT_IND (RTP=10.23.23.1:23{AMR:octet-align=1#112}) MSC --> MNCC: callref 0x423: MNCC_ALERT_IND v=0 o=OsmoMSC 0 0 IN IP4 10.23.23.1 s=GSM Call c=IN IP4 10.23.23.1 t=0 0 -m=audio 23 RTP/AVP 96 -a=rtpmap:96 VND.3GPP.IUFP/16000 +m=audio 23 RTP/AVP 112 +a=rtpmap:112 AMR/8000 +a=fmtp:112 octet-align=1 a=ptime:20 DREF msc_a(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){MSC_A_ST_COMMUNICATING}: - rx_from_ms: now used by 1 (cc) @@ -890,15 +893,16 @@ DCC trans(CC:CALL_RECEIVED IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP callref-0x423 tid-0) rx CONNECT in state CALL_RECEIVED DCC trans(CC:CALL_RECEIVED IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP callref-0x423 tid-0) stopping pending timer T301 DCC trans(CC:CALL_RECEIVED IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP callref-0x423 tid-0) new state CALL_RECEIVED -> CONNECT_REQUEST -DMNCC trans(CC:CONNECT_REQUEST IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP callref-0x423 tid-0) tx MNCC_SETUP_CNF (RTP=10.23.23.1:23{VND.3GPP.IUFP/16000#96}) +DMNCC trans(CC:CONNECT_REQUEST IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP callref-0x423 tid-0) tx MNCC_SETUP_CNF (RTP=10.23.23.1:23{AMR:octet-align=1#112}) MSC --> MNCC: callref 0x423: MNCC_SETUP_CNF v=0 o=OsmoMSC 0 0 IN IP4 10.23.23.1 s=GSM Call c=IN IP4 10.23.23.1 t=0 0 -m=audio 23 RTP/AVP 96 -a=rtpmap:96 VND.3GPP.IUFP/16000 +m=audio 23 RTP/AVP 112 +a=rtpmap:112 AMR/8000 +a=fmtp:112 octet-align=1 a=ptime:20 DREF msc_a(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){MSC_A_ST_COMMUNICATING}: - rx_from_ms: now used by 1 (cc) @@ -1362,23 +1366,24 @@ DIUCS msc_a(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){MSC_A_ST_COMMUNICATING}: RAN decode: ASSIGNMENT_COMPLETE DCC rtp_stream(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP:trans-0:call-1059:RTP_TO_RAN:no-CI){UNINITIALIZED}: setting remote addr to 1.2.3.4:1234 DCC rtp_stream(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP:trans-0:call-1059:RTP_TO_RAN:no-CI:local-10-23-23-1-23:remote-1-2-3-4-1234){UNINITIALIZED}: Not committing: no MGW endpoint CI set up -DCC trans(CC:MO_TERM_CALL_CONF IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP callref-0x423 tid-0) Assignment Complete: RAN: VND.3GPP.IUFP/16000#96, CN: VND.3GPP.IUFP/16000#96 +DCC trans(CC:MO_TERM_CALL_CONF IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP callref-0x423 tid-0) Assignment Complete: RAN: VND.3GPP.IUFP/16000#96, CN: AMR:octet-align=1#112 DCC trans(CC:MO_TERM_CALL_CONF IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP callref-0x423 tid-0) Assignment complete, but still waiting for the CRCX OK on the CN side RTP - When the CN side RTP address is known, ack MNCC_RTP_CREATE with full SDP MGW --CRCX OK to RTP_TO_CN--> MSC DCC call_leg(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){ESTABLISHING}: Received Event CALL_LEG_EV_RTP_STREAM_ADDR_AVAILABLE DMSC msc_a(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){MSC_A_ST_COMMUNICATING}: Received Event MSC_EV_CALL_LEG_RTP_LOCAL_ADDR_AVAILABLE DIUCS msc_a(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){MSC_A_ST_COMMUNICATING}: MGW endpoint's RTP address available for the CI RTP_TO_CN: 10.23.23.1:23 (osmux=no:-2) -DCC trans(CC:MO_TERM_CALL_CONF IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP callref-0x423 tid-0) codecs: 10.23.23.1:23{VND.3GPP.IUFP/16000#96} (from: assigned=VND.3GPP.IUFP/16000#96 remote=10.23.23.1:23{AMR:octet-align=1#112} MS={AMR:octet-align=1#112,GSM-EFR#110,GSM#3,GSM-HR-08#111} RAN={AMR:octet-align=1#112,AMR-WB/16000:octet-align=1#113}) -DMNCC trans(CC:MO_TERM_CALL_CONF IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP callref-0x423 tid-0) tx MNCC_RTP_CREATE (RTP=10.23.23.1:23{VND.3GPP.IUFP/16000#96}) +DCC trans(CC:MO_TERM_CALL_CONF IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP callref-0x423 tid-0) codecs: 10.23.23.1:23{AMR:octet-align=1#112} (from: assigned=AMR:octet-align=1#112 remote=10.23.23.1:23{AMR:octet-align=1#112} MS={AMR:octet-align=1#112,GSM-EFR#110,GSM#3,GSM-HR-08#111} RAN={AMR:octet-align=1#112,AMR-WB/16000:octet-align=1#113}) +DMNCC trans(CC:MO_TERM_CALL_CONF IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP callref-0x423 tid-0) tx MNCC_RTP_CREATE (RTP=10.23.23.1:23{AMR:octet-align=1#112}) MSC --> MNCC: callref 0x423: MNCC_RTP_CREATE v=0 o=OsmoMSC 0 0 IN IP4 10.23.23.1 s=GSM Call c=IN IP4 10.23.23.1 t=0 0 -m=audio 23 RTP/AVP 96 -a=rtpmap:96 VND.3GPP.IUFP/16000 +m=audio 23 RTP/AVP 112 +a=rtpmap:112 AMR/8000 +a=fmtp:112 octet-align=1 a=ptime:20 - Total time passed: 1.000023 s @@ -1390,16 +1395,17 @@ DCC trans(CC:MO_TERM_CALL_CONF IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP callref-0x423 tid-0) stopping pending timer T310 DCC trans(CC:MO_TERM_CALL_CONF IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP callref-0x423 tid-0) starting timer T301 with 180 seconds DCC trans(CC:MO_TERM_CALL_CONF IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP callref-0x423 tid-0) new state MO_TERM_CALL_CONF -> CALL_RECEIVED -DCC trans(CC:CALL_RECEIVED IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP callref-0x423 tid-0) codecs: 10.23.23.1:23{VND.3GPP.IUFP/16000#96} (from: assigned=VND.3GPP.IUFP/16000#96 remote=10.23.23.1:23{AMR:octet-align=1#112} MS={AMR:octet-align=1#112,GSM-EFR#110,GSM#3,GSM-HR-08#111} RAN={AMR:octet-align=1#112,AMR-WB/16000:octet-align=1#113}) -DMNCC trans(CC:CALL_RECEIVED IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP callref-0x423 tid-0) tx MNCC_ALERT_IND (RTP=10.23.23.1:23{VND.3GPP.IUFP/16000#96}) +DCC trans(CC:CALL_RECEIVED IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP callref-0x423 tid-0) codecs: 10.23.23.1:23{AMR:octet-align=1#112} (from: assigned=AMR:octet-align=1#112 remote=10.23.23.1:23{AMR:octet-align=1#112} MS={AMR:octet-align=1#112,GSM-EFR#110,GSM#3,GSM-HR-08#111} RAN={AMR:octet-align=1#112,AMR-WB/16000:octet-align=1#113}) +DMNCC trans(CC:CALL_RECEIVED IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP callref-0x423 tid-0) tx MNCC_ALERT_IND (RTP=10.23.23.1:23{AMR:octet-align=1#112}) MSC --> MNCC: callref 0x423: MNCC_ALERT_IND v=0 o=OsmoMSC 0 0 IN IP4 10.23.23.1 s=GSM Call c=IN IP4 10.23.23.1 t=0 0 -m=audio 23 RTP/AVP 96 -a=rtpmap:96 VND.3GPP.IUFP/16000 +m=audio 23 RTP/AVP 112 +a=rtpmap:112 AMR/8000 +a=fmtp:112 octet-align=1 a=ptime:20 DREF msc_a(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){MSC_A_ST_COMMUNICATING}: - rx_from_ms: now used by 1 (cc) @@ -1811,17 +1817,18 @@ DIUCS msc_a(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ){MSC_A_ST_COMMUNICATING}: RAN decode: ASSIGNMENT_COMPLETE DCC rtp_stream(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ:trans-8:call-2147483650:RTP_TO_RAN:no-CI){UNINITIALIZED}: setting remote addr to 1.2.3.4:1234 DCC rtp_stream(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ:trans-8:call-2147483650:RTP_TO_RAN:no-CI:local-10-23-23-1-23:remote-1-2-3-4-1234){UNINITIALIZED}: Not committing: no MGW endpoint CI set up -DCC trans(CC:INITIATED IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ callref-0x80000002 tid-8) Assignment Complete: RAN: VND.3GPP.IUFP/16000#96, CN: VND.3GPP.IUFP/16000#96 -DCC trans(CC:INITIATED IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ callref-0x80000002 tid-8) codecs: 10.23.23.1:23{VND.3GPP.IUFP/16000#96} (from: assigned=VND.3GPP.IUFP/16000#96 MS={AMR:octet-align=1#112,GSM-EFR#110,GSM#3,GSM-HR-08#111} RAN={AMR:octet-align=1#112,AMR-WB/16000:octet-align=1#113}) -DMNCC trans(CC:INITIATED IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ callref-0x80000002 tid-8) tx MNCC_RTP_CREATE (RTP=10.23.23.1:23{VND.3GPP.IUFP/16000#96}) +DCC trans(CC:INITIATED IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ callref-0x80000002 tid-8) Assignment Complete: RAN: VND.3GPP.IUFP/16000#96, CN: AMR:octet-align=1#112 +DCC trans(CC:INITIATED IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ callref-0x80000002 tid-8) codecs: 10.23.23.1:23{AMR:octet-align=1#112} (from: assigned=AMR:octet-align=1#112 MS={AMR:octet-align=1#112,GSM-EFR#110,GSM#3,GSM-HR-08#111} RAN={AMR:octet-align=1#112,AMR-WB/16000:octet-align=1#113}) +DMNCC trans(CC:INITIATED IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ callref-0x80000002 tid-8) tx MNCC_RTP_CREATE (RTP=10.23.23.1:23{AMR:octet-align=1#112}) MSC --> MNCC: callref 0x80000002: MNCC_RTP_CREATE v=0 o=OsmoMSC 0 0 IN IP4 10.23.23.1 s=GSM Call c=IN IP4 10.23.23.1 t=0 0 -m=audio 23 RTP/AVP 96 -a=rtpmap:96 VND.3GPP.IUFP/16000 +m=audio 23 RTP/AVP 112 +a=rtpmap:112 AMR/8000 +a=fmtp:112 octet-align=1 a=ptime:20 - MNCC says that's fine @@ -2261,17 +2268,18 @@ DIUCS msc_a(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ){MSC_A_ST_COMMUNICATING}: RAN decode: ASSIGNMENT_COMPLETE DCC rtp_stream(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ:trans-8:call-2147483651:RTP_TO_RAN:no-CI){UNINITIALIZED}: setting remote addr to 1.2.3.4:1234 DCC rtp_stream(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ:trans-8:call-2147483651:RTP_TO_RAN:no-CI:local-10-23-23-1-23:remote-1-2-3-4-1234){UNINITIALIZED}: Not committing: no MGW endpoint CI set up -DCC trans(CC:INITIATED IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ callref-0x80000003 tid-8) Assignment Complete: RAN: VND.3GPP.IUFP/16000#96, CN: VND.3GPP.IUFP/16000#96 -DCC trans(CC:INITIATED IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ callref-0x80000003 tid-8) codecs: 10.23.23.1:23{VND.3GPP.IUFP/16000#96} (from: assigned=VND.3GPP.IUFP/16000#96 MS={AMR:octet-align=1#112,GSM-EFR#110,GSM#3,GSM-HR-08#111} RAN={AMR:octet-align=1#112,AMR-WB/16000:octet-align=1#113}) -DMNCC trans(CC:INITIATED IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ callref-0x80000003 tid-8) tx MNCC_RTP_CREATE (RTP=10.23.23.1:23{VND.3GPP.IUFP/16000#96}) +DCC trans(CC:INITIATED IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ callref-0x80000003 tid-8) Assignment Complete: RAN: VND.3GPP.IUFP/16000#96, CN: AMR:octet-align=1#112 +DCC trans(CC:INITIATED IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ callref-0x80000003 tid-8) codecs: 10.23.23.1:23{AMR:octet-align=1#112} (from: assigned=AMR:octet-align=1#112 MS={AMR:octet-align=1#112,GSM-EFR#110,GSM#3,GSM-HR-08#111} RAN={AMR:octet-align=1#112,AMR-WB/16000:octet-align=1#113}) +DMNCC trans(CC:INITIATED IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ callref-0x80000003 tid-8) tx MNCC_RTP_CREATE (RTP=10.23.23.1:23{AMR:octet-align=1#112}) MSC --> MNCC: callref 0x80000003: MNCC_RTP_CREATE v=0 o=OsmoMSC 0 0 IN IP4 10.23.23.1 s=GSM Call c=IN IP4 10.23.23.1 t=0 0 -m=audio 23 RTP/AVP 96 -a=rtpmap:96 VND.3GPP.IUFP/16000 +m=audio 23 RTP/AVP 112 +a=rtpmap:112 AMR/8000 +a=fmtp:112 octet-align=1 a=ptime:20 - MNCC says that's fine -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/32069 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I386a6a426c318040b019ab5541689c67e94672a1 Gerrit-Change-Number: 32069 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[M] Change in osmo-iuh[master]: RAB Assignment: add more SDUs for more AMR modes
by neels 25 Mar '23

25 Mar '23

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/32067 ) Change subject: RAB Assignment: add more SDUs for more AMR modes ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: still need to verify that these changes work. So far only tested with nano3G, which seems stubbornly fixated on 12k2 AMR only. -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/32067 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I61e0e9e75e3239662846fd797532acdefa9f73dc Gerrit-Change-Number: 32067 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Sat, 25 Mar 2023 23:20:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in osmo-iuh[master]: RAB Assignment: add more SDUs for more AMR modes
by neels 25 Mar '23

25 Mar '23

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-iuh/+/32067 ) Change subject: RAB Assignment: add more SDUs for more AMR modes ...................................................................... RAB Assignment: add more SDUs for more AMR modes Change-Id: I61e0e9e75e3239662846fd797532acdefa9f73dc --- M src/ranap_msg_factory.c M src/tests/test-ranap.ok 2 files changed, 82 insertions(+), 19 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/67/32067/1 diff --git a/src/ranap_msg_factory.c b/src/ranap_msg_factory.c index b871343..25209c2 100644 --- a/src/ranap_msg_factory.c +++ b/src/ranap_msg_factory.c @@ -545,16 +545,31 @@ switch (profile) { case SDUPAR_P_VOICE0: - sdui->sDU_ErrorRatio = new_sdu_error_ratio(1, 5); + sdui->sDU_ErrorRatio = new_sdu_error_ratio(7, 3); sdui->residualBitErrorRatio.mantissa = 1; - sdui->residualBitErrorRatio.exponent = 6; + sdui->residualBitErrorRatio.exponent = 4; sdui->deliveryOfErroneousSDU = RANAP_DeliveryOfErroneousSDU_yes; sdui->sDU_FormatInformationParameters = fmtip; fmti = new_format_info_pars(81); ASN_SEQUENCE_ADD(fmtip, fmti); + fmti = new_format_info_pars(65); + ASN_SEQUENCE_ADD(fmtip, fmti); + fmti = new_format_info_pars(75); + ASN_SEQUENCE_ADD(fmtip, fmti); + fmti = new_format_info_pars(61); + ASN_SEQUENCE_ADD(fmtip, fmti); + fmti = new_format_info_pars(58); + ASN_SEQUENCE_ADD(fmtip, fmti); + fmti = new_format_info_pars(55); + ASN_SEQUENCE_ADD(fmtip, fmti); + fmti = new_format_info_pars(49); + ASN_SEQUENCE_ADD(fmtip, fmti); + fmti = new_format_info_pars(42); + ASN_SEQUENCE_ADD(fmtip, fmti); fmti = new_format_info_pars(39); ASN_SEQUENCE_ADD(fmtip, fmti); - /* FIXME: could be 10 SDU descriptors for AMR! */ + fmti = new_format_info_pars(0); + ASN_SEQUENCE_ADD(fmtip, fmti); break; case SDUPAR_P_VOICE1: sdui->residualBitErrorRatio.mantissa = 1; @@ -563,17 +578,48 @@ sdui->sDU_FormatInformationParameters = fmtip; fmti = new_format_info_pars(103); ASN_SEQUENCE_ADD(fmtip, fmti); + fmti = new_format_info_pars(99); + ASN_SEQUENCE_ADD(fmtip, fmti); + fmti = new_format_info_pars(84); + ASN_SEQUENCE_ADD(fmtip, fmti); + fmti = new_format_info_pars(87); + ASN_SEQUENCE_ADD(fmtip, fmti); + fmti = new_format_info_pars(76); + ASN_SEQUENCE_ADD(fmtip, fmti); + fmti = new_format_info_pars(63); + ASN_SEQUENCE_ADD(fmtip, fmti); + fmti = new_format_info_pars(54); + ASN_SEQUENCE_ADD(fmtip, fmti); + fmti = new_format_info_pars(53); + ASN_SEQUENCE_ADD(fmtip, fmti); fmti = new_format_info_pars(0); ASN_SEQUENCE_ADD(fmtip, fmti); - /* FIXME: could be 10 SDU descriptors for AMR! */ + fmti = new_format_info_pars(0); + ASN_SEQUENCE_ADD(fmtip, fmti); break; case SDUPAR_P_VOICE2: - sdui->residualBitErrorRatio.mantissa = 5; + sdui->residualBitErrorRatio.mantissa = 1; sdui->residualBitErrorRatio.exponent = 3; sdui->deliveryOfErroneousSDU = RANAP_DeliveryOfErroneousSDU_no_error_detection_consideration; sdui->sDU_FormatInformationParameters = fmtip; fmti = new_format_info_pars(60); ASN_SEQUENCE_ADD(fmtip, fmti); + fmti = new_format_info_pars(40); + ASN_SEQUENCE_ADD(fmtip, fmti); + fmti = new_format_info_pars(0); + ASN_SEQUENCE_ADD(fmtip, fmti); + fmti = new_format_info_pars(0); + ASN_SEQUENCE_ADD(fmtip, fmti); + fmti = new_format_info_pars(0); + ASN_SEQUENCE_ADD(fmtip, fmti); + fmti = new_format_info_pars(0); + ASN_SEQUENCE_ADD(fmtip, fmti); + fmti = new_format_info_pars(0); + ASN_SEQUENCE_ADD(fmtip, fmti); + fmti = new_format_info_pars(0); + ASN_SEQUENCE_ADD(fmtip, fmti); + fmti = new_format_info_pars(0); + ASN_SEQUENCE_ADD(fmtip, fmti); fmti = new_format_info_pars(0); ASN_SEQUENCE_ADD(fmtip, fmti); /* FIXME: could be 10 SDU descriptors for AMR! */ @@ -639,7 +685,7 @@ sdui = new_sdu_par_item(SDUPAR_P_VOICE2); ASN_SEQUENCE_ADD(&rab->sDU_Parameters, sdui); - rab->transferDelay = new_long(80); + rab->transferDelay = new_long(100); rab->allocationOrRetentionPriority = new_alloc_ret_prio(RANAP_PriorityLevel_no_priority, 0, 1, 0); rab->sourceStatisticsDescriptor = new_long(RANAP_SourceStatisticsDescriptor_speech); @@ -745,7 +791,7 @@ memset(&first, 0, sizeof(first)); assign_new_ra_id(&first.rAB_ID, rab_id); first.nAS_SynchronisationIndicator = new_rab_nas_sync_ind(60); - first.rAB_Parameters = new_rab_par_voice(6700, 12200); + first.rAB_Parameters = new_rab_par_voice(4750, 12200); first.userPlaneInformation = new_upi(RANAP_UserPlaneMode_support_mode_for_predefined_SDU_sizes, 1); /* 2? */ rtp_addr.u.sin.sin_family = AF_INET; diff --git a/src/tests/test-ranap.ok b/src/tests/test-ranap.ok index a0ea521..ebfa2dc 100644 --- a/src/tests/test-ranap.ok +++ b/src/tests/test-ranap.ok @@ -88,11 +88,15 @@ <id>53</id> <firstCriticality><reject/></firstCriticality> <firstValue> - 78 02 CD 80 10 2F A7 20 1A 2C 00 00 F4 4C 08 0A - 02 80 00 51 40 00 27 20 28 14 00 67 40 00 00 22 - 28 14 00 3C 40 00 00 00 50 3D 02 00 02 27 C0 35 - 00 01 0A 0B 0C 0D 00 00 00 00 00 00 00 00 00 00 - 00 00 00 40 09 26 00 00 + 78 02 CD 80 10 2F A7 20 12 8E 00 00 F4 4C 64 06 + 12 80 00 51 40 00 41 40 00 4B 40 00 3D 40 00 3A + 40 00 37 40 00 31 40 00 2A 40 00 27 40 00 00 20 + 28 94 00 67 40 00 63 40 00 54 40 00 57 40 00 4C + 40 00 3F 40 00 36 40 00 35 40 00 00 40 00 00 20 + 28 94 00 3C 40 00 28 40 00 00 40 00 00 40 00 00 + 40 00 00 40 00 00 40 00 00 40 00 00 40 00 00 00 + 64 3D 02 00 02 27 C0 35 00 01 0A 0B 0C 0D 00 00 + 00 00 00 00 00 00 00 00 00 00 00 40 09 26 00 00 </firstValue> <secondCriticality><ignore/></secondCriticality> <secondValue>00</secondValue> @@ -101,15 +105,19 @@ <id>54</id> <criticality><ignore/></criticality> <value> - 00 00 01 00 35 00 48 78 02 CD 80 10 2F A7 20 1A - 2C 00 00 F4 4C 08 0A 02 80 00 51 40 00 27 20 28 - 14 00 67 40 00 00 22 28 14 00 3C 40 00 00 00 50 - 3D 02 00 02 27 C0 35 00 01 0A 0B 0C 0D 00 00 00 - 00 00 00 00 00 00 00 00 00 00 40 09 26 00 00 40 - 01 00 + 00 00 01 00 35 00 80 90 78 02 CD 80 10 2F A7 20 + 12 8E 00 00 F4 4C 64 06 12 80 00 51 40 00 41 40 + 00 4B 40 00 3D 40 00 3A 40 00 37 40 00 31 40 00 + 2A 40 00 27 40 00 00 20 28 94 00 67 40 00 63 40 + 00 54 40 00 57 40 00 4C 40 00 3F 40 00 36 40 00 + 35 40 00 00 40 00 00 20 28 94 00 3C 40 00 28 40 + 00 00 40 00 00 40 00 00 40 00 00 40 00 00 40 00 + 00 40 00 00 40 00 00 00 64 3D 02 00 02 27 C0 35 + 00 01 0A 0B 0C 0D 00 00 00 00 00 00 00 00 00 00 + 00 00 00 40 09 26 00 00 40 01 00 </value> </RANAP_IE> -00 00 00 59 00 00 01 00 36 40 52 00 00 01 00 35 00 48 78 02 cd 80 10 2f a7 20 1a 2c 00 00 f4 4c 08 0a 02 80 00 51 40 00 27 20 28 14 00 67 40 00 00 22 28 14 00 3c 40 00 00 00 50 3d 02 00 02 27 c0 35 00 01 0a 0b 0c 0d 00 00 00 00 00 00 00 00 00 00 00 00 00 40 09 26 00 00 40 01 00 +00 00 00 80 a3 00 00 01 00 36 40 80 9b 00 00 01 00 35 00 80 90 78 02 cd 80 10 2f a7 20 12 8e 00 00 f4 4c 64 06 12 80 00 51 40 00 41 40 00 4b 40 00 3d 40 00 3a 40 00 37 40 00 31 40 00 2a 40 00 27 40 00 00 20 28 94 00 67 40 00 63 40 00 54 40 00 57 40 00 4c 40 00 3f 40 00 36 40 00 35 40 00 00 40 00 00 20 28 94 00 3c 40 00 28 40 00 00 40 00 00 40 00 00 40 00 00 40 00 00 40 00 00 40 00 00 40 00 00 00 64 3d 02 00 02 27 c0 35 00 01 0a 0b 0c 0d 00 00 00 00 00 00 00 00 00 00 00 00 00 40 09 26 00 00 40 01 00 ==> RAB ASSIGNMENT COMMAND (DATA) <RANAP_ProtocolIE-FieldPair> -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/32067 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I61e0e9e75e3239662846fd797532acdefa9f73dc Gerrit-Change-Number: 32067 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-bts[master]: PCU interface: Log version when starting listener
by arehbein 25 Mar '23

25 Mar '23

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/32064 to look at the new patch set (#3). Change subject: PCU interface: Log version when starting listener ...................................................................... PCU interface: Log version when starting listener Change-Id: Ieba46cc7eee7758033815014ee38bf4751a0f26f --- M src/common/pcu_sock.c 1 file changed, 10 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/64/32064/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32064 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ieba46cc7eee7758033815014ee38bf4751a0f26f Gerrit-Change-Number: 32064 Gerrit-PatchSet: 3 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-pcu[master]: PCU interface: Log version when starting listener
by arehbein 25 Mar '23

25 Mar '23

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/32066 to look at the new patch set (#2). Change subject: PCU interface: Log version when starting listener ...................................................................... PCU interface: Log version when starting listener Change-Id: Ic831ba20917293d8fa9b00ad276b31ad2ff77a64 --- M src/osmobts_sock.c 1 file changed, 10 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/66/32066/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32066 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ic831ba20917293d8fa9b00ad276b31ad2ff77a64 Gerrit-Change-Number: 32066 Gerrit-PatchSet: 2 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-bsc[master]: PCU interface: Log version when starting listener
by arehbein 25 Mar '23

25 Mar '23

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/32065 to look at the new patch set (#2). Change subject: PCU interface: Log version when starting listener ...................................................................... PCU interface: Log version when starting listener Change-Id: Ie3d8ebcb3175412313dfae3b7d560202a98ff8ab --- M src/osmo-bsc/pcu_sock.c 1 file changed, 11 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/65/32065/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32065 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie3d8ebcb3175412313dfae3b7d560202a98ff8ab Gerrit-Change-Number: 32065 Gerrit-PatchSet: 2 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-pcu[master]: PCU interface: Log version when starting listener
by arehbein 25 Mar '23

25 Mar '23

arehbein has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/32066 ) Change subject: PCU interface: Log version when starting listener ...................................................................... PCU interface: Log version when starting listener Since the PCU interface version is determined by including a define statement, it depends on the include configuration. This will make it easier to immediately see what version is run. Change-Id: Ic831ba20917293d8fa9b00ad276b31ad2ff77a64 --- M src/osmobts_sock.c 1 file changed, 12 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/66/32066/1 diff --git a/src/osmobts_sock.c b/src/osmobts_sock.c index 6d46a84..bf1fbb4 100644 --- a/src/osmobts_sock.c +++ b/src/osmobts_sock.c @@ -216,7 +216,7 @@ int pcu_l1if_open(void) { int rc; - LOGP(DL1IF, LOGL_INFO, "Opening OsmoPCU L1 interface to OsmoBTS\n"); + LOGP(DL1IF, LOGL_INFO, "Opening OsmoPCU L1 interface v%u to OsmoBTS\n", PCU_IF_VERSION); memset(&pcu_sock_state, 0x00, sizeof(pcu_sock_state)); INIT_LLIST_HEAD(&pcu_sock_state.upqueue); -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32066 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ic831ba20917293d8fa9b00ad276b31ad2ff77a64 Gerrit-Change-Number: 32066 Gerrit-PatchSet: 1 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-bts[master]: PCU interface: Log version when starting listener
by arehbein 25 Mar '23

25 Mar '23

arehbein has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-bts/+/32064 ) Change subject: PCU interface: Log version when starting listener ...................................................................... PCU interface: Log version when starting listener Since the PCU interface version is determined by including a define statement, it depends on the include configuration. This will make it easier to immediately see what version is run. Change-Id: Ieba46cc7eee7758033815014ee38bf4751a0f26f --- M src/common/pcu_sock.c 1 file changed, 12 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/64/32064/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32064 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ieba46cc7eee7758033815014ee38bf4751a0f26f Gerrit-Change-Number: 32064 Gerrit-PatchSet: 2 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-bsc[master]: PCU interface: Log version when starting listener
by arehbein 25 Mar '23

25 Mar '23

arehbein has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/32065 ) Change subject: PCU interface: Log version when starting listener ...................................................................... PCU interface: Log version when starting listener Since the PCU interface version is determined by including a define statement, it depends on the include configuration. This will make it easier to immediately see what version is run. Change-Id: Ie3d8ebcb3175412313dfae3b7d560202a98ff8ab --- M src/osmo-bsc/pcu_sock.c 1 file changed, 13 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/65/32065/1 diff --git a/src/osmo-bsc/pcu_sock.c b/src/osmo-bsc/pcu_sock.c index dba502f..0988c3b 100644 --- a/src/osmo-bsc/pcu_sock.c +++ b/src/osmo-bsc/pcu_sock.c @@ -1003,7 +1003,8 @@ return rc; } - LOGP(DPCU, LOGL_INFO, "Started listening on PCU socket: %s\n", net->pcu_sock_path); + LOGP(DPCU, LOGL_INFO, "Started listening on PCU socket (PCU IF v%u): %s\n", + PCU_IF_VERSION, net->pcu_sock_path); net->pcu_state = state; return 0; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32065 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie3d8ebcb3175412313dfae3b7d560202a98ff8ab Gerrit-Change-Number: 32065 Gerrit-PatchSet: 1 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-bts[master]: PCU interface: Log version when starting listener
by arehbein 25 Mar '23

25 Mar '23

arehbein has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/32064 ) Change subject: PCU interface: Log version when starting listener ...................................................................... PCU interface: Log version when starting listener Since the PCU interface version is determined by including a define statement, the PCU version depends on the include configuration. This will make it easier to immediately see what version is run. Change-Id: Ieba46cc7eee7758033815014ee38bf4751a0f26f --- M src/common/pcu_sock.c 1 file changed, 12 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/64/32064/1 diff --git a/src/common/pcu_sock.c b/src/common/pcu_sock.c index 5e4b06b..018e3c7 100644 --- a/src/common/pcu_sock.c +++ b/src/common/pcu_sock.c @@ -1213,7 +1213,7 @@ bts_gsmnet.pcu_state = state; - LOGP(DPCU, LOGL_INFO, "Started listening on PCU socket: %s\n", path); + LOGP(DPCU, LOGL_INFO, "Started listening on PCU socket (PCU IF v%u): %s\n", PCU_IF_VERSION, path); return 0; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32064 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ieba46cc7eee7758033815014ee38bf4751a0f26f Gerrit-Change-Number: 32064 Gerrit-PatchSet: 1 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-MessageType: newchange

1 0