neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/32067 )
Change subject: RAB Assignment: add more SDUs for more AMR modes
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
still need to verify that these changes work.
So far only tested with nano3G, which seems stubbornly fixated on 12k2 AMR only.
--
To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/32067
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-Change-Id: I61e0e9e75e3239662846fd797532acdefa9f73dc
Gerrit-Change-Number: 32067
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Sat, 25 Mar 2023 23:20:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-bts/+/32064
to look at the new patch set (#3).
Change subject: PCU interface: Log version when starting listener
......................................................................
PCU interface: Log version when starting listener
Change-Id: Ieba46cc7eee7758033815014ee38bf4751a0f26f
---
M src/common/pcu_sock.c
1 file changed, 10 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/64/32064/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32064
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ieba46cc7eee7758033815014ee38bf4751a0f26f
Gerrit-Change-Number: 32064
Gerrit-PatchSet: 3
Gerrit-Owner: arehbein <arehbein(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-MessageType: newpatchset
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-pcu/+/32066
to look at the new patch set (#2).
Change subject: PCU interface: Log version when starting listener
......................................................................
PCU interface: Log version when starting listener
Change-Id: Ic831ba20917293d8fa9b00ad276b31ad2ff77a64
---
M src/osmobts_sock.c
1 file changed, 10 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/66/32066/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32066
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ic831ba20917293d8fa9b00ad276b31ad2ff77a64
Gerrit-Change-Number: 32066
Gerrit-PatchSet: 2
Gerrit-Owner: arehbein <arehbein(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-MessageType: newpatchset
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-bsc/+/32065
to look at the new patch set (#2).
Change subject: PCU interface: Log version when starting listener
......................................................................
PCU interface: Log version when starting listener
Change-Id: Ie3d8ebcb3175412313dfae3b7d560202a98ff8ab
---
M src/osmo-bsc/pcu_sock.c
1 file changed, 11 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/65/32065/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32065
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ie3d8ebcb3175412313dfae3b7d560202a98ff8ab
Gerrit-Change-Number: 32065
Gerrit-PatchSet: 2
Gerrit-Owner: arehbein <arehbein(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-MessageType: newpatchset
arehbein has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/32066 )
Change subject: PCU interface: Log version when starting listener
......................................................................
PCU interface: Log version when starting listener
Since the PCU interface version is determined by including a define statement, it depends on the include configuration. This will make it easier to immediately see what version is run.
Change-Id: Ic831ba20917293d8fa9b00ad276b31ad2ff77a64
---
M src/osmobts_sock.c
1 file changed, 12 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/66/32066/1
diff --git a/src/osmobts_sock.c b/src/osmobts_sock.c
index 6d46a84..bf1fbb4 100644
--- a/src/osmobts_sock.c
+++ b/src/osmobts_sock.c
@@ -216,7 +216,7 @@
int pcu_l1if_open(void)
{
int rc;
- LOGP(DL1IF, LOGL_INFO, "Opening OsmoPCU L1 interface to OsmoBTS\n");
+ LOGP(DL1IF, LOGL_INFO, "Opening OsmoPCU L1 interface v%u to OsmoBTS\n", PCU_IF_VERSION);
memset(&pcu_sock_state, 0x00, sizeof(pcu_sock_state));
INIT_LLIST_HEAD(&pcu_sock_state.upqueue);
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32066
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ic831ba20917293d8fa9b00ad276b31ad2ff77a64
Gerrit-Change-Number: 32066
Gerrit-PatchSet: 1
Gerrit-Owner: arehbein <arehbein(a)sysmocom.de>
Gerrit-MessageType: newchange
arehbein has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-bts/+/32064 )
Change subject: PCU interface: Log version when starting listener
......................................................................
PCU interface: Log version when starting listener
Since the PCU interface version is determined by including a define statement, it depends on the include configuration. This will make it easier to immediately see what version is run.
Change-Id: Ieba46cc7eee7758033815014ee38bf4751a0f26f
---
M src/common/pcu_sock.c
1 file changed, 12 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/64/32064/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32064
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ieba46cc7eee7758033815014ee38bf4751a0f26f
Gerrit-Change-Number: 32064
Gerrit-PatchSet: 2
Gerrit-Owner: arehbein <arehbein(a)sysmocom.de>
Gerrit-CC: Jenkins Builder
Gerrit-MessageType: newpatchset
arehbein has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/32065 )
Change subject: PCU interface: Log version when starting listener
......................................................................
PCU interface: Log version when starting listener
Since the PCU interface version is determined by including a define statement, it depends on the include configuration. This will make it easier to immediately see what version is run.
Change-Id: Ie3d8ebcb3175412313dfae3b7d560202a98ff8ab
---
M src/osmo-bsc/pcu_sock.c
1 file changed, 13 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/65/32065/1
diff --git a/src/osmo-bsc/pcu_sock.c b/src/osmo-bsc/pcu_sock.c
index dba502f..0988c3b 100644
--- a/src/osmo-bsc/pcu_sock.c
+++ b/src/osmo-bsc/pcu_sock.c
@@ -1003,7 +1003,8 @@
return rc;
}
- LOGP(DPCU, LOGL_INFO, "Started listening on PCU socket: %s\n", net->pcu_sock_path);
+ LOGP(DPCU, LOGL_INFO, "Started listening on PCU socket (PCU IF v%u): %s\n",
+ PCU_IF_VERSION, net->pcu_sock_path);
net->pcu_state = state;
return 0;
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32065
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ie3d8ebcb3175412313dfae3b7d560202a98ff8ab
Gerrit-Change-Number: 32065
Gerrit-PatchSet: 1
Gerrit-Owner: arehbein <arehbein(a)sysmocom.de>
Gerrit-MessageType: newchange
arehbein has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/32064 )
Change subject: PCU interface: Log version when starting listener
......................................................................
PCU interface: Log version when starting listener
Since the PCU interface version is determined by including a define statement, the PCU version depends on the include configuration. This will make it easier to immediately see what version is run.
Change-Id: Ieba46cc7eee7758033815014ee38bf4751a0f26f
---
M src/common/pcu_sock.c
1 file changed, 12 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/64/32064/1
diff --git a/src/common/pcu_sock.c b/src/common/pcu_sock.c
index 5e4b06b..018e3c7 100644
--- a/src/common/pcu_sock.c
+++ b/src/common/pcu_sock.c
@@ -1213,7 +1213,7 @@
bts_gsmnet.pcu_state = state;
- LOGP(DPCU, LOGL_INFO, "Started listening on PCU socket: %s\n", path);
+ LOGP(DPCU, LOGL_INFO, "Started listening on PCU socket (PCU IF v%u): %s\n", PCU_IF_VERSION, path);
return 0;
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32064
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ieba46cc7eee7758033815014ee38bf4751a0f26f
Gerrit-Change-Number: 32064
Gerrit-PatchSet: 1
Gerrit-Owner: arehbein <arehbein(a)sysmocom.de>
Gerrit-MessageType: newchange