Attention is currently required from: laforge.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-bts/+/32093
to look at the new patch set (#2).
Change subject: Replace explicit gsm_lchan_name() calls with LOGPLCHAN
......................................................................
Replace explicit gsm_lchan_name() calls with LOGPLCHAN
There was a surprising number of explicit gsm_lchan_name() calls
from within log message code. Let's avoid that whenever possible and
use a LOGPLCHAN() or related macro.
Change-Id: If4f4f555f5ca61dfa624b298805f5375efc0b137
---
M src/common/l1sap.c
M src/common/measurement.c
M src/common/rsl.c
M src/osmo-bts-lc15/oml.c
M src/osmo-bts-oc2g/oml.c
M src/osmo-bts-octphy/l1_tch.c
M src/osmo-bts-sysmo/oml.c
M src/osmo-bts-virtual/l1_if.c
8 files changed, 162 insertions(+), 273 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/93/32093/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32093
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: If4f4f555f5ca61dfa624b298805f5375efc0b137
Gerrit-Change-Number: 32093
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: newpatchset
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/32105 )
Change subject: lc15: fix compiler warning about unused variable cell_size
......................................................................
lc15: fix compiler warning about unused variable cell_size
oml.c: In function ‘bts_model_apply_oml’:
oml.c:1814:17: error: variable ‘cell_size’ set but not used [-Werror=unused-but-set-variable]
1814 | uint8_t cell_size;
| ^~~~~~~~~
Change-Id: I0bf1542f613f613d03609d50836137ff440401af
---
M src/osmo-bts-lc15/oml.c
1 file changed, 16 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/05/32105/1
diff --git a/src/osmo-bts-lc15/oml.c b/src/osmo-bts-lc15/oml.c
index fa8aa9b..221e075 100644
--- a/src/osmo-bts-lc15/oml.c
+++ b/src/osmo-bts-lc15/oml.c
@@ -1811,7 +1811,6 @@
int rc;
struct gsm_bts_trx *trx;
struct lc15l1_hdl *fl1h;
- uint8_t cell_size;
/* TODO: NM Object without FSM: */
switch (foh->obj_class) {
@@ -1825,10 +1824,10 @@
case NM_MT_SET_RADIO_ATTR:
trx = obj;
fl1h = trx_lc15l1_hdl(trx);
- /* convert max TA to max cell size in qbits */
- cell_size = bts->max_ta << 2;
#if LITECELL15_API_VERSION >= LITECELL15_API(2,1,7)
+ /* convert max TA to max cell size in qbits */
+ uint8_t cell_size = bts->max_ta << 2;
/* We do not need to check for L1 handle
* because the max cell size parameter can receive before MphInit */
if (fl1h->phy_inst->u.lc15.max_cell_size != cell_size) {
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32105
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I0bf1542f613f613d03609d50836137ff440401af
Gerrit-Change-Number: 32105
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: newchange
Attention is currently required from: matanp.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/gapk/+/32094
to look at the new patch set (#3).
Change subject: fmt_rtp_amr,fmt_rtp_efr: replace damaged packets with silence
......................................................................
fmt_rtp_amr,fmt_rtp_efr: replace damaged packets with silence
Change-Id: I7245aa0bc0955cc8b94d5401a15e694f50498093
---
M src/fmt_rtp_amr.c
M src/fmt_rtp_efr.c
2 files changed, 32 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/gapk refs/changes/94/32094/3
--
To view, visit https://gerrit.osmocom.org/c/gapk/+/32094
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: gapk
Gerrit-Branch: master
Gerrit-Change-Id: I7245aa0bc0955cc8b94d5401a15e694f50498093
Gerrit-Change-Number: 32094
Gerrit-PatchSet: 3
Gerrit-Owner: matanp <matan1008(a)gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: matanp <matan1008(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: laforge, fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32087 )
Change subject: Introduce LOGPLCFN() for logging lchan-name + frame number
......................................................................
Patch Set 3:
(1 comment)
File src/common/measurement.c:
https://gerrit.osmocom.org/c/osmo-bts/+/32087/comment/b588dc62_9b10c032
PS3, Line 76: LOGPLCFN(lchan, DMEAS, LOGL_ERROR, fn, "Unsupported lchan->tch_mode %u\n",
> exactly, I've just used the conventions of the pre-exisging LOGPLCHAN() macro and the LOGPFN macro. […]
Yeah, that makes sense each alone, but joining them and ending up with one fmt var before logging related params and one afterwards really feels like the wrong decision ;)
Not going to block though, feel free to merge or fix later.
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32087
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I214af0448652a9f321ccbab77977b67663ba28f9
Gerrit-Change-Number: 32087
Gerrit-PatchSet: 3
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 28 Mar 2023 13:17:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment