March 2023 - gerrit-log - lists.osmocom.org

[M] Change in osmo-bts[master]: speech TCH, all models: implement option of Themyscira BFI packets
by falconia 28 Mar '23

28 Mar '23

Attention is currently required from: falconia. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/32099 to look at the new patch set (#2). Change subject: speech TCH, all models: implement option of Themyscira BFI packets ...................................................................... speech TCH, all models: implement option of Themyscira BFI packets Themyscira Wireless System Software is an external add-on to Osmocom CNI that provides interconnection between an Osmocom GSM network and regular national public telephone networks, developed initially for USA PSTN. Voice plane interconnection to PSTN is achieved by way of G.711 RTP streams, and these public-interfacing RTP streams are required to be fully continuous, emitting 160 PCM samples every 20 ms no matter what is happening on the GSM side. The transcoding boundary MGW component of ThemWi is responsible for comfort noise generation during GSM DTXu pauses and error concealment any time GSM UL traffic frames are lost for any other reason - but it requires a bit of assistance from the IP BTS that is the ultimate origin of the outgoing RTP stream: when FR or EFR codec is used, ThemWi transcoding MGW expects the IP BTS to emit special Themyscira-invented BFI packets any time a BFI condition occurs. These Themyscira BFI packets also carry a TAF bit exactly like the one in GSM 08.60 TRAU UL frames. The present change extends the rtp always-output vty option added just previously: the new option becomes rtp always-output [themyscira-bfi], and if the last qualifier is included, the special Themyscira extension mode is enabled. In this mode, which only affects FR and EFR codecs, RTP packets emitted when there is no speech or SID frame to be sent change from zero-length RTP payload to Themyscira BFI marker format, including TAF. Related: OS#5975 Change-Id: Ib935efb1f7c9c8d919a4a0ea2bef244a47e5fb24 --- M include/osmo-bts/bts.h M src/common/l1sap.c M src/common/vty.c M src/osmo-bts-trx/l1_if.c M src/osmo-bts-trx/sched_lchan_tchf.c M tests/osmo-bts.vty 6 files changed, 96 insertions(+), 16 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/99/32099/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32099 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ib935efb1f7c9c8d919a4a0ea2bef244a47e5fb24 Gerrit-Change-Number: 32099 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-MessageType: newpatchset

1 0

[M] Change in libosmocore[master]: logging vty: add 'logging print timestamp', deprecate other timestamp...
by pespin 28 Mar '23

28 Mar '23

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/5861 ) Change subject: logging vty: add 'logging print timestamp', deprecate other timestamp cmds ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/5861 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I58c792dda3cbcf8618648ba4429c27fa398a9e15 Gerrit-Change-Number: 5861 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Mar 2023 09:21:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in libosmocore[master]: logging: add 'logging timezone (localtime|utc)'
by pespin 28 Mar '23

28 Mar '23

Attention is currently required from: neels, laforge, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32043 ) Change subject: logging: add 'logging timezone (localtime|utc)' ...................................................................... Patch Set 2: Code-Review-1 (2 comments) Patchset: PS2: Marking with -1 since I'm not the only one thinking set_timezone() should fail if not supported by the system. File src/core/logging.c: https://gerrit.osmocom.org/c/libosmocore/+/32043/comment/b9c67540_4a046f59 PS1, Line 874: target->timezone = timezone; > i don't agree. i would not want to duplicate some enum validation code here. […] How does the caller (the user) know if it is setting a timezone which is not supported by his system? Does he need to go check cryptic support documentation in Narnia? This *is* the place where the user should get to know that it is trying to set a value which is not going to work properly on the current system. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32043 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I7f868b47bf8f8dfcf85e735f490ae69b18111af4 Gerrit-Change-Number: 32043 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Mar 2023 09:15:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[M] Change in osmo-bts[master]: Introduce LOGPLCFN() for logging lchan-name + frame number
by fixeria 28 Mar '23

28 Mar '23

Attention is currently required from: laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32087 ) Change subject: Introduce LOGPLCFN() for logging lchan-name + frame number ...................................................................... Patch Set 3: (1 comment) File src/common/measurement.c: https://gerrit.osmocom.org/c/osmo-bts/+/32087/comment/42041e70_1bba5633 PS3, Line 76: LOGPLCFN(lchan, DMEAS, LOGL_ERROR, fn, "Unsupported lchan->tch_mode %u\n", > This is totally weird. You are passing lchan before DMEAS and LOGL_ERROR, but "fn" afterwards. […] I would not say "totally"... The current approach is consistent with both LOGPLCHAN and LOGPFN macros: the former accepts lchan as the first argument, the later accepts fn after the logging level. Personally I don't really care, as long as it's more or less consistent. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32087 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I214af0448652a9f321ccbab77977b67663ba28f9 Gerrit-Change-Number: 32087 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Mar 2023 09:09:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-bts[master]: common/vty: Print AMR MultiRate Configuration in "show lchan"
by pespin 28 Mar '23

28 Mar '23

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32091 ) Change subject: common/vty: Print AMR MultiRate Configuration in "show lchan" ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32091 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I630af8c3835c2fcbea325c07db269d25e4e18f62 Gerrit-Change-Number: 32091 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 28 Mar 2023 09:05:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-bts[master]: bts-{sysmo,oc2g,lc15}: Fix RTP of AMR SID_FIRST_P1
by pespin 28 Mar '23

28 Mar '23

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32088 ) Change subject: bts-{sysmo,oc2g,lc15}: Fix RTP of AMR SID_FIRST_P1 ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32088 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I90479efcc002d497648a71e73847af54e6208358 Gerrit-Change-Number: 32088 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 28 Mar 2023 09:05:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-bts[master]: Introduce LOGPLCFN() for logging lchan-name + frame number
by pespin 28 Mar '23

28 Mar '23

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32087 ) Change subject: Introduce LOGPLCFN() for logging lchan-name + frame number ...................................................................... Patch Set 3: (1 comment) File src/common/measurement.c: https://gerrit.osmocom.org/c/osmo-bts/+/32087/comment/7e1c797f_f69097e3 PS3, Line 76: LOGPLCFN(lchan, DMEAS, LOGL_ERROR, fn, "Unsupported lchan->tch_mode %u\n", This is totally weird. You are passing lchan before DMEAS and LOGL_ERROR, but "fn" afterwards. Please put both paramters at the same place. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32087 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I214af0448652a9f321ccbab77977b67663ba28f9 Gerrit-Change-Number: 32087 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 28 Mar 2023 09:02:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in osmo-bts[master]: DTX: bts-{sysmo,oc2g,lc15}: Print DEBUG messages about ONSET
by pespin 28 Mar '23

28 Mar '23

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32086 ) Change subject: DTX: bts-{sysmo,oc2g,lc15}: Print DEBUG messages about ONSET ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32086 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I9a1511d9929444cef96388492d907e8f3a082311 Gerrit-Change-Number: 32086 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 28 Mar 2023 09:01:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmocom-bb[master]: layer23: modem: Forward GMMRR primitives between GMM and RLCMAC layers
by pespin 28 Mar '23

28 Mar '23

Attention is currently required from: pespin. Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/32080 to look at the new patch set (#4). Change subject: layer23: modem: Forward GMMRR primitives between GMM and RLCMAC layers ...................................................................... layer23: modem: Forward GMMRR primitives between GMM and RLCMAC layers Related: OS#5501 Change-Id: I7603d8bbda0cdd437eb7557267efb7bbc3552565 --- M src/host/layer23/src/modem/gmm.c M src/host/layer23/src/modem/rlcmac.c 2 files changed, 42 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/80/32080/4 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32080 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I7603d8bbda0cdd437eb7557267efb7bbc3552565 Gerrit-Change-Number: 32080 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmocom-bb[master]: layer23: modem: Forward GMMRR primitives between GMM and RLCMAC layers
by pespin 28 Mar '23

28 Mar '23

Attention is currently required from: pespin. Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/32080 to look at the new patch set (#3). Change subject: layer23: modem: Forward GMMRR primitives between GMM and RLCMAC layers ...................................................................... layer23: modem: Forward GMMRR primitives between GMM and RLCMAC layers Related: OS#5501 Change-Id: I7603d8bbda0cdd437eb7557267efb7bbc3552565 --- M src/host/layer23/src/modem/gmm.c M src/host/layer23/src/modem/rlcmac.c 2 files changed, 41 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/80/32080/3 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32080 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I7603d8bbda0cdd437eb7557267efb7bbc3552565 Gerrit-Change-Number: 32080 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0