March 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-bts[master]: trx: detect UL SID in EFR just like in FR
by laforge 28 Mar '23

28 Mar '23

Attention is currently required from: falconia, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32095 ) Change subject: trx: detect UL SID in EFR just like in FR ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: > Please add a line to TODO-RELEASE file saying that osmo-bts now requires libosmocore > 1.8. […] ACK, was exactly my thought, too. Apart from that: Thanks! -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32095 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ib043e00dbf92145c2a6c32f6365517244472a922 Gerrit-Change-Number: 32095 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Mar 2023 11:39:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[M] Change in osmo-ci[master]: Revert "jobs: tweak build-discarder values"
by laforge 28 Mar '23

28 Mar '23

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/32102 ) Change subject: Revert "jobs: tweak build-discarder values" ...................................................................... Revert "jobs: tweak build-discarder values" This reverts commit 719ff9760808acb1fe944f4c496c356c7dc07c91. The disk consumption of jenkins has grown by almost 500GB since we merged this patch. Clearly this is not expected, and we'd have ran out of disk space in a few weeks. I personally think the current allocation of 1.5TB of disk space to jenkins should be more than sufficient; we just need to manage it better. Closes: OS#5980 Change-Id: I6b744a8b84a3e1255a8d51f73d1721ccfd028ac1 --- M jobs/coverity.yml M jobs/gerrit-binpkgs.yml M jobs/gerrit-lint.yml M jobs/gerrit-pipeline-endianness.yml M jobs/gerrit-verifications-comment.yml M jobs/gerrit-verifications-dahdi.yml M jobs/gerrit-verifications.yml M jobs/master-builds-dahdi.yml M jobs/master-builds.yml M jobs/octsim_osmo-ccid-firmware.yml M jobs/ttcn3-testsuites-kernel-git.yml M jobs/ttcn3-testsuites.yml M jobs/update-osmo-ci-on-slaves.yml M jobs/update-osmo-python-on-slaves.yml 14 files changed, 60 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/02/32102/1 diff --git a/jobs/coverity.yml b/jobs/coverity.yml index 277bbf0..242d1aa 100644 --- a/jobs/coverity.yml +++ b/jobs/coverity.yml @@ -22,6 +22,7 @@ properties: - build-discarder: days-to-keep: 30 + num-to-keep: 30 parameters: - string: name: BRANCH diff --git a/jobs/gerrit-binpkgs.yml b/jobs/gerrit-binpkgs.yml index 49a2b48..247ebad 100644 --- a/jobs/gerrit-binpkgs.yml +++ b/jobs/gerrit-binpkgs.yml @@ -19,6 +19,9 @@ properties: - build-discarder: days-to-keep: 30 + num-to-keep: 120 + artifact-days-to-keep: -1 + artifact-num-to-keep: -1 description: | {type} package job of CI for patches sent to <a href="https://gerrit.osmocom.org">gerrit</a> diff --git a/jobs/gerrit-lint.yml b/jobs/gerrit-lint.yml index b0c9c06..7b537b9 100644 --- a/jobs/gerrit-lint.yml +++ b/jobs/gerrit-lint.yml @@ -16,6 +16,9 @@ properties: - build-discarder: days-to-keep: 30 + num-to-keep: 120 + artifact-days-to-keep: -1 + artifact-num-to-keep: -1 description: | Lint job of CI for patches sent to <a href="https://gerrit.osmocom.org">gerrit</a>. </br></br> diff --git a/jobs/gerrit-pipeline-endianness.yml b/jobs/gerrit-pipeline-endianness.yml index c9904f4..809cce6 100644 --- a/jobs/gerrit-pipeline-endianness.yml +++ b/jobs/gerrit-pipeline-endianness.yml @@ -15,6 +15,9 @@ properties: - build-discarder: days-to-keep: 30 + num-to-keep: 120 + artifact-days-to-keep: -1 + artifact-num-to-keep: -1 description: | Run <code>struct_endianness.py</code> from libosmocore.git on patches sent to <a href="https://gerrit.osmocom.org">gerrit</a>. diff --git a/jobs/gerrit-verifications-comment.yml b/jobs/gerrit-verifications-comment.yml index 046c986..f781bf8 100644 --- a/jobs/gerrit-verifications-comment.yml +++ b/jobs/gerrit-verifications-comment.yml @@ -15,6 +15,9 @@ properties: - build-discarder: days-to-keep: 30 + num-to-keep: 120 + artifact-days-to-keep: -1 + artifact-num-to-keep: -1 description: | Send start and result comments to <a href="https://gerrit.osmocom.org">gerrit</a>. </br></br> diff --git a/jobs/gerrit-verifications-dahdi.yml b/jobs/gerrit-verifications-dahdi.yml index 526dc78..d594378 100644 --- a/jobs/gerrit-verifications-dahdi.yml +++ b/jobs/gerrit-verifications-dahdi.yml @@ -16,6 +16,9 @@ properties: - build-discarder: days-to-keep: 30 + num-to-keep: 120 + artifact-days-to-keep: -1 + artifact-num-to-keep: -1 description: | Pending gerrit code reviews of <a href="https://gerrit.osmocom.org/#/q/status:open+project:dahdi-linux">dahdi-linux</a> diff --git a/jobs/gerrit-verifications.yml b/jobs/gerrit-verifications.yml index 9ab2d48..2bd9296 100644 --- a/jobs/gerrit-verifications.yml +++ b/jobs/gerrit-verifications.yml @@ -627,6 +627,9 @@ properties: - build-discarder: days-to-keep: 30 + num-to-keep: 120 + artifact-days-to-keep: -1 + artifact-num-to-keep: -1 description: | Pipeline of CI for patches sent to <a href="https://gerrit.osmocom.org/#/q/status:open+project:{repos}">{repos}</a> @@ -677,6 +680,9 @@ properties: - build-discarder: days-to-keep: 30 + num-to-keep: 120 + artifact-days-to-keep: -1 + artifact-num-to-keep: -1 description: | Build job of CI for patches sent to <a href="https://gerrit.osmocom.org/#/q/status:open+project:{repos}">{repos}</a> diff --git a/jobs/master-builds-dahdi.yml b/jobs/master-builds-dahdi.yml index 068c92d..b152805 100644 --- a/jobs/master-builds-dahdi.yml +++ b/jobs/master-builds-dahdi.yml @@ -16,6 +16,9 @@ properties: - build-discarder: days-to-keep: 30 + num-to-keep: 120 + artifact-days-to-keep: -1 + artifact-num-to-keep: -1 description: | Automatic jenkins test job of <a href="https://gerrit.osmocom.org/#/q/status:open+project:dahdi-linux">dahdi-linux</a> diff --git a/jobs/master-builds.yml b/jobs/master-builds.yml index 23e5219..724628d 100644 --- a/jobs/master-builds.yml +++ b/jobs/master-builds.yml @@ -517,6 +517,9 @@ properties: - build-discarder: days-to-keep: 30 + num-to-keep: 120 + artifact-days-to-keep: -1 + artifact-num-to-keep: -1 description: | Automatic jenkins test job of <a href="{git_base_url}/{repos}">{repos}</a> diff --git a/jobs/octsim_osmo-ccid-firmware.yml b/jobs/octsim_osmo-ccid-firmware.yml index efabe57..17e3cef 100644 --- a/jobs/octsim_osmo-ccid-firmware.yml +++ b/jobs/octsim_osmo-ccid-firmware.yml @@ -35,7 +35,10 @@ queue-scanning: DISABLED use-build-blocker: false - build-discarder: + artifact-days-to-keep: -1 + artifact-num-to-keep: -1 days-to-keep: 30 + num-to-keep: 120 - rebuild: auto-rebuild: false rebuild-disabled: false diff --git a/jobs/ttcn3-testsuites-kernel-git.yml b/jobs/ttcn3-testsuites-kernel-git.yml index ce7dd26..fbed5ea 100644 --- a/jobs/ttcn3-testsuites-kernel-git.yml +++ b/jobs/ttcn3-testsuites-kernel-git.yml @@ -116,6 +116,9 @@ properties: - build-discarder: days-to-keep: 30 + num-to-keep: 120 + artifact-days-to-keep: -1 + artifact-num-to-keep: -1 wrappers: - ansicolor: colormap: xterm diff --git a/jobs/ttcn3-testsuites.yml b/jobs/ttcn3-testsuites.yml index 9500662..cac271f 100644 --- a/jobs/ttcn3-testsuites.yml +++ b/jobs/ttcn3-testsuites.yml @@ -384,7 +384,10 @@ only-if-success: false properties: - build-discarder: - days-to-keep: 120 + days-to-keep: 30 + num-to-keep: 120 + artifact-days-to-keep: -1 + artifact-num-to-keep: -1 wrappers: - ansicolor: colormap: xterm diff --git a/jobs/update-osmo-ci-on-slaves.yml b/jobs/update-osmo-ci-on-slaves.yml index 749f5b1..8ab1e12 100644 --- a/jobs/update-osmo-ci-on-slaves.yml +++ b/jobs/update-osmo-ci-on-slaves.yml @@ -18,6 +18,7 @@ properties: - build-discarder: days-to-keep: 30 + num-to-keep: 120 scm: - git: url: https://gerrit.osmocom.org/osmo-ci diff --git a/jobs/update-osmo-python-on-slaves.yml b/jobs/update-osmo-python-on-slaves.yml index 8efb141..4a2afbc 100644 --- a/jobs/update-osmo-python-on-slaves.yml +++ b/jobs/update-osmo-python-on-slaves.yml @@ -15,6 +15,7 @@ properties: - build-discarder: days-to-keep: 30 + num-to-keep: 120 scm: - git: url: https://gerrit.osmocom.org/python/osmo-python-tests -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/32102 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I6b744a8b84a3e1255a8d51f73d1721ccfd028ac1 Gerrit-Change-Number: 32102 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 0

[M] Change in osmo-mgw[master]: mgcp_codec: refactor payload type converstion
by dexter 28 Mar '23

28 Mar '23

Attention is currently required from: pespin. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/32083 ) Change subject: mgcp_codec: refactor payload type converstion ...................................................................... Patch Set 2: (1 comment) File src/libosmo-mgcp/mgcp_network.c: https://gerrit.osmocom.org/c/osmo-mgw/+/32083/comment/99594051_22fd554f PS2, Line 516: codec_dst = mgcp_codec_find_convertible(conn_dst, codec_src); > The function mgcp_codec_find_convertible always prefers codecs that are the same. […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/32083 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I085260a2ca8cfecdb58656b7a046c536189e238d Gerrit-Change-Number: 32083 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Mar 2023 10:31:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in libosmo-gprs[master]: gmm: Several fixes to GMMSM prim alloc functions
by pespin 28 Mar '23

28 Mar '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/32101 ) Change subject: gmm: Several fixes to GMMSM prim alloc functions ...................................................................... gmm: Several fixes to GMMSM prim alloc functions Change-Id: Ie49cb448806101a24c58a85f7073e13baccada5b --- M src/gmm/gmm_prim.c 1 file changed, 16 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/01/32101/1 diff --git a/src/gmm/gmm_prim.c b/src/gmm/gmm_prim.c index 059c22a..c4de625 100644 --- a/src/gmm/gmm_prim.c +++ b/src/gmm/gmm_prim.c @@ -263,7 +263,7 @@ /*** GMMSM ***/ -static inline struct osmo_gprs_gmm_prim *gmm_prim_gmmsm_alloc(enum osmo_gprs_gmm_gmmrr_prim_type type, +static inline struct osmo_gprs_gmm_prim *gmm_prim_gmmsm_alloc(enum osmo_gprs_gmm_gmmsm_prim_type type, enum osmo_prim_operation operation, unsigned int extra_size) { @@ -274,7 +274,7 @@ struct osmo_gprs_gmm_prim *osmo_gprs_gmm_prim_alloc_gmmsm_establish_req(void) { struct osmo_gprs_gmm_prim *gmm_prim; - gmm_prim = gmm_prim_gmmrr_alloc(OSMO_GPRS_GMM_GMMSM_ESTABLISH, PRIM_OP_REQUEST, 0); + gmm_prim = gmm_prim_gmmsm_alloc(OSMO_GPRS_GMM_GMMSM_ESTABLISH, PRIM_OP_REQUEST, 0); return gmm_prim; } @@ -282,16 +282,16 @@ struct osmo_gprs_gmm_prim *gprs_gmm_prim_alloc_gmmsm_establish_cnf(uint8_t cause) { struct osmo_gprs_gmm_prim *gmm_prim; - gmm_prim = gmm_prim_gmmrr_alloc(OSMO_GPRS_GMM_GMMSM_ESTABLISH, PRIM_OP_CONFIRM, 0); + gmm_prim = gmm_prim_gmmsm_alloc(OSMO_GPRS_GMM_GMMSM_ESTABLISH, PRIM_OP_CONFIRM, 0); gmm_prim->gmmsm.establish_cnf.cause = cause; return gmm_prim; } /* 3GPP TS 24.007 9.5.1.4 GMMSM-RELEASE-IND:*/ -struct osmo_gprs_gmm_prim *gprs_gmm_prim_alloc_gmmrr_release_ind(void) +struct osmo_gprs_gmm_prim *gprs_gmm_prim_alloc_gmmsm_release_ind(void) { struct osmo_gprs_gmm_prim *gmm_prim; - gmm_prim = gmm_prim_gmmrr_alloc(OSMO_GPRS_GMM_GMMSM_RELEASE, PRIM_OP_INDICATION, 0); + gmm_prim = gmm_prim_gmmsm_alloc(OSMO_GPRS_GMM_GMMSM_RELEASE, PRIM_OP_INDICATION, 0); return gmm_prim; } @@ -299,7 +299,7 @@ struct osmo_gprs_gmm_prim *osmo_gprs_gmm_prim_alloc_gmmsm_unitdata_req(uint8_t *smpdu, unsigned int smpdu_len) { struct osmo_gprs_gmm_prim *gmm_prim; - gmm_prim = gmm_prim_gmmrr_alloc(OSMO_GPRS_GMM_GMMSM_UNITDATA, PRIM_OP_REQUEST, 0); + gmm_prim = gmm_prim_gmmsm_alloc(OSMO_GPRS_GMM_GMMSM_UNITDATA, PRIM_OP_REQUEST, smpdu_len); gmm_prim->gmmsm.unitdata_req.smpdu = smpdu; gmm_prim->gmmsm.unitdata_req.smpdu_len = smpdu_len; return gmm_prim; @@ -309,7 +309,7 @@ struct osmo_gprs_gmm_prim *gprs_gmm_prim_alloc_gmmsm_unitdata_ind(uint8_t *smpdu, unsigned int smpdu_len) { struct osmo_gprs_gmm_prim *gmm_prim; - gmm_prim = gmm_prim_gmmrr_alloc(OSMO_GPRS_GMM_GMMSM_UNITDATA, PRIM_OP_INDICATION, 0); + gmm_prim = gmm_prim_gmmsm_alloc(OSMO_GPRS_GMM_GMMSM_UNITDATA, PRIM_OP_INDICATION, smpdu_len); gmm_prim->gmmsm.unitdata_ind.smpdu = smpdu; gmm_prim->gmmsm.unitdata_ind.smpdu_len = smpdu_len; return gmm_prim; -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/32101 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Ie49cb448806101a24c58a85f7073e13baccada5b Gerrit-Change-Number: 32101 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[M] Change in osmo-bts[master]: common: implement rtp always-output mode
by pespin 28 Mar '23

28 Mar '23

Attention is currently required from: falconia. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32098 ) Change subject: common: implement rtp always-output mode ...................................................................... Patch Set 2: (3 comments) File src/common/l1sap.c: https://gerrit.osmocom.org/c/osmo-bts/+/32098/comment/d308483b_46cafad6 PS2, Line 1250: /* A zero-length payload is never valid, it is merely a BFI marker Can you explain a bit more this change in logic here? It's not explained in the commit description so it's not clear why you added this. https://gerrit.osmocom.org/c/osmo-bts/+/32098/comment/929c99d1_37b7f337 PS2, Line 1253: if (!resp_msg->len) == 0 would be clearer here, since len is an int and not a bool. File src/common/vty.c: https://gerrit.osmocom.org/c/osmo-bts/+/32098/comment/5ab42375_db8e1976 PS2, Line 425: vty_out(vty, " rtp always-output%s", VTY_NEWLINE); what about "rtp tx-lost" or "rtp tx-forged-lost" or similar? "always-output" is a bit difficult to understand its meaning. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32098 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ic0e2edf2ed90ba0ac6bee5e7d9629bf0255e256d Gerrit-Change-Number: 32098 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Tue, 28 Mar 2023 09:43:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in osmo-bts[master]: TCH-IND interface: move link quality check into model code
by pespin 28 Mar '23

28 Mar '23

Attention is currently required from: falconia. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32097 ) Change subject: TCH-IND interface: move link quality check into model code ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32097 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Id95e48a578b7a8ce576862655abbe553c5b9a7bf Gerrit-Change-Number: 32097 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Tue, 28 Mar 2023 09:37:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-bts[master]: sysmo: fix handling of SID in EFR
by pespin 28 Mar '23

28 Mar '23

Attention is currently required from: falconia. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32096 ) Change subject: sysmo: fix handling of SID in EFR ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32096 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ia56c1bb7432968685110456961d24a907b0a201f Gerrit-Change-Number: 32096 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Tue, 28 Mar 2023 09:34:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-bts[master]: trx: detect UL SID in EFR just like in FR
by pespin 28 Mar '23

28 Mar '23

Attention is currently required from: falconia. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32095 ) Change subject: trx: detect UL SID in EFR just like in FR ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: Please add a line to TODO-RELEASE file saying that osmo-bts now requires libosmocore > 1.8.0 due to use of osmo_efr_check_sid(). -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32095 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ib043e00dbf92145c2a6c32f6365517244472a922 Gerrit-Change-Number: 32095 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Tue, 28 Mar 2023 09:32:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in gapk[master]: fmt_rtp_amr,fmt_rtp_efr: replace damaged packets with silence
by pespin 28 Mar '23

28 Mar '23

Attention is currently required from: Matan Perelman. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/gapk/+/32094 ) Change subject: fmt_rtp_amr,fmt_rtp_efr: replace damaged packets with silence ...................................................................... Patch Set 2: (3 comments) File src/fmt_rtp_amr.c: https://gerrit.osmocom.org/c/gapk/+/32094/comment/f1a673de_3905b60e PS2, Line 30: static const uint8_t SILENCE[] = {0x80, 0x44, 0x00, 0x00, 0x00, 0x00, 0x00}; can you add a some comment with some spec reference as from where this hexstring comes from? File src/fmt_rtp_efr.c: https://gerrit.osmocom.org/c/gapk/+/32094/comment/109a4b78_82da5107 PS2, Line 33: static const uint8_t DAMAGED_PACKET[EFR_LEN] = { Same here. https://gerrit.osmocom.org/c/gapk/+/32094/comment/b54e7661_c990f8c3 PS2, Line 70: if (!memcmp(DAMAGED_PACKET, src, EFR_LEN)) is EFR_LEN garanteed to be == src_len here? -- To view, visit https://gerrit.osmocom.org/c/gapk/+/32094 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: gapk Gerrit-Branch: master Gerrit-Change-Id: I7245aa0bc0955cc8b94d5401a15e694f50498093 Gerrit-Change-Number: 32094 Gerrit-PatchSet: 2 Gerrit-Owner: Matan Perelman <matan1008(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Matan Perelman <matan1008(a)gmail.com> Gerrit-Comment-Date: Tue, 28 Mar 2023 09:30:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in osmo-bts[master]: common: implement rtp always-output mode
by falconia 28 Mar '23

28 Mar '23

Attention is currently required from: falconia. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/32098 to look at the new patch set (#2). Change subject: common: implement rtp always-output mode ...................................................................... common: implement rtp always-output mode In some environments it is highly desirable for the RTP stream coming from each GSM call UL on a BTS to be fully continuous, without any gaps, with _some_ RTP packet emitted every 20 ms, even if there is no speech or SID frame to be sent in that frame time window. The present change adds an rtp always-output vty option which, when enabled, causes the BTS to emit RTP packets with a zero-length payload, instead of producing gaps in the RTP stream, when it has nothing else to send. Related: OS#5975 Change-Id: Ic0e2edf2ed90ba0ac6bee5e7d9629bf0255e256d --- M include/osmo-bts/bts.h M src/common/l1sap.c M src/common/vty.c M tests/osmo-bts.vty 4 files changed, 59 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/98/32098/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32098 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ic0e2edf2ed90ba0ac6bee5e7d9629bf0255e256d Gerrit-Change-Number: 32098 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-MessageType: newpatchset

1 0