March 2023 - gerrit-log - lists.osmocom.org

[M] Change in osmo-bts[master]: common+trx: add rtp ecu-downstream vty option
by falconia 28 Mar '23

28 Mar '23

falconia has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/32110 ) Change subject: common+trx: add rtp ecu-downstream vty option ...................................................................... common+trx: add rtp ecu-downstream vty option Current osmo-bts-trx includes a provision for invoking ECUs from libosmocodec in the UL path from the channel decoder to the RTP output; no other models currently do likewise, but there is no particular reason why this ECU invokation couldn't be moved into model-independent code. However, there are some network configurations in which this in-BTS ECU invokation is undesirable, and the desire is to disable or suppress it no matter which BTS model is used, rather than extend the feature to BTS models which currently don't support it. Usually the reason for wishing to suppress the ECU currently provided by osmo-bts-trx is that another network element somewhere downstream in RTP implements either a better ECU than what libosmocore provides or a more complete Rx DTX handler of which the ECU is just one part. The new rtp ecu-downstream vty option disables libosmocodec ECU invokation in OsmoBTS. The intended usage model is that this option will be used together with rtp continuous-streaming, but in the strict sense the two options are orthogonal. Related: OS#5975 Change-Id: I0acca9c6d7da966a623287563e0789db9e0fae8e --- M include/osmo-bts/bts.h M src/common/vty.c M src/osmo-bts-trx/l1_if.c M tests/osmo-bts.vty 4 files changed, 70 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/10/32110/1 diff --git a/include/osmo-bts/bts.h b/include/osmo-bts/bts.h index 56bf289..add2825 100644 --- a/include/osmo-bts/bts.h +++ b/include/osmo-bts/bts.h @@ -316,6 +316,7 @@ bool rtp_nogaps_mode; /* emit RTP stream without any gaps */ bool rtp_themyscira_ext; /* Themyscira extension for FR/EFR BFI */ + bool rtp_ecu_downstream; /* ECU present downstream, don't apply our own */ struct { uint8_t ciphers; /* flags A5/1==0x1, A5/2==0x2, A5/3==0x4 */ diff --git a/src/common/vty.c b/src/common/vty.c index 8a51170..bf25727 100644 --- a/src/common/vty.c +++ b/src/common/vty.c @@ -428,6 +428,8 @@ vty_out(vty, " themyscira-bfi"); vty_out(vty, "%s", VTY_NEWLINE); } + if (bts->rtp_ecu_downstream) + vty_out(vty, " rtp ecu-downstream%s", VTY_NEWLINE); vty_out(vty, " paging queue-size %u%s", paging_get_queue_max(bts->paging_state), VTY_NEWLINE); vty_out(vty, " paging lifetime %u%s", paging_get_lifetime(bts->paging_state), @@ -815,6 +817,28 @@ return CMD_SUCCESS; } +DEFUN(cfg_bts_rtp_ecu_downstream, + cfg_bts_rtp_ecu_downstream_cmd, + "rtp ecu-downstream", + RTP_STR "Rely on a downstream ECU instead of providing one in the BTS\n") +{ + struct gsm_bts *bts = vty->index; + + bts->rtp_ecu_downstream = true; + return CMD_SUCCESS; +} + +DEFUN(cfg_bts_no_rtp_ecu_downstream, + cfg_bts_no_rtp_ecu_downstream_cmd, + "no rtp ecu-downstream", + NO_STR RTP_STR "Rely on a downstream ECU instead of providing one in the BTS\n") +{ + struct gsm_bts *bts = vty->index; + + bts->rtp_ecu_downstream = false; + return CMD_SUCCESS; +} + #define PAG_STR "Paging related parameters\n" DEFUN_ATTR(cfg_bts_paging_queue_size, @@ -2717,6 +2741,8 @@ install_element(BTS_NODE, &cfg_bts_rtp_priority_cmd); install_element(BTS_NODE, &cfg_bts_rtp_cont_stream_cmd); install_element(BTS_NODE, &cfg_bts_no_rtp_cont_stream_cmd); + install_element(BTS_NODE, &cfg_bts_rtp_ecu_downstream_cmd); + install_element(BTS_NODE, &cfg_bts_no_rtp_ecu_downstream_cmd); install_element(BTS_NODE, &cfg_bts_band_cmd); install_element(BTS_NODE, &cfg_description_cmd); install_element(BTS_NODE, &cfg_no_description_cmd); diff --git a/src/osmo-bts-trx/l1_if.c b/src/osmo-bts-trx/l1_if.c index 2ed1868..caba9e1 100644 --- a/src/osmo-bts-trx/l1_if.c +++ b/src/osmo-bts-trx/l1_if.c @@ -439,8 +439,13 @@ break; } - /* attempt to allocate an Error Concealment Unit instance, if available */ - lchan->ecu_state = osmo_ecu_init(trx, lchan2ecu_codec(lchan)); + /* Attempt to allocate an Error Concealment Unit + * instance, if available, unless it is disabled by the + * rtp ecu-downstream option in vty config. */ + if (!trx->bts->rtp_ecu_downstream) + lchan->ecu_state = osmo_ecu_init(trx, lchan2ecu_codec(lchan)); + else + lchan->ecu_state = NULL; /* activate dedicated channel */ trx_sched_set_lchan(lchan, chan_nr, LID_DEDIC, true); @@ -473,7 +478,10 @@ /* ECU for possibly new codec */ if (lchan->ecu_state) osmo_ecu_destroy(lchan->ecu_state); - lchan->ecu_state = osmo_ecu_init(trx, lchan2ecu_codec(lchan)); + if (!trx->bts->rtp_ecu_downstream) + lchan->ecu_state = osmo_ecu_init(trx, lchan2ecu_codec(lchan)); + else + lchan->ecu_state = NULL; /* change mode */ trx_sched_set_mode(lchan->ts, chan_nr, lchan->rsl_cmode, lchan->tch_mode, diff --git a/tests/osmo-bts.vty b/tests/osmo-bts.vty index 6613f41..450d6ad 100644 --- a/tests/osmo-bts.vty +++ b/tests/osmo-bts.vty @@ -235,6 +235,8 @@ rtp socket-priority <0-255> rtp continuous-streaming [themyscira-bfi] no rtp continuous-streaming + rtp ecu-downstream + no rtp ecu-downstream band (450|GSM450|480|GSM480|750|GSM750|810|GSM810|850|GSM850|900|GSM900|1800|DCS1800|1900|PCS1900) description .TEXT no description -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32110 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I0acca9c6d7da966a623287563e0789db9e0fae8e Gerrit-Change-Number: 32110 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-MessageType: newchange

1 0

[M] Change in osmo-bts[master]: common: implement rtp continuous-streaming mode
by falconia 28 Mar '23

28 Mar '23

Attention is currently required from: laforge, pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/32098 to look at the new patch set (#3). Change subject: common: implement rtp continuous-streaming mode ...................................................................... common: implement rtp continuous-streaming mode In some environments it is highly desirable for the RTP stream coming from each GSM call UL on a BTS to be fully continuous, without any gaps, with _some_ RTP packet emitted every 20 ms, even if there is no speech or SID frame to be sent in that frame time window. The present change adds an rtp continuous-streaming vty option which, when enabled, causes the BTS to emit RTP packets with a zero-length payload, instead of producing gaps in the RTP stream, when it has nothing else to send. Related: OS#5975 Change-Id: Ic0e2edf2ed90ba0ac6bee5e7d9629bf0255e256d --- M include/osmo-bts/bts.h M src/common/l1sap.c M src/common/vty.c M tests/osmo-bts.vty 4 files changed, 90 insertions(+), 16 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/98/32098/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32098 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ic0e2edf2ed90ba0ac6bee5e7d9629bf0255e256d Gerrit-Change-Number: 32098 Gerrit-PatchSet: 3 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[M] Change in osmo-bts[master]: rtp continuous-streaming: add themyscira-bfi option
by falconia 28 Mar '23

28 Mar '23

Attention is currently required from: falconia. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/32099 to look at the new patch set (#3). Change subject: rtp continuous-streaming: add themyscira-bfi option ...................................................................... rtp continuous-streaming: add themyscira-bfi option The just-added rtp continuous-streaming mode solves the principal problem of OS#5975, but there is still room for improvement, particularly in the case of FR and EFR codecs. The BFI packet format sent in our rtp continuous-streaming mode (without additional qualifiers) is zero-length RTP payload, which has the benefit of being universal, applicable to any codec type and any encoding variant. However, this most generic BFI packet format lacks the ability to represent the Time Alignment Flag (TAF) of GSM 06.31 and 06.81, traditionally carried in TRAU UL frames of GSM 08.60 in the classic GSM RAN architecture. There exist published-source implementations of FR and EFR decoders that implement Rx DTX handler functions exactly to the letter of GSM 06.31 and 06.81 specs, they take BFI and TAF flags as inputs along with received frame payloads, and they rely on the TAF bit being correct (reflecting the frame position relative to SACCH) when BFI=1. A need is thus created for an RTP transport mechanism for FR&EFR that includes BFI marker packets that contain this TAF bit. An ad hoc extension to the standard RTP transport format for FR&EFR that does exactly what has just been described has been implemented by Themyscira Wireless, a retronetworking intentional community (RNIC) that operates an Osmocom-based GSM network. The present change adds OsmoBTS support for this Themyscira RTP BFI extension, and it does so by extending the rtp continuous-streaming vty option added just previously; the new option becomes: rtp continuous-streaming [themyscira-bfi] If the last qualifier is included, the special Themyscira extension mode is enabled. In this mode, which only affects FR and EFR codecs, RTP packets emitted when there is no speech or SID frame to be sent change from zero-length RTP payload to Themyscira BFI marker format, including TAF. Related: OS#5975 Change-Id: Ib935efb1f7c9c8d919a4a0ea2bef244a47e5fb24 --- M include/osmo-bts/bts.h M src/common/l1sap.c M src/common/vty.c M src/osmo-bts-trx/sched_lchan_tchf.c M tests/osmo-bts.vty 5 files changed, 96 insertions(+), 13 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/99/32099/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32099 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ib935efb1f7c9c8d919a4a0ea2bef244a47e5fb24 Gerrit-Change-Number: 32099 Gerrit-PatchSet: 3 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-bts[master]: trx: detect UL SID in EFR just like in FR
by falconia 28 Mar '23

28 Mar '23

Attention is currently required from: laforge, pespin. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/32095 to look at the new patch set (#2). Change subject: trx: detect UL SID in EFR just like in FR ...................................................................... trx: detect UL SID in EFR just like in FR The TCH/F Rx code in osmo-bts-trx uses osmo_fr_check_sid() to detect when the MS sends SID, and passes the flag to lchan_set_marker(). However, equivalent logic was missing for EFR, as until recently there was no EFR SID check function in libosmocodec. Now that we have osmo_efr_check_sid(), use it. Change-Id: Ib043e00dbf92145c2a6c32f6365517244472a922 --- M TODO-RELEASE M src/osmo-bts-trx/sched_lchan_tchf.c 2 files changed, 18 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/95/32095/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32095 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ib043e00dbf92145c2a6c32f6365517244472a922 Gerrit-Change-Number: 32095 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[M] Change in osmo-bts[master]: sysmo: emit empty RTP ticks during FACCH stealing on TCH/F
by falconia 28 Mar '23

28 Mar '23

Attention is currently required from: laforge. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/32100 to look at the new patch set (#3). Change subject: sysmo: emit empty RTP ticks during FACCH stealing on TCH/F ...................................................................... sysmo: emit empty RTP ticks during FACCH stealing on TCH/F When FACCH stealing occurs and sysmoBTS L1 delivers GsmL1_Sapi_FacchF instead of GsmL1_Sapi_TchF, that 20 ms unit still needs to be accounted for in the RTP timestamp cadence, and if we run with rtp continuous-streaming enabled, then an actual BFI packet needs to be emitted. The original code failed to do either; the present change implements correct behavior for TCH/F. The present patch only covers the case of TCH/F; handling of TCH/H is left as a FIXME for other/later developers. Related: OS#5974 Change-Id: I39d15faade28fb7d670493a99a0e0bdb654e2a4a --- M src/osmo-bts-sysmo/l1_if.c M src/osmo-bts-sysmo/l1_if.h M src/osmo-bts-sysmo/tch.c 3 files changed, 64 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/00/32100/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32100 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I39d15faade28fb7d670493a99a0e0bdb654e2a4a Gerrit-Change-Number: 32100 Gerrit-PatchSet: 3 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

1 0

[M] Change in osmo-bts[master]: sysmo: emit empty RTP ticks during FACCH stealing on TCH/F
by falconia 28 Mar '23

28 Mar '23

Attention is currently required from: laforge. falconia has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32100 ) Change subject: sysmo: emit empty RTP ticks during FACCH stealing on TCH/F ...................................................................... Patch Set 2: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-bts/+/32100/comment/f9dfb92e_1cb7fe7f PS2, Line 16: The case of TCH/H is still unhandled, and it may or may not be : possible to handle correctly, particularly for rtp always-output mode. : The fundamental difficulty is that in order to produce truly : undisrupted RTP timing, two BFI packets will need to be sent for : one FACCH, spaced 20 ms apart - but if the PHY only sends one : GsmL1_Sapi_FacchH message surrounded by a 40 ms time gap, then : we may be out of luck. > * might make sense to add this as a comment into/above the if-clause that treats FACCH/F but not FAC […] I am now preparing the next iteration of the full patch series, and the next version of the present patch will have better comments. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32100 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I39d15faade28fb7d670493a99a0e0bdb654e2a4a Gerrit-Change-Number: 32100 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 28 Mar 2023 19:47:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

1 0

[S] Change in libosmocore[master]: gsm: Add missing TS 24.008 SM layer IEs
by pespin 28 Mar '23

28 Mar '23

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/32109 to look at the new patch set (#2). Change subject: gsm: Add missing TS 24.008 SM layer IEs ...................................................................... gsm: Add missing TS 24.008 SM layer IEs Change-Id: Iec0dbf617c8d0f2c8c44156d936244cedda9b303 --- M include/osmocom/gsm/protocol/gsm_04_08_gprs.h 1 file changed, 18 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/09/32109/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32109 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iec0dbf617c8d0f2c8c44156d936244cedda9b303 Gerrit-Change-Number: 32109 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

1 0

[S] Change in libosmocore[master]: gsm: Add missing TS 24.008 SM layer IEs
by pespin 28 Mar '23

28 Mar '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/32109 ) Change subject: gsm: Add missing TS 24.008 SM layer IEs ...................................................................... gsm: Add missing TS 24.008 SM layer IEs Change-Id: Iec0dbf617c8d0f2c8c44156d936244cedda9b303 --- M include/osmocom/gsm/protocol/gsm_04_08_gprs.h 1 file changed, 16 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/09/32109/1 diff --git a/include/osmocom/gsm/protocol/gsm_04_08_gprs.h b/include/osmocom/gsm/protocol/gsm_04_08_gprs.h index 40c8413..905a3b8 100644 --- a/include/osmocom/gsm/protocol/gsm_04_08_gprs.h +++ b/include/osmocom/gsm/protocol/gsm_04_08_gprs.h @@ -101,15 +101,22 @@ }; enum gsm48_gprs_ie_sm { + GSM48_IE_GSM_DEV_PROP = 0x0C, /* 10.5.7.8 */ GSM48_IE_GSM_APN = 0x28, /* 10.5.6.1 */ GSM48_IE_GSM_PROTO_CONF_OPT = 0x27, /* 10.5.6.3 */ GSM48_IE_GSM_PDP_ADDR = 0x2b, /* 10.5.6.4 */ GSM48_IE_GSM_AA_TMR = 0x29, /* 10.5.7.3 */ + GSM48_IE_GSM_QOS = 0x30, /* 10.5.6.5 */ + GSM48_IE_GSM_TFT = 0x31, /* 10.5.6.12 */ + GSM48_IE_GSM_LLC_SAPI = 0x32, /* 10.5.6.9 */ + GSM48_IE_GSM_MBIFOM_CONT = 0x33, /* 10.5.6.21 */ GSM48_IE_GSM_NAME_FULL = 0x43, /* 10.5.3.5a */ GSM48_IE_GSM_NAME_SHORT = 0x45, /* 10.5.3.5a */ GSM48_IE_GSM_TIMEZONE = 0x46, /* 10.5.3.8 */ GSM48_IE_GSM_UTC_AND_TZ = 0x47, /* 10.5.3.9 */ GSM48_IE_GSM_LSA_ID = 0x48, /* 10.5.3.11 */ + GSM48_IE_GSM_EXT_QOS = 0x5C, /* 10.5.6.5B */ + GSM48_IE_GSM_EXT_PROTO_CONF_OPT = 0x7B, /* 10.5.6.3a */ /* Fake IEs that are not present on the Layer3 air interface, * but which we use to simplify internal APIs */ -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32109 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iec0dbf617c8d0f2c8c44156d936244cedda9b303 Gerrit-Change-Number: 32109 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-bts[master]: cosmetic: Remove "FIXME?" from Odd AMR CMI phase
by laforge 28 Mar '23

28 Mar '23

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/32108 ) Change subject: cosmetic: Remove "FIXME?" from Odd AMR CMI phase ...................................................................... cosmetic: Remove "FIXME?" from Odd AMR CMI phase This default phase of the Codec Mode Indication in downlink direction is called "odd", which is defined by starting with CMC in every 26 multiframe. At call set-up, after every successful handover and after a channel mode modify, the default phase (odd) shall be used in downlink direction. During a call, the phase of Codec Mode Indication may be changed in downlink by using a RATSCCH message. As we don't implement RATSCCH, odd is always correct. Change-Id: Ia64767fbfdc3fb067d72dbf5eabb1d84e3868ce5 --- M src/osmo-bts-lc15/oml.c M src/osmo-bts-oc2g/oml.c M src/osmo-bts-sysmo/oml.c 3 files changed, 29 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/08/32108/1 diff --git a/src/osmo-bts-lc15/oml.c b/src/osmo-bts-lc15/oml.c index 2619c75..56e8221 100644 --- a/src/osmo-bts-lc15/oml.c +++ b/src/osmo-bts-lc15/oml.c @@ -962,7 +962,9 @@ case GSM48_CMODE_SPEECH_AMR: lch_par->tch.tchPlType = GsmL1_TchPlType_Amr; set_payload_format(lch_par); - lch_par->tch.amrCmiPhase = GsmL1_AmrCmiPhase_Odd; /* FIXME? */ + /* At call set-up, after every successful handover and after a channel mode modify, the + * default phase (odd) shall be used in downlink direction. */ + lch_par->tch.amrCmiPhase = GsmL1_AmrCmiPhase_Odd; lch_par->tch.amrInitCodecMode = amr_get_initial_mode(lchan); /* initialize to clean state */ diff --git a/src/osmo-bts-oc2g/oml.c b/src/osmo-bts-oc2g/oml.c index 9ea6a4d..7820079 100644 --- a/src/osmo-bts-oc2g/oml.c +++ b/src/osmo-bts-oc2g/oml.c @@ -977,7 +977,9 @@ case GSM48_CMODE_SPEECH_AMR: lch_par->tch.tchPlType = GsmL1_TchPlType_Amr; set_payload_format(lch_par); - lch_par->tch.amrCmiPhase = GsmL1_AmrCmiPhase_Odd; /* FIXME? */ + /* At call set-up, after every successful handover and after a channel mode modify, the + * default phase (odd) shall be used in downlink direction. */ + lch_par->tch.amrCmiPhase = GsmL1_AmrCmiPhase_Odd; lch_par->tch.amrInitCodecMode = amr_get_initial_mode(lchan); /* initialize to clean state */ diff --git a/src/osmo-bts-sysmo/oml.c b/src/osmo-bts-sysmo/oml.c index 565f9f8..d7b0bd7 100644 --- a/src/osmo-bts-sysmo/oml.c +++ b/src/osmo-bts-sysmo/oml.c @@ -970,7 +970,9 @@ case GSM48_CMODE_SPEECH_AMR: lch_par->tch.tchPlType = GsmL1_TchPlType_Amr; set_payload_format(lch_par); - lch_par->tch.amrCmiPhase = GsmL1_AmrCmiPhase_Odd; /* FIXME? */ + /* At call set-up, after every successful handover and after a channel mode modify, the + * default phase (odd) shall be used in downlink direction. */ + lch_par->tch.amrCmiPhase = GsmL1_AmrCmiPhase_Odd; lch_par->tch.amrInitCodecMode = amr_get_initial_mode(lchan); /* initialize to clean state */ -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32108 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ia64767fbfdc3fb067d72dbf5eabb1d84e3868ce5 Gerrit-Change-Number: 32108 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 0

[M] Change in osmo-bts[master]: common: implement rtp always-output mode
by falconia 28 Mar '23

28 Mar '23

Attention is currently required from: laforge, pespin. falconia has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32098 ) Change subject: common: implement rtp always-output mode ...................................................................... Patch Set 2: (3 comments) File src/common/l1sap.c: https://gerrit.osmocom.org/c/osmo-bts/+/32098/comment/6601730d_ae3b9968 PS2, Line 1250: /* A zero-length payload is never valid, it is merely a BFI marker > Can you explain a bit more this change in logic here? It's not explained in the commit description s […] The next iteration will include a comment in the code explaining that this check is for TrFO calls, i.e., call B DL coming from call A UL. If leg A sends out continuous-streaming BFI markers, then leg B needs to gracefully handle receiving such. https://gerrit.osmocom.org/c/osmo-bts/+/32098/comment/efe15312_8c1763cc PS2, Line 1253: if (!resp_msg->len) > == 0 would be clearer here, since len is an int and not a bool. Will fix in the next iteration. File src/common/vty.c: https://gerrit.osmocom.org/c/osmo-bts/+/32098/comment/0bd3b3b4_29b7805f PS2, Line 425: vty_out(vty, " rtp always-output%s", VTY_NEWLINE); > I know it always sucks to debate over naming, but I am certain it is worth the extra effort to make […] I struggled myself with the naming, and I was also less than 100% happy with my initial naming choice of "rtp always-output". But thanks to @laforge we now have a very good name as in "rtp continuous-streaming" - so that is the name I shall use in the next iteration of this patch series. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32098 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ic0e2edf2ed90ba0ac6bee5e7d9629bf0255e256d Gerrit-Change-Number: 32098 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Mar 2023 16:06:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0