March 2023 - gerrit-log - lists.osmocom.org

[M] Change in osmo-msc[master]: in ran_msg, return gsm0808_speech_codec (intra-MSC)
by neels 07 Mar '23

07 Mar '23

Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/31695 ) Change subject: in ran_msg, return gsm0808_speech_codec (intra-MSC) ...................................................................... Patch Set 3: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-msc/+/31695/comment/e19901b4_517a305f PS3, Line 15: - CN side: introduce flag ran_msg.assignment_complete.codec_with_iuup, > I think this field was incorrectly added in previous commit? nope, that was ran_infra.force_mgw_codecs_to_ran. So, basically - I chose to force RAN MGW conn to do IUFP always (ran_infra.force_mgw_codecs_to_ran), and - in ran_msg to only tell the gsm0808 codec it is *compatible* with. - Then I had the problem that for the time being, i still want to force IuUP towards CN for now (better change from IuUP <-> IuUP to IuUP <-> AMR/RTP in a separate patch), and I want to get rid of the "if UTRAN" special cases. So this flag is actually only needed for the intermediate phase where we still forward IuUP to the CN. As soon as we always decaps to plain RTP on the CN side, we only need the ran_infra forced codecs, because we never use IUFP on the CN anymore. Still i think this flag clarifies a bit what is actually going on, even if we will soon stop actually using it. - The ran_infra.force_mgw_codecs_to_ran is important because the first CRCX happens before assignment starts, that already needs to be IuUP aware for the IuUP Initialization to work (which happens before RAB Assignment completes). - The ran_msg.codec tells the msc_a code that after assignment is done, the assignment is compatible with a given gsm0808_speech_codec (namely AMR), and please use AMR on the CN side. - Then this flag ran_msg.codec_with_iuup says "look, you should use the ran_msg.codec (AMR) plain as it is towards CN, but btw it is coming in on IuUP, so if you still want to forward IuUP to the CN like in olden times then go ahead" -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/31695 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ia666cb697fbd140d7239089628faed93860ce671 Gerrit-Change-Number: 31695 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 07 Mar 2023 16:16:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in libosmo-gprs[master]: rlcmac: Fix several ptr bugs looking up ul tbf upon rx PktUlAss
by pespin 07 Mar '23

07 Mar '23

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31727 ) Change subject: rlcmac: Fix several ptr bugs looking up ul tbf upon rx PktUlAss ...................................................................... rlcmac: Fix several ptr bugs looking up ul tbf upon rx PktUlAss Related: Coverity CID#310957 Change-Id: I0b031761dbbc93c1c06ba94967e91180062613fd --- M src/rlcmac/rlcmac.c 1 file changed, 23 insertions(+), 8 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/rlcmac/rlcmac.c b/src/rlcmac/rlcmac.c index 82394e6..b090cee 100644 --- a/src/rlcmac/rlcmac.c +++ b/src/rlcmac/rlcmac.c @@ -366,13 +366,14 @@ const Packet_Uplink_Assignment_t *ulass = &dl_block->u.Packet_Uplink_Assignment; int rc; - /* Attempt to find relevant UL TBF in assignment state from ID (set "gre" ptr): */ + /* Attempt to find relevant MS owning UL TBF in assignment state from ID (set "gre" ptr): */ switch (ulass->ID.UnionType) { case 0: /* GLOBAL_TFI: */ switch (ulass->ID.u.Global_TFI.UnionType) { case 0: /* UL TFI */ ul_tbf = gprs_rlcmac_find_ul_tbf_by_tfi(ulass->ID.u.Global_TFI.u.UPLINK_TFI); - gre = ul_tbf->tbf.gre; + if (ul_tbf) + gre = ul_tbf->tbf.gre; break; case 1: /* DL TFI */ dl_tbf = gprs_rlcmac_find_dl_tbf_by_tfi(ulass->ID.u.Global_TFI.u.DOWNLINK_TFI); @@ -385,8 +386,6 @@ break; case 1: /* TLLI */ gre = gprs_rlcmac_find_entity_by_tlli(ulass->ID.u.TLLI); - if (gre) - ul_tbf = gre->ul_tbf; break; case 2: /* TQI */ case 3: /* Packet_Request_Reference */ @@ -397,11 +396,17 @@ break; } - if (!gre->ul_tbf) { - LOGRLCMAC(LOGL_INFO, "TS=%u FN=%u Rx Pkt UL ACK/NACK: UL_TBF TFI=%u not found\n", + if (!gre) { + LOGRLCMAC(LOGL_INFO, "TS=%u FN=%u Rx Pkt UL ASS: MS not found\n", rlcmac_prim->l1ctl.pdch_data_ind.ts_nr, - rlcmac_prim->l1ctl.pdch_data_ind.fn, - dl_block->TFI); + rlcmac_prim->l1ctl.pdch_data_ind.fn); + return -ENOENT; + } + + if (!gre->ul_tbf) { + LOGGRE(gre, LOGL_INFO, "TS=%u FN=%u Rx Pkt UL ASS: MS has no UL TBF\n", + rlcmac_prim->l1ctl.pdch_data_ind.ts_nr, + rlcmac_prim->l1ctl.pdch_data_ind.fn); return -ENOENT; } -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31727 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I0b031761dbbc93c1c06ba94967e91180062613fd Gerrit-Change-Number: 31727 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in libosmo-gprs[master]: rlcmac: ignore PACKET_DOWNLINK_DUMMY_CONTROL_BLOCK
by pespin 07 Mar '23

07 Mar '23

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31640 ) Change subject: rlcmac: ignore PACKET_DOWNLINK_DUMMY_CONTROL_BLOCK ...................................................................... rlcmac: ignore PACKET_DOWNLINK_DUMMY_CONTROL_BLOCK It's expected to receive dummy DL blocks when listening to PDCH, so do not spam the logging with errors: DRLCMAC ERROR rlcmac.c:392 TS=7 FN=3035694080 Rx Pkt DL Dummy Ctrl Block NOT SUPPORTED! ignoring Change-Id: I6a40e2795adc71b9312d39c96b01aba9a258da42 Related: OS#5500 --- M src/rlcmac/rlcmac.c 1 file changed, 18 insertions(+), 0 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/rlcmac/rlcmac.c b/src/rlcmac/rlcmac.c index b090cee..3b30fb6 100644 --- a/src/rlcmac/rlcmac.c +++ b/src/rlcmac/rlcmac.c @@ -448,6 +448,8 @@ case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_UPLINK_ASSIGNMENT: rc = gprs_rlcmac_handle_pkt_ul_ass(rlcmac_prim, dl_ctrl_block); break; + case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_DOWNLINK_DUMMY_CONTROL_BLOCK: + break; /* Ignore dummy blocks */ default: LOGRLCMAC(LOGL_ERROR, "TS=%u FN=%u Rx %s NOT SUPPORTED! ignoring\n", rlcmac_prim->l1ctl.pdch_data_ind.ts_nr, -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31640 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I6a40e2795adc71b9312d39c96b01aba9a258da42 Gerrit-Change-Number: 31640 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-gsm-tester[master]: doc/manuals: set OSMO_REPOSITORY
by pespin 07 Mar '23

07 Mar '23

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/31728 ) Change subject: doc/manuals: set OSMO_REPOSITORY ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/31728 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: Ia9935e176ee7633270ccd2926d60d7f8cea822f8 Gerrit-Change-Number: 31728 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 07 Mar 2023 16:09:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-pcu[master]: tbf: Increase log level if polling requested in wrong TS
by pespin 07 Mar '23

07 Mar '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31729 ) Change subject: tbf: Increase log level if polling requested in wrong TS ...................................................................... tbf: Increase log level if polling requested in wrong TS Change-Id: I641bddcb4027ecc9cc1ec66d4d6b9b483c94c617 --- M src/tbf.cpp 1 file changed, 10 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/29/31729/1 diff --git a/src/tbf.cpp b/src/tbf.cpp index 9e03089..9648c71 100644 --- a/src/tbf.cpp +++ b/src/tbf.cpp @@ -818,7 +818,7 @@ if (!tbf_is_control_ts(tbf, pdch)) { char buf[128]; - LOGPTBF(tbf, LOGL_DEBUG, "Polling cannot be " + LOGPTBF(tbf, LOGL_NOTICE, "Polling cannot be " "scheduled in this TS %s (control TS %s)\n", pdch_name(pdch), tbf->control_ts ? pdch_name_buf(tbf->control_ts, buf, sizeof(buf)) : "none"); -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31729 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I641bddcb4027ecc9cc1ec66d4d6b9b483c94c617 Gerrit-Change-Number: 31729 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[L] Change in osmo-msc[master]: rtp_stream: allow multiple codecs / use codec filter from Assignment
by neels 07 Mar '23

07 Mar '23

Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/30125 ) Change subject: rtp_stream: allow multiple codecs / use codec filter from Assignment ...................................................................... Patch Set 4: (2 comments) Patchset: PS4: > i had this sort of separate once, but here we are now. […] (I mean ".._set_codecs()") File include/osmocom/msc/msc_a.h: https://gerrit.osmocom.org/c/osmo-msc/+/30125/comment/078407eb_6c392c8e PS4, Line 225: struct sdp_audio_codecs *msc_a_ran_codecs(struct msc_a *msc_a); > drop unused function Done -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/30125 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: If9c67b298b30f893ec661f84c9fc622ad01b5ee5 Gerrit-Change-Number: 30125 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 07 Mar 2023 15:56:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[L] Change in osmo-msc[master]: rtp_stream: allow multiple codecs / use codec filter from Assignment
by neels 07 Mar '23

07 Mar '23

Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/30125 ) Change subject: rtp_stream: allow multiple codecs / use codec filter from Assignment ...................................................................... Patch Set 4: (1 comment) File include/osmocom/msc/msc_a.h: https://gerrit.osmocom.org/c/osmo-msc/+/30125/comment/b910db28_d49ab8ab PS4, Line 225: struct sdp_audio_codecs *msc_a_ran_codecs(struct msc_a *msc_a); drop unused function -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/30125 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: If9c67b298b30f893ec661f84c9fc622ad01b5ee5 Gerrit-Change-Number: 30125 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 07 Mar 2023 15:52:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in osmo-msc[master]: rtp_stream: allow multiple codecs / use codec filter from Assignment
by neels 07 Mar '23

07 Mar '23

Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/30125 ) Change subject: rtp_stream: allow multiple codecs / use codec filter from Assignment ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: > I have the feeling this commit is still renaming and changing logic both things at the same time, wh […] i had this sort of separate once, but here we are now. my opinion now is that it is better to rename "codec" to "codecs" at the same time when it changes to multiple codecs involved where there was only one before: this shows in one patch all the places that are affected by the change, e.g. 'git blame' will hint at this patch. Especially when adding the function ".._add_one_codec()" it is better to have the other function named "..._add_codecs()", not ".._add_codec()". -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/30125 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: If9c67b298b30f893ec661f84c9fc622ad01b5ee5 Gerrit-Change-Number: 30125 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 07 Mar 2023 15:51:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-gsm-tester[master]: doc/manuals: set OSMO_REPOSITORY
by osmith 07 Mar '23

07 Mar '23

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/31728 ) Change subject: doc/manuals: set OSMO_REPOSITORY ...................................................................... doc/manuals: set OSMO_REPOSITORY Fix uploading manuals to the wrong directory. Related: OS#5902 Change-Id: Ia9935e176ee7633270ccd2926d60d7f8cea822f8 --- M doc/manuals/Makefile 1 file changed, 13 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester refs/changes/28/31728/1 diff --git a/doc/manuals/Makefile b/doc/manuals/Makefile index 0730411..8b548b6 100644 --- a/doc/manuals/Makefile +++ b/doc/manuals/Makefile @@ -5,4 +5,5 @@ ASCIIDOC_DEPS = $(srcdir)/chapters/*.adoc include $(OSMO_GSM_MANUALS_DIR)/build/Makefile.asciidoc.inc +OSMO_REPOSITORY = osmo-gsm-tester include $(OSMO_GSM_MANUALS_DIR)/build/Makefile.common.inc -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/31728 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: Ia9935e176ee7633270ccd2926d60d7f8cea822f8 Gerrit-Change-Number: 31728 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[M] Change in osmo-bsc[master]: pcu_sock: handle multiple BTSs with multiple BSC co-located PCUs
by dexter 07 Mar '23

07 Mar '23

Attention is currently required from: neels, laforge, pespin. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31618 ) Change subject: pcu_sock: handle multiple BTSs with multiple BSC co-located PCUs ...................................................................... Patch Set 8: (2 comments) Patchset: PS8: > Thanks for clarifying this. One BSC co-located PCU only. […] Done File include/osmocom/bsc/pcu_if.h: https://gerrit.osmocom.org/c/osmo-bsc/+/31618/comment/3b840200_0e2b15c4 PS7, Line 11: struct gsm_bts *bts; /* BTS that is associated with this PCU */ > I thought the outcome of the discussion was that we didn't want to limit 1 BTS per PCU, and instead […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31618 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I0b42c2c130106f6ffca2dd08d079e1a7bda41f0b Gerrit-Change-Number: 31618 Gerrit-PatchSet: 8 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 07 Mar 2023 15:48:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: comment

1 0