March 2023 - gerrit-log - lists.osmocom.org

[S] Change in libosmo-gprs[master]: rlcmac: Fix several ptr bugs looking up ul tbf upon rx PktUlAss
by pespin 07 Mar '23

07 Mar '23

Attention is currently required from: laforge, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31727 ) Change subject: rlcmac: Fix several ptr bugs looking up ul tbf upon rx PktUlAss ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31727 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I0b031761dbbc93c1c06ba94967e91180062613fd Gerrit-Change-Number: 31727 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 07 Mar 2023 15:47:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libosmo-gprs[master]: rlcmac: ignore PACKET_DOWNLINK_DUMMY_CONTROL_BLOCK
by pespin 07 Mar '23

07 Mar '23

Attention is currently required from: neels, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31640 ) Change subject: rlcmac: ignore PACKET_DOWNLINK_DUMMY_CONTROL_BLOCK ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Patchset: PS2: I rebased this one and fixed the merge conflict in the process. -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31640 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I6a40e2795adc71b9312d39c96b01aba9a258da42 Gerrit-Change-Number: 31640 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 07 Mar 2023 15:47:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libosmo-gprs[master]: rlcmac: ignore PACKET_DOWNLINK_DUMMY_CONTROL_BLOCK
by pespin 07 Mar '23

07 Mar '23

Attention is currently required from: neels, fixeria. pespin has uploaded a new patch set (#2) to the change originally created by fixeria. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31640 ) Change subject: rlcmac: ignore PACKET_DOWNLINK_DUMMY_CONTROL_BLOCK ...................................................................... rlcmac: ignore PACKET_DOWNLINK_DUMMY_CONTROL_BLOCK It's expected to receive dummy DL blocks when listening to PDCH, so do not spam the logging with errors: DRLCMAC ERROR rlcmac.c:392 TS=7 FN=3035694080 Rx Pkt DL Dummy Ctrl Block NOT SUPPORTED! ignoring Change-Id: I6a40e2795adc71b9312d39c96b01aba9a258da42 Related: OS#5500 --- M src/rlcmac/rlcmac.c 1 file changed, 18 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/40/31640/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31640 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I6a40e2795adc71b9312d39c96b01aba9a258da42 Gerrit-Change-Number: 31640 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[L] Change in osmo-msc[master]: [codecs filter] add codec_filter.h,c
by neels 07 Mar '23

07 Mar '23

Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/30116 ) Change subject: [codecs filter] add codec_filter.h,c ...................................................................... Patch Set 4: (2 comments) File src/libmsc/codec_filter.c: https://gerrit.osmocom.org/c/osmo-msc/+/30116/comment/8f2a34b1_5a8a79de PS1, Line 8: * SPDX-License-Identifier: GPL-2.0+ > Ack Done https://gerrit.osmocom.org/c/osmo-msc/+/30116/comment/cde0d383_0292ae73 PS1, Line 28: static void sdp_add_all_mobile_codecs(struct sdp_audio_codecs *ac) > Ack Done -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/30116 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I4d90f7ca62f2307a7b93dd164aeecbf4bd98ff0a Gerrit-Change-Number: 30116 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 07 Mar 2023 15:40:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[M] Change in osmo-msc[master]: MNCC: use codec_mapping, drop mgcp_codec_to_mncc_payload_msg_type()
by neels 07 Mar '23

07 Mar '23

Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/30115 ) Change subject: MNCC: use codec_mapping, drop mgcp_codec_to_mncc_payload_msg_type() ...................................................................... Patch Set 4: (2 comments) File tests/msc_vlr/msc_vlr_test_call.err: https://gerrit.osmocom.org/c/osmo-msc/+/30115/comment/95c160c0_93514f00 PS1, Line 317: DCC rtp_stream(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ:trans-8:call-2147483649:RTP_TO_RAN:no-CI:local-10-23-23-1-23){UNINITIALIZED}: remote addr already :0, no change > this change looks from a previous commit. Done https://gerrit.osmocom.org/c/osmo-msc/+/30115/comment/4a863574_56037838 PS1, Line 318: DCC rtp_stream(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ:trans-8:call-2147483649:RTP_TO_RAN:no-CI:local-10-23-23-1-23){UNINITIALIZED}: Not committing: no remote RTP address known > This too. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/30115 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I8995ef43b9f79bc1db5672362c6433e4d96dd9e0 Gerrit-Change-Number: 30115 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 07 Mar 2023 15:38:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[L] Change in osmo-msc[master]: add codec_mapping.h,c
by neels 07 Mar '23

07 Mar '23

Attention is currently required from: laforge, pespin, fixeria. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/30114 ) Change subject: add codec_mapping.h,c ...................................................................... Patch Set 4: (3 comments) File include/osmocom/msc/codec_mapping.h: https://gerrit.osmocom.org/c/osmo-msc/+/30114/comment/3485efdb_5dd973b7 PS4, Line 44: for ((CODEC_MAPPING) = codec_map; (CODEC_MAPPING) < codec_map + ARRAY_SIZE(codec_map); (CODEC_MAPPING)++) > It's an interesting question if the preprocessor really can determine the size here or not. […] TL;dr: I'll move this to the .c file and don't even publish the array in the .h file. The mapping entries are always accessed via functions. details: so we need to solve the fundamental question whether we can trust our ARRAY_SIZE() macro. It's not the preprocessor that needs to know, the preproc resolves to sizeof(this)/sizeof(that), and then the compiler figures that out compile time. if sizeof() didn't work on the thing passed to it, i.e. if the storage size were unknown, the compiler would tell us. To illustrate, i added this code to some random place in osmo-msc: printf("hi %zu\n", ARRAY_SIZE(osmo_tdef_unit_names)); it calls ARRAY_SIZE on a libosmocore "unsized" array. then we get: error: invalid application of ‘sizeof’ to incomplete type ‘const struct value_string[]’ 54 | printf("hi %zu\n", ARRAY_SIZE(osmo_tdef_unit_names)); | ^~~~~~~~~~ So the main question is whether this codec mapping should be movable to a different library -- This array is used only within osmo-msc, actually only accessed directly from codec_mapping.c, so it doesn't need to be in the .h file at all File src/libmsc/codec_mapping.c: https://gerrit.osmocom.org/c/osmo-msc/+/30114/comment/821d024f_68f15f83 PS4, Line 290: if (bearer_cap->speech_ver[i] == -1) { > I actually think -1 is more obvious, and I think we have plenty of similar examples seech_ver = -1 is used all over the GSM code; we can change that but that's orthogonal https://gerrit.osmocom.org/c/osmo-msc/+/30114/comment/4c27956e_188b1a5f PS4, Line 308: if (bearer_cap->speech_ver[i] == -1) > -1 as define Done -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/30114 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Iaa307be6a8487aa8d4ba7cd59d5c5ef04818a744 Gerrit-Change-Number: 30114 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 07 Mar 2023 15:38:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-bsc[master]: pcu_sock: only allow Ericsson RBS to connect to external PCU
by dexter 07 Mar '23

07 Mar '23

dexter has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31687 ) Change subject: pcu_sock: only allow Ericsson RBS to connect to external PCU ...................................................................... Abandoned Since we decided to use only one BSC co located PCU for multiple BTS we cannot use this approach anymore. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31687 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I18d190d661b06015419078382915c4606be01b04 Gerrit-Change-Number: 31687 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: abandon

1 0

[S] Change in osmo-bsc[master]: pcu_sock: only allow Ericsson RBS to connect to external PCU
by dexter 07 Mar '23

07 Mar '23

Attention is currently required from: laforge, fixeria. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31687 ) Change subject: pcu_sock: only allow Ericsson RBS to connect to external PCU ...................................................................... Patch Set 3: (1 comment) File src/osmo-bsc/pcu_sock.c: https://gerrit.osmocom.org/c/osmo-bsc/+/31687/comment/6d433085_2f3e0b3b PS2, Line 964: return -EINVAL; > What are you doing? My concern was that there is already a message being printed (by the VTY code), […] Well, you explicitly asked for printing nothing specific, just something ;-) "But nothing specific *why* it failed. Please print something here." - Never mind I misunderstood this. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31687 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I18d190d661b06015419078382915c4606be01b04 Gerrit-Change-Number: 31687 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 07 Mar 2023 15:36:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-msc[master]: sdp_msg.c: fix missing rate in sdp_audio_codecs_add()
by neels 07 Mar '23

07 Mar '23

neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/31691 ) Change subject: sdp_msg.c: fix missing rate in sdp_audio_codecs_add() ...................................................................... sdp_msg.c: fix missing rate in sdp_audio_codecs_add() When a new entry is is added by sdp_audio_codecs_add(), also add the proper rate. Change-Id: I17ad8862f662975e2df72a332eb83df7fb048cad --- M src/libmsc/sdp_msg.c 1 file changed, 13 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/libmsc/sdp_msg.c b/src/libmsc/sdp_msg.c index 49fc5d2..dba1541 100644 --- a/src/libmsc/sdp_msg.c +++ b/src/libmsc/sdp_msg.c @@ -154,6 +154,7 @@ OSMO_STRLCPY_ARRAY(codec->subtype_name, subtype_name); if (fmtp) OSMO_STRLCPY_ARRAY(codec->fmtp, fmtp); + codec->rate = rate; return codec; } -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/31691 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I17ad8862f662975e2df72a332eb83df7fb048cad Gerrit-Change-Number: 31691 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-msc[master]: IuCS: remove IuUP LOOPBACK hack
by neels 07 Mar '23

07 Mar '23

neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/31693 ) Change subject: IuCS: remove IuUP LOOPBACK hack ...................................................................... IuCS: remove IuUP LOOPBACK hack Since osmo-mgw now supports IuUP properly, and since we indicate IUFP in the MGCP CRCX towars an IuCS RAN [1], we should no longer place the MGW endpoint in loopback mode to hack up an IuUP Initialization. This hack should have been removed along with [1]. [1] IUFP sent to MGW since this commit: commit 3a02d298049149f126fecc51e8445392cdb3b950 Refs: 1.8.0-13-g3a02d2980 Announce IuFP audio codec for UTRAN conns in CRCX towards MGW I7aca671e00ed27ac03f0d106b5a6b665a9bed4c1 Change-Id: I6446c64421e3e13e2b829293d031c98b99cd39a7 --- M src/libmsc/msc_a.c 1 file changed, 21 insertions(+), 6 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/libmsc/msc_a.c b/src/libmsc/msc_a.c index a5ab2fb..e74a425 100644 --- a/src/libmsc/msc_a.c +++ b/src/libmsc/msc_a.c @@ -1755,12 +1755,6 @@ MSC_EV_CALL_LEG_RTP_LOCAL_ADDR_AVAILABLE, MSC_EV_CALL_LEG_RTP_COMPLETE); OSMO_ASSERT(cl); - - /* HACK: We put the connection in loopback mode at the beginning to - * trick the hNodeB into doing the IuUP negotiation with itself. - * This is a hack we need because osmo-mgw does not support IuUP yet, see OS#2459. */ - if (msc_a->c.ran->type == OSMO_RAT_UTRAN_IU) - cl->crcx_conn_mode[RTP_TO_RAN] = MGCP_CONN_LOOPBACK; } if (net->use_osmux != OSMUX_USAGE_OFF) { -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/31693 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I6446c64421e3e13e2b829293d031c98b99cd39a7 Gerrit-Change-Number: 31693 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0