March 2023 - gerrit-log - lists.osmocom.org

[M] Change in osmo-bsc[master]: pcu_sock: handle multiple BTSs with multiple BSC co-located PCUs
by laforge 07 Mar '23

07 Mar '23

Attention is currently required from: neels, pespin, dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31618 ) Change subject: pcu_sock: handle multiple BTSs with multiple BSC co-located PCUs ...................................................................... Patch Set 8: -Code-Review (1 comment) Patchset: PS8: I think we want (from the BSC side) to support a single, BSC-colocated PCU for now, and not any other scenarios. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31618 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I0b42c2c130106f6ffca2dd08d079e1a7bda41f0b Gerrit-Change-Number: 31618 Gerrit-PatchSet: 8 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 07 Mar 2023 14:13:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-bsc[master]: pcuif_proto: increment version number
by laforge 07 Mar '23

07 Mar '23

Attention is currently required from: neels, dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31597 ) Change subject: pcuif_proto: increment version number ...................................................................... Patch Set 9: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31597 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I8315bd67c7f3eb0d7ee71b64cd4dff889a84fcf1 Gerrit-Change-Number: 31597 Gerrit-PatchSet: 9 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 07 Mar 2023 14:12:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-bsc[master]: doc: add sample configuration for GPRS with ericsson RBS
by laforge 07 Mar '23

07 Mar '23

Attention is currently required from: pespin, dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31725 ) Change subject: doc: add sample configuration for GPRS with ericsson RBS ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: > Don't you need to add those to any Makefile. […] Nope, not to Makefile.am, it does wildcard expansion: CFG_FILES = find $(srcdir) -name '*.cfg*' -o -name '*.confmerge*' | sed -e 's,^$(srcdir),,' likewise debian: usr/share/doc/osmo-bsc/examples/osmo-bsc/*/osmo-bsc*.cfg and rpm: %{_docdir}/%{name}/examples/osmo-bsc/*/osmo-bsc*.cfg -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31725 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I923608d4edc28b02e882c5f04851a29fc11bad4e Gerrit-Change-Number: 31725 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 07 Mar 2023 14:12:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-bts[master]: pcu_sock: do not mess with the osmo fd flags directly
by laforge 07 Mar '23

07 Mar '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31679 ) Change subject: pcu_sock: do not mess with the osmo fd flags directly ...................................................................... pcu_sock: do not mess with the osmo fd flags directly When we disable the old socket connection, let's use osmo_fd_read_disable(). Change-Id: I6b6854e9881c79b5c4794bde4ba4f6841dd06386 --- M src/common/pcu_sock.c 1 file changed, 13 insertions(+), 1 deletion(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/common/pcu_sock.c b/src/common/pcu_sock.c index 119d7b8..7e87f6d 100644 --- a/src/common/pcu_sock.c +++ b/src/common/pcu_sock.c @@ -1172,7 +1172,7 @@ if (conn_bfd->fd >= 0) { LOGP(DPCU, LOGL_NOTICE, "PCU connects but we already have another active connection ?!?\n"); /* We already have one PCU connected, this is all we support */ - state->listen_bfd.when &= ~OSMO_FD_READ; + osmo_fd_read_disable(&state->listen_bfd); close(fd); return 0; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31679 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I6b6854e9881c79b5c4794bde4ba4f6841dd06386 Gerrit-Change-Number: 31679 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-gsm-manuals[master]: publish: make sure OSMO_REPOSITORY isn't default
by pespin 07 Mar '23

07 Mar '23

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/31726 ) Change subject: publish: make sure OSMO_REPOSITORY isn't default ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/31726/comment/1bc30b5f_4e8d… PS1, Line 9: Instead of checking whether OSMO_REPOSITORY is empty, check if it has I'm not sure I'm following the logic here. If the default is not empty and contains some directory name, but we don't want to use that default value by all means, then why (the hell) do we set the default value to something not empty? -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/31726 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: Ie21d58dd57a893a83f566eea464ab3eec82b67a4 Gerrit-Change-Number: 31726 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 07 Mar 2023 14:09:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in osmo-bsc[master]: doc: add sample configuration for GPRS with ericsson RBS
by pespin 07 Mar '23

07 Mar '23

Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31725 ) Change subject: doc: add sample configuration for GPRS with ericsson RBS ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Don't you need to add those to any Makefile.am so they are installed as documentation like the others? or is that done automatically? (also check debian/rpm) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31725 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I923608d4edc28b02e882c5f04851a29fc11bad4e Gerrit-Change-Number: 31725 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 07 Mar 2023 14:06:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in osmo-bsc[master]: pcu_sock: only allow Ericsson RBS to connect to external PCU
by fixeria 07 Mar '23

07 Mar '23

Attention is currently required from: laforge, dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31687 ) Change subject: pcu_sock: only allow Ericsson RBS to connect to external PCU ...................................................................... Patch Set 3: Code-Review-1 (1 comment) File src/osmo-bsc/pcu_sock.c: https://gerrit.osmocom.org/c/osmo-bsc/+/31687/comment/c32a08e7_0582af2c PS2, Line 964: return -EINVAL; > Thanks. […] What are you doing? My concern was that there is already a message being printed (by the VTY code), but it does not say *what exactly is wrong*. It might not be obvious to the user/operator that only Ericsson RBS is supported, so we should make this clear in the logging message. See below: "Could not create unix socket", "Could not register listen"... -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31687 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I18d190d661b06015419078382915c4606be01b04 Gerrit-Change-Number: 31687 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 07 Mar 2023 14:03:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[M] Change in osmo-pcu[master]: bts: add IMMEDIATE ASSIGNMENT via PCH transmission
by dexter 07 Mar '23

07 Mar '23

Attention is currently required from: neels, pespin, fixeria. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31145 ) Change subject: bts: add IMMEDIATE ASSIGNMENT via PCH transmission ...................................................................... Patch Set 24: (2 comments) Patchset: PS24: I see that this patch is ready to get merged. To be sure everything is fine I will test it once more now. File include/osmocom/pcu/pcuif_proto.h: https://gerrit.osmocom.org/c/osmo-pcu/+/31145/comment/3ca0f64c_ffa53c73 PS18, Line 43: PCU_IF_SAPI_PCH_DT > I have seen your BTS patch. Thanks. I will test this today. I didn't look at the tests yet. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31145 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I2a78651593323e8b9627c39918d949a33497b70f Gerrit-Change-Number: 31145 Gerrit-PatchSet: 24 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 07 Mar 2023 13:57:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-gsm-manuals[master]: publish: make sure OSMO_REPOSITORY isn't default
by osmith 07 Mar '23

07 Mar '23

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/31726 ) Change subject: publish: make sure OSMO_REPOSITORY isn't default ...................................................................... publish: make sure OSMO_REPOSITORY isn't default Instead of checking whether OSMO_REPOSITORY is empty, check if it has the default value of "osmo-gsm-manuals" and print a meaningful error if that is the case. Otherwise it leads to manuals getting uploaded into an "osmo-gsm-manuals" directory. Related: OS#5902 Change-Id: Ie21d58dd57a893a83f566eea464ab3eec82b67a4 --- M build/Makefile.common.inc 1 file changed, 24 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals refs/changes/26/31726/1 diff --git a/build/Makefile.common.inc b/build/Makefile.common.inc index a9a8ddf..28a607f 100644 --- a/build/Makefile.common.inc +++ b/build/Makefile.common.inc @@ -30,7 +30,15 @@ distclean: clean publish: $(UPLOAD_FILES) - [ -n "$(OSMO_REPOSITORY)" ] || exit 1 + @if [ "$(OSMO_REPOSITORY)" = "osmo-gsm-manuals" ]; then \ + echo; \ + echo "ERROR: set OSMO_REPOSITORY to the project name (e.g. osmo-hlr)" \ + "before including Makefile.common.inc."; \ + echo "This will be the name of the directory here:" \ + "https://downloads.osmocom.org/docs/"; \ + echo; \ + exit 1; \ + fi rm -rf "$(PUBLISH_TEMPDIR)" mkdir -p "$(PUBLISH_TEMPDIR)/$(OSMO_REPOSITORY)/$(PUBLISH_REF)" cp $(UPLOAD_FILES) "$(PUBLISH_TEMPDIR)/$(OSMO_REPOSITORY)/$(PUBLISH_REF)" -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/31726 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: Ie21d58dd57a893a83f566eea464ab3eec82b67a4 Gerrit-Change-Number: 31726 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-bsc[master]: pcu_sock: only allow Ericsson RBS to connect to external PCU
by dexter 07 Mar '23

07 Mar '23

Attention is currently required from: laforge, fixeria. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31687 ) Change subject: pcu_sock: only allow Ericsson RBS to connect to external PCU ...................................................................... Patch Set 3: (1 comment) File src/osmo-bsc/pcu_sock.c: https://gerrit.osmocom.org/c/osmo-bsc/+/31687/comment/f5ca2a11_08aefea1 PS2, Line 964: return -EINVAL; > So when this condition is true, osmo-bsc would fail to start printing: […] Thanks. good idea! -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31687 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I18d190d661b06015419078382915c4606be01b04 Gerrit-Change-Number: 31687 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 07 Mar 2023 13:53:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0