March 2023 - gerrit-log - lists.osmocom.org

[M] Change in osmo-msc[master]: [codecs filter] use filter result in MT DTAP CC Setup
by pespin 07 Mar '23

07 Mar '23

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/31697 ) Change subject: [codecs filter] use filter result in MT DTAP CC Setup ...................................................................... Patch Set 3: Code-Review+1 (1 comment) File src/libmsc/gsm_04_08_cc.c: https://gerrit.osmocom.org/c/osmo-msc/+/31697/comment/b764ba47_307794ca PS3, Line 727: * finding a matching codec. */ > no, not yet. […] Regarding your 2nd paragraph (MGW telling MSC which transcoding matches it support), I think the idea behind having an MGW is precisely not needing to worry about that, as in the MGW should in theory be capable of transcoding whatever you throw at it. Whatever limitations our MGW has in transcoding/handling different codecs on each conn side, it means we need to add some hacky code in our client to avoid those imho, nothing more. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/31697 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I9586221ef56352b7ce4b2604ae0dc04554145a78 Gerrit-Change-Number: 31697 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 07 Mar 2023 17:05:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[M] Change in osmo-msc[master]: [codecs filter] use filter result in Assignment
by pespin 07 Mar '23

07 Mar '23

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/30126 ) Change subject: [codecs filter] use filter result in Assignment ...................................................................... Patch Set 4: (1 comment) File src/libmsc/gsm_04_08_cc.c: https://gerrit.osmocom.org/c/osmo-msc/+/30126/comment/d53fd5b4_bc0e3fc1 PS4, Line 1797: codec_filter_run(&trans->cc.codecs); > Previously we discussed that codec_filter_run() should be called just before its result is used. […] I think that was an unconclusive discussion, and probably I was not really happy about that 😊 What's the point in calling that function (which I guess is quite expensive) every time you need to use the result, instead of calling it when you *modify* the inputs? -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/30126 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I66e7c8c5e401f4f3a7d3d42b9525b2c6e99691d9 Gerrit-Change-Number: 30126 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 07 Mar 2023 17:01:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-bts[master]: pcu_sock: Submit all DATA.ind regardless of link quality
by pespin 07 Mar '23

07 Mar '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/31731 ) Change subject: pcu_sock: Submit all DATA.ind regardless of link quality ...................................................................... pcu_sock: Submit all DATA.ind regardless of link quality osmo-pcu requires to get DATA.ind for all FN/TS it manages in order to tick its internal FN clock and trigger timeouts. Without this, some events are ticked in a delay fashion when osmo-pcu detects FN jumps. Change-Id: I8f1856dd9061c1bfca8b15be30df7a51760231b0 --- M src/common/pcu_sock.c 1 file changed, 13 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/31/31731/1 diff --git a/src/common/pcu_sock.c b/src/common/pcu_sock.c index 7e87f6d..849f3c3 100644 --- a/src/common/pcu_sock.c +++ b/src/common/pcu_sock.c @@ -475,12 +475,6 @@ LOGP(DPCU, LOGL_DEBUG, "Sending data indication: sapi=%s arfcn=%d block=%d data=%s\n", sapi_string[sapi], arfcn, block_nr, osmo_hexdump(data, len)); - if (lqual < bts->min_qual_norm) { - LOGP(DPCU, LOGL_DEBUG, "Link quality %"PRId16" is below threshold %d, dropping packet\n", - lqual, bts->min_qual_norm); - return 0; - } - msg = pcu_msgb_alloc(PCU_IF_MSG_DATA_IND, bts->nr); if (!msg) return -ENOMEM; -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31731 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I8f1856dd9061c1bfca8b15be30df7a51760231b0 Gerrit-Change-Number: 31731 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-pcu[master]: tbf_ul_fm: Allow receiving event TBF_EV_MAX_N3105 in state RELEASING
by pespin 07 Mar '23

07 Mar '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31730 ) Change subject: tbf_ul_fm: Allow receiving event TBF_EV_MAX_N3105 in state RELEASING ...................................................................... tbf_ul_fm: Allow receiving event TBF_EV_MAX_N3105 in state RELEASING Change-Id: I8560293d7b0f3bfefc1641208196404bc4848bfd --- M src/tbf_ul_fsm.c 1 file changed, 18 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/30/31730/1 diff --git a/src/tbf_ul_fsm.c b/src/tbf_ul_fsm.c index 571c689..cbfe634 100644 --- a/src/tbf_ul_fsm.c +++ b/src/tbf_ul_fsm.c @@ -279,7 +279,13 @@ static void st_releasing(struct osmo_fsm_inst *fi, uint32_t event, void *data) { - OSMO_ASSERT(0); + switch (event) { + case TBF_EV_MAX_N3105: + /* This may be received here if the TBF had several polls + * allocated concurrently and several failed each increasing N3105 + * over MAX_N3015. We are already releasing, ignore.*/ + break; + } } static int tbf_ul_fsm_timer_cb(struct osmo_fsm_inst *fi) @@ -351,7 +357,8 @@ .action = st_finished, }, [TBF_ST_RELEASING] = { - .in_event_mask = 0, + .in_event_mask = + X(TBF_EV_MAX_N3105), .out_state_mask = 0, .name = "RELEASING", -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31730 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I8560293d7b0f3bfefc1641208196404bc4848bfd Gerrit-Change-Number: 31730 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[M] Change in osmo-msc[master]: [codecs filter] use filter result in Assignment
by neels 07 Mar '23

07 Mar '23

Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/30126 ) Change subject: [codecs filter] use filter result in Assignment ...................................................................... Patch Set 4: (2 comments) File src/libmsc/gsm_04_08_cc.c: https://gerrit.osmocom.org/c/osmo-msc/+/30126/comment/04057ece_68c8a16d PS4, Line 1797: codec_filter_run(&trans->cc.codecs); > why does this need to be called here? I see no codec being changed before it? Previously we discussed that codec_filter_run() should be called just before its result is used. That is what this is doing. File src/libmsc/msc_a.c: https://gerrit.osmocom.org/c/osmo-msc/+/30126/comment/48f430ac_38f53665 PS4, Line 1826: /* Make sure an MGW endpoint towards RAN is present, and when the RTP to RAN is set up, an Assignment Request is > not sure what this comment is about. […] yeah i'm not sure either =) I think it should be a lot shorter. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/30126 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I66e7c8c5e401f4f3a7d3d42b9525b2c6e99691d9 Gerrit-Change-Number: 30126 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 07 Mar 2023 16:48:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[M] Change in osmo-bsc[master]: pcu_sock: handle multiple BTSs with one BSC co-located PCU (in theory)
by laforge 07 Mar '23

07 Mar '23

Attention is currently required from: neels, pespin, dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31618 ) Change subject: pcu_sock: handle multiple BTSs with one BSC co-located PCU (in theory) ...................................................................... Patch Set 9: Code-Review+1 (1 comment) File src/osmo-bsc/bts_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/31618/comment/0a676642_383ebfa8 PS9, Line 2198: "Path in the file system for the unix-domain PCU socket\n", normally we need to add a backwards compatibility VTY command to not break old config files. However, given that we did never really officially support BSC-colocated PCU setups, and we are not aware of any users, we can get away with it this time. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31618 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I0b42c2c130106f6ffca2dd08d079e1a7bda41f0b Gerrit-Change-Number: 31618 Gerrit-PatchSet: 9 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 07 Mar 2023 16:48:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XL] Change in osmo-pcu[master]: support for Ericsson RBS E1 CCU
by laforge 07 Mar '23

07 Mar '23

Attention is currently required from: neels, fixeria, dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31176 ) Change subject: support for Ericsson RBS E1 CCU ...................................................................... Patch Set 25: (1 comment) File contrib/osmo-pcu.spec.in: https://gerrit.osmocom.org/c/osmo-pcu/+/31176/comment/13fe09fb_74bbeb93 PS24, Line 49: configure > Done not yet resolved, looks like only the spec file was updated, but not the debian packaging? -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31176 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I5c0a76667339ca984a12cbd2052f5d9e5b0f9c4d Gerrit-Change-Number: 31176 Gerrit-PatchSet: 25 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 07 Mar 2023 16:46:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[M] Change in osmo-msc[master]: [codecs filter] use filter result in MT DTAP CC Setup
by neels 07 Mar '23

07 Mar '23

Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/31697 ) Change subject: [codecs filter] use filter result in MT DTAP CC Setup ...................................................................... Patch Set 3: (2 comments) File src/libmsc/gsm_04_08_cc.c: https://gerrit.osmocom.org/c/osmo-msc/+/31697/comment/9ea88aca_87fc01c2 PS3, Line 711: .speech_ver = { -1 }, > everything is starting to be full of magic values (-1). some UNSET defines would be great. this is still speech_ver = -1, it is definitely not "everything full of", maybe you can dial back your wording a little https://gerrit.osmocom.org/c/osmo-msc/+/31697/comment/d89bd1ed_859e5e12 PS3, Line 727: * finding a matching codec. */ > but we can actually do some transoding already, like AMR BWE<->OA and AMR<->IuUP. […] no, not yet. Intelligently selecting conversions between codecs is a bit more complex, let's tackle that a bit later. So far the codecs filter is all about: what codec shall we use on the MGW <-> CN RTP leg. (And so far it needs to match the RAN <-> MGW leg) The main open point is: should osmo-msc really have knowledge about what can be converted to what. Because then we need to update the osmo-msc config (or hardcoded) prior knowlede about what the MGW is able to do. What would be really good: if the MGW can *tell us dynamically* which codecs translations it is able to do. Maybe in the CRCX or MDCX we can send codecs, and in the OK response the MGW lists all compatible codecs?? Not sure yet. Also i haven't finished figuring out the AMR OA vs BE modes really. IIRC I always force to OA=1 in SDP sent out, but accept BE in SDP coming in from SIP... I tried to make sense of it but time is running out. So far osmo_mgcp_client can't even send OA and BE at the same time in one MGCP message, so there's a whole other construction site there. Also i haven't finished figuring out the SDP AMR mode-set picking AMR rates, and how to marry that up to the GSM representation of allowed modes (S0-S15 bits). So far we just plug any AMR into any other AMR and hope for the best, and we also just override 3G RAN with IUFP and handwavy magic hopefully happens in osmo-mgw. I guess we still need a quite complex code compatibility/translatability section. This patch series has the aim to match up identical codecs, only (plus sneak in IuUP<->AMR somehow). Even that basic 1:1 codec matching ability is still completely missing from osmo-msc master, so that is the first step. Proper translation shall follow later, haven't written anything for that yet. For 3G I have this way with ran_msg returning AMR because we urgently need the translation for 3G<->2G now, but it's not really how i want to do it for everything else in the future. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/31697 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I9586221ef56352b7ce4b2604ae0dc04554145a78 Gerrit-Change-Number: 31697 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 07 Mar 2023 16:45:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[M] Change in osmo-msc[master]: in ran_msg, return gsm0808_speech_codec (inter-MSC)
by laforge 07 Mar '23

07 Mar '23

Attention is currently required from: neels, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/31696 ) Change subject: in ran_msg, return gsm0808_speech_codec (inter-MSC) ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/31696 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I9c649f98738a55b8637ae600d5cdf81099fd08e5 Gerrit-Change-Number: 31696 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 07 Mar 2023 16:42:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-msc[master]: in ran_msg, return gsm0808_speech_codec (intra-MSC)
by laforge 07 Mar '23

07 Mar '23

Attention is currently required from: neels, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/31695 ) Change subject: in ran_msg, return gsm0808_speech_codec (intra-MSC) ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/31695 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ia666cb697fbd140d7239089628faed93860ce671 Gerrit-Change-Number: 31695 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 07 Mar 2023 16:42:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0