March 2023 - gerrit-log - lists.osmocom.org

[S] Change in libosmo-pfcp[master]: libosmo-pfcp.pc: move libosmogsm to Requires
by laforge 14 Mar '23

14 Mar '23

Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/31760 ) Change subject: libosmo-pfcp.pc: move libosmogsm to Requires ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > I would like to know how and why something fails before blindly doing workarounds. […] so libosmo-pfcp.so is not linked against libosmogsm.so: The output of "ldd /usr/local/lib/libosmo-pfcp.so" shows: linux-vdso.so.1 (0x00007fffe8937000) libasan.so.8 => /lib/x86_64-linux-gnu/libasan.so.8 (0x00007f1af2000000) libubsan.so.1 => /lib/x86_64-linux-gnu/libubsan.so.1 (0x00007f1af1800000) libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007f1af161f000) libm.so.6 => /lib/x86_64-linux-gnu/libm.so.6 (0x00007f1af2bd7000) libgcc_s.so.1 => /lib/x86_64-linux-gnu/libgcc_s.so.1 (0x00007f1af2bb7000) libstdc++.so.6 => /lib/x86_64-linux-gnu/libstdc++.so.6 (0x00007f1af1400000) /lib64/ld-linux-x86-64.so.2 (0x00007f1af2cf1000) -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/31760 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: I319173c1fab068dfe1361ae6cd02f729461d4cf8 Gerrit-Change-Number: 31760 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 Mar 2023 20:19:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: msc fix log typo
by neels 14 Mar '23

14 Mar '23

neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31706 ) Change subject: msc fix log typo ...................................................................... msc fix log typo Change-Id: Id6767c5e7f00ad7e44c569dcba1a56e2717d2e1a --- M msc/MSC_Tests.ttcn 1 file changed, 10 insertions(+), 1 deletion(-) Approvals: pespin: Looks good to me, approved msuraev: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn index 36fe1eb..a571fc0 100644 --- a/msc/MSC_Tests.ttcn +++ b/msc/MSC_Tests.ttcn @@ -1816,7 +1816,7 @@ } [] MNCC.receive(tr_MNCC_DISC_ind(cpars.mncc_callref)) { MNCC.send(ts_MNCC_REL_req(cpars.mncc_callref, valueof(ts_MNCC_cause(23)))); - log("Rx MNCC DISC.ind, T310.read yelds ", T310.read); + log("Rx MNCC DISC.ind, T310.read yields ", T310.read); setverdict(pass); } [] MNCC.receive(MNCC_PDU:?) -> value mncc_rx { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31706 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id6767c5e7f00ad7e44c569dcba1a56e2717d2e1a Gerrit-Change-Number: 31706 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-ttcn3-hacks[master]: msc: TC_mt_t310: fix an interleave
by neels 14 Mar '23

14 Mar '23

neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31707 ) Change subject: msc: TC_mt_t310: fix an interleave ...................................................................... msc: TC_mt_t310: fix an interleave the MNCC.receive doesn't depend on the MGCP really. Change-Id: If29e755c2c061836ce2ba472e44a621eadba4fc6 --- M msc/MSC_Tests.ttcn 1 file changed, 13 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve msuraev: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn index a571fc0..0372ec7 100644 --- a/msc/MSC_Tests.ttcn +++ b/msc/MSC_Tests.ttcn @@ -1797,8 +1797,9 @@ /* MSC->MGW: CRCX (second) */ [] MGCP.receive(tr_CRCX) -> value mgcp_cmd { f_handle_crcx(cpars, mgcp_cmd); /* MSC<-MGW: OK */ - MNCC.receive(tr_MNCC_RTP_CREATE(cpars.mncc_callref)); } + + [] MNCC.receive(tr_MNCC_RTP_CREATE(cpars.mncc_callref)); } /* Reschedule the guard timeout */ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31707 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If29e755c2c061836ce2ba472e44a621eadba4fc6 Gerrit-Change-Number: 31707 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-ttcn3-hacks[master]: msc: CC Re-Est: allow MNCC_RTP_CREATE upon Assgmt
by neels 14 Mar '23

14 Mar '23

neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31708 ) Change subject: msc: CC Re-Est: allow MNCC_RTP_CREATE upon Assgmt ...................................................................... msc: CC Re-Est: allow MNCC_RTP_CREATE upon Assgmt In f_tc_call_re_establishment_2(), after Assignment Complete, optionally allow an MNCC_RTP_CREATE. When Re-Establishing a call, the Assignment Complete usually affects codec and RTP address, so an MNCC_RTP_CREATE should happen after the Assignment Complete message. Current osmo-msc master does not send this MNCC_RTP_CREATE. This is unlikely to be correct (would be ok if no RTP port changes), likely omitted due to a bug. An upcoming patch adds the MNCC_RTP_CREATE in Call Re-Establishment to osmo-msc. Related: Ie433db1ba0c46d4b97538a969233c155cefac21c (osmo-msc) Change-Id: I06d19947ba2e9b6696269db0e4f3d47d4b98bde6 --- M msc/MSC_Tests.ttcn 1 file changed, 31 insertions(+), 0 deletions(-) Approvals: neels: Looks good to me, approved Jenkins Builder: Verified diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn index 0372ec7..1767761 100644 --- a/msc/MSC_Tests.ttcn +++ b/msc/MSC_Tests.ttcn @@ -6670,6 +6670,10 @@ vc_conn.done; } +private altstep as_mncc_rx_rtp_create(CallParameters cpars) runs on BSC_ConnHdlr { + [] MNCC.receive(tr_MNCC_RTP_CREATE(cpars.mncc_callref)); +} + const charstring REEST_LOST_CONNECTION := "REEST_LOST_CONNECTION"; const charstring REEST_CLEARED := "REEST_CLEARED"; @@ -6734,12 +6738,15 @@ * Apparently osmo-msc currently also sends an MDCX to the CN side, just repeating the same configuration that * is already in use. This test accepts any number of or even lack of MDCX. */ var default ack_mdcx := activate(as_mgcp_ack_all_mdcx(cpars)); + var default optional_rtp_create := activate(as_mncc_rx_rtp_create(cpars)); BSSAP.send(ts_BSSMAP_AssignmentComplete(omit, tla, codec)); + /* The call has been fully re-established. * Let a bit of time pass before hanging up, for everything to settle. */ f_sleep(3.0); + deactivate(optional_rtp_create); deactivate(ack_mdcx); /* Hang up the call and clear the new, second A connection */ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31708 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I06d19947ba2e9b6696269db0e4f3d47d4b98bde6 Gerrit-Change-Number: 31708 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-ttcn3-hacks[master]: msc: CC Re-Est: allow MNCC_RTP_CREATE upon Assgmt
by neels 14 Mar '23

14 Mar '23

Attention is currently required from: msuraev. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31708 ) Change subject: msc: CC Re-Est: allow MNCC_RTP_CREATE upon Assgmt ...................................................................... Patch Set 3: Code-Review+2 (2 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31708/comment/94bf95b5_b95d… PS2, Line 16: Current osmo-msc master does not send this MNCC_RTP_CREATE. This is is > typo: is is Done Patchset: PS3: re-add votes after commit log tweak -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31708 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I06d19947ba2e9b6696269db0e4f3d47d4b98bde6 Gerrit-Change-Number: 31708 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 Mar 2023 20:17:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in libosmocore[master]: error log: osmo_sock_init2_multiaddr() v4/v6 mix
by neels 14 Mar '23

14 Mar '23

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31771 ) Change subject: error log: osmo_sock_init2_multiaddr() v4/v6 mix ...................................................................... Patch Set 2: (1 comment) File src/core/socket.c: https://gerrit.osmocom.org/c/libosmocore/+/31771/comment/9f9a65ab_030d0e02 PS1, Line 776: ((flags & OSMO_SOCK_F_BIND) && (flags & OSMO_SOCK_F_CONNECT)) && : !addrinfo_has_in6addr_any((const struct addrinfo **)res_loc, local_hosts_cnt) && : (loc_has_v4addr != rem_has_v4addr || loc_has_v6addr != rem_has_v6addr)) { > general note about this (unrelated to the patch): It appeasr to ignore IPv4-mapped IPv6 addresses (h […] i guess we need a new issue for this if it shouldn't be forgotten in this comment... -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31771 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0fd12b08e0788ce3af6dc519ff8c82ad196a115f Gerrit-Change-Number: 31771 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 Mar 2023 20:15:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

1 0

[S] Change in libosmocore[master]: error log: osmo_sock_init2_multiaddr() v4/v6 mix
by neels 14 Mar '23

14 Mar '23

neels has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31771 ) Change subject: error log: osmo_sock_init2_multiaddr() v4/v6 mix ...................................................................... error log: osmo_sock_init2_multiaddr() v4/v6 mix Provide some more information for the error case when local and remote addresses mix v4 and v6. Change-Id: I0fd12b08e0788ce3af6dc519ff8c82ad196a115f --- M src/core/socket.c M tests/socket/socket_sctp_test.err 2 files changed, 21 insertions(+), 5 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/core/socket.c b/src/core/socket.c index 9e0f84e..1b14794 100644 --- a/src/core/socket.c +++ b/src/core/socket.c @@ -776,7 +776,11 @@ if (((flags & OSMO_SOCK_F_BIND) && (flags & OSMO_SOCK_F_CONNECT)) && !addrinfo_has_in6addr_any((const struct addrinfo **)res_loc, local_hosts_cnt) && (loc_has_v4addr != rem_has_v4addr || loc_has_v6addr != rem_has_v6addr)) { - LOGP(DLGLOBAL, LOGL_ERROR, "Invalid v4 vs v6 in local vs remote addresses\n"); + LOGP(DLGLOBAL, LOGL_ERROR, "Invalid v4 vs v6 in local vs remote addresses: " + "local:%s%s remote:%s%s\n", + loc_has_v4addr ? " v4" : "", loc_has_v6addr ? " v6" : "", + rem_has_v4addr ? " v4" : "", rem_has_v6addr ? " v6" : "" + ); rc = -EINVAL; goto ret_freeaddrinfo; } diff --git a/tests/socket/socket_sctp_test.err b/tests/socket/socket_sctp_test.err index 996d092..7583a2a 100644 --- a/tests/socket/socket_sctp_test.err +++ b/tests/socket/socket_sctp_test.err @@ -1,8 +1,8 @@ invalid: you have to specify either BIND or CONNECT flags -Invalid v4 vs v6 in local vs remote addresses -Invalid v4 vs v6 in local vs remote addresses +Invalid v4 vs v6 in local vs remote addresses: local: v4 remote: v6 +Invalid v4 vs v6 in local vs remote addresses: local: v6 remote: v4 invalid: you have to specify either BIND or CONNECT flags -Invalid v4 vs v6 in local vs remote addresses -Invalid v4 vs v6 in local vs remote addresses +Invalid v4 vs v6 in local vs remote addresses: local: v4 remote: v6 +Invalid v4 vs v6 in local vs remote addresses: local: v6 remote: v4 getaddrinfo(::1, 0) failed: Address family for hostname not supported getaddrinfo(127.0.0.1, 0) failed: Address family for hostname not supported -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31771 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0fd12b08e0788ce3af6dc519ff8c82ad196a115f Gerrit-Change-Number: 31771 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-cbc[master]: tests: use -no-install libtool flag to avoid ./lt-* scripts
by laforge 14 Mar '23

14 Mar '23

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/31834 ) Change subject: tests: use -no-install libtool flag to avoid ./lt-* scripts ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/31834 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I405b5e85113e9529b4491c7eeeec71afe25ef488 Gerrit-Change-Number: 31834 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 Mar 2023 20:13:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libsmpp34[master]: binaries/Makefile.am: libraries shall not be in AM_LDFLAGS
by laforge 14 Mar '23

14 Mar '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libsmpp34/+/31779 ) Change subject: binaries/Makefile.am: libraries shall not be in AM_LDFLAGS ...................................................................... binaries/Makefile.am: libraries shall not be in AM_LDFLAGS Change-Id: I7258743969f5d3ac85dfb887ee1729cff8a910b6 --- M binaries/Makefile.am 1 file changed, 10 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve msuraev: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/binaries/Makefile.am b/binaries/Makefile.am index 9fd565e..71997b8 100644 --- a/binaries/Makefile.am +++ b/binaries/Makefile.am @@ -9,9 +9,8 @@ include $(top_srcdir)/test_apps/Makefile.am include $(top_srcdir)/src/Makefile.am -LDADD = libsmpp34.la +LDADD = libsmpp34.la -lrt -lpthread AM_CPPFLAGS = -D_REENTRANT -DBSD_COMP -D_POSIX_PTHREAD_SEMANTICS AM_CFLAGS = @CFLAGS@ -Wall -fPIC # -static INCLUDES = -I$(top_srcdir)/src -I$(top_srcdir) -AM_LDFLAGS = -lrt -lpthread OBJ_EXTRA_DIST = $(esme_EXTRA_DIST) -- To view, visit https://gerrit.osmocom.org/c/libsmpp34/+/31779 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libsmpp34 Gerrit-Branch: master Gerrit-Change-Id: I7258743969f5d3ac85dfb887ee1729cff8a910b6 Gerrit-Change-Number: 31779 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in libsmpp34[master]: binaries/Makefile.am: libraries shall not be in AM_LDFLAGS
by laforge 14 Mar '23

14 Mar '23

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libsmpp34/+/31779 ) Change subject: binaries/Makefile.am: libraries shall not be in AM_LDFLAGS ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libsmpp34/+/31779 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libsmpp34 Gerrit-Branch: master Gerrit-Change-Id: I7258743969f5d3ac85dfb887ee1729cff8a910b6 Gerrit-Change-Number: 31779 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 Mar 2023 20:13:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0