March 2023 - gerrit-log - lists.osmocom.org

[S] Change in libosmo-pfcp[master]: build: fix linking gen__pfcp_ies_auto to use build-tree libosmo-gtlv
by fixeria 14 Mar '23

14 Mar '23

Attention is currently required from: neels, laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/31741 ) Change subject: build: fix linking gen__pfcp_ies_auto to use build-tree libosmo-gtlv ...................................................................... Patch Set 4: Code-Review+1 (3 comments) Commit Message: https://gerrit.osmocom.org/c/libosmo-pfcp/+/31741/comment/e6dfeb5e_380fc298 PS3, Line 15: used > use Done File src/libosmo-pfcp/Makefile.am: https://gerrit.osmocom.org/c/libosmo-pfcp/+/31741/comment/7e11e922_d7912021 PS1, Line 68: gen__pfcp_ies_auto_LDFLAGS > for the record: fixeria is correct; LDFLAGS and LIBS are separate things, and have always been for a […] Done File src/libosmo-pfcp/Makefile.am: https://gerrit.osmocom.org/c/libosmo-pfcp/+/31741/comment/0963da43_14a3101c PS3, Line 71: COVERAGE_LDFLAGS > This does not belong here and should be done in https://gerrit.osmocom.org/c/libosmo-pfcp/+/31761. Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/31741 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: I2e92238b214d8e79bab1095d6093139bad05bc66 Gerrit-Change-Number: 31741 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 Mar 2023 20:43:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in libosmo-pfcp[master]: build: libosmo-gtlv: move LIBS to libosmo_gtlv_la_LIBADD
by fixeria 14 Mar '23

14 Mar '23

Attention is currently required from: neels. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/31762 ) Change subject: build: libosmo-gtlv: move LIBS to libosmo_gtlv_la_LIBADD ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File src/libosmo-gtlv/Makefile.am: https://gerrit.osmocom.org/c/libosmo-pfcp/+/31762/comment/bc23b4f4_7128ff66 PS1, Line 14: LIBOSMOCORE_LIBS > I think you still want `libosmo-gtlv.la` to depend on libosmocore, right? […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/31762 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: I6fd777bed9366c35f5b1453cde1e6f5c1617e338 Gerrit-Change-Number: 31762 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 Mar 2023 20:42:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in libosmo-pfcp[master]: build: drop LIBOSMOVTY from libosmo-pfcp
by fixeria 14 Mar '23

14 Mar '23

Attention is currently required from: neels. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/31917 ) Change subject: build: drop LIBOSMOVTY from libosmo-pfcp ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/31917 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: I8c772386ee7c6d035aabbc854fadbbcde03f7d33 Gerrit-Change-Number: 31917 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 Mar 2023 20:41:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libosmo-pfcp[master]: libosmo-pfcp.pc: move libosmogsm to Requires
by neels 14 Mar '23

14 Mar '23

Attention is currently required from: laforge. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/31760 ) Change subject: libosmo-pfcp.pc: move libosmogsm to Requires ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > So in libosmoi-pfcp/Makefile.am you are […] I hope this new patch set fixes the real problem: https://gerrit.osmocom.org/c/libosmo-pfcp/+/31741/4 (and that i can abandon this patch then) -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/31760 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: I319173c1fab068dfe1361ae6cd02f729461d4cf8 Gerrit-Change-Number: 31760 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 14 Mar 2023 20:38:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

1 0

[M] Change in osmo-ttcn3-hacks[master]: hnbgw: add f_rua_expect()
by neels 14 Mar '23

14 Mar '23

Attention is currently required from: laforge. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31765 ) Change subject: hnbgw: add f_rua_expect() ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > I completely agree with the flexibility of altsteps -- however, for example in f_iu2iuh() we want to […] i'm looking more closely which callers actually use the return value, apparently almost none. good to use altsteps where the returned value is never used. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31765 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I29e6b7659ba53efee9f676197b502f79780ead7e Gerrit-Change-Number: 31765 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 14 Mar 2023 20:30:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

1 0

[M] Change in osmo-ttcn3-hacks[master]: hnbgw: add f_rua_expect()
by neels 14 Mar '23

14 Mar '23

Attention is currently required from: laforge. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31765 ) Change subject: hnbgw: add f_rua_expect() ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > I'm not sure if this is really best handled in a function. […] I completely agree with the flexibility of altsteps -- however, for example in f_iu2iuh() we want to return the received RUA message. An altstep cannot have a return value, so that's a bummer. Also it seems we cannot use a "-> value msg" syntax with "[] as_rua_expect()". So the only way I see is have code dup, once as f_foo_expect() returning the received message, and once as as_foo_expect() without a return value? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31765 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I29e6b7659ba53efee9f676197b502f79780ead7e Gerrit-Change-Number: 31765 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 14 Mar 2023 20:28:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

1 0

[S] Change in libosmo-pfcp[master]: libosmo-pfcp.pc: move libosmogsm to Requires
by laforge 14 Mar '23

14 Mar '23

Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/31760 ) Change subject: libosmo-pfcp.pc: move libosmogsm to Requires ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > And indeed, the linker command while building libosmo-pfcp seems to be: […] So in libosmoi-pfcp/Makefile.am you are * including LIBOSMOGSM_LIBS in AM_LDFLAGS (where it doesn't belong, but let's set that aside for now) * then overriding those flags by using libosmo_pfcp_la_LDFLAGS *without* including LDFLAGS. So all other programs/libraries/targets (that don't have a prog_name_LDFLAGS) will be linked against libosmocore, but not the library itself As a result, you have a library that depens on other librarires, but which doesn't express this dependency to the dynamic linker at runtime. pkg-config can't fix that. pkg-config is just metadata for easy discovery of linker flags / cflags, and it has to assume the libraries are correctly linked in the first place. -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/31760 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: I319173c1fab068dfe1361ae6cd02f729461d4cf8 Gerrit-Change-Number: 31760 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 Mar 2023 20:25:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

1 0

[S] Change in libosmo-pfcp[master]: libosmo-pfcp.pc: move libosmogsm to Requires
by laforge 14 Mar '23

14 Mar '23

Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/31760 ) Change subject: libosmo-pfcp.pc: move libosmogsm to Requires ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > so libosmo-pfcp.so is not linked against libosmogsm.so: […] And indeed, the linker command while building libosmo-pfcp seems to be: libtool: link: gcc -shared -fPIC -DPIC .libs/pfcp_endpoint.o .libs/pfcp_ies_custom.o .libs/pfcp_msg.o .libs/pfcp_strs.o .libs/pfcp_cp_peer.o .libs/pfcp_ies_auto.o -fsanitize=address -fsanitize=undefined -pthread -Wl,-soname -Wl,libosmo-pfcp.so.0 -Wl,-version-script -Wl,.libs/libosmo-pfcp.ver -o .libs/libosmo-pfcp.so.0.1.0 - no -losmogsm in that linker command! -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/31760 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: I319173c1fab068dfe1361ae6cd02f729461d4cf8 Gerrit-Change-Number: 31760 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 Mar 2023 20:21:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: msc: TC_mt_t310: avoid sporadic failure from X2 timeout
by neels 14 Mar '23

14 Mar '23

neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31710 ) Change subject: msc: TC_mt_t310: avoid sporadic failure from X2 timeout ...................................................................... msc: TC_mt_t310: avoid sporadic failure from X2 timeout Change-Id: Ic23cbca5775031dcb0ea1744454e20cda090701c --- M msc/MSC_Tests.ttcn 1 file changed, 13 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve msuraev: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn index 1767761..0490901 100644 --- a/msc/MSC_Tests.ttcn +++ b/msc/MSC_Tests.ttcn @@ -1766,6 +1766,10 @@ f_init_handler(pars); + /* Make sure X2 does not fire in this test. This test does not send a CN RTP port to osmo-msc, which will + * trigger X2 timeout. We want to test T310, so make X2 significantly longer than T310=30s. */ + f_vty_config(MSCVTY, "msc", "timer mgw X2 40"); + /* Initiate a MT call, establish connection */ f_mt_call_start(cpars); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31710 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic23cbca5775031dcb0ea1744454e20cda090701c Gerrit-Change-Number: 31710 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[M] Change in osmo-ttcn3-hacks[master]: msc: detect RTP to CN failure in call tests
by neels 14 Mar '23

14 Mar '23

neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31711 ) Change subject: msc: detect RTP to CN failure in call tests ...................................................................... msc: detect RTP to CN failure in call tests When CN RTP is missing, the X2 timer will fire after all other call signalling looks successful. So far we establish an MT call, wait three seconds and directly disconnect, long before X2 or X2427 can fire. Make X2 shorter. (By means of f_vty_config() from ttcn, so that we don't need to edit various osmo-msc.cfg in various repositories. The short timer is always critical for the test to be accurate.) Add proper function to detect premature disconnect. Otherwise we just get a cryptic message like "Couldn't find MnccExpect for incoming call" because of MNCC messaging after the unexpected release event. Change-Id: I3ccf541360cc8440e664f0e29494b9ce7b6f8943 --- M msc/BSC_ConnectionHandler.ttcn M msc/MSC_Tests.ttcn 2 files changed, 54 insertions(+), 4 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve msuraev: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/msc/BSC_ConnectionHandler.ttcn b/msc/BSC_ConnectionHandler.ttcn index fe9187c..d96ae0b 100644 --- a/msc/BSC_ConnectionHandler.ttcn +++ b/msc/BSC_ConnectionHandler.ttcn @@ -1349,6 +1349,33 @@ setverdict(pass); } +function f_call_keep_open(inout CallParameters cpars, float open_time := 5.0) +runs on BSC_ConnHdlr { + log("Hold the call for some time"); + + timer T := open_time; + T.start; + alt { + [] MNCC.receive(tr_MNCC_DISC_ind(cpars.mncc_callref)); + [] MNCC.receive(tr_MNCC_REL_ind(cpars.mncc_callref)); + [] BSSAP.receive(tr_PDU_DTAP_MT(tr_ML3_MT_CC_DISC(cpars.transaction_id))); + [] BSSAP.receive(tr_PDU_DTAP_MT(tr_ML3_MT_CC_RELEASE(cpars.transaction_id))); + [] BSSAP.receive(RAN_Conn_Prim:MSC_CONN_PRIM_DISC_IND); + [] BSSAP.receive(tr_BSSMAP_ClearCommand); + [] BSSAP.receive(tr_BSSMAP_ClearCommandCSFB); + [] BSSAP.receive(tr_RANAP_IuReleaseCommand(?)); + + [] T.timeout { + log("Call stayed open for ", open_time, " seconds, all is well.") + setverdict(pass); + return; + } + } + + setverdict(fail, "An unexpected release event disconnected the active call prematurely"); + mtc.stop; +} + /* Reply to a received CRCX with an OK (or the reply configured in cpars), using the given parameters. * Return true when an OK reply was sent, false otherwise. * Count occurence of Osmux, include Osmux parameters in the reply if necessary. */ @@ -1797,8 +1824,7 @@ f_mt_call_establish(cpars); - log("Hold the call for some time"); - f_sleep(3.0); + f_call_keep_open(cpars); log("Hangup"); f_call_hangup(cpars, true); @@ -1811,8 +1837,7 @@ f_mo_call_establish(cpars); - log("Hold the call for some time"); - f_sleep(3.0); + f_call_keep_open(cpars); log("Hangup"); f_call_hangup(cpars, false); diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn index 0490901..8fc212c 100644 --- a/msc/MSC_Tests.ttcn +++ b/msc/MSC_Tests.ttcn @@ -324,6 +324,10 @@ f_vty_config(MSCVTY, "msc", "osmux off"); } + /* Configure the MGCP timeout so that a failure to set up all RTP streams triggers within the time that we keep + * an otherwise established call open. */ + f_vty_config(MSCVTY, "msc", "timer mgw X2 3"); + for (var integer i := 0; i < num_bsc; i := i + 1) { if (isbound(mp_bssap_cfg[i])) { var RanOps ranops := BSC_RanOps; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31711 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3ccf541360cc8440e664f0e29494b9ce7b6f8943 Gerrit-Change-Number: 31711 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0