March 2023 - gerrit-log - lists.osmocom.org

[M] Change in libosmocore[master]: New osmo-gsmtap-logsend utility
by keith 14 Mar '23

14 Mar '23

Attention is currently required from: laforge, keith. keith has uploaded a new patch set (#4) to the change originally created by laforge. ( https://gerrit.osmocom.org/c/libosmocore/+/31916 ) Change subject: New osmo-gsmtap-logsend utility ...................................................................... New osmo-gsmtap-logsend utility This utility can be used to "pipe" stdin or some file as log lines via GSMTAP logging. Change-Id: Ida96e87d84e0c349c5069edc67fec1c3cf19d1ab --- M debian/libosmocore-utils.install M utils/Makefile.am A utils/gsmtap-logsend.c 3 files changed, 155 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/16/31916/4 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31916 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ida96e87d84e0c349c5069edc67fec1c3cf19d1ab Gerrit-Change-Number: 31916 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: keith <keith(a)rhizomatica.org> Gerrit-MessageType: newpatchset

1 0

[M] Change in libosmocore[master]: New osmo-gsmtap-logsend utility
by keith 14 Mar '23

14 Mar '23

Attention is currently required from: laforge, keith. keith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31916 ) Change subject: New osmo-gsmtap-logsend utility ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31916 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ida96e87d84e0c349c5069edc67fec1c3cf19d1ab Gerrit-Change-Number: 31916 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: keith <keith(a)rhizomatica.org> Gerrit-Comment-Date: Tue, 14 Mar 2023 22:22:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-upf[master]: build: add libupf.la (noinst)
by neels 14 Mar '23

14 Mar '23

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-upf/+/31920 ) Change subject: build: add libupf.la (noinst) ...................................................................... build: add libupf.la (noinst) Like we do in osmo-bsc.git, gather the osmo-upf objects into a not-installed libupf.la, so that we can trivially and flexibly link these to regression test programs. Will be used by upcoming patch I36acff15f22d23ade4d281c2af3eb117dfc10359 (unique_ids_test). Change-Id: Id179a47b5d40821d86c7214add14449600198e07 --- M src/osmo-upf/Makefile.am 1 file changed, 32 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-upf refs/changes/20/31920/1 diff --git a/src/osmo-upf/Makefile.am b/src/osmo-upf/Makefile.am index d5e392b..be72bc2 100644 --- a/src/osmo-upf/Makefile.am +++ b/src/osmo-upf/Makefile.am @@ -18,19 +18,15 @@ $(NULL) AM_LDFLAGS = \ - $(LIBGTPNL_LDFLAGS) \ - $(LIBNFTNL_LDFLAGS) \ - $(LIBNFTABLES_LDFLAGS) \ $(COVERAGE_LDFLAGS) \ $(NULL) -bin_PROGRAMS = \ - osmo-upf \ +noinst_LTLIBRARIES = \ + libupf.la \ $(NULL) -osmo_upf_SOURCES = \ +libupf_la_SOURCES = \ netinst.c \ - osmo_upf_main.c \ up_endpoint.c \ up_gtp_action.c \ up_peer.c \ @@ -42,7 +38,7 @@ upf_vty.c \ $(NULL) -osmo_upf_LDADD = \ +libupf_la_LIBADD = \ $(LIBOSMOCORE_LIBS) \ $(LIBOSMOVTY_LIBS) \ $(LIBOSMOCTRL_LIBS) \ @@ -50,5 +46,16 @@ $(LIBGTPNL_LIBS) \ $(LIBNFTNL_LIBS) \ $(LIBNFTABLES_LIBS) \ - $(COVERAGE_LDFLAGS) \ + $(NULL) + +bin_PROGRAMS = \ + osmo-upf \ + $(NULL) + +osmo_upf_SOURCES = \ + osmo_upf_main.c \ + $(NULL) + +osmo_upf_LDADD = \ + libupf.la \ $(NULL) -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/31920 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Id179a47b5d40821d86c7214add14449600198e07 Gerrit-Change-Number: 31920 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-upf[master]: build: drop LIBOSMO_GTLV
by neels 14 Mar '23

14 Mar '23

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-upf/+/31919 ) Change subject: build: drop LIBOSMO_GTLV ...................................................................... build: drop LIBOSMO_GTLV After libosmo-gtlv was dropped from configure.ac in 22006ba039b26514ce194ccae924ecaa50bea89e, these $(LIBOSMO_GTLV_*) are empty anyway. Since we depend on libosmo-pfcp, there is no need to list libosmo-gtlv, which should be implicitly included. Change-Id: I3acd3d674e226b004101d65d47beacbbdeed0466 --- M src/osmo-pfcp-tool/Makefile.am M src/osmo-upf/Makefile.am 2 files changed, 16 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-upf refs/changes/19/31919/1 diff --git a/src/osmo-pfcp-tool/Makefile.am b/src/osmo-pfcp-tool/Makefile.am index 6c23d9f..a35c59a 100644 --- a/src/osmo-pfcp-tool/Makefile.am +++ b/src/osmo-pfcp-tool/Makefile.am @@ -10,7 +10,6 @@ $(LIBOSMOCORE_CFLAGS) \ $(LIBOSMOVTY_CFLAGS) \ $(LIBOSMOCTRL_CFLAGS) \ - $(LIBOSMOGTLV_CFLAGS) \ $(LIBOSMOPFCP_CFLAGS) \ $(COVERAGE_CFLAGS) \ $(NULL) @@ -19,7 +18,6 @@ $(LIBOSMOCORE_LIBS) \ $(LIBOSMOVTY_LIBS) \ $(LIBOSMOCTRL_LIBS) \ - $(LIBOSMOGTLV_LIBS) \ $(LIBOSMOPFCP_LIBS) \ $(COVERAGE_LDFLAGS) \ $(NULL) diff --git a/src/osmo-upf/Makefile.am b/src/osmo-upf/Makefile.am index 403fb06..d5e392b 100644 --- a/src/osmo-upf/Makefile.am +++ b/src/osmo-upf/Makefile.am @@ -10,7 +10,6 @@ $(LIBOSMOCORE_CFLAGS) \ $(LIBOSMOVTY_CFLAGS) \ $(LIBOSMOCTRL_CFLAGS) \ - $(LIBOSMOGTLV_CFLAGS) \ $(LIBOSMOPFCP_CFLAGS) \ $(LIBGTPNL_CFLAGS) \ $(LIBNFTNL_CFLAGS) \ @@ -47,7 +46,6 @@ $(LIBOSMOCORE_LIBS) \ $(LIBOSMOVTY_LIBS) \ $(LIBOSMOCTRL_LIBS) \ - $(LIBOSMOGTLV_LIBS) \ $(LIBOSMOPFCP_LIBS) \ $(LIBGTPNL_LIBS) \ $(LIBNFTNL_LIBS) \ -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/31919 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I3acd3d674e226b004101d65d47beacbbdeed0466 Gerrit-Change-Number: 31919 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[XL] Change in osmo-upf[master]: add unique_ids_test.c
by neels 14 Mar '23

14 Mar '23

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-upf/+/31482 to look at the new patch set (#4). Change subject: add unique_ids_test.c ...................................................................... add unique_ids_test.c Verify that skipping used IDs works for: - PFCP UP-SEID - GTP local TEID - chain_id for nft rulesets -- so far expected to fail, fix follows in I139b46de0bd15185a7a06109d55f7c759755ec81. Related: OS#5900 Change-Id: I36acff15f22d23ade4d281c2af3eb117dfc10359 --- M configure.ac M include/osmocom/upf/up_endpoint.h M include/osmocom/upf/up_session.h M include/osmocom/upf/upf.h M src/osmo-upf/up_endpoint.c M src/osmo-upf/up_peer.c M src/osmo-upf/up_session.c M src/osmo-upf/upf.c M src/osmo-upf/upf_nft.c M tests/Makefile.am M tests/testsuite.at A tests/unique_ids/Makefile.am A tests/unique_ids/unique_ids_test.c A tests/unique_ids/unique_ids_test.err A tests/unique_ids/unique_ids_test.ok 15 files changed, 1,092 insertions(+), 24 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-upf refs/changes/82/31482/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/31482 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I36acff15f22d23ade4d281c2af3eb117dfc10359 Gerrit-Change-Number: 31482 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-hnbgw[master]: tweak LOGHNB()
by neels 14 Mar '23

14 Mar '23

neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/31764 ) Change subject: tweak LOGHNB() ...................................................................... tweak LOGHNB() Add braces around context part. In the HNBGW_Tests.ttcn output, I see this: DRUA DEBUG TTCN3 HNodeB transmitting RUA DirectTransfer which reads like the hNodeB would transmit a RUA to us. Instead, this is us sending RUA to the hNodeB, which is much clearer like this: DRUA DEBUG (TTCN3 HNodeB) transmitting RUA DirectTransfer This matches the way we typically show context info in osmo logging. Change-Id: If6f0c3ae81c737b7488fa93c435179dcf27a5c94 --- M include/osmocom/hnbgw/hnbgw.h 1 file changed, 23 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/include/osmocom/hnbgw/hnbgw.h b/include/osmocom/hnbgw/hnbgw.h index 96a2ef3..1bf140a 100644 --- a/include/osmocom/hnbgw/hnbgw.h +++ b/include/osmocom/hnbgw/hnbgw.h @@ -24,7 +24,7 @@ }; #define LOGHNB(HNB_CTX, ss, lvl, fmt, args ...) \ - LOGP(ss, lvl, "%s " fmt, hnb_context_name(HNB_CTX), ## args) + LOGP(ss, lvl, "(%s) " fmt, hnb_context_name(HNB_CTX), ## args) enum hnb_ctrl_node { CTRL_NODE_HNB = _LAST_CTRL_NODE, -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/31764 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: If6f0c3ae81c737b7488fa93c435179dcf27a5c94 Gerrit-Change-Number: 31764 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-hnbgw[master]: debug log: log received RANAP message types on DCN, DHNB
by neels 14 Mar '23

14 Mar '23

neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/31770 ) Change subject: debug log: log received RANAP message types on DCN, DHNB ...................................................................... debug log: log received RANAP message types on DCN, DHNB Change-Id: Ib295e49f2c53164c5787002797145b3e6de5546b --- M src/osmo-hnbgw/context_map_rua.c M src/osmo-hnbgw/context_map_sccp.c 2 files changed, 26 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve neels: Looks good to me, approved diff --git a/src/osmo-hnbgw/context_map_rua.c b/src/osmo-hnbgw/context_map_rua.c index 674fc50..980fad2 100644 --- a/src/osmo-hnbgw/context_map_rua.c +++ b/src/osmo-hnbgw/context_map_rua.c @@ -128,8 +128,9 @@ } /* Dispatch RANAP message to SCCP, if any. */ -static int handle_rx_rua(struct hnbgw_context_map *map, struct msgb *ranap_msg) +static int handle_rx_rua(struct osmo_fsm_inst *fi, struct msgb *ranap_msg) { + struct hnbgw_context_map *map = fi->priv; int rc; if (!msg_has_l2_data(ranap_msg)) return 0; @@ -142,6 +143,9 @@ if (rc == 0) { talloc_set_destructor(message, destruct_ranap_cn_rx_co_ies); + LOGPFSML(fi, LOGL_DEBUG, "rx from RUA: RANAP %s\n", + get_value_string(ranap_procedure_code_vals, message->procedureCode)); + switch (message->procedureCode) { case RANAP_ProcedureCode_id_RAB_Assignment: /* mgw_fsm_handle_rab_ass_resp() takes ownership of prim->oph and (ranap) message */ @@ -156,6 +160,9 @@ if (rc == 0) { talloc_set_destructor(message, destruct_ranap_cn_rx_co_ies); + LOGPFSML(fi, LOGL_DEBUG, "rx from RUA: RANAP %s\n", + get_value_string(ranap_procedure_code_vals, message->procedureCode)); + switch (message->procedureCode) { case RANAP_ProcedureCode_id_RAB_Assignment: /* ps_rab_ass_fsm takes ownership of prim->oph and RANAP message */ @@ -205,7 +212,7 @@ case MAP_RUA_EV_CN_DISC: case MAP_RUA_EV_HNB_LINK_LOST: /* Unlikely that SCCP is active, but let the SCCP FSM decide about that. */ - handle_rx_rua(map, ranap_msg); + handle_rx_rua(fi, ranap_msg); /* There is a reason to shut down this RUA connection. Super unlikely, we haven't even processed the * MAP_RUA_EV_RX_CONNECT that created this FSM. Semantically, RUA is not connected, so we can * directly go to MAP_RUA_ST_DISCONNECTED. */ @@ -246,7 +253,7 @@ case MAP_RUA_EV_RX_DIRECT_TRANSFER: /* received DirectTransfer from RUA, forward to SCCP */ - handle_rx_rua(map, ranap_msg); + handle_rx_rua(fi, ranap_msg); return; case MAP_RUA_EV_TX_DIRECT_TRANSFER: @@ -263,7 +270,7 @@ return; } map_rua_fsm_state_chg(MAP_RUA_ST_DISCONNECTED); - handle_rx_rua(map, ranap_msg); + handle_rx_rua(fi, ranap_msg); return; case MAP_RUA_EV_HNB_LINK_LOST: diff --git a/src/osmo-hnbgw/context_map_sccp.c b/src/osmo-hnbgw/context_map_sccp.c index 9245ed5..deb6e0f 100644 --- a/src/osmo-hnbgw/context_map_sccp.c +++ b/src/osmo-hnbgw/context_map_sccp.c @@ -191,6 +191,9 @@ if (rc == 0) { talloc_set_destructor(message, destruct_ranap_ran_rx_co_ies); + LOGPFSML(fi, LOGL_DEBUG, "rx from SCCP: RANAP %s\n", + get_value_string(ranap_procedure_code_vals, message->procedureCode)); + switch (message->procedureCode) { case RANAP_ProcedureCode_id_RAB_Assignment: /* mgw_fsm_alloc_and_handle_rab_ass_req() takes ownership of (ranap) message */ @@ -212,6 +215,9 @@ if (rc == 0) { talloc_set_destructor(message, destruct_ranap_ran_rx_co_ies); + LOGPFSML(fi, LOGL_DEBUG, "rx from SCCP: RANAP %s\n", + get_value_string(ranap_procedure_code_vals, message->procedureCode)); + switch (message->procedureCode) { case RANAP_ProcedureCode_id_RAB_Assignment: -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/31770 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ib295e49f2c53164c5787002797145b3e6de5546b Gerrit-Change-Number: 31770 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-hnbgw[master]: debug log: log received RANAP message types on DCN, DHNB
by neels 14 Mar '23

14 Mar '23

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/31770 ) Change subject: debug log: log received RANAP message types on DCN, DHNB ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/31770 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ib295e49f2c53164c5787002797145b3e6de5546b Gerrit-Change-Number: 31770 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 Mar 2023 22:10:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-ttcn3-hacks[master]: hnbgw: add f_bssap_expect()
by neels 14 Mar '23

14 Mar '23

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31767 ) Change subject: hnbgw: add f_bssap_expect() ...................................................................... Patch Set 2: (1 comment) File hnbgw/HNBGW_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31767/comment/ec9e2d06_2275… PS1, Line 479: timer T := 5.0; > T. […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31767 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I51c60ed8fcef83c98e6c62c9f62a8c3c665de860 Gerrit-Change-Number: 31767 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 14 Mar 2023 22:06:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: add f_pfcp_expect()
by neels 14 Mar '23

14 Mar '23

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31766 ) Change subject: hnbgw: add f_pfcp_expect() ...................................................................... Patch Set 2: (1 comment) File hnbgw/HNBGW_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31766/comment/dcce8ac3_9d27… PS1, Line 1311: timer T := 5.0; > T. […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31766 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2117475b695d486b1204d61e5bb21120a6187354 Gerrit-Change-Number: 31766 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 14 Mar 2023 22:05:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: comment

1 0