Attention is currently required from: neels, fixeria, pespin.
Hello Jenkins Builder, fixeria, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmo-pfcp/+/31741
to look at the new patch set (#4).
Change subject: build: fix linking gen__pfcp_ies_auto to use build-tree libosmo-gtlv
......................................................................
build: fix linking gen__pfcp_ies_auto to use build-tree libosmo-gtlv
By moving *_LIBS to libosmo_pfcp_la_LIBADD, fix linking of
gen__pfcp_ies_auto to prefer the locally built libosmo-gtlv over a
system installed one.
Related: OS#5942
Change-Id: I2e92238b214d8e79bab1095d6093139bad05bc66
---
M src/libosmo-pfcp/Makefile.am
1 file changed, 20 insertions(+), 5 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-pfcp refs/changes/41/31741/4
--
To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/31741
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-pfcp
Gerrit-Branch: master
Gerrit-Change-Id: I2e92238b214d8e79bab1095d6093139bad05bc66
Gerrit-Change-Number: 31741
Gerrit-PatchSet: 4
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: fixeria.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/31784 )
Change subject: tests/auc/Makefile.am: put object files to LDADD
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Patchset:
PS1:
ugh. C sourec code files in LDADD? how could that have ever worked.
--
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/31784
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: Iaefcfe7a8904841a29094fe40eb5850912544b4c
Gerrit-Change-Number: 31784
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 14 Mar 2023 20:11:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/31835 )
Change subject: tests: use -no-install libtool flag to avoid ./lt-* scripts
......................................................................
tests: use -no-install libtool flag to avoid ./lt-* scripts
This option should be used for any executables which are used only
for testing, or for generating other files and are consequently never
installed. By specifying this option, we are telling Libtool that
the executable it links will only ever be executed from where it is
built in the build tree. Libtool is usually able to considerably
speed up the link process for such executables.
Change-Id: I2ca675e93dc5b34bb08d3b841adc115e93558137
---
M tests/gtp/Makefile.am
M tests/lib/Makefile.am
2 files changed, 18 insertions(+), 0 deletions(-)
Approvals:
Jenkins Builder: Verified
msuraev: Looks good to me, but someone else must approve
pespin: Looks good to me, approved
diff --git a/tests/gtp/Makefile.am b/tests/gtp/Makefile.am
index e49d824..ef69260 100644
--- a/tests/gtp/Makefile.am
+++ b/tests/gtp/Makefile.am
@@ -1,4 +1,5 @@
AM_CFLAGS = -Wall -I$(top_srcdir)/include $(LIBOSMOCORE_CFLAGS)
+AM_LDFLAGS = -no-install
EXTRA_DIST = \
gtpie_test.ok \
diff --git a/tests/lib/Makefile.am b/tests/lib/Makefile.am
index 8f0301c..e807281 100644
--- a/tests/lib/Makefile.am
+++ b/tests/lib/Makefile.am
@@ -1,4 +1,5 @@
AM_CFLAGS = -Wall -I$(top_srcdir)/include $(LIBOSMOCORE_CFLAGS)
+AM_LDFLAGS = -no-install
EXTRA_DIST = ippool_test.ok \
ippool_test.err \
--
To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/31835
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-Change-Id: I2ca675e93dc5b34bb08d3b841adc115e93558137
Gerrit-Change-Number: 31835
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: merged