March 2023 - gerrit-log - lists.osmocom.org

[M] Change in osmo-bsc[master]: fix coverity (false) warning in codec-list vty
by neels 18 Mar '23

18 Mar '23

neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31712 ) Change subject: fix coverity (false) warning in codec-list vty ...................................................................... fix coverity (false) warning in codec-list vty Since there were complaints about this old parsing code during recent code review in Ifdc9e04bf1d623da65bfb8a2fddea765601f6d9b, and now also coverity finds something odd in it, just rewrite this. Related: CID#310912 Change-Id: I96cd5d88ec6808a2915c6bccd0c0140216f328f2 --- M src/osmo-bsc/bsc_vty.c M tests/msc.vty 2 files changed, 41 insertions(+), 29 deletions(-) Approvals: fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/osmo-bsc/bsc_vty.c b/src/osmo-bsc/bsc_vty.c index e14aecb..467301b 100644 --- a/src/osmo-bsc/bsc_vty.c +++ b/src/osmo-bsc/bsc_vty.c @@ -2712,6 +2712,7 @@ { struct bsc_msc_data *data = bsc_msc_data(vty); struct gsm_audio_support tmp[ARRAY_SIZE(data->audio_support)]; + const char *arg = NULL; int i; /* Nr of arguments must fit in the array */ @@ -2724,30 +2725,23 @@ /* check all given arguments first */ for (i = 0; i < argc; i++) { int j; + int ver; + arg = argv[i]; - /* check for hrX or frX */ - if (strlen(argv[i]) != 3 - || argv[i][1] != 'r' - || (argv[i][0] != 'h' && argv[i][0] != 'f') - || argv[i][2] < '0' - || argv[i][2] > '9') { - vty_out(vty, "Codec name must be hrX or frX. Was '%s'%s", argv[i], VTY_NEWLINE); - return CMD_WARNING; - } - - /* store in tmp[] first, to not overwrite data->audio_support[] in case of error */ - tmp[i].ver = atoi(argv[i] + 2); - if (strncmp("hr", argv[i], 2) == 0) + if (strncmp("hr", arg, 2) == 0) tmp[i].hr = 1; - else if (strncmp("fr", argv[i], 2) == 0) + else if (strncmp("fr", arg, 2) == 0) tmp[i].hr = 0; + else + goto invalid_arg; - /* forbid invalid versions */ - if (tmp[i].ver < 1 || tmp[i].ver > 7 - || (tmp[i].hr && tmp[i].ver == 2)) { - vty_out(vty, "'%s' is not a valid codec version%s", argv[i], VTY_NEWLINE); - return CMD_WARNING; - } + ver = atoi(arg + 2); + if (ver < 1 || ver > 7) + goto invalid_arg; + tmp[i].ver = ver; + + if (tmp[i].hr == 1 && ver == 2) + goto invalid_arg; /* prevent duplicate entries */ for (j = 0; j < i; j++) { @@ -2762,6 +2756,10 @@ data->audio_length = argc; return CMD_SUCCESS; + +invalid_arg: + vty_out(vty, "%s is not a valid codec version%s", osmo_quote_cstr_c(OTC_SELECT, arg, -1), VTY_NEWLINE); + return CMD_WARNING; } #define LEGACY_STR "This command has no effect, it is kept to support legacy config files\n" diff --git a/tests/msc.vty b/tests/msc.vty index d67f2b9..08c7f71 100644 --- a/tests/msc.vty +++ b/tests/msc.vty @@ -33,16 +33,16 @@ ... OsmoBSC(config-msc)# codec-list foo -Codec name must be hrX or frX. Was 'foo' +"foo" is not a valid codec version OsmoBSC(config-msc)# codec-list fr10 -Codec name must be hrX or frX. Was 'fr10' +"fr10" is not a valid codec version OsmoBSC(config-msc)# codec-list hr10 -Codec name must be hrX or frX. Was 'hr10' +"hr10" is not a valid codec version OsmoBSC(config-msc)# codec-list FR1 -Codec name must be hrX or frX. Was 'FR1' +"FR1" is not a valid codec version OsmoBSC(config-msc)# # Ensure the codec-list with wrong args did not change the config OsmoBSC(config-msc)# show running-config @@ -62,7 +62,7 @@ ... OsmoBSC(config-msc)# codec-list fr0 fr1 -'fr0' is not a valid codec version +"fr0" is not a valid codec version OsmoBSC(config-msc)# show running-config ... msc 0 @@ -71,7 +71,7 @@ ... OsmoBSC(config-msc)# codec-list hr0 hr1 -'hr0' is not a valid codec version +"hr0" is not a valid codec version OsmoBSC(config-msc)# show running-config ... msc 0 @@ -80,7 +80,7 @@ ... OsmoBSC(config-msc)# codec-list fr8 fr9 -'fr8' is not a valid codec version +"fr8" is not a valid codec version OsmoBSC(config-msc)# show running-config ... msc 0 @@ -89,7 +89,7 @@ ... OsmoBSC(config-msc)# codec-list hr8 hr9 -'hr8' is not a valid codec version +"hr8" is not a valid codec version OsmoBSC(config-msc)# show running-config ... msc 0 @@ -98,7 +98,7 @@ ... OsmoBSC(config-msc)# codec-list fr2 hr2 -'hr2' is not a valid codec version +"hr2" is not a valid codec version OsmoBSC(config-msc)# show running-config ... msc 0 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31712 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I96cd5d88ec6808a2915c6bccd0c0140216f328f2 Gerrit-Change-Number: 31712 Gerrit-PatchSet: 5 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[L] Change in osmo-msc[master]: do CN CRCX first
by neels 18 Mar '23

18 Mar '23

Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/31740 ) Change subject: do CN CRCX first ...................................................................... Patch Set 5: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-msc/+/31740/comment/527f746a_9724b493 PS4, Line 9: In order to send the MSC's RTP endpoint IP address+port in the inital > typo: initial Ack -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/31740 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ie433db1ba0c46d4b97538a969233c155cefac21c Gerrit-Change-Number: 31740 Gerrit-PatchSet: 5 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 18 Mar 2023 02:06:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[L] Change in osmo-msc[master]: do CN CRCX first
by neels 18 Mar '23

18 Mar '23

Attention is currently required from: neels. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/31740 to look at the new patch set (#5). Change subject: do CN CRCX first ...................................................................... do CN CRCX first In order to send the MSC's RTP endpoint IP address+port in the initial SDP, move the MGCP CRCX up to an earlier point in the sequence of establishing a voice call. Update the voice call sequence chart to show the effects. Though the semantic change is rather simple, the patch is rather huge -- things have to happen in a different order, and async waits have to happen at different times. The new codec filter helps to carry codec resolution information across the newly arranged code paths. Related: SYS#5066 Change-Id: Ie433db1ba0c46d4b97538a969233c155cefac21c --- M doc/sequence_charts/voice_call_external_mncc.msc M doc/sequence_charts/voice_call_internal_mncc.msc M include/osmocom/msc/gsm_04_08.h M include/osmocom/msc/msc_a.h M src/libmsc/gsm_04_08_cc.c M src/libmsc/msc_a.c M tests/msc_vlr/msc_vlr_test_call.c M tests/msc_vlr/msc_vlr_test_call.err 8 files changed, 487 insertions(+), 261 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/40/31740/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/31740 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ie433db1ba0c46d4b97538a969233c155cefac21c Gerrit-Change-Number: 31740 Gerrit-PatchSet: 5 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[L] Change in osmo-msc[master]: [codecs filter] send + receive SDP via MNCC
by neels 18 Mar '23

18 Mar '23

Attention is currently required from: laforge, pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/31698 ) Change subject: [codecs filter] send + receive SDP via MNCC ...................................................................... Patch Set 7: (1 comment) Patchset: PS7: > Ok, if others are fine with it let's merge it, though I really think this paradigm of having to call […] codec_filter_run() does not log. I believe the strong opinion is a gut feel that the inputs do not change often, that "filter_run()" sounds expensive, and that the results are not used often. All of these are not accurate impressions. Inputs update more often than results are being used, and codec_filter_run() is not expensive. The amount of us discussing when to call run() far exceeds the significance of this aspect. You've asked about this over an extended period of time and in many different patches. I'm trying to convince you that it is not an important issue, but it seems my responses don't reach home. Important at this point is that it has correct results. There are a number of quite non-trivial aspects of this patch series, IMHO this part is just a bike shed slash premature optimization, rather don't let review get distracted by this marginal aspect. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/31698 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ie0668c0e079ec69da1532b52d00621efe114fc2c Gerrit-Change-Number: 31698 Gerrit-PatchSet: 7 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 18 Mar 2023 02:03:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[M] Change in osmo-msc[master]: [codecs filter] use filter result in Assignment
by neels 18 Mar '23

18 Mar '23

Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/30126 ) Change subject: [codecs filter] use filter result in Assignment ...................................................................... Patch Set 8: (1 comment) File src/libmsc/gsm_04_08_cc.c: https://gerrit.osmocom.org/c/osmo-msc/+/30126/comment/1583eb47_86d845eb PS4, Line 1797: codec_filter_run(&trans->cc.codecs); > I think that was an unconclusive discussion, and probably I was not really happy about that 😊 […] no, it's not expensive to call codec_filter_run(). In reverse I could ask: what's the point in calling it every time the inputs modify when nothing is using the result between input modifications? Inputs are from various sources, e.g. BSSAP Codec List (BSS Supported), MS Bearer Capabilites, the SDP from the remote call leg. It is a simple way to just call codec_filter_run() before using its result. Yes, we could also call it whenever any of the inputs change. We could also call it implicitly from every codec_filter_set_foo() function. Neither would make much of a difference. I chose to run() before using the result as a simple way to not call run() overly often, and I think there's nothing wrong with this approach. If you would like to optimize performance, here is my usual answer: run a profiler to measure and prove the places that are inefficient; i'm pretty sure the codec filter is not a significant contender. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/30126 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I66e7c8c5e401f4f3a7d3d42b9525b2c6e99691d9 Gerrit-Change-Number: 30126 Gerrit-PatchSet: 8 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 18 Mar 2023 01:48:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-upf[master]: build: add libupf.la (noinst)
by neels 18 Mar '23

18 Mar '23

neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/31920 ) Change subject: build: add libupf.la (noinst) ...................................................................... build: add libupf.la (noinst) Like we do in osmo-bsc.git, gather the osmo-upf objects into a not-installed libupf.la, so that we can trivially and flexibly link these to regression test programs. Will be used by upcoming patch I36acff15f22d23ade4d281c2af3eb117dfc10359 (unique_ids_test). Change-Id: Id179a47b5d40821d86c7214add14449600198e07 --- M src/osmo-upf/Makefile.am 1 file changed, 32 insertions(+), 9 deletions(-) Approvals: laforge: Looks good to me, approved; Verified pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/osmo-upf/Makefile.am b/src/osmo-upf/Makefile.am index d5e392b..be72bc2 100644 --- a/src/osmo-upf/Makefile.am +++ b/src/osmo-upf/Makefile.am @@ -18,19 +18,15 @@ $(NULL) AM_LDFLAGS = \ - $(LIBGTPNL_LDFLAGS) \ - $(LIBNFTNL_LDFLAGS) \ - $(LIBNFTABLES_LDFLAGS) \ $(COVERAGE_LDFLAGS) \ $(NULL) -bin_PROGRAMS = \ - osmo-upf \ +noinst_LTLIBRARIES = \ + libupf.la \ $(NULL) -osmo_upf_SOURCES = \ +libupf_la_SOURCES = \ netinst.c \ - osmo_upf_main.c \ up_endpoint.c \ up_gtp_action.c \ up_peer.c \ @@ -42,7 +38,7 @@ upf_vty.c \ $(NULL) -osmo_upf_LDADD = \ +libupf_la_LIBADD = \ $(LIBOSMOCORE_LIBS) \ $(LIBOSMOVTY_LIBS) \ $(LIBOSMOCTRL_LIBS) \ @@ -50,5 +46,16 @@ $(LIBGTPNL_LIBS) \ $(LIBNFTNL_LIBS) \ $(LIBNFTABLES_LIBS) \ - $(COVERAGE_LDFLAGS) \ + $(NULL) + +bin_PROGRAMS = \ + osmo-upf \ + $(NULL) + +osmo_upf_SOURCES = \ + osmo_upf_main.c \ + $(NULL) + +osmo_upf_LDADD = \ + libupf.la \ $(NULL) -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/31920 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Id179a47b5d40821d86c7214add14449600198e07 Gerrit-Change-Number: 31920 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[M] Change in osmo-upf[master]: tunmap: ensure assigned chain_id is unused
by neels 18 Mar '23

18 Mar '23

neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/31483 ) Change subject: tunmap: ensure assigned chain_id is unused ...................................................................... tunmap: ensure assigned chain_id is unused When handing out a chain_id, make sure it is not in use yet. So far picking a chain_id was of PoC grade quality. As osmo-upf is approaching production grade, make this waterproof. So far with inefficient iteration of all sessions; faster lookup follows in I36a75ec4698cd83558185c1f202400eb53ae8ff6. Related: OS#5900 Change-Id: I139b46de0bd15185a7a06109d55f7c759755ec81 --- M include/osmocom/upf/upf.h M src/osmo-upf/upf.c M src/osmo-upf/upf_nft.c M tests/unique_ids/unique_ids_test.c M tests/unique_ids/unique_ids_test.err 5 files changed, 141 insertions(+), 71 deletions(-) Approvals: laforge: Looks good to me, approved osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/include/osmocom/upf/upf.h b/include/osmocom/upf/upf.h index c1dc39a..db73c1f 100644 --- a/include/osmocom/upf/upf.h +++ b/include/osmocom/upf/upf.h @@ -141,3 +141,4 @@ void upf_gtp_devs_close(); uint32_t upf_next_local_teid(void); +uint32_t upf_next_chain_id(void); diff --git a/src/osmo-upf/upf.c b/src/osmo-upf/upf.c index 41f6f62..3d00cc2 100644 --- a/src/osmo-upf/upf.c +++ b/src/osmo-upf/upf.c @@ -31,6 +31,7 @@ #include <osmocom/upf/up_endpoint.h> #include <osmocom/upf/up_peer.h> #include <osmocom/upf/up_session.h> +#include <osmocom/upf/up_gtp_action.h> #include <osmocom/upf/upf_gtp.h> struct g_upf *g_upf = NULL; @@ -150,3 +151,54 @@ } return 0; } + +static uint32_t upf_next_chain_id_inc(void) +{ + g_upf->tunmap.next_chain_id_state++; + if (!g_upf->tunmap.next_chain_id_state) + g_upf->tunmap.next_chain_id_state++; + return g_upf->tunmap.next_chain_id_state; +} + +/* Return an unused chain_id, or 0 if none is found with sane effort. */ +uint32_t upf_next_chain_id(void) +{ + uint32_t sanity; + + /* Make sure the new chain_id is not used anywhere */ + for (sanity = 2342; sanity; sanity--) { + struct up_peer *peer; + uint32_t chain_id = upf_next_chain_id_inc(); + bool taken = false; + + if (!g_upf->pfcp.ep) + return chain_id; + + llist_for_each_entry(peer, &g_upf->pfcp.ep->peers, entry) { + struct up_session *session; + int bkt; + hash_for_each(peer->sessions_by_up_seid, bkt, session, node_by_up_seid) { + struct up_gtp_action *a; + llist_for_each_entry(a, &session->active_gtp_actions, entry) { + if (a->kind != UP_GTP_U_TUNMAP) + continue; + if (a->tunmap.access.chain_id == chain_id + || a->tunmap.core.chain_id == chain_id) { + taken = true; + break; + } + } + if (taken) + break; + } + if (taken) + break; + } + + if (!taken) + return chain_id; + } + + /* finding a chain_id became insane, return invalid = 0 */ + return 0; +} diff --git a/src/osmo-upf/upf_nft.c b/src/osmo-upf/upf_nft.c index e91443b..4401f1e 100644 --- a/src/osmo-upf/upf_nft.c +++ b/src/osmo-upf/upf_nft.c @@ -343,23 +343,9 @@ g_upf->tunmap.priority_post); } -static uint32_t chain_id_next(void) -{ - g_upf->tunmap.next_chain_id_state++; - if (!g_upf->tunmap.next_chain_id_state) - g_upf->tunmap.next_chain_id_state++; - return g_upf->tunmap.next_chain_id_state; -} - char *upf_nft_tunmap_get_ruleset_str(void *ctx, struct upf_tunmap *tunmap) { struct upf_nft_args args; - - if (!tunmap->access.chain_id) - tunmap->access.chain_id = chain_id_next(); - if (!tunmap->core.chain_id) - tunmap->core.chain_id = chain_id_next(); - upf_nft_args_from_tunmap(&args, tunmap); return upf_nft_ruleset_tunmap_create_c(ctx, &args); } @@ -371,8 +357,21 @@ return upf_nft_ruleset_tunmap_delete_c(ctx, &args); } +static int upf_nft_tunmap_ensure_chain_id(struct upf_nft_tun *tun) +{ + if (tun->chain_id) + return 0; + tun->chain_id = upf_next_chain_id(); + if (!tun->chain_id) + return -ENOSPC; + return 0; +} + int upf_nft_tunmap_create(struct upf_tunmap *tunmap) { + if (upf_nft_tunmap_ensure_chain_id(&tunmap->access) + || upf_nft_tunmap_ensure_chain_id(&tunmap->core)) + return -ENOSPC; return upf_nft_run(upf_nft_tunmap_get_ruleset_str(OTC_SELECT, tunmap)); } diff --git a/tests/unique_ids/unique_ids_test.c b/tests/unique_ids/unique_ids_test.c index 52cd9e8..2120ab4 100644 --- a/tests/unique_ids/unique_ids_test.c +++ b/tests/unique_ids/unique_ids_test.c @@ -349,8 +349,8 @@ log_assert(a->kind == UP_GTP_U_TUNMAP); log_assert(a->tunmap.core.tun.local.teid == 3); log_assert(a->tunmap.access.tun.local.teid == 4); - log_assert_expect_failure(a->tunmap.access.chain_id == 3); - log_assert_expect_failure(a->tunmap.core.chain_id == 4); + log_assert(a->tunmap.access.chain_id == 3); + log_assert(a->tunmap.core.chain_id == 4); log("\n"); log("drop first tunmap (%s)\n", s1->fi->name); @@ -387,8 +387,8 @@ log_assert(a->kind == UP_GTP_U_TUNMAP); log_assert(a->tunmap.core.tun.local.teid == 5); log_assert(a->tunmap.access.tun.local.teid == 6); - log_assert_expect_failure(a->tunmap.access.chain_id == 5); - log_assert_expect_failure(a->tunmap.core.chain_id == 6); + log_assert(a->tunmap.access.chain_id == 5); + log_assert(a->tunmap.core.chain_id == 6); log("\n"); cleanup(); diff --git a/tests/unique_ids/unique_ids_test.err b/tests/unique_ids/unique_ids_test.err index dfd57ef..f9ea23a 100644 --- a/tests/unique_ids/unique_ids_test.err +++ b/tests/unique_ids/unique_ids_test.err @@ -125,21 +125,21 @@ DSESSION DEBUG up_session(1-2-3-4-0x2){INIT}: enabling: GTP:tunmap GTP-access-r:5.6.7.8 TEID-access-r:0x102 GTP-access-l:1.1.1.1 TEID-access-l:0x4 GTP-core-r:13.14.15.16 TEID-core-r:0x103 GTP-core-l:1.1.1.1 TEID-core-l:0x3 PFCP-peer:1.2.3.4 SEID-l:0x2 PDR-access:2 PDR-core:1 [test override] nft_run_cmd_from_buffer(): -add chain inet osmo-upf tunmap-pre-1; -add rule inet osmo-upf tunmap-pre-1 ip daddr set 13.14.15.16 meta mark set 1 counter accept; -add chain inet osmo-upf tunmap-post-1; -add rule inet osmo-upf tunmap-post-1 ip saddr set 1.1.1.1 @ih,32,32 set 0x103 counter accept; -add element inet osmo-upf tunmap-pre { 1.1.1.1 . 0x4 : jump tunmap-pre-1 }; -add element inet osmo-upf tunmap-post { 1 : jump tunmap-post-1 }; -add chain inet osmo-upf tunmap-pre-2; -add rule inet osmo-upf tunmap-pre-2 ip daddr set 5.6.7.8 meta mark set 2 counter accept; -add chain inet osmo-upf tunmap-post-2; -add rule inet osmo-upf tunmap-post-2 ip saddr set 1.1.1.1 @ih,32,32 set 0x102 counter accept; -add element inet osmo-upf tunmap-pre { 1.1.1.1 . 0x3 : jump tunmap-pre-2 }; -add element inet osmo-upf tunmap-post { 2 : jump tunmap-post-2 }; +add chain inet osmo-upf tunmap-pre-3; +add rule inet osmo-upf tunmap-pre-3 ip daddr set 13.14.15.16 meta mark set 3 counter accept; +add chain inet osmo-upf tunmap-post-3; +add rule inet osmo-upf tunmap-post-3 ip saddr set 1.1.1.1 @ih,32,32 set 0x103 counter accept; +add element inet osmo-upf tunmap-pre { 1.1.1.1 . 0x4 : jump tunmap-pre-3 }; +add element inet osmo-upf tunmap-post { 3 : jump tunmap-post-3 }; +add chain inet osmo-upf tunmap-pre-4; +add rule inet osmo-upf tunmap-pre-4 ip daddr set 5.6.7.8 meta mark set 4 counter accept; +add chain inet osmo-upf tunmap-post-4; +add rule inet osmo-upf tunmap-post-4 ip saddr set 1.1.1.1 @ih,32,32 set 0x102 counter accept; +add element inet osmo-upf tunmap-pre { 1.1.1.1 . 0x3 : jump tunmap-pre-4 }; +add element inet osmo-upf tunmap-post { 4 : jump tunmap-post-4 }; -DNFT DEBUG run nft ruleset: "add chain inet osmo-upf tunmap-pre-1;\nadd rule inet osmo-upf tunmap-pre-1 ip daddr set 13.14.15.16 meta mark set 1 counter accept;\nadd chain inet osmo-upf tunmap-post-1;\nadd rule inet osmo-upf tunmap-post-1 ip saddr set 1.1.1.1 @ih,32,32 set 0x103 counter accept;\nadd element inet osmo-upf tunmap-pre { 1.1.1.1 . 0x4 : jump tunmap-pre-1 };\nadd element inet osmo-upf tunmap-post { 1 : jump tunmap-post-1 };\nadd chain inet osmo-upf tunmap-pre-2;\nadd rule inet osmo-upf tunmap-pre-2 ip daddr set 5.6.7.8 meta mark set 2 counter accept;\nadd chain inet osmo-upf tunmap-post-2;\nadd rule inet osmo-upf tunmap-post-2 ip saddr set 1.1.1.1 @ih,32,32 set 0x102 counter accept;\nadd element inet osmo-upf tunmap-pre { 1.1.1.1 . 0x3 : jump tunmap-pre-2 };\nadd element inet osmo-upf tunmap-post { 2 : jump tunmap-post-2 };\n" -DGTP NOTICE GTP:tunmap GTP-access-r:5.6.7.8 TEID-access-r:0x102 GTP-access-l:1.1.1.1 TEID-access-l:0x4 GTP-core-r:13.14.15.16 TEID-core-r:0x103 GTP-core-l:1.1.1.1 TEID-core-l:0x3 PFCP-peer:1.2.3.4 SEID-l:0x2 PDR-access:2 PDR-core:1: Enabled tunmap, nft chain IDs: access--1-> <-2--core +DNFT DEBUG run nft ruleset: "add chain inet osmo-upf tunmap-pre-3;\nadd rule inet osmo-upf tunmap-pre-3 ip daddr set 13.14.15.16 meta mark set 3 counter accept;\nadd chain inet osmo-upf tunmap-post-3;\nadd rule inet osmo-upf tunmap-post-3 ip saddr set 1.1.1.1 @ih,32,32 set 0x103 counter accept;\nadd element inet osmo-upf tunmap-pre { 1.1.1.1 . 0x4 : jump tunmap-pre-3 };\nadd element inet osmo-upf tunmap-post { 3 : jump tunmap-post-3 };\nadd chain inet osmo-upf tunmap-pre-4;\nadd rule inet osmo-upf tunmap-pre-4 ip daddr set 5.6.7.8 meta mark set 4 counter accept;\nadd chain inet osmo-upf tunmap-post-4;\nadd rule inet osmo-upf tunmap-post-4 ip saddr set 1.1.1.1 @ih,32,32 set 0x102 counter accept;\nadd element inet osmo-upf tunmap-pre { 1.1.1.1 . 0x3 : jump tunmap-pre-4 };\nadd element inet osmo-upf tunmap-post { 4 : jump tunmap-post-4 };\n" +DGTP NOTICE GTP:tunmap GTP-access-r:5.6.7.8 TEID-access-r:0x102 GTP-access-l:1.1.1.1 TEID-access-l:0x4 GTP-core-r:13.14.15.16 TEID-core-r:0x103 GTP-core-l:1.1.1.1 TEID-core-l:0x3 PFCP-peer:1.2.3.4 SEID-l:0x2 PDR-access:2 PDR-core:1: Enabled tunmap, nft chain IDs: access--3-> <-4--core [test override] PFCP tx: PFCPv1 SESSION_EST_RESP hdr={seq=0 SEID=0x101} ies={ 'Node ID'=v4:unsupported family 0 'Cause'=Request accepted (success) 'F-SEID'=0x2,v4:1.1.1.1 'Created PDR'={ { 'PDR ID'=1 'F-TEID'=TEID-0x3,v4:1.1.1.1 }, { 'PDR ID'=2 'F-TEID'=TEID-0x4,v4:1.1.1.1 } } } @@ -158,15 +158,15 @@ state: | peer up_peer(1-2-3-4) ASSOCIATED | session[ESTABLISHED]: UP-SEID 0x1; chain_id access=1 core=2; local TEID access=0x2 core=0x1 - | session[ESTABLISHED]: UP-SEID 0x2; chain_id access=1 core=2; local TEID access=0x4 core=0x3 + | session[ESTABLISHED]: UP-SEID 0x2; chain_id access=3 core=4; local TEID access=0x4 core=0x3 assert(s2->up_seid == 2) assert(a = llist_first_entry_or_null(&s2->active_gtp_actions, struct up_gtp_action, entry)) assert(a->kind == UP_GTP_U_TUNMAP) assert(a->tunmap.core.tun.local.teid == 3) assert(a->tunmap.access.tun.local.teid == 4) -assert(a->tunmap.access.chain_id == 3) <-- EXPECTED TO FAIL (known error) -assert(a->tunmap.core.chain_id == 4) <-- EXPECTED TO FAIL (known error) +assert(a->tunmap.access.chain_id == 3) +assert(a->tunmap.core.chain_id == 4) drop first tunmap (up_session(1-2-3-4-0x1)) assert(session) @@ -206,7 +206,7 @@ state: | peer up_peer(1-2-3-4) ASSOCIATED - | session[ESTABLISHED]: UP-SEID 0x2; chain_id access=1 core=2; local TEID access=0x4 core=0x3 + | session[ESTABLISHED]: UP-SEID 0x2; chain_id access=3 core=4; local TEID access=0x4 core=0x3 assert(up_session_find_by_up_seid(peer, s1_up_seid) == NULL) @@ -266,7 +266,7 @@ state: | peer up_peer(1-2-3-4) ASSOCIATED | session[ESTABLISHED]: UP-SEID 0x1; chain_id access=1 core=2; local TEID access=0x2 core=0x1 - | session[ESTABLISHED]: UP-SEID 0x2; chain_id access=1 core=2; local TEID access=0x4 core=0x3 + | session[ESTABLISHED]: UP-SEID 0x2; chain_id access=3 core=4; local TEID access=0x4 core=0x3 assert(s3->up_seid == 1) assert(a = llist_first_entry_or_null(&s3->active_gtp_actions, struct up_gtp_action, entry)) @@ -298,21 +298,21 @@ DSESSION DEBUG up_session(1-2-3-4-0x3){INIT}: enabling: GTP:tunmap GTP-access-r:5.6.7.8 TEID-access-r:0x106 GTP-access-l:1.1.1.1 TEID-access-l:0x6 GTP-core-r:13.14.15.16 TEID-core-r:0x107 GTP-core-l:1.1.1.1 TEID-core-l:0x5 PFCP-peer:1.2.3.4 SEID-l:0x3 PDR-access:2 PDR-core:1 [test override] nft_run_cmd_from_buffer(): -add chain inet osmo-upf tunmap-pre-3; -add rule inet osmo-upf tunmap-pre-3 ip daddr set 13.14.15.16 meta mark set 3 counter accept; -add chain inet osmo-upf tunmap-post-3; -add rule inet osmo-upf tunmap-post-3 ip saddr set 1.1.1.1 @ih,32,32 set 0x107 counter accept; -add element inet osmo-upf tunmap-pre { 1.1.1.1 . 0x6 : jump tunmap-pre-3 }; -add element inet osmo-upf tunmap-post { 3 : jump tunmap-post-3 }; -add chain inet osmo-upf tunmap-pre-4; -add rule inet osmo-upf tunmap-pre-4 ip daddr set 5.6.7.8 meta mark set 4 counter accept; -add chain inet osmo-upf tunmap-post-4; -add rule inet osmo-upf tunmap-post-4 ip saddr set 1.1.1.1 @ih,32,32 set 0x106 counter accept; -add element inet osmo-upf tunmap-pre { 1.1.1.1 . 0x5 : jump tunmap-pre-4 }; -add element inet osmo-upf tunmap-post { 4 : jump tunmap-post-4 }; +add chain inet osmo-upf tunmap-pre-5; +add rule inet osmo-upf tunmap-pre-5 ip daddr set 13.14.15.16 meta mark set 5 counter accept; +add chain inet osmo-upf tunmap-post-5; +add rule inet osmo-upf tunmap-post-5 ip saddr set 1.1.1.1 @ih,32,32 set 0x107 counter accept; +add element inet osmo-upf tunmap-pre { 1.1.1.1 . 0x6 : jump tunmap-pre-5 }; +add element inet osmo-upf tunmap-post { 5 : jump tunmap-post-5 }; +add chain inet osmo-upf tunmap-pre-6; +add rule inet osmo-upf tunmap-pre-6 ip daddr set 5.6.7.8 meta mark set 6 counter accept; +add chain inet osmo-upf tunmap-post-6; +add rule inet osmo-upf tunmap-post-6 ip saddr set 1.1.1.1 @ih,32,32 set 0x106 counter accept; +add element inet osmo-upf tunmap-pre { 1.1.1.1 . 0x5 : jump tunmap-pre-6 }; +add element inet osmo-upf tunmap-post { 6 : jump tunmap-post-6 }; -DNFT DEBUG run nft ruleset: "add chain inet osmo-upf tunmap-pre-3;\nadd rule inet osmo-upf tunmap-pre-3 ip daddr set 13.14.15.16 meta mark set 3 counter accept;\nadd chain inet osmo-upf tunmap-post-3;\nadd rule inet osmo-upf tunmap-post-3 ip saddr set 1.1.1.1 @ih,32,32 set 0x107 counter accept;\nadd element inet osmo-upf tunmap-pre { 1.1.1.1 . 0x6 : jump tunmap-pre-3 };\nadd element inet osmo-upf tunmap-post { 3 : jump tunmap-post-3 };\nadd chain inet osmo-upf tunmap-pre-4;\nadd rule inet osmo-upf tunmap-pre-4 ip daddr set 5.6.7.8 meta mark set 4 counter accept;\nadd chain inet osmo-upf tunmap-post-4;\nadd rule inet osmo-upf tunmap-post-4 ip saddr set 1.1.1.1 @ih,32,32 set 0x106 counter accept;\nadd element inet osmo-upf tunmap-pre { 1.1.1.1 . 0x5 : jump tunmap-pre-4 };\nadd element inet osmo-upf tunmap-post { 4 : jump tunmap-post-4 };\n" -DGTP NOTICE GTP:tunmap GTP-access-r:5.6.7.8 TEID-access-r:0x106 GTP-access-l:1.1.1.1 TEID-access-l:0x6 GTP-core-r:13.14.15.16 TEID-core-r:0x107 GTP-core-l:1.1.1.1 TEID-core-l:0x5 PFCP-peer:1.2.3.4 SEID-l:0x3 PDR-access:2 PDR-core:1: Enabled tunmap, nft chain IDs: access--3-> <-4--core +DNFT DEBUG run nft ruleset: "add chain inet osmo-upf tunmap-pre-5;\nadd rule inet osmo-upf tunmap-pre-5 ip daddr set 13.14.15.16 meta mark set 5 counter accept;\nadd chain inet osmo-upf tunmap-post-5;\nadd rule inet osmo-upf tunmap-post-5 ip saddr set 1.1.1.1 @ih,32,32 set 0x107 counter accept;\nadd element inet osmo-upf tunmap-pre { 1.1.1.1 . 0x6 : jump tunmap-pre-5 };\nadd element inet osmo-upf tunmap-post { 5 : jump tunmap-post-5 };\nadd chain inet osmo-upf tunmap-pre-6;\nadd rule inet osmo-upf tunmap-pre-6 ip daddr set 5.6.7.8 meta mark set 6 counter accept;\nadd chain inet osmo-upf tunmap-post-6;\nadd rule inet osmo-upf tunmap-post-6 ip saddr set 1.1.1.1 @ih,32,32 set 0x106 counter accept;\nadd element inet osmo-upf tunmap-pre { 1.1.1.1 . 0x5 : jump tunmap-pre-6 };\nadd element inet osmo-upf tunmap-post { 6 : jump tunmap-post-6 };\n" +DGTP NOTICE GTP:tunmap GTP-access-r:5.6.7.8 TEID-access-r:0x106 GTP-access-l:1.1.1.1 TEID-access-l:0x6 GTP-core-r:13.14.15.16 TEID-core-r:0x107 GTP-core-l:1.1.1.1 TEID-core-l:0x5 PFCP-peer:1.2.3.4 SEID-l:0x3 PDR-access:2 PDR-core:1: Enabled tunmap, nft chain IDs: access--5-> <-6--core [test override] PFCP tx: PFCPv1 SESSION_EST_RESP hdr={seq=0 SEID=0x103} ies={ 'Node ID'=v4:unsupported family 0 'Cause'=Request accepted (success) 'F-SEID'=0x3,v4:1.1.1.1 'Created PDR'={ { 'PDR ID'=1 'F-TEID'=TEID-0x5,v4:1.1.1.1 }, { 'PDR ID'=2 'F-TEID'=TEID-0x6,v4:1.1.1.1 } } } @@ -330,17 +330,17 @@ state: | peer up_peer(1-2-3-4) ASSOCIATED - | session[ESTABLISHED]: UP-SEID 0x3; chain_id access=3 core=4; local TEID access=0x6 core=0x5 + | session[ESTABLISHED]: UP-SEID 0x3; chain_id access=5 core=6; local TEID access=0x6 core=0x5 | session[ESTABLISHED]: UP-SEID 0x1; chain_id access=1 core=2; local TEID access=0x2 core=0x1 - | session[ESTABLISHED]: UP-SEID 0x2; chain_id access=1 core=2; local TEID access=0x4 core=0x3 + | session[ESTABLISHED]: UP-SEID 0x2; chain_id access=3 core=4; local TEID access=0x4 core=0x3 assert(s4->up_seid == 3) assert(a = llist_first_entry_or_null(&s4->active_gtp_actions, struct up_gtp_action, entry)) assert(a->kind == UP_GTP_U_TUNMAP) assert(a->tunmap.core.tun.local.teid == 5) assert(a->tunmap.access.tun.local.teid == 6) -assert(a->tunmap.access.chain_id == 5) <-- EXPECTED TO FAIL (known error) -assert(a->tunmap.core.chain_id == 6) <-- EXPECTED TO FAIL (known error) +assert(a->tunmap.access.chain_id == 5) +assert(a->tunmap.core.chain_id == 6) DPEER DEBUG up_peer(1-2-3-4){ASSOCIATED}: Terminating (cause = OSMO_FSM_TERM_REGULAR) DSESSION DEBUG up_session(1-2-3-4-0x3){ESTABLISHED}: Terminating (cause = OSMO_FSM_TERM_PARENT) @@ -351,16 +351,16 @@ [test override] nft_run_cmd_from_buffer(): delete element inet osmo-upf tunmap-pre { 1.1.1.1 . 0x6 }; -delete element inet osmo-upf tunmap-post { 3 }; -delete chain inet osmo-upf tunmap-pre-3; -delete chain inet osmo-upf tunmap-post-3; +delete element inet osmo-upf tunmap-post { 5 }; +delete chain inet osmo-upf tunmap-pre-5; +delete chain inet osmo-upf tunmap-post-5; delete element inet osmo-upf tunmap-pre { 1.1.1.1 . 0x5 }; -delete element inet osmo-upf tunmap-post { 4 }; -delete chain inet osmo-upf tunmap-pre-4; -delete chain inet osmo-upf tunmap-post-4; +delete element inet osmo-upf tunmap-post { 6 }; +delete chain inet osmo-upf tunmap-pre-6; +delete chain inet osmo-upf tunmap-post-6; -DNFT DEBUG run nft ruleset: "delete element inet osmo-upf tunmap-pre { 1.1.1.1 . 0x6 };\ndelete element inet osmo-upf tunmap-post { 3 };\ndelete chain inet osmo-upf tunmap-pre-3;\ndelete chain inet osmo-upf tunmap-post-3;\ndelete element inet osmo-upf tunmap-pre { 1.1.1.1 . 0x5 };\ndelete element inet osmo-upf tunmap-post { 4 };\ndelete chain inet osmo-upf tunmap-pre-4;\ndelete chain inet osmo-upf tunmap-post-4;\n" -DGTP NOTICE GTP:tunmap GTP-access-r:5.6.7.8 TEID-access-r:0x106 GTP-access-l:1.1.1.1 TEID-access-l:0x6 GTP-core-r:13.14.15.16 TEID-core-r:0x107 GTP-core-l:1.1.1.1 TEID-core-l:0x5 PFCP-peer:1.2.3.4 SEID-l:0x3 PDR-access:2 PDR-core:1: Disabled tunmap, nft chain IDs: access--3-> <-4--core +DNFT DEBUG run nft ruleset: "delete element inet osmo-upf tunmap-pre { 1.1.1.1 . 0x6 };\ndelete element inet osmo-upf tunmap-post { 5 };\ndelete chain inet osmo-upf tunmap-pre-5;\ndelete chain inet osmo-upf tunmap-post-5;\ndelete element inet osmo-upf tunmap-pre { 1.1.1.1 . 0x5 };\ndelete element inet osmo-upf tunmap-post { 6 };\ndelete chain inet osmo-upf tunmap-pre-6;\ndelete chain inet osmo-upf tunmap-post-6;\n" +DGTP NOTICE GTP:tunmap GTP-access-r:5.6.7.8 TEID-access-r:0x106 GTP-access-l:1.1.1.1 TEID-access-l:0x6 GTP-core-r:13.14.15.16 TEID-core-r:0x107 GTP-core-l:1.1.1.1 TEID-core-l:0x5 PFCP-peer:1.2.3.4 SEID-l:0x3 PDR-access:2 PDR-core:1: Disabled tunmap, nft chain IDs: access--5-> <-6--core DSESSION DEBUG up_session(1-2-3-4-0x3){ESTABLISHED}: Freeing instance DSESSION DEBUG up_session(1-2-3-4-0x3){ESTABLISHED}: Deallocated DSESSION DEBUG up_session(1-2-3-4-0x1){ESTABLISHED}: Terminating (cause = OSMO_FSM_TERM_PARENT) @@ -391,16 +391,16 @@ [test override] nft_run_cmd_from_buffer(): delete element inet osmo-upf tunmap-pre { 1.1.1.1 . 0x4 }; -delete element inet osmo-upf tunmap-post { 1 }; -delete chain inet osmo-upf tunmap-pre-1; -delete chain inet osmo-upf tunmap-post-1; +delete element inet osmo-upf tunmap-post { 3 }; +delete chain inet osmo-upf tunmap-pre-3; +delete chain inet osmo-upf tunmap-post-3; delete element inet osmo-upf tunmap-pre { 1.1.1.1 . 0x3 }; -delete element inet osmo-upf tunmap-post { 2 }; -delete chain inet osmo-upf tunmap-pre-2; -delete chain inet osmo-upf tunmap-post-2; +delete element inet osmo-upf tunmap-post { 4 }; +delete chain inet osmo-upf tunmap-pre-4; +delete chain inet osmo-upf tunmap-post-4; -DNFT DEBUG run nft ruleset: "delete element inet osmo-upf tunmap-pre { 1.1.1.1 . 0x4 };\ndelete element inet osmo-upf tunmap-post { 1 };\ndelete chain inet osmo-upf tunmap-pre-1;\ndelete chain inet osmo-upf tunmap-post-1;\ndelete element inet osmo-upf tunmap-pre { 1.1.1.1 . 0x3 };\ndelete element inet osmo-upf tunmap-post { 2 };\ndelete chain inet osmo-upf tunmap-pre-2;\ndelete chain inet osmo-upf tunmap-post-2;\n" -DGTP NOTICE GTP:tunmap GTP-access-r:5.6.7.8 TEID-access-r:0x102 GTP-access-l:1.1.1.1 TEID-access-l:0x4 GTP-core-r:13.14.15.16 TEID-core-r:0x103 GTP-core-l:1.1.1.1 TEID-core-l:0x3 PFCP-peer:1.2.3.4 SEID-l:0x2 PDR-access:2 PDR-core:1: Disabled tunmap, nft chain IDs: access--1-> <-2--core +DNFT DEBUG run nft ruleset: "delete element inet osmo-upf tunmap-pre { 1.1.1.1 . 0x4 };\ndelete element inet osmo-upf tunmap-post { 3 };\ndelete chain inet osmo-upf tunmap-pre-3;\ndelete chain inet osmo-upf tunmap-post-3;\ndelete element inet osmo-upf tunmap-pre { 1.1.1.1 . 0x3 };\ndelete element inet osmo-upf tunmap-post { 4 };\ndelete chain inet osmo-upf tunmap-pre-4;\ndelete chain inet osmo-upf tunmap-post-4;\n" +DGTP NOTICE GTP:tunmap GTP-access-r:5.6.7.8 TEID-access-r:0x102 GTP-access-l:1.1.1.1 TEID-access-l:0x4 GTP-core-r:13.14.15.16 TEID-core-r:0x103 GTP-core-l:1.1.1.1 TEID-core-l:0x3 PFCP-peer:1.2.3.4 SEID-l:0x2 PDR-access:2 PDR-core:1: Disabled tunmap, nft chain IDs: access--3-> <-4--core DSESSION DEBUG up_session(1-2-3-4-0x2){ESTABLISHED}: Freeing instance DSESSION DEBUG up_session(1-2-3-4-0x2){ESTABLISHED}: Deallocated DPEER NOTICE up_peer(1-2-3-4){ASSOCIATED}: Peer removed -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/31483 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I139b46de0bd15185a7a06109d55f7c759755ec81 Gerrit-Change-Number: 31483 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[XL] Change in osmo-upf[master]: add unique_ids_test.c
by neels 18 Mar '23

18 Mar '23

neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/31482 ) Change subject: add unique_ids_test.c ...................................................................... add unique_ids_test.c Verify that skipping used IDs works for: - PFCP UP-SEID - GTP local TEID - chain_id for nft rulesets -- so far expected to fail, fix follows in I139b46de0bd15185a7a06109d55f7c759755ec81. Related: OS#5900 Change-Id: I36acff15f22d23ade4d281c2af3eb117dfc10359 --- M configure.ac M include/osmocom/upf/up_endpoint.h M include/osmocom/upf/up_session.h M include/osmocom/upf/upf.h M src/osmo-upf/up_endpoint.c M src/osmo-upf/up_peer.c M src/osmo-upf/up_session.c M src/osmo-upf/upf.c M src/osmo-upf/upf_nft.c M tests/Makefile.am M tests/testsuite.at A tests/unique_ids/Makefile.am A tests/unique_ids/unique_ids_test.c A tests/unique_ids/unique_ids_test.err A tests/unique_ids/unique_ids_test.ok 15 files changed, 1,092 insertions(+), 24 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/configure.ac b/configure.ac index 0108f92..5181131 100644 --- a/configure.ac +++ b/configure.ac @@ -203,6 +203,7 @@ src/osmo-pfcp-tool/Makefile tests/Makefile tests/atlocal + tests/unique_ids/Makefile doc/Makefile doc/examples/Makefile doc/manuals/Makefile diff --git a/include/osmocom/upf/up_endpoint.h b/include/osmocom/upf/up_endpoint.h index 58fe01c..ac240cd 100644 --- a/include/osmocom/upf/up_endpoint.h +++ b/include/osmocom/upf/up_endpoint.h @@ -41,7 +41,8 @@ uint64_t next_up_seid_state; }; -struct up_endpoint *up_endpoint_init(void *ctx, const struct osmo_sockaddr *local_addr); +struct up_endpoint *up_endpoint_alloc(void *ctx, const struct osmo_sockaddr *local_addr); +int up_endpoint_bind(struct up_endpoint *up_ep); void up_endpoint_free(struct up_endpoint **ep); uint64_t up_endpoint_next_up_seid(struct up_endpoint *ep); diff --git a/include/osmocom/upf/up_session.h b/include/osmocom/upf/up_session.h index 215a414..c424df9 100644 --- a/include/osmocom/upf/up_session.h +++ b/include/osmocom/upf/up_session.h @@ -66,8 +66,7 @@ struct llist_head active_gtp_actions; }; -struct up_session *up_session_find_or_add(struct up_peer *peer, const struct osmo_pfcp_ie_f_seid *cp_f_seid, - const struct osmo_pfcp_ie_f_seid *up_f_seid); +struct up_session *up_session_find_or_add(struct up_peer *peer, const struct osmo_pfcp_ie_f_seid *cp_f_seid); struct up_session *up_session_find_by_up_seid(struct up_peer *peer, uint64_t up_seid); struct up_session *up_session_find_by_cp_f_seid(struct up_peer *peer, const struct osmo_pfcp_ie_f_seid *cp_f_seid); struct up_session *up_session_find_by_local_teid(struct up_peer *peer, uint32_t teid); diff --git a/include/osmocom/upf/upf.h b/include/osmocom/upf/upf.h index 041edea..c1dc39a 100644 --- a/include/osmocom/upf/upf.h +++ b/include/osmocom/upf/upf.h @@ -134,7 +134,8 @@ void g_upf_alloc(void *ctx); void upf_vty_init(); -int upf_pfcp_listen(); +int upf_pfcp_init(void); +int upf_pfcp_listen(void); int upf_gtp_devs_open(); void upf_gtp_devs_close(); diff --git a/src/osmo-upf/up_endpoint.c b/src/osmo-upf/up_endpoint.c index 7a2628a..34351a6 100644 --- a/src/osmo-upf/up_endpoint.c +++ b/src/osmo-upf/up_endpoint.c @@ -233,9 +233,8 @@ } } -struct up_endpoint *up_endpoint_init(void *ctx, const struct osmo_sockaddr *local_addr) +struct up_endpoint *up_endpoint_alloc(void *ctx, const struct osmo_sockaddr *local_addr) { - int rc; struct osmo_pfcp_endpoint_cfg cfg; struct up_endpoint *up_ep; up_ep = talloc_zero(ctx, struct up_endpoint); @@ -252,14 +251,16 @@ up_ep->pfcp_ep = osmo_pfcp_endpoint_create(up_ep, &cfg); OSMO_ASSERT(up_ep->pfcp_ep); - rc = osmo_pfcp_endpoint_bind(up_ep->pfcp_ep); - if (rc) { - talloc_free(up_ep); - return NULL; - } return up_ep; } +int up_endpoint_bind(struct up_endpoint *up_ep) +{ + OSMO_ASSERT(up_ep); + OSMO_ASSERT(up_ep->pfcp_ep); + return osmo_pfcp_endpoint_bind(up_ep->pfcp_ep); +} + static struct up_session *up_endpoint_find_session(struct up_endpoint *ep, uint64_t up_seid) { struct up_peer *peer; diff --git a/src/osmo-upf/up_peer.c b/src/osmo-upf/up_peer.c index c0e43e4..08f7d12 100644 --- a/src/osmo-upf/up_peer.c +++ b/src/osmo-upf/up_peer.c @@ -299,7 +299,7 @@ { enum osmo_pfcp_cause cause = OSMO_PFCP_CAUSE_REQUEST_ACCEPTED; struct osmo_pfcp_msg *resp; - struct up_session *session = up_session_find_or_add(peer, &m->ies.session_est_req.cp_f_seid, NULL); + struct up_session *session = up_session_find_or_add(peer, &m->ies.session_est_req.cp_f_seid); if (!session) { cause = OSMO_PFCP_CAUSE_NO_RESOURCES_AVAILABLE; diff --git a/src/osmo-upf/up_session.c b/src/osmo-upf/up_session.c index 5874f3c..593f131 100644 --- a/src/osmo-upf/up_session.c +++ b/src/osmo-upf/up_session.c @@ -1021,16 +1021,11 @@ return session; } -struct up_session *up_session_find_or_add(struct up_peer *peer, const struct osmo_pfcp_ie_f_seid *cp_f_seid, - const struct osmo_pfcp_ie_f_seid *up_f_seid) +struct up_session *up_session_find_or_add(struct up_peer *peer, const struct osmo_pfcp_ie_f_seid *cp_f_seid) { struct up_session *session; - if (cp_f_seid) - session = up_session_find_by_cp_f_seid(peer, cp_f_seid); - else if (up_f_seid) - session = up_session_find_by_up_seid(peer, up_f_seid->seid); - else - return NULL; + OSMO_ASSERT(cp_f_seid); + session = up_session_find_by_cp_f_seid(peer, cp_f_seid); if (session) return session; diff --git a/src/osmo-upf/upf.c b/src/osmo-upf/upf.c index 047a6ff..41f6f62 100644 --- a/src/osmo-upf/upf.c +++ b/src/osmo-upf/upf.c @@ -67,7 +67,7 @@ INIT_LLIST_HEAD(&g_upf->netinst); } -int upf_pfcp_listen() +int upf_pfcp_init(void) { struct osmo_sockaddr_str local_addr_str; struct osmo_sockaddr local_addr; @@ -79,9 +79,8 @@ * osmo_sockaddr. */ osmo_sockaddr_str_from_str(&local_addr_str, g_upf->pfcp.vty_cfg.local_addr, g_upf->pfcp.vty_cfg.local_port); osmo_sockaddr_str_to_sockaddr(&local_addr_str, &local_addr.u.sas); - LOGP(DLPFCP, LOGL_NOTICE, "PFCP: Listening on %s\n", osmo_sockaddr_to_str_c(OTC_SELECT, &local_addr)); - g_upf->pfcp.ep = up_endpoint_init(g_upf, &local_addr); + g_upf->pfcp.ep = up_endpoint_alloc(g_upf, &local_addr); if (!g_upf->pfcp.ep) { fprintf(stderr, "Failed to allocate PFCP endpoint.\n"); return -1; @@ -89,6 +88,26 @@ return 0; } +int upf_pfcp_listen(void) +{ + int rc; + if (!g_upf->pfcp.ep) { + rc = upf_pfcp_init(); + if (rc) + return rc; + } + + rc = up_endpoint_bind(g_upf->pfcp.ep); + if (rc) { + LOGP(DLPFCP, LOGL_ERROR, "PFCP: failed to listen on %s\n", + osmo_sockaddr_to_str_c(OTC_SELECT, osmo_pfcp_endpoint_get_local_addr(g_upf->pfcp.ep->pfcp_ep))); + return rc; + } + LOGP(DLPFCP, LOGL_NOTICE, "PFCP: Listening on %s\n", + osmo_sockaddr_to_str_c(OTC_SELECT, osmo_pfcp_endpoint_get_local_addr(g_upf->pfcp.ep->pfcp_ep))); + return 0; +} + int upf_gtp_devs_open() { struct tunend_vty_cfg *c = &g_upf->tunend.vty_cfg; diff --git a/src/osmo-upf/upf_nft.c b/src/osmo-upf/upf_nft.c index ed3b921..e91443b 100644 --- a/src/osmo-upf/upf_nft.c +++ b/src/osmo-upf/upf_nft.c @@ -81,7 +81,7 @@ return -EIO; } - LOGP(DNFT, LOGL_DEBUG, "set up nft ruleset: %s\n", osmo_quote_str_c(OTC_SELECT, ruleset, -1)); + LOGP(DNFT, LOGL_DEBUG, "run nft ruleset: %s\n", osmo_quote_str_c(OTC_SELECT, ruleset, -1)); return 0; } diff --git a/tests/Makefile.am b/tests/Makefile.am index dbdb5f2..5e1d517 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -1,3 +1,7 @@ +SUBDIRS = \ + unique_ids \ + $(NULL) + # The `:;' works around a Bash 3.2 bug when the output is not writeable. $(srcdir)/package.m4: $(top_srcdir)/configure.ac :;{ \ diff --git a/tests/testsuite.at b/tests/testsuite.at index 09a77c3..45a5145 100644 --- a/tests/testsuite.at +++ b/tests/testsuite.at @@ -1,2 +1,9 @@ AT_INIT AT_BANNER([Regression tests.]) + +AT_SETUP([unique_ids_test]) +AT_KEYWORDS([unique_ids_test]) +cat $abs_srcdir/unique_ids/unique_ids_test.ok > expout +cat $abs_srcdir/unique_ids/unique_ids_test.err > experr +AT_CHECK([$abs_top_builddir/tests/unique_ids/unique_ids_test], [], [expout], [experr]) +AT_CLEANUP diff --git a/tests/unique_ids/Makefile.am b/tests/unique_ids/Makefile.am new file mode 100644 index 0000000..45eb9f9 --- /dev/null +++ b/tests/unique_ids/Makefile.am @@ -0,0 +1,41 @@ +AM_CPPFLAGS = \ + -I$(top_srcdir)/include \ + $(NULL) + +AM_CFLAGS = \ + -Wall \ + $(LIBOSMOCORE_CFLAGS) \ + $(LIBOSMOVTY_CFLAGS) \ + $(LIBOSMOCTRL_CFLAGS) \ + $(LIBOSMOGTLV_CFLAGS) \ + $(LIBOSMOPFCP_CFLAGS) \ + $(LIBGTPNL_CFLAGS) \ + $(LIBNFTNL_CFLAGS) \ + $(LIBNFTABLES_CFLAGS) \ + $(COVERAGE_CFLAGS) \ + $(NULL) + +EXTRA_DIST = \ + unique_ids_test.ok \ + unique_ids_test.err \ + $(NULL) + +check_PROGRAMS = \ + unique_ids_test \ + $(NULL) + +unique_ids_test_SOURCES = \ + unique_ids_test.c \ + $(NULL) + +unique_ids_test_LDADD = \ + $(top_builddir)/src/osmo-upf/libupf.la \ + $(NULL) + +unique_ids_test_LDFLAGS = \ + -no-install \ + $(NULL) + +.PHONY: update_exp +update_exp: + $(builddir)/unique_ids_test >$(srcdir)/unique_ids_test.ok 2>$(srcdir)/unique_ids_test.err diff --git a/tests/unique_ids/unique_ids_test.c b/tests/unique_ids/unique_ids_test.c new file mode 100644 index 0000000..52cd9e8 --- /dev/null +++ b/tests/unique_ids/unique_ids_test.c @@ -0,0 +1,571 @@ +/* OsmoUPF: Verify that skipping used ids works for: UP-SEID, GTP local TEID, nft ruleset chain_id. */ + +/* (C) 2023 by sysmocom - s.f.m.c. GmbH <info(a)sysmocom.de> + * + * All Rights Reserved + * + * Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> + * + * SPDX-License-Identifier: GPL-2.0+ + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program. If not, see <http://www.gnu.org/licenses/>. + * + */ + +#include <getopt.h> + +#include <nftables/libnftables.h> + +#include <osmocom/core/sockaddr_str.h> +#include <osmocom/core/application.h> + +#include <osmocom/pfcp/pfcp_endpoint.h> + +#include <osmocom/upf/upf.h> +#include <osmocom/upf/netinst.h> +#include <osmocom/upf/up_endpoint.h> +#include <osmocom/upf/up_peer.h> +#include <osmocom/upf/up_session.h> +#include <osmocom/upf/up_gtp_action.h> + +#define log(FMT, ARGS...) fprintf(stderr, FMT, ##ARGS) +#define log_assert(COND) do { \ + log("assert(" #COND ")\n"); \ + OSMO_ASSERT(COND); \ + } while (0) + +#define log_assert_expect_failure(COND) do { \ + log("assert(" #COND ") <-- EXPECTED TO FAIL (known error)\n"); \ + OSMO_ASSERT(!(COND)); \ + } while (0) + + +void *main_ctx; +void *ctx; + +/* The override of osmo_pfcp_endpoint_tx() stores any Session Establishment Response's UP-SEID here, so that this test + * can reference specific sessions later. + */ +uint64_t last_up_seid = 0; + +void select_poll(void) +{ + while (osmo_select_main_ctx(1)); +} + +static void setup(const char *name) +{ + log("\n===== START of %s\n", name); + ctx = talloc_named_const(main_ctx, 0, name); + g_upf_alloc(ctx); + osmo_talloc_replace_string(g_upf, &g_upf->pfcp.vty_cfg.local_addr, "1.1.1.1"); + + OSMO_ASSERT(netinst_add(g_upf, &g_upf->netinst, "default", "1.1.1.1", NULL)); + + /* PFCP endpoint recovery timestamp overridden by time() below */ + upf_pfcp_init(); + /* but do not upf_pfcp_listen() */ + + upf_nft_init(); + + select_poll(); + log("\n"); +} + +static void cleanup(void) +{ + up_endpoint_free(&g_upf->pfcp.ep); + upf_gtp_devs_close(); + + upf_gtp_genl_close(); + + upf_nft_free(); + + log("\n===== END of %s\n", talloc_get_name(ctx)); + talloc_free(ctx); +} + +static struct osmo_sockaddr *str2addr(const char *addr, uint16_t port) +{ + static struct osmo_sockaddr osa; + struct osmo_sockaddr_str str; + osmo_sockaddr_str_from_str(&str, addr, port); + osmo_sockaddr_str_to_sockaddr(&str, &osa.u.sas); + return &osa; +} + +static struct up_peer *have_peer(const char *remote_addr, uint16_t port) +{ + return up_peer_find_or_add(g_upf->pfcp.ep, str2addr(remote_addr, port)); +} + +static struct osmo_pfcp_msg *new_pfcp_msg_for_osmo_upf_rx(struct up_peer *from_peer, enum osmo_pfcp_message_type msg_type) +{ + /* pfcp_endpoint discards received messages immediately after dispatching; in this test, allocate them in + * OTC_SELECT so they get discarded on the next select_poll(). + * osmo_pfcp_msg_alloc_rx() is not useful here, it creates a blank struct to be decoded from raw data; instead, + * use osmo_pfcp_msg_alloc_tx_req() which properly sets up the internal structures to match the given msg_type, + * and when that is done set m->rx = true to indicate it is a message received by osmo-upf. */ + struct osmo_pfcp_msg *m = osmo_pfcp_msg_alloc_tx_req(OTC_SELECT, &from_peer->remote_addr, msg_type); + m->rx = true; + return m; +} + +static void peer_assoc(struct up_peer *peer) +{ + struct osmo_pfcp_msg *m = new_pfcp_msg_for_osmo_upf_rx(peer, OSMO_PFCP_MSGT_ASSOC_SETUP_REQ); + m->ies.assoc_setup_req.recovery_time_stamp = 1234; + osmo_fsm_inst_dispatch(peer->fi, UP_PEER_EV_RX_ASSOC_SETUP_REQ, m); + select_poll(); +} + +static int next_teid = 0x100; +static int next_cp_seid = 0x100; + +/* Send a PFCP Session Establishment Request, and return the created session */ +static struct up_session *session_est_tunmap(struct up_peer *peer) +{ + struct osmo_pfcp_msg *m; + + struct osmo_pfcp_ie_f_seid cp_f_seid; + + struct osmo_pfcp_ie_f_teid f_teid_access_local; + struct osmo_pfcp_ie_outer_header_creation ohc_access; + + struct osmo_pfcp_ie_f_teid f_teid_core_local; + struct osmo_pfcp_ie_outer_header_creation ohc_core; + + struct osmo_pfcp_ie_apply_action aa = {}; + + osmo_pfcp_bits_set(aa.bits, OSMO_PFCP_APPLY_ACTION_FORW, true); + + f_teid_access_local = (struct osmo_pfcp_ie_f_teid){ + .choose_flag = true, + .choose = { + .ipv4_addr = true, + }, + }; + + ohc_access = (struct osmo_pfcp_ie_outer_header_creation){ + .teid_present = true, + .teid = next_teid++, + .ip_addr = { + .v4_present = true, + .v4 = *str2addr("5.6.7.8", 0), + }, + }; + osmo_pfcp_bits_set(ohc_access.desc_bits, OSMO_PFCP_OUTER_HEADER_CREATION_GTP_U_UDP_IPV4, true); + + f_teid_core_local = (struct osmo_pfcp_ie_f_teid){ + .choose_flag = true, + .choose = { + .ipv4_addr = true, + }, + }; + + ohc_core = (struct osmo_pfcp_ie_outer_header_creation){ + .teid_present = true, + .teid = next_teid++, + .ip_addr = { + .v4_present = true, + .v4 = *str2addr("13.14.15.16", 0), + }, + }; + osmo_pfcp_bits_set(ohc_core.desc_bits, OSMO_PFCP_OUTER_HEADER_CREATION_GTP_U_UDP_IPV4, true); + + cp_f_seid = (struct osmo_pfcp_ie_f_seid){ + .seid = next_cp_seid++, + }; + osmo_pfcp_ip_addrs_set(&cp_f_seid.ip_addr, osmo_pfcp_endpoint_get_local_addr(g_upf->pfcp.ep->pfcp_ep)); + + m = new_pfcp_msg_for_osmo_upf_rx(peer, OSMO_PFCP_MSGT_SESSION_EST_REQ); + m->h.seid_present = true; + m->h.seid = 0; + /* GTP tunmap: remove header from both directions, and add header in both directions */ + m->ies.session_est_req = (struct osmo_pfcp_msg_session_est_req){ + .node_id = m->ies.session_est_req.node_id, + .cp_f_seid_present = true, + .cp_f_seid = cp_f_seid, + .create_pdr_count = 2, + .create_pdr = { + { + .pdr_id = 1, + .precedence = 255, + .pdi = { + .source_iface = OSMO_PFCP_SOURCE_IFACE_CORE, + .local_f_teid_present = true, + .local_f_teid = f_teid_core_local, + }, + .outer_header_removal_present = true, + .outer_header_removal = { + .desc = OSMO_PFCP_OUTER_HEADER_REMOVAL_GTP_U_UDP_IPV4, + }, + .far_id_present = true, + .far_id = 1, + }, + { + .pdr_id = 2, + .precedence = 255, + .pdi = { + .source_iface = OSMO_PFCP_SOURCE_IFACE_ACCESS, + .local_f_teid_present = true, + .local_f_teid = f_teid_access_local, + }, + .outer_header_removal_present = true, + .outer_header_removal = { + .desc = OSMO_PFCP_OUTER_HEADER_REMOVAL_GTP_U_UDP_IPV4, + }, + .far_id_present = true, + .far_id = 2, + }, + }, + .create_far_count = 2, + .create_far = { + { + .far_id = 1, + .forw_params_present = true, + .forw_params = { + .destination_iface = OSMO_PFCP_DEST_IFACE_ACCESS, + .outer_header_creation_present = true, + .outer_header_creation = ohc_access, + }, + .apply_action = aa, + }, + { + .far_id = 2, + .forw_params_present = true, + .forw_params = { + .destination_iface = OSMO_PFCP_DEST_IFACE_CORE, + .outer_header_creation_present = true, + .outer_header_creation = ohc_core, + }, + .apply_action = aa, + }, + }, + }; + + osmo_fsm_inst_dispatch(peer->fi, UP_PEER_EV_RX_SESSION_EST_REQ, m); + select_poll(); + + return up_session_find_by_up_seid(peer, last_up_seid); +} + +static void session_del(struct up_session *session) +{ + struct osmo_pfcp_msg *m; + + log_assert(session); + + m = new_pfcp_msg_for_osmo_upf_rx(session->up_peer, OSMO_PFCP_MSGT_SESSION_DEL_REQ); + m->h.seid_present = true; + m->h.seid = session->up_seid; + + osmo_fsm_inst_dispatch(session->fi, UP_SESSION_EV_RX_SESSION_DEL_REQ, m); + select_poll(); +} + +static void dump_state(void) +{ + struct up_peer *peer; + log("\n state:\n"); + llist_for_each_entry(peer, &g_upf->pfcp.ep->peers, entry) { + struct up_session *session; + int bkt; + log(" | peer %s %s\n", peer->fi->name, osmo_fsm_inst_state_name(peer->fi)); + hash_for_each(peer->sessions_by_up_seid, bkt, session, node_by_up_seid) { + struct up_gtp_action *a; + llist_for_each_entry(a, &session->active_gtp_actions, entry) { + if (a->kind != UP_GTP_U_TUNMAP) + continue; + log(" | session[%s]: UP-SEID 0x%"PRIx64"; chain_id access=%u core=%u;" + " local TEID access=0x%x core=0x%x\n", + osmo_fsm_inst_state_name(session->fi), + session->up_seid, + a->tunmap.access.chain_id, a->tunmap.core.chain_id, + a->tunmap.access.tun.local.teid, a->tunmap.core.tun.local.teid); + } + } + } + log("\n"); +} + +static void test_skip_used_id(void) +{ + struct up_peer *peer; + struct up_session *s1; + uint64_t s1_up_seid; + struct up_session *s2; + struct up_session *s3; + struct up_session *s4; + struct up_gtp_action *a; + + setup(__func__); + + log("PFCP Associate peer\n"); + peer = have_peer("1.2.3.4", 1234); + peer_assoc(peer); + dump_state(); + + /* Make sure to start out all IDs with 1 */ + g_upf->pfcp.ep->next_up_seid_state = 0; + g_upf->gtp.next_local_teid_state = 0; + g_upf->tunmap.next_chain_id_state = 0; + + log("set up tunmap, which assigns first UP-SEID 0x1, local-TEID 0x1 and 0x2, chain_ids 1 and 2\n"); + s1 = session_est_tunmap(peer); + dump_state(); + + log_assert(s1->up_seid == 1); + log_assert(a = llist_first_entry_or_null(&s1->active_gtp_actions, struct up_gtp_action, entry)); + log_assert(a->kind == UP_GTP_U_TUNMAP); + log_assert(a->tunmap.core.tun.local.teid == 1); + log_assert(a->tunmap.access.tun.local.teid == 2); + log_assert(a->tunmap.access.chain_id == 1); + log_assert(a->tunmap.core.chain_id == 2); + log("\n"); + + log("simulate wrapping of IDs back to 1\n"); + g_upf->pfcp.ep->next_up_seid_state = 0; + g_upf->gtp.next_local_teid_state = 0; + g_upf->tunmap.next_chain_id_state = 0; + + log("set up second tunmap, should use distinct IDs\n"); + s2 = session_est_tunmap(peer); + dump_state(); + + log_assert(s2->up_seid == 2); + log_assert(a = llist_first_entry_or_null(&s2->active_gtp_actions, struct up_gtp_action, entry)); + log_assert(a->kind == UP_GTP_U_TUNMAP); + log_assert(a->tunmap.core.tun.local.teid == 3); + log_assert(a->tunmap.access.tun.local.teid == 4); + log_assert_expect_failure(a->tunmap.access.chain_id == 3); + log_assert_expect_failure(a->tunmap.core.chain_id == 4); + log("\n"); + + log("drop first tunmap (%s)\n", s1->fi->name); + s1_up_seid = s1->up_seid; + session_del(s1); + dump_state(); + log_assert(up_session_find_by_up_seid(peer, s1_up_seid) == NULL); + log("\n"); + + log("again wrap all ID state back to 1\n"); + g_upf->pfcp.ep->next_up_seid_state = 0; + g_upf->gtp.next_local_teid_state = 0; + g_upf->tunmap.next_chain_id_state = 0; + + log("set up third tunmap, should now re-use same IDs as the first session\n"); + s3 = session_est_tunmap(peer); + dump_state(); + + log_assert(s3->up_seid == 1); + log_assert(a = llist_first_entry_or_null(&s3->active_gtp_actions, struct up_gtp_action, entry)); + log_assert(a->kind == UP_GTP_U_TUNMAP); + log_assert(a->tunmap.core.tun.local.teid == 1); + log_assert(a->tunmap.access.tun.local.teid == 2); + log_assert(a->tunmap.access.chain_id == 1); + log_assert(a->tunmap.core.chain_id == 2); + log("\n"); + + log("set up 4th tunmap; chain_id state would use 3 and 4, but they are in use, so should assign 5 and 6\n"); + s4 = session_est_tunmap(peer); + dump_state(); + + log_assert(s4->up_seid == 3); + log_assert(a = llist_first_entry_or_null(&s4->active_gtp_actions, struct up_gtp_action, entry)); + log_assert(a->kind == UP_GTP_U_TUNMAP); + log_assert(a->tunmap.core.tun.local.teid == 5); + log_assert(a->tunmap.access.tun.local.teid == 6); + log_assert_expect_failure(a->tunmap.access.chain_id == 5); + log_assert_expect_failure(a->tunmap.core.chain_id == 6); + log("\n"); + + cleanup(); +} + +static const struct log_info_cat test_default_categories[] = { + [DREF] = { + .name = "DREF", + .description = "Reference Counting", + .enabled = 1, .loglevel = LOGL_DEBUG, + .color = OSMO_LOGCOLOR_DARKGREY, + }, + [DPEER] = { + .name = "DPEER", + .description = "PFCP peer association", + .enabled = 1, .loglevel = LOGL_DEBUG, + .color = OSMO_LOGCOLOR_YELLOW, + }, + [DSESSION] = { + .name = "DSESSION", + .description = "PFCP sessions", + .enabled = 1, .loglevel = LOGL_DEBUG, + .color = OSMO_LOGCOLOR_BLUE, + }, + [DGTP] = { + .name = "DGTP", + .description = "GTP tunneling", + .enabled = 1, .loglevel = LOGL_DEBUG, + .color = OSMO_LOGCOLOR_PURPLE, + }, + [DNFT] = { + .name = "DNFT", + .description = "GTP forwarding rules via linux netfilter", + .enabled = 1, .loglevel = LOGL_DEBUG, + .color = OSMO_LOGCOLOR_PURPLE, + }, +}; + +const struct log_info log_info = { + .cat = test_default_categories, + .num_cat = ARRAY_SIZE(test_default_categories), +}; + +static struct { + bool verbose; +} cmdline_opts = { + .verbose = false, +}; + +static void print_help(const char *program) +{ + printf("Usage:\n" + " %s [-v]\n" + "Options:\n" + " -h --help show this text.\n" + " -v --verbose print source file and line numbers\n", + program + ); +} + +static void handle_options(int argc, char **argv) +{ + while (1) { + int option_index = 0, c; + static struct option long_options[] = { + {"help", 0, 0, 'h'}, + {"verbose", 1, 0, 'v'}, + {0, 0, 0, 0} + }; + + c = getopt_long(argc, argv, "hv", + long_options, &option_index); + if (c == -1) + break; + + switch (c) { + case 'h': + print_help(argv[0]); + exit(0); + case 'v': + cmdline_opts.verbose = true; + break; + default: + /* catch unknown options *as well as* missing arguments. */ + fprintf(stderr, "Error in command line options. Exiting.\n"); + exit(-1); + break; + } + } +} + +int main(int argc, char **argv) +{ + handle_options(argc, argv); + + main_ctx = talloc_named_const(NULL, 0, "main"); + + msgb_talloc_ctx_init(main_ctx, 0); + + osmo_fsm_set_dealloc_ctx(OTC_SELECT); + + osmo_init_logging2(main_ctx, &log_info); + log_set_print_category_hex(osmo_stderr_target, 0); + log_set_print_category(osmo_stderr_target, 1); + log_set_print_level(osmo_stderr_target, 1); + log_set_print_timestamp(osmo_stderr_target, 0); + log_set_print_extended_timestamp(osmo_stderr_target, 0); + log_set_all_filter(osmo_stderr_target, 1); + + if (cmdline_opts.verbose) { + log_set_print_filename2(osmo_stderr_target, LOG_FILENAME_BASENAME); + log_set_print_filename_pos(osmo_stderr_target, LOG_FILENAME_POS_LINE_END); + log_set_use_color(osmo_stderr_target, 1); + } else { + log_set_print_filename2(osmo_stderr_target, LOG_FILENAME_NONE); + log_set_use_color(osmo_stderr_target, 0); + } + + osmo_fsm_log_timeouts(true); + osmo_fsm_log_addr(false); + + /* actual tests */ + test_skip_used_id(); + + log_fini(); + talloc_free(main_ctx); + return 0; +} + +/* overrides */ + +int osmo_pfcp_endpoint_tx(struct osmo_pfcp_endpoint *ep, struct osmo_pfcp_msg *m) +{ + enum osmo_pfcp_cause *cause; + + log("\n[test override] PFCP tx:\n%s\n\n", osmo_pfcp_msg_to_str_c(OTC_SELECT, m)); + + last_up_seid = 0; + + cause = osmo_pfcp_msg_cause(m); + switch (m->h.message_type) { + case OSMO_PFCP_MSGT_SESSION_EST_RESP: + if (*cause == OSMO_PFCP_CAUSE_REQUEST_ACCEPTED) { + last_up_seid = m->ies.session_est_resp.up_f_seid.seid; + log("osmo-upf created session 0x%"PRIx64"\n\n", last_up_seid); + } + break; + default: + break; + }; + osmo_pfcp_msg_free(m); + return 0; +} + +static void *fake_nft_ctx = (void *)0x1; + +struct nft_ctx *nft_ctx_new(uint32_t flags) +{ + log("[test override] %s()\n", __func__); + return fake_nft_ctx; +} + +void nft_ctx_free(struct nft_ctx *ctx) +{ + log("[test override] %s()\n", __func__); + log_assert(ctx == fake_nft_ctx); +} + +int nft_run_cmd_from_buffer(struct nft_ctx *nft, const char *buf) +{ + log("\n[test override] %s():\n%s\n", __func__, buf); + return 0; +} + +/* for deterministic recovery_time_stamp */ +time_t time(time_t *tloc) +{ + log("[test override] %s()\n", __func__); + return 0; +} diff --git a/tests/unique_ids/unique_ids_test.err b/tests/unique_ids/unique_ids_test.err new file mode 100644 index 0000000..dfd57ef --- /dev/null +++ b/tests/unique_ids/unique_ids_test.err @@ -0,0 +1,412 @@ + +===== START of test_skip_used_id +[test override] time() +[test override] time() +DLPFCP NOTICE PFCP endpoint: recovery timestamp = 0x83aa7e80 (0 seconds since UNIX epoch, which is 2208988800 seconds since NTP era 0; IETF RFC 5905) +[test override] nft_ctx_new() + +[test override] nft_run_cmd_from_buffer(): +add table inet osmo-upf { flags owner; }; + +DNFT DEBUG run nft ruleset: "add table inet osmo-upf { flags owner; };\n" +DNFT NOTICE Created nft table "osmo-upf" + +[test override] nft_run_cmd_from_buffer(): +add chain inet osmo-upf pre { type filter hook prerouting priority -300; policy accept; }; +add chain inet osmo-upf post { type filter hook postrouting priority 400; policy accept; }; +add map inet osmo-upf tunmap-pre { typeof ip daddr . @ih,32,32 : verdict; }; +add map inet osmo-upf tunmap-post { typeof meta mark : verdict; }; +add rule inet osmo-upf pre udp dport 2152 ip daddr . @ih,32,32 vmap @tunmap-pre; +add rule inet osmo-upf post meta mark vmap @tunmap-post; + +DNFT DEBUG run nft ruleset: "add chain inet osmo-upf pre { type filter hook prerouting priority -300; policy accept; };\nadd chain inet osmo-upf post { type filter hook postrouting priority 400; policy accept; };\nadd map inet osmo-upf tunmap-pre { typeof ip daddr . @ih,32,32 : verdict; };\nadd map inet osmo-upf tunmap-post { typeof meta mark : verdict; };\nadd rule inet osmo-upf pre udp dport 2152 ip daddr . @ih,32,32 vmap @tunmap-pre;\nadd rule inet osmo-upf post meta mark vmap @tunmap-post;\n" + +PFCP Associate peer +DPEER DEBUG up_peer{NOT_ASSOCIATED}: Allocated +DPEER DEBUG up_peer(1-2-3-4){NOT_ASSOCIATED}: Updated id +DPEER DEBUG up_peer(1-2-3-4){NOT_ASSOCIATED}: Received Event UP_PEER_EV_RX_ASSOC_SETUP_REQ +DPEER DEBUG up_peer(1-2-3-4){NOT_ASSOCIATED}: State change to ASSOCIATED (no timeout) +DREF INFO up_peer(1-2-3-4){ASSOCIATED}: + msg-tx: now used by 1 (msg-tx) + +[test override] PFCP tx: +PFCPv1 ASSOC_SETUP_RESP hdr={seq=0} ies={ 'Node ID'=v4:unsupported family 0 'Cause'=Request accepted (success) 'Recovery Time Stamp'=2208988800 'UP Function Features'=FTUP+BUNDL+RTTL } + +DREF INFO up_peer(1-2-3-4){ASSOCIATED}: - msg-tx: now used by 0 (-) +DPEER DEBUG up_peer(1-2-3-4){ASSOCIATED}: Received Event UP_PEER_EV_USE_COUNT_ZERO +DPEER NOTICE up_peer(1-2-3-4){ASSOCIATED}: Peer associated, Node-Id=v4:unsupported family 0. Local UP features: [FTUP+BUNDL+RTTL]; Peer CP features: [-] + + state: + | peer up_peer(1-2-3-4) ASSOCIATED + +set up tunmap, which assigns first UP-SEID 0x1, local-TEID 0x1 and 0x2, chain_ids 1 and 2 +DPEER DEBUG up_peer(1-2-3-4){ASSOCIATED}: Received Event UP_PEER_EV_RX_SESSION_EST_REQ +DSESSION DEBUG up_session(1-2-3-4){INIT}: Allocated +DSESSION DEBUG up_session(1-2-3-4){INIT}: is child of up_peer(1-2-3-4) +DSESSION INFO up_session(1-2-3-4){INIT}: Allocated new UP-SEID: 0x1 +DSESSION DEBUG up_session(1-2-3-4-0x1){INIT}: Updated id +DREF INFO up_peer(1-2-3-4){ASSOCIATED}: + msg-rx: now used by 1 (msg-rx) +DREF INFO up_session(1-2-3-4-0x1){INIT}: + msg-rx: now used by 1 (msg-rx) +DSESSION DEBUG up_session(1-2-3-4-0x1){INIT}: Received Event UP_SESSION_EV_RX_SESSION_EST_REQ +DREF DEBUG up_peer(1-2-3-4){ASSOCIATED}: + msg-tx: now used by 2 (msg-rx,msg-tx) +DREF DEBUG up_session(1-2-3-4-0x1){INIT}: + msg-tx: now used by 2 (msg-rx,msg-tx) +DSESSION INFO up_session(1-2-3-4-0x1){INIT}: Allocated new local F-TEID TEID-0x1,v4:1.1.1.1 +DSESSION INFO up_session(1-2-3-4-0x1){INIT}: New PDR-1{src:Core TEID-0x1,v4:1.1.1.1 decaps-GTP_U_UDP_IPV4} --> FAR-1{FORW dst:Access,GTP_U_UDP_IPV4,TEID:0x100,v4:5.6.7.8} +DSESSION INFO up_session(1-2-3-4-0x1){INIT}: Allocated new local F-TEID TEID-0x2,v4:1.1.1.1 +DSESSION INFO up_session(1-2-3-4-0x1){INIT}: New PDR-2{src:Access TEID-0x2,v4:1.1.1.1 decaps-GTP_U_UDP_IPV4} --> FAR-2{FORW dst:Core,GTP_U_UDP_IPV4,TEID:0x101,v4:13.14.15.16} +DSESSION DEBUG up_session(1-2-3-4-0x1){INIT}: Active PDR set: PDR-2{src:Access TEID-0x2,v4:1.1.1.1 decaps-GTP_U_UDP_IPV4} --> FAR-2{FORW dst:Core,GTP_U_UDP_IPV4,TEID:0x101,v4:13.14.15.16} +DSESSION DEBUG up_session(1-2-3-4-0x1){INIT}: Active PDR set: + PDR-1{src:Core TEID-0x1,v4:1.1.1.1 decaps-GTP_U_UDP_IPV4} --> FAR-1{FORW dst:Access,GTP_U_UDP_IPV4,TEID:0x100,v4:5.6.7.8} +DSESSION DEBUG up_session(1-2-3-4-0x1){INIT}: GTP actions: 0 previously active; want active: 1 +DSESSION DEBUG up_session(1-2-3-4-0x1){INIT}: want: GTP:tunmap GTP-access-r:5.6.7.8 TEID-access-r:0x100 GTP-access-l:1.1.1.1 TEID-access-l:0x2 GTP-core-r:13.14.15.16 TEID-core-r:0x101 GTP-core-l:1.1.1.1 TEID-core-l:0x1 PFCP-peer:1.2.3.4 SEID-l:0x1 PDR-access:2 PDR-core:1 +DSESSION DEBUG up_session(1-2-3-4-0x1){INIT}: enabling: GTP:tunmap GTP-access-r:5.6.7.8 TEID-access-r:0x100 GTP-access-l:1.1.1.1 TEID-access-l:0x2 GTP-core-r:13.14.15.16 TEID-core-r:0x101 GTP-core-l:1.1.1.1 TEID-core-l:0x1 PFCP-peer:1.2.3.4 SEID-l:0x1 PDR-access:2 PDR-core:1 + +[test override] nft_run_cmd_from_buffer(): +add chain inet osmo-upf tunmap-pre-1; +add rule inet osmo-upf tunmap-pre-1 ip daddr set 13.14.15.16 meta mark set 1 counter accept; +add chain inet osmo-upf tunmap-post-1; +add rule inet osmo-upf tunmap-post-1 ip saddr set 1.1.1.1 @ih,32,32 set 0x101 counter accept; +add element inet osmo-upf tunmap-pre { 1.1.1.1 . 0x2 : jump tunmap-pre-1 }; +add element inet osmo-upf tunmap-post { 1 : jump tunmap-post-1 }; +add chain inet osmo-upf tunmap-pre-2; +add rule inet osmo-upf tunmap-pre-2 ip daddr set 5.6.7.8 meta mark set 2 counter accept; +add chain inet osmo-upf tunmap-post-2; +add rule inet osmo-upf tunmap-post-2 ip saddr set 1.1.1.1 @ih,32,32 set 0x100 counter accept; +add element inet osmo-upf tunmap-pre { 1.1.1.1 . 0x1 : jump tunmap-pre-2 }; +add element inet osmo-upf tunmap-post { 2 : jump tunmap-post-2 }; + +DNFT DEBUG run nft ruleset: "add chain inet osmo-upf tunmap-pre-1;\nadd rule inet osmo-upf tunmap-pre-1 ip daddr set 13.14.15.16 meta mark set 1 counter accept;\nadd chain inet osmo-upf tunmap-post-1;\nadd rule inet osmo-upf tunmap-post-1 ip saddr set 1.1.1.1 @ih,32,32 set 0x101 counter accept;\nadd element inet osmo-upf tunmap-pre { 1.1.1.1 . 0x2 : jump tunmap-pre-1 };\nadd element inet osmo-upf tunmap-post { 1 : jump tunmap-post-1 };\nadd chain inet osmo-upf tunmap-pre-2;\nadd rule inet osmo-upf tunmap-pre-2 ip daddr set 5.6.7.8 meta mark set 2 counter accept;\nadd chain inet osmo-upf tunmap-post-2;\nadd rule inet osmo-upf tunmap-post-2 ip saddr set 1.1.1.1 @ih,32,32 set 0x100 counter accept;\nadd element inet osmo-upf tunmap-pre { 1.1.1.1 . 0x1 : jump tunmap-pre-2 };\nadd element inet osmo-upf tunmap-post { 2 : jump tunmap-post-2 };\n" +DGTP NOTICE GTP:tunmap GTP-access-r:5.6.7.8 TEID-access-r:0x100 GTP-access-l:1.1.1.1 TEID-access-l:0x2 GTP-core-r:13.14.15.16 TEID-core-r:0x101 GTP-core-l:1.1.1.1 TEID-core-l:0x1 PFCP-peer:1.2.3.4 SEID-l:0x1 PDR-access:2 PDR-core:1: Enabled tunmap, nft chain IDs: access--1-> <-2--core + +[test override] PFCP tx: +PFCPv1 SESSION_EST_RESP hdr={seq=0 SEID=0x100} ies={ 'Node ID'=v4:unsupported family 0 'Cause'=Request accepted (success) 'F-SEID'=0x1,v4:1.1.1.1 'Created PDR'={ { 'PDR ID'=1 'F-TEID'=TEID-0x1,v4:1.1.1.1 }, { 'PDR ID'=2 'F-TEID'=TEID-0x2,v4:1.1.1.1 } } } + +osmo-upf created session 0x1 + +DREF DEBUG up_session(1-2-3-4-0x1){INIT}: - msg-tx: now used by 1 (msg-rx) +DREF DEBUG up_peer(1-2-3-4){ASSOCIATED}: - msg-tx: now used by 1 (msg-rx) +DSESSION DEBUG up_session(1-2-3-4-0x1){INIT}: State change to ESTABLISHED (no timeout) +DSESSION NOTICE up_session(1-2-3-4-0x1){ESTABLISHED}: Session established: peer:1.2.3.4 SEID-r:0x100 SEID-l:0x1 state:ESTABLISHED PDR-active:2/2 FAR-active:2/2 GTP-active:1 +DREF INFO up_session(1-2-3-4-0x1){ESTABLISHED}: - msg-rx: now used by 0 (-) +DSESSION DEBUG up_session(1-2-3-4-0x1){ESTABLISHED}: Received Event UP_SESSION_EV_USE_COUNT_ZERO +DREF INFO up_peer(1-2-3-4){ASSOCIATED}: - msg-rx: now used by 0 (-) +DPEER DEBUG up_peer(1-2-3-4){ASSOCIATED}: Received Event UP_PEER_EV_USE_COUNT_ZERO + + state: + | peer up_peer(1-2-3-4) ASSOCIATED + | session[ESTABLISHED]: UP-SEID 0x1; chain_id access=1 core=2; local TEID access=0x2 core=0x1 + +assert(s1->up_seid == 1) +assert(a = llist_first_entry_or_null(&s1->active_gtp_actions, struct up_gtp_action, entry)) +assert(a->kind == UP_GTP_U_TUNMAP) +assert(a->tunmap.core.tun.local.teid == 1) +assert(a->tunmap.access.tun.local.teid == 2) +assert(a->tunmap.access.chain_id == 1) +assert(a->tunmap.core.chain_id == 2) + +simulate wrapping of IDs back to 1 +set up second tunmap, should use distinct IDs +DPEER DEBUG up_peer(1-2-3-4){ASSOCIATED}: Received Event UP_PEER_EV_RX_SESSION_EST_REQ +DSESSION DEBUG up_session(1-2-3-4){INIT}: Allocated +DSESSION DEBUG up_session(1-2-3-4){INIT}: is child of up_peer(1-2-3-4) +DSESSION INFO up_session(1-2-3-4){INIT}: Allocated new UP-SEID: 0x2 +DSESSION DEBUG up_session(1-2-3-4-0x2){INIT}: Updated id +DREF INFO up_peer(1-2-3-4){ASSOCIATED}: + msg-rx: now used by 1 (msg-rx) +DREF INFO up_session(1-2-3-4-0x2){INIT}: + msg-rx: now used by 1 (msg-rx) +DSESSION DEBUG up_session(1-2-3-4-0x2){INIT}: Received Event UP_SESSION_EV_RX_SESSION_EST_REQ +DREF DEBUG up_peer(1-2-3-4){ASSOCIATED}: + msg-tx: now used by 2 (msg-rx,msg-tx) +DREF DEBUG up_session(1-2-3-4-0x2){INIT}: + msg-tx: now used by 2 (msg-rx,msg-tx) +DSESSION INFO up_session(1-2-3-4-0x2){INIT}: Allocated new local F-TEID TEID-0x3,v4:1.1.1.1 +DSESSION INFO up_session(1-2-3-4-0x2){INIT}: New PDR-1{src:Core TEID-0x3,v4:1.1.1.1 decaps-GTP_U_UDP_IPV4} --> FAR-1{FORW dst:Access,GTP_U_UDP_IPV4,TEID:0x102,v4:5.6.7.8} +DSESSION INFO up_session(1-2-3-4-0x2){INIT}: Allocated new local F-TEID TEID-0x4,v4:1.1.1.1 +DSESSION INFO up_session(1-2-3-4-0x2){INIT}: New PDR-2{src:Access TEID-0x4,v4:1.1.1.1 decaps-GTP_U_UDP_IPV4} --> FAR-2{FORW dst:Core,GTP_U_UDP_IPV4,TEID:0x103,v4:13.14.15.16} +DSESSION DEBUG up_session(1-2-3-4-0x2){INIT}: Active PDR set: PDR-2{src:Access TEID-0x4,v4:1.1.1.1 decaps-GTP_U_UDP_IPV4} --> FAR-2{FORW dst:Core,GTP_U_UDP_IPV4,TEID:0x103,v4:13.14.15.16} +DSESSION DEBUG up_session(1-2-3-4-0x2){INIT}: Active PDR set: + PDR-1{src:Core TEID-0x3,v4:1.1.1.1 decaps-GTP_U_UDP_IPV4} --> FAR-1{FORW dst:Access,GTP_U_UDP_IPV4,TEID:0x102,v4:5.6.7.8} +DSESSION DEBUG up_session(1-2-3-4-0x2){INIT}: GTP actions: 0 previously active; want active: 1 +DSESSION DEBUG up_session(1-2-3-4-0x2){INIT}: want: GTP:tunmap GTP-access-r:5.6.7.8 TEID-access-r:0x102 GTP-access-l:1.1.1.1 TEID-access-l:0x4 GTP-core-r:13.14.15.16 TEID-core-r:0x103 GTP-core-l:1.1.1.1 TEID-core-l:0x3 PFCP-peer:1.2.3.4 SEID-l:0x2 PDR-access:2 PDR-core:1 +DSESSION DEBUG up_session(1-2-3-4-0x2){INIT}: enabling: GTP:tunmap GTP-access-r:5.6.7.8 TEID-access-r:0x102 GTP-access-l:1.1.1.1 TEID-access-l:0x4 GTP-core-r:13.14.15.16 TEID-core-r:0x103 GTP-core-l:1.1.1.1 TEID-core-l:0x3 PFCP-peer:1.2.3.4 SEID-l:0x2 PDR-access:2 PDR-core:1 + +[test override] nft_run_cmd_from_buffer(): +add chain inet osmo-upf tunmap-pre-1; +add rule inet osmo-upf tunmap-pre-1 ip daddr set 13.14.15.16 meta mark set 1 counter accept; +add chain inet osmo-upf tunmap-post-1; +add rule inet osmo-upf tunmap-post-1 ip saddr set 1.1.1.1 @ih,32,32 set 0x103 counter accept; +add element inet osmo-upf tunmap-pre { 1.1.1.1 . 0x4 : jump tunmap-pre-1 }; +add element inet osmo-upf tunmap-post { 1 : jump tunmap-post-1 }; +add chain inet osmo-upf tunmap-pre-2; +add rule inet osmo-upf tunmap-pre-2 ip daddr set 5.6.7.8 meta mark set 2 counter accept; +add chain inet osmo-upf tunmap-post-2; +add rule inet osmo-upf tunmap-post-2 ip saddr set 1.1.1.1 @ih,32,32 set 0x102 counter accept; +add element inet osmo-upf tunmap-pre { 1.1.1.1 . 0x3 : jump tunmap-pre-2 }; +add element inet osmo-upf tunmap-post { 2 : jump tunmap-post-2 }; + +DNFT DEBUG run nft ruleset: "add chain inet osmo-upf tunmap-pre-1;\nadd rule inet osmo-upf tunmap-pre-1 ip daddr set 13.14.15.16 meta mark set 1 counter accept;\nadd chain inet osmo-upf tunmap-post-1;\nadd rule inet osmo-upf tunmap-post-1 ip saddr set 1.1.1.1 @ih,32,32 set 0x103 counter accept;\nadd element inet osmo-upf tunmap-pre { 1.1.1.1 . 0x4 : jump tunmap-pre-1 };\nadd element inet osmo-upf tunmap-post { 1 : jump tunmap-post-1 };\nadd chain inet osmo-upf tunmap-pre-2;\nadd rule inet osmo-upf tunmap-pre-2 ip daddr set 5.6.7.8 meta mark set 2 counter accept;\nadd chain inet osmo-upf tunmap-post-2;\nadd rule inet osmo-upf tunmap-post-2 ip saddr set 1.1.1.1 @ih,32,32 set 0x102 counter accept;\nadd element inet osmo-upf tunmap-pre { 1.1.1.1 . 0x3 : jump tunmap-pre-2 };\nadd element inet osmo-upf tunmap-post { 2 : jump tunmap-post-2 };\n" +DGTP NOTICE GTP:tunmap GTP-access-r:5.6.7.8 TEID-access-r:0x102 GTP-access-l:1.1.1.1 TEID-access-l:0x4 GTP-core-r:13.14.15.16 TEID-core-r:0x103 GTP-core-l:1.1.1.1 TEID-core-l:0x3 PFCP-peer:1.2.3.4 SEID-l:0x2 PDR-access:2 PDR-core:1: Enabled tunmap, nft chain IDs: access--1-> <-2--core + +[test override] PFCP tx: +PFCPv1 SESSION_EST_RESP hdr={seq=0 SEID=0x101} ies={ 'Node ID'=v4:unsupported family 0 'Cause'=Request accepted (success) 'F-SEID'=0x2,v4:1.1.1.1 'Created PDR'={ { 'PDR ID'=1 'F-TEID'=TEID-0x3,v4:1.1.1.1 }, { 'PDR ID'=2 'F-TEID'=TEID-0x4,v4:1.1.1.1 } } } + +osmo-upf created session 0x2 + +DREF DEBUG up_session(1-2-3-4-0x2){INIT}: - msg-tx: now used by 1 (msg-rx) +DREF DEBUG up_peer(1-2-3-4){ASSOCIATED}: - msg-tx: now used by 1 (msg-rx) +DSESSION DEBUG up_session(1-2-3-4-0x2){INIT}: State change to ESTABLISHED (no timeout) +DSESSION NOTICE up_session(1-2-3-4-0x2){ESTABLISHED}: Session established: peer:1.2.3.4 SEID-r:0x101 SEID-l:0x2 state:ESTABLISHED PDR-active:2/2 FAR-active:2/2 GTP-active:1 +DREF INFO up_session(1-2-3-4-0x2){ESTABLISHED}: - msg-rx: now used by 0 (-) +DSESSION DEBUG up_session(1-2-3-4-0x2){ESTABLISHED}: Received Event UP_SESSION_EV_USE_COUNT_ZERO +DREF INFO up_peer(1-2-3-4){ASSOCIATED}: - msg-rx: now used by 0 (-) +DPEER DEBUG up_peer(1-2-3-4){ASSOCIATED}: Received Event UP_PEER_EV_USE_COUNT_ZERO + + state: + | peer up_peer(1-2-3-4) ASSOCIATED + | session[ESTABLISHED]: UP-SEID 0x1; chain_id access=1 core=2; local TEID access=0x2 core=0x1 + | session[ESTABLISHED]: UP-SEID 0x2; chain_id access=1 core=2; local TEID access=0x4 core=0x3 + +assert(s2->up_seid == 2) +assert(a = llist_first_entry_or_null(&s2->active_gtp_actions, struct up_gtp_action, entry)) +assert(a->kind == UP_GTP_U_TUNMAP) +assert(a->tunmap.core.tun.local.teid == 3) +assert(a->tunmap.access.tun.local.teid == 4) +assert(a->tunmap.access.chain_id == 3) <-- EXPECTED TO FAIL (known error) +assert(a->tunmap.core.chain_id == 4) <-- EXPECTED TO FAIL (known error) + +drop first tunmap (up_session(1-2-3-4-0x1)) +assert(session) +DSESSION DEBUG up_session(1-2-3-4-0x1){ESTABLISHED}: Received Event UP_SESSION_EV_RX_SESSION_DEL_REQ +DREF INFO up_peer(1-2-3-4){ASSOCIATED}: + msg-tx: now used by 1 (msg-tx) +DREF INFO up_session(1-2-3-4-0x1){ESTABLISHED}: + msg-tx: now used by 1 (msg-tx) + +[test override] PFCP tx: +PFCPv1 SESSION_DEL_RESP hdr={seq=0 SEID=0x100} ies={ 'Cause'=Request accepted (success) } + +DREF INFO up_session(1-2-3-4-0x1){ESTABLISHED}: - msg-tx: now used by 0 (-) +DSESSION DEBUG up_session(1-2-3-4-0x1){ESTABLISHED}: Received Event UP_SESSION_EV_USE_COUNT_ZERO +DREF INFO up_peer(1-2-3-4){ASSOCIATED}: - msg-tx: now used by 0 (-) +DPEER DEBUG up_peer(1-2-3-4){ASSOCIATED}: Received Event UP_PEER_EV_USE_COUNT_ZERO +DSESSION NOTICE up_session(1-2-3-4-0x1){ESTABLISHED}: Session releasing: peer:1.2.3.4 SEID-r:0x100 SEID-l:0x1 state:ESTABLISHED PDR-active:2/2 FAR-active:2/2 GTP-active:1 + +[test override] nft_run_cmd_from_buffer(): +delete element inet osmo-upf tunmap-pre { 1.1.1.1 . 0x2 }; +delete element inet osmo-upf tunmap-post { 1 }; +delete chain inet osmo-upf tunmap-pre-1; +delete chain inet osmo-upf tunmap-post-1; +delete element inet osmo-upf tunmap-pre { 1.1.1.1 . 0x1 }; +delete element inet osmo-upf tunmap-post { 2 }; +delete chain inet osmo-upf tunmap-pre-2; +delete chain inet osmo-upf tunmap-post-2; + +DNFT DEBUG run nft ruleset: "delete element inet osmo-upf tunmap-pre { 1.1.1.1 . 0x2 };\ndelete element inet osmo-upf tunmap-post { 1 };\ndelete chain inet osmo-upf tunmap-pre-1;\ndelete chain inet osmo-upf tunmap-post-1;\ndelete element inet osmo-upf tunmap-pre { 1.1.1.1 . 0x1 };\ndelete element inet osmo-upf tunmap-post { 2 };\ndelete chain inet osmo-upf tunmap-pre-2;\ndelete chain inet osmo-upf tunmap-post-2;\n" +DGTP NOTICE GTP:tunmap GTP-access-r:5.6.7.8 TEID-access-r:0x100 GTP-access-l:1.1.1.1 TEID-access-l:0x2 GTP-core-r:13.14.15.16 TEID-core-r:0x101 GTP-core-l:1.1.1.1 TEID-core-l:0x1 PFCP-peer:1.2.3.4 SEID-l:0x1 PDR-access:2 PDR-core:1: Disabled tunmap, nft chain IDs: access--1-> <-2--core +DSESSION DEBUG up_session(1-2-3-4-0x1){ESTABLISHED}: State change to WAIT_USE_COUNT (no timeout) +DSESSION DEBUG up_session(1-2-3-4-0x1){WAIT_USE_COUNT}: GTP actions: 0 previously active; want active: 0 +DSESSION DEBUG up_session(1-2-3-4-0x1){WAIT_USE_COUNT}: Terminating (cause = OSMO_FSM_TERM_REGULAR) +DSESSION DEBUG up_session(1-2-3-4-0x1){WAIT_USE_COUNT}: Removing from parent up_peer(1-2-3-4) +DSESSION DEBUG up_session(1-2-3-4-0x1){WAIT_USE_COUNT}: GTP actions: 0 previously active; want active: 0 +DSESSION DEBUG up_session(1-2-3-4-0x1){WAIT_USE_COUNT}: Freeing instance +DSESSION DEBUG up_session(1-2-3-4-0x1){WAIT_USE_COUNT}: Deallocated +DPEER DEBUG up_peer(1-2-3-4){ASSOCIATED}: Received Event UP_PEER_EV_SESSION_TERM + + state: + | peer up_peer(1-2-3-4) ASSOCIATED + | session[ESTABLISHED]: UP-SEID 0x2; chain_id access=1 core=2; local TEID access=0x4 core=0x3 + +assert(up_session_find_by_up_seid(peer, s1_up_seid) == NULL) + +again wrap all ID state back to 1 +set up third tunmap, should now re-use same IDs as the first session +DPEER DEBUG up_peer(1-2-3-4){ASSOCIATED}: Received Event UP_PEER_EV_RX_SESSION_EST_REQ +DSESSION DEBUG up_session(1-2-3-4){INIT}: Allocated +DSESSION DEBUG up_session(1-2-3-4){INIT}: is child of up_peer(1-2-3-4) +DSESSION INFO up_session(1-2-3-4){INIT}: Allocated new UP-SEID: 0x1 +DSESSION DEBUG up_session(1-2-3-4-0x1){INIT}: Updated id +DREF INFO up_peer(1-2-3-4){ASSOCIATED}: + msg-rx: now used by 1 (msg-rx) +DREF INFO up_session(1-2-3-4-0x1){INIT}: + msg-rx: now used by 1 (msg-rx) +DSESSION DEBUG up_session(1-2-3-4-0x1){INIT}: Received Event UP_SESSION_EV_RX_SESSION_EST_REQ +DREF DEBUG up_peer(1-2-3-4){ASSOCIATED}: + msg-tx: now used by 2 (msg-rx,msg-tx) +DREF DEBUG up_session(1-2-3-4-0x1){INIT}: + msg-tx: now used by 2 (msg-rx,msg-tx) +DSESSION INFO up_session(1-2-3-4-0x1){INIT}: Allocated new local F-TEID TEID-0x1,v4:1.1.1.1 +DSESSION INFO up_session(1-2-3-4-0x1){INIT}: New PDR-1{src:Core TEID-0x1,v4:1.1.1.1 decaps-GTP_U_UDP_IPV4} --> FAR-1{FORW dst:Access,GTP_U_UDP_IPV4,TEID:0x104,v4:5.6.7.8} +DSESSION INFO up_session(1-2-3-4-0x1){INIT}: Allocated new local F-TEID TEID-0x2,v4:1.1.1.1 +DSESSION INFO up_session(1-2-3-4-0x1){INIT}: New PDR-2{src:Access TEID-0x2,v4:1.1.1.1 decaps-GTP_U_UDP_IPV4} --> FAR-2{FORW dst:Core,GTP_U_UDP_IPV4,TEID:0x105,v4:13.14.15.16} +DSESSION DEBUG up_session(1-2-3-4-0x1){INIT}: Active PDR set: PDR-2{src:Access TEID-0x2,v4:1.1.1.1 decaps-GTP_U_UDP_IPV4} --> FAR-2{FORW dst:Core,GTP_U_UDP_IPV4,TEID:0x105,v4:13.14.15.16} +DSESSION DEBUG up_session(1-2-3-4-0x1){INIT}: Active PDR set: + PDR-1{src:Core TEID-0x1,v4:1.1.1.1 decaps-GTP_U_UDP_IPV4} --> FAR-1{FORW dst:Access,GTP_U_UDP_IPV4,TEID:0x104,v4:5.6.7.8} +DSESSION DEBUG up_session(1-2-3-4-0x1){INIT}: GTP actions: 0 previously active; want active: 1 +DSESSION DEBUG up_session(1-2-3-4-0x1){INIT}: want: GTP:tunmap GTP-access-r:5.6.7.8 TEID-access-r:0x104 GTP-access-l:1.1.1.1 TEID-access-l:0x2 GTP-core-r:13.14.15.16 TEID-core-r:0x105 GTP-core-l:1.1.1.1 TEID-core-l:0x1 PFCP-peer:1.2.3.4 SEID-l:0x1 PDR-access:2 PDR-core:1 +DSESSION DEBUG up_session(1-2-3-4-0x1){INIT}: enabling: GTP:tunmap GTP-access-r:5.6.7.8 TEID-access-r:0x104 GTP-access-l:1.1.1.1 TEID-access-l:0x2 GTP-core-r:13.14.15.16 TEID-core-r:0x105 GTP-core-l:1.1.1.1 TEID-core-l:0x1 PFCP-peer:1.2.3.4 SEID-l:0x1 PDR-access:2 PDR-core:1 + +[test override] nft_run_cmd_from_buffer(): +add chain inet osmo-upf tunmap-pre-1; +add rule inet osmo-upf tunmap-pre-1 ip daddr set 13.14.15.16 meta mark set 1 counter accept; +add chain inet osmo-upf tunmap-post-1; +add rule inet osmo-upf tunmap-post-1 ip saddr set 1.1.1.1 @ih,32,32 set 0x105 counter accept; +add element inet osmo-upf tunmap-pre { 1.1.1.1 . 0x2 : jump tunmap-pre-1 }; +add element inet osmo-upf tunmap-post { 1 : jump tunmap-post-1 }; +add chain inet osmo-upf tunmap-pre-2; +add rule inet osmo-upf tunmap-pre-2 ip daddr set 5.6.7.8 meta mark set 2 counter accept; +add chain inet osmo-upf tunmap-post-2; +add rule inet osmo-upf tunmap-post-2 ip saddr set 1.1.1.1 @ih,32,32 set 0x104 counter accept; +add element inet osmo-upf tunmap-pre { 1.1.1.1 . 0x1 : jump tunmap-pre-2 }; +add element inet osmo-upf tunmap-post { 2 : jump tunmap-post-2 }; + +DNFT DEBUG run nft ruleset: "add chain inet osmo-upf tunmap-pre-1;\nadd rule inet osmo-upf tunmap-pre-1 ip daddr set 13.14.15.16 meta mark set 1 counter accept;\nadd chain inet osmo-upf tunmap-post-1;\nadd rule inet osmo-upf tunmap-post-1 ip saddr set 1.1.1.1 @ih,32,32 set 0x105 counter accept;\nadd element inet osmo-upf tunmap-pre { 1.1.1.1 . 0x2 : jump tunmap-pre-1 };\nadd element inet osmo-upf tunmap-post { 1 : jump tunmap-post-1 };\nadd chain inet osmo-upf tunmap-pre-2;\nadd rule inet osmo-upf tunmap-pre-2 ip daddr set 5.6.7.8 meta mark set 2 counter accept;\nadd chain inet osmo-upf tunmap-post-2;\nadd rule inet osmo-upf tunmap-post-2 ip saddr set 1.1.1.1 @ih,32,32 set 0x104 counter accept;\nadd element inet osmo-upf tunmap-pre { 1.1.1.1 . 0x1 : jump tunmap-pre-2 };\nadd element inet osmo-upf tunmap-post { 2 : jump tunmap-post-2 };\n" +DGTP NOTICE GTP:tunmap GTP-access-r:5.6.7.8 TEID-access-r:0x104 GTP-access-l:1.1.1.1 TEID-access-l:0x2 GTP-core-r:13.14.15.16 TEID-core-r:0x105 GTP-core-l:1.1.1.1 TEID-core-l:0x1 PFCP-peer:1.2.3.4 SEID-l:0x1 PDR-access:2 PDR-core:1: Enabled tunmap, nft chain IDs: access--1-> <-2--core + +[test override] PFCP tx: +PFCPv1 SESSION_EST_RESP hdr={seq=0 SEID=0x102} ies={ 'Node ID'=v4:unsupported family 0 'Cause'=Request accepted (success) 'F-SEID'=0x1,v4:1.1.1.1 'Created PDR'={ { 'PDR ID'=1 'F-TEID'=TEID-0x1,v4:1.1.1.1 }, { 'PDR ID'=2 'F-TEID'=TEID-0x2,v4:1.1.1.1 } } } + +osmo-upf created session 0x1 + +DREF DEBUG up_session(1-2-3-4-0x1){INIT}: - msg-tx: now used by 1 (msg-rx) +DREF DEBUG up_peer(1-2-3-4){ASSOCIATED}: - msg-tx: now used by 1 (msg-rx) +DSESSION DEBUG up_session(1-2-3-4-0x1){INIT}: State change to ESTABLISHED (no timeout) +DSESSION NOTICE up_session(1-2-3-4-0x1){ESTABLISHED}: Session established: peer:1.2.3.4 SEID-r:0x102 SEID-l:0x1 state:ESTABLISHED PDR-active:2/2 FAR-active:2/2 GTP-active:1 +DREF INFO up_session(1-2-3-4-0x1){ESTABLISHED}: - msg-rx: now used by 0 (-) +DSESSION DEBUG up_session(1-2-3-4-0x1){ESTABLISHED}: Received Event UP_SESSION_EV_USE_COUNT_ZERO +DREF INFO up_peer(1-2-3-4){ASSOCIATED}: - msg-rx: now used by 0 (-) +DPEER DEBUG up_peer(1-2-3-4){ASSOCIATED}: Received Event UP_PEER_EV_USE_COUNT_ZERO + + state: + | peer up_peer(1-2-3-4) ASSOCIATED + | session[ESTABLISHED]: UP-SEID 0x1; chain_id access=1 core=2; local TEID access=0x2 core=0x1 + | session[ESTABLISHED]: UP-SEID 0x2; chain_id access=1 core=2; local TEID access=0x4 core=0x3 + +assert(s3->up_seid == 1) +assert(a = llist_first_entry_or_null(&s3->active_gtp_actions, struct up_gtp_action, entry)) +assert(a->kind == UP_GTP_U_TUNMAP) +assert(a->tunmap.core.tun.local.teid == 1) +assert(a->tunmap.access.tun.local.teid == 2) +assert(a->tunmap.access.chain_id == 1) +assert(a->tunmap.core.chain_id == 2) + +set up 4th tunmap; chain_id state would use 3 and 4, but they are in use, so should assign 5 and 6 +DPEER DEBUG up_peer(1-2-3-4){ASSOCIATED}: Received Event UP_PEER_EV_RX_SESSION_EST_REQ +DSESSION DEBUG up_session(1-2-3-4){INIT}: Allocated +DSESSION DEBUG up_session(1-2-3-4){INIT}: is child of up_peer(1-2-3-4) +DSESSION INFO up_session(1-2-3-4){INIT}: Allocated new UP-SEID: 0x3 +DSESSION DEBUG up_session(1-2-3-4-0x3){INIT}: Updated id +DREF INFO up_peer(1-2-3-4){ASSOCIATED}: + msg-rx: now used by 1 (msg-rx) +DREF INFO up_session(1-2-3-4-0x3){INIT}: + msg-rx: now used by 1 (msg-rx) +DSESSION DEBUG up_session(1-2-3-4-0x3){INIT}: Received Event UP_SESSION_EV_RX_SESSION_EST_REQ +DREF DEBUG up_peer(1-2-3-4){ASSOCIATED}: + msg-tx: now used by 2 (msg-rx,msg-tx) +DREF DEBUG up_session(1-2-3-4-0x3){INIT}: + msg-tx: now used by 2 (msg-rx,msg-tx) +DSESSION INFO up_session(1-2-3-4-0x3){INIT}: Allocated new local F-TEID TEID-0x5,v4:1.1.1.1 +DSESSION INFO up_session(1-2-3-4-0x3){INIT}: New PDR-1{src:Core TEID-0x5,v4:1.1.1.1 decaps-GTP_U_UDP_IPV4} --> FAR-1{FORW dst:Access,GTP_U_UDP_IPV4,TEID:0x106,v4:5.6.7.8} +DSESSION INFO up_session(1-2-3-4-0x3){INIT}: Allocated new local F-TEID TEID-0x6,v4:1.1.1.1 +DSESSION INFO up_session(1-2-3-4-0x3){INIT}: New PDR-2{src:Access TEID-0x6,v4:1.1.1.1 decaps-GTP_U_UDP_IPV4} --> FAR-2{FORW dst:Core,GTP_U_UDP_IPV4,TEID:0x107,v4:13.14.15.16} +DSESSION DEBUG up_session(1-2-3-4-0x3){INIT}: Active PDR set: PDR-2{src:Access TEID-0x6,v4:1.1.1.1 decaps-GTP_U_UDP_IPV4} --> FAR-2{FORW dst:Core,GTP_U_UDP_IPV4,TEID:0x107,v4:13.14.15.16} +DSESSION DEBUG up_session(1-2-3-4-0x3){INIT}: Active PDR set: + PDR-1{src:Core TEID-0x5,v4:1.1.1.1 decaps-GTP_U_UDP_IPV4} --> FAR-1{FORW dst:Access,GTP_U_UDP_IPV4,TEID:0x106,v4:5.6.7.8} +DSESSION DEBUG up_session(1-2-3-4-0x3){INIT}: GTP actions: 0 previously active; want active: 1 +DSESSION DEBUG up_session(1-2-3-4-0x3){INIT}: want: GTP:tunmap GTP-access-r:5.6.7.8 TEID-access-r:0x106 GTP-access-l:1.1.1.1 TEID-access-l:0x6 GTP-core-r:13.14.15.16 TEID-core-r:0x107 GTP-core-l:1.1.1.1 TEID-core-l:0x5 PFCP-peer:1.2.3.4 SEID-l:0x3 PDR-access:2 PDR-core:1 +DSESSION DEBUG up_session(1-2-3-4-0x3){INIT}: enabling: GTP:tunmap GTP-access-r:5.6.7.8 TEID-access-r:0x106 GTP-access-l:1.1.1.1 TEID-access-l:0x6 GTP-core-r:13.14.15.16 TEID-core-r:0x107 GTP-core-l:1.1.1.1 TEID-core-l:0x5 PFCP-peer:1.2.3.4 SEID-l:0x3 PDR-access:2 PDR-core:1 + +[test override] nft_run_cmd_from_buffer(): +add chain inet osmo-upf tunmap-pre-3; +add rule inet osmo-upf tunmap-pre-3 ip daddr set 13.14.15.16 meta mark set 3 counter accept; +add chain inet osmo-upf tunmap-post-3; +add rule inet osmo-upf tunmap-post-3 ip saddr set 1.1.1.1 @ih,32,32 set 0x107 counter accept; +add element inet osmo-upf tunmap-pre { 1.1.1.1 . 0x6 : jump tunmap-pre-3 }; +add element inet osmo-upf tunmap-post { 3 : jump tunmap-post-3 }; +add chain inet osmo-upf tunmap-pre-4; +add rule inet osmo-upf tunmap-pre-4 ip daddr set 5.6.7.8 meta mark set 4 counter accept; +add chain inet osmo-upf tunmap-post-4; +add rule inet osmo-upf tunmap-post-4 ip saddr set 1.1.1.1 @ih,32,32 set 0x106 counter accept; +add element inet osmo-upf tunmap-pre { 1.1.1.1 . 0x5 : jump tunmap-pre-4 }; +add element inet osmo-upf tunmap-post { 4 : jump tunmap-post-4 }; + +DNFT DEBUG run nft ruleset: "add chain inet osmo-upf tunmap-pre-3;\nadd rule inet osmo-upf tunmap-pre-3 ip daddr set 13.14.15.16 meta mark set 3 counter accept;\nadd chain inet osmo-upf tunmap-post-3;\nadd rule inet osmo-upf tunmap-post-3 ip saddr set 1.1.1.1 @ih,32,32 set 0x107 counter accept;\nadd element inet osmo-upf tunmap-pre { 1.1.1.1 . 0x6 : jump tunmap-pre-3 };\nadd element inet osmo-upf tunmap-post { 3 : jump tunmap-post-3 };\nadd chain inet osmo-upf tunmap-pre-4;\nadd rule inet osmo-upf tunmap-pre-4 ip daddr set 5.6.7.8 meta mark set 4 counter accept;\nadd chain inet osmo-upf tunmap-post-4;\nadd rule inet osmo-upf tunmap-post-4 ip saddr set 1.1.1.1 @ih,32,32 set 0x106 counter accept;\nadd element inet osmo-upf tunmap-pre { 1.1.1.1 . 0x5 : jump tunmap-pre-4 };\nadd element inet osmo-upf tunmap-post { 4 : jump tunmap-post-4 };\n" +DGTP NOTICE GTP:tunmap GTP-access-r:5.6.7.8 TEID-access-r:0x106 GTP-access-l:1.1.1.1 TEID-access-l:0x6 GTP-core-r:13.14.15.16 TEID-core-r:0x107 GTP-core-l:1.1.1.1 TEID-core-l:0x5 PFCP-peer:1.2.3.4 SEID-l:0x3 PDR-access:2 PDR-core:1: Enabled tunmap, nft chain IDs: access--3-> <-4--core + +[test override] PFCP tx: +PFCPv1 SESSION_EST_RESP hdr={seq=0 SEID=0x103} ies={ 'Node ID'=v4:unsupported family 0 'Cause'=Request accepted (success) 'F-SEID'=0x3,v4:1.1.1.1 'Created PDR'={ { 'PDR ID'=1 'F-TEID'=TEID-0x5,v4:1.1.1.1 }, { 'PDR ID'=2 'F-TEID'=TEID-0x6,v4:1.1.1.1 } } } + +osmo-upf created session 0x3 + +DREF DEBUG up_session(1-2-3-4-0x3){INIT}: - msg-tx: now used by 1 (msg-rx) +DREF DEBUG up_peer(1-2-3-4){ASSOCIATED}: - msg-tx: now used by 1 (msg-rx) +DSESSION DEBUG up_session(1-2-3-4-0x3){INIT}: State change to ESTABLISHED (no timeout) +DSESSION NOTICE up_session(1-2-3-4-0x3){ESTABLISHED}: Session established: peer:1.2.3.4 SEID-r:0x103 SEID-l:0x3 state:ESTABLISHED PDR-active:2/2 FAR-active:2/2 GTP-active:1 +DREF INFO up_session(1-2-3-4-0x3){ESTABLISHED}: - msg-rx: now used by 0 (-) +DSESSION DEBUG up_session(1-2-3-4-0x3){ESTABLISHED}: Received Event UP_SESSION_EV_USE_COUNT_ZERO +DREF INFO up_peer(1-2-3-4){ASSOCIATED}: - msg-rx: now used by 0 (-) +DPEER DEBUG up_peer(1-2-3-4){ASSOCIATED}: Received Event UP_PEER_EV_USE_COUNT_ZERO + + state: + | peer up_peer(1-2-3-4) ASSOCIATED + | session[ESTABLISHED]: UP-SEID 0x3; chain_id access=3 core=4; local TEID access=0x6 core=0x5 + | session[ESTABLISHED]: UP-SEID 0x1; chain_id access=1 core=2; local TEID access=0x2 core=0x1 + | session[ESTABLISHED]: UP-SEID 0x2; chain_id access=1 core=2; local TEID access=0x4 core=0x3 + +assert(s4->up_seid == 3) +assert(a = llist_first_entry_or_null(&s4->active_gtp_actions, struct up_gtp_action, entry)) +assert(a->kind == UP_GTP_U_TUNMAP) +assert(a->tunmap.core.tun.local.teid == 5) +assert(a->tunmap.access.tun.local.teid == 6) +assert(a->tunmap.access.chain_id == 5) <-- EXPECTED TO FAIL (known error) +assert(a->tunmap.core.chain_id == 6) <-- EXPECTED TO FAIL (known error) + +DPEER DEBUG up_peer(1-2-3-4){ASSOCIATED}: Terminating (cause = OSMO_FSM_TERM_REGULAR) +DSESSION DEBUG up_session(1-2-3-4-0x3){ESTABLISHED}: Terminating (cause = OSMO_FSM_TERM_PARENT) +DSESSION DEBUG up_session(1-2-3-4-0x3){ESTABLISHED}: Removing from parent up_peer(1-2-3-4) +DSESSION DEBUG up_session(1-2-3-4-0x3){ESTABLISHED}: GTP actions: 1 previously active; want active: 0 +DSESSION DEBUG up_session(1-2-3-4-0x3){ESTABLISHED}: active: GTP:tunmap GTP-access-r:5.6.7.8 TEID-access-r:0x106 GTP-access-l:1.1.1.1 TEID-access-l:0x6 GTP-core-r:13.14.15.16 TEID-core-r:0x107 GTP-core-l:1.1.1.1 TEID-core-l:0x5 PFCP-peer:1.2.3.4 SEID-l:0x3 PDR-access:2 PDR-core:1 +DSESSION DEBUG up_session(1-2-3-4-0x3){ESTABLISHED}: disabling: GTP:tunmap GTP-access-r:5.6.7.8 TEID-access-r:0x106 GTP-access-l:1.1.1.1 TEID-access-l:0x6 GTP-core-r:13.14.15.16 TEID-core-r:0x107 GTP-core-l:1.1.1.1 TEID-core-l:0x5 PFCP-peer:1.2.3.4 SEID-l:0x3 PDR-access:2 PDR-core:1 + +[test override] nft_run_cmd_from_buffer(): +delete element inet osmo-upf tunmap-pre { 1.1.1.1 . 0x6 }; +delete element inet osmo-upf tunmap-post { 3 }; +delete chain inet osmo-upf tunmap-pre-3; +delete chain inet osmo-upf tunmap-post-3; +delete element inet osmo-upf tunmap-pre { 1.1.1.1 . 0x5 }; +delete element inet osmo-upf tunmap-post { 4 }; +delete chain inet osmo-upf tunmap-pre-4; +delete chain inet osmo-upf tunmap-post-4; + +DNFT DEBUG run nft ruleset: "delete element inet osmo-upf tunmap-pre { 1.1.1.1 . 0x6 };\ndelete element inet osmo-upf tunmap-post { 3 };\ndelete chain inet osmo-upf tunmap-pre-3;\ndelete chain inet osmo-upf tunmap-post-3;\ndelete element inet osmo-upf tunmap-pre { 1.1.1.1 . 0x5 };\ndelete element inet osmo-upf tunmap-post { 4 };\ndelete chain inet osmo-upf tunmap-pre-4;\ndelete chain inet osmo-upf tunmap-post-4;\n" +DGTP NOTICE GTP:tunmap GTP-access-r:5.6.7.8 TEID-access-r:0x106 GTP-access-l:1.1.1.1 TEID-access-l:0x6 GTP-core-r:13.14.15.16 TEID-core-r:0x107 GTP-core-l:1.1.1.1 TEID-core-l:0x5 PFCP-peer:1.2.3.4 SEID-l:0x3 PDR-access:2 PDR-core:1: Disabled tunmap, nft chain IDs: access--3-> <-4--core +DSESSION DEBUG up_session(1-2-3-4-0x3){ESTABLISHED}: Freeing instance +DSESSION DEBUG up_session(1-2-3-4-0x3){ESTABLISHED}: Deallocated +DSESSION DEBUG up_session(1-2-3-4-0x1){ESTABLISHED}: Terminating (cause = OSMO_FSM_TERM_PARENT) +DSESSION DEBUG up_session(1-2-3-4-0x1){ESTABLISHED}: Removing from parent up_peer(1-2-3-4) +DSESSION DEBUG up_session(1-2-3-4-0x1){ESTABLISHED}: GTP actions: 1 previously active; want active: 0 +DSESSION DEBUG up_session(1-2-3-4-0x1){ESTABLISHED}: active: GTP:tunmap GTP-access-r:5.6.7.8 TEID-access-r:0x104 GTP-access-l:1.1.1.1 TEID-access-l:0x2 GTP-core-r:13.14.15.16 TEID-core-r:0x105 GTP-core-l:1.1.1.1 TEID-core-l:0x1 PFCP-peer:1.2.3.4 SEID-l:0x1 PDR-access:2 PDR-core:1 +DSESSION DEBUG up_session(1-2-3-4-0x1){ESTABLISHED}: disabling: GTP:tunmap GTP-access-r:5.6.7.8 TEID-access-r:0x104 GTP-access-l:1.1.1.1 TEID-access-l:0x2 GTP-core-r:13.14.15.16 TEID-core-r:0x105 GTP-core-l:1.1.1.1 TEID-core-l:0x1 PFCP-peer:1.2.3.4 SEID-l:0x1 PDR-access:2 PDR-core:1 + +[test override] nft_run_cmd_from_buffer(): +delete element inet osmo-upf tunmap-pre { 1.1.1.1 . 0x2 }; +delete element inet osmo-upf tunmap-post { 1 }; +delete chain inet osmo-upf tunmap-pre-1; +delete chain inet osmo-upf tunmap-post-1; +delete element inet osmo-upf tunmap-pre { 1.1.1.1 . 0x1 }; +delete element inet osmo-upf tunmap-post { 2 }; +delete chain inet osmo-upf tunmap-pre-2; +delete chain inet osmo-upf tunmap-post-2; + +DNFT DEBUG run nft ruleset: "delete element inet osmo-upf tunmap-pre { 1.1.1.1 . 0x2 };\ndelete element inet osmo-upf tunmap-post { 1 };\ndelete chain inet osmo-upf tunmap-pre-1;\ndelete chain inet osmo-upf tunmap-post-1;\ndelete element inet osmo-upf tunmap-pre { 1.1.1.1 . 0x1 };\ndelete element inet osmo-upf tunmap-post { 2 };\ndelete chain inet osmo-upf tunmap-pre-2;\ndelete chain inet osmo-upf tunmap-post-2;\n" +DGTP NOTICE GTP:tunmap GTP-access-r:5.6.7.8 TEID-access-r:0x104 GTP-access-l:1.1.1.1 TEID-access-l:0x2 GTP-core-r:13.14.15.16 TEID-core-r:0x105 GTP-core-l:1.1.1.1 TEID-core-l:0x1 PFCP-peer:1.2.3.4 SEID-l:0x1 PDR-access:2 PDR-core:1: Disabled tunmap, nft chain IDs: access--1-> <-2--core +DSESSION DEBUG up_session(1-2-3-4-0x1){ESTABLISHED}: Freeing instance +DSESSION DEBUG up_session(1-2-3-4-0x1){ESTABLISHED}: Deallocated +DSESSION DEBUG up_session(1-2-3-4-0x2){ESTABLISHED}: Terminating (cause = OSMO_FSM_TERM_PARENT) +DSESSION DEBUG up_session(1-2-3-4-0x2){ESTABLISHED}: Removing from parent up_peer(1-2-3-4) +DSESSION DEBUG up_session(1-2-3-4-0x2){ESTABLISHED}: GTP actions: 1 previously active; want active: 0 +DSESSION DEBUG up_session(1-2-3-4-0x2){ESTABLISHED}: active: GTP:tunmap GTP-access-r:5.6.7.8 TEID-access-r:0x102 GTP-access-l:1.1.1.1 TEID-access-l:0x4 GTP-core-r:13.14.15.16 TEID-core-r:0x103 GTP-core-l:1.1.1.1 TEID-core-l:0x3 PFCP-peer:1.2.3.4 SEID-l:0x2 PDR-access:2 PDR-core:1 +DSESSION DEBUG up_session(1-2-3-4-0x2){ESTABLISHED}: disabling: GTP:tunmap GTP-access-r:5.6.7.8 TEID-access-r:0x102 GTP-access-l:1.1.1.1 TEID-access-l:0x4 GTP-core-r:13.14.15.16 TEID-core-r:0x103 GTP-core-l:1.1.1.1 TEID-core-l:0x3 PFCP-peer:1.2.3.4 SEID-l:0x2 PDR-access:2 PDR-core:1 + +[test override] nft_run_cmd_from_buffer(): +delete element inet osmo-upf tunmap-pre { 1.1.1.1 . 0x4 }; +delete element inet osmo-upf tunmap-post { 1 }; +delete chain inet osmo-upf tunmap-pre-1; +delete chain inet osmo-upf tunmap-post-1; +delete element inet osmo-upf tunmap-pre { 1.1.1.1 . 0x3 }; +delete element inet osmo-upf tunmap-post { 2 }; +delete chain inet osmo-upf tunmap-pre-2; +delete chain inet osmo-upf tunmap-post-2; + +DNFT DEBUG run nft ruleset: "delete element inet osmo-upf tunmap-pre { 1.1.1.1 . 0x4 };\ndelete element inet osmo-upf tunmap-post { 1 };\ndelete chain inet osmo-upf tunmap-pre-1;\ndelete chain inet osmo-upf tunmap-post-1;\ndelete element inet osmo-upf tunmap-pre { 1.1.1.1 . 0x3 };\ndelete element inet osmo-upf tunmap-post { 2 };\ndelete chain inet osmo-upf tunmap-pre-2;\ndelete chain inet osmo-upf tunmap-post-2;\n" +DGTP NOTICE GTP:tunmap GTP-access-r:5.6.7.8 TEID-access-r:0x102 GTP-access-l:1.1.1.1 TEID-access-l:0x4 GTP-core-r:13.14.15.16 TEID-core-r:0x103 GTP-core-l:1.1.1.1 TEID-core-l:0x3 PFCP-peer:1.2.3.4 SEID-l:0x2 PDR-access:2 PDR-core:1: Disabled tunmap, nft chain IDs: access--1-> <-2--core +DSESSION DEBUG up_session(1-2-3-4-0x2){ESTABLISHED}: Freeing instance +DSESSION DEBUG up_session(1-2-3-4-0x2){ESTABLISHED}: Deallocated +DPEER NOTICE up_peer(1-2-3-4){ASSOCIATED}: Peer removed +DPEER DEBUG up_peer(1-2-3-4){ASSOCIATED}: Freeing instance +DPEER DEBUG up_peer(1-2-3-4){ASSOCIATED}: Deallocated +[test override] nft_ctx_free() +assert(ctx == fake_nft_ctx) + +===== END of test_skip_used_id diff --git a/tests/unique_ids/unique_ids_test.ok b/tests/unique_ids/unique_ids_test.ok new file mode 100644 index 0000000..e69de29 --- /dev/null +++ b/tests/unique_ids/unique_ids_test.ok -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/31482 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I36acff15f22d23ade4d281c2af3eb117dfc10359 Gerrit-Change-Number: 31482 Gerrit-PatchSet: 5 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[M] Change in osmo-bsc[master]: Fix Lb/A SCCP conn lookup after recent regression in optimization patch
by pespin 17 Mar '23

17 Mar '23

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31940 ) Change subject: Fix Lb/A SCCP conn lookup after recent regression in optimization patch ...................................................................... Patch Set 4: (2 comments) Patchset: PS1: > I think this needs further study in terms of the SCCP/sigtran rlated data structures. […] Done Patchset: PS2: > Let me try to fix this today, otherwise I'll merge a revert. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31940 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If42d93adee71d646766929a09bc01ae92b734ef3 Gerrit-Change-Number: 31940 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 17 Mar 2023 18:08:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[M] Change in osmo-bsc[master]: Fix Lb/A SCCP conn lookup after recent regression in optimization patch
by pespin 17 Mar '23

17 Mar '23

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31940 ) Change subject: Fix Lb/A SCCP conn lookup after recent regression in optimization patch ...................................................................... Fix Lb/A SCCP conn lookup after recent regression in optimization patch In osmo-bsc, there's currently 0..1 Lb links and 0..N A links, where N is the number of MSC, but links can be shared in the underlaying stack (struct osmo_sccp_instance), hence range 0..N of different osmo_sccp_instance (identified by PC). Even more, the Lb and A link can share the same underlaying stack, so osmo-bsc can end up with only 1 struct osmo_sccp_instance shared by all the above mentioned links in case all are configured under the same PC. Total range A+Lb is 0..(1+N). A struct gsm_subscriber_conn stores 2 struct sccp_instance*, one for Lb (conn->lcs.lb.*)and one for A (conn->sccp.*). They can actually point to the same sccp_instance or to different ones, as explained above, depending on the configured setup. In any case, a gsm_subscriber_conn needs 2 rb_nodes since it can hold any of the 2 conn_ids independently (A or Lb). The previous patch forgot to add that 2nd rb_node as well as some initialization and release code for the Lb conn. This patch addresses that. When the 2nd rb_node, a problem when iterating the rbtree appears: how to find out the "conn" pointer from the rb_node pointer, since the rb_node pointer can be any of the 2 rb_nodes inside the struct at a different offsets. In order to solve that problem, a new struct bscp_sccp_conn_node is added, which holds all the relevant information used by the rbtree lookup code in a generic way (rb_node and conn_id), plus a backpointer to the struct bsc_gsm_subcriber it relates too. Fixes: 85062ccad31e9fb73e0256a5ee556c6ae0a16449 Change-Id: If42d93adee71d646766929a09bc01ae92b734ef3 --- M include/osmocom/bsc/gsm_data.h M src/osmo-bsc/bsc_sccp.c M src/osmo-bsc/bsc_subscr_conn_fsm.c M src/osmo-bsc/bsc_vty.c M src/osmo-bsc/handover_fsm.c M src/osmo-bsc/lb.c M src/osmo-bsc/lchan_rtp_fsm.c M src/osmo-bsc/osmo_bsc_sigtran.c M tests/bsc/bsc_test.c 9 files changed, 125 insertions(+), 58 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/include/osmocom/bsc/gsm_data.h b/include/osmocom/bsc/gsm_data.h index dc7ee3f..25e634a 100644 --- a/include/osmocom/bsc/gsm_data.h +++ b/include/osmocom/bsc/gsm_data.h @@ -281,6 +281,21 @@ struct osmo_mgcpc_ep_ci *created_ci_for_msc; }; +struct gsm_subscriber_connection; + +struct bscp_sccp_conn_node { + /* entry in (struct bsc_sccp_inst)->connections */ + struct rb_node node; + /* Sigtran connection ID: + * if set: Range (0..SCCP_CONN_ID_MAX) (24 bit) + * if unset: SCCP_CONN_ID_UNSET (-1) if unset */ + uint32_t conn_id; + /* backpointer where this sccp conn belongs to: */ + struct gsm_subscriber_connection *gscon; +}; + +void bscp_sccp_conn_node_init(struct bscp_sccp_conn_node *sccp_conn, struct gsm_subscriber_connection *gscon); + /* active radio connection of a mobile subscriber */ struct gsm_subscriber_connection { /* global linked list of subscriber_connections */ @@ -332,15 +347,8 @@ struct { /* SCCP connection related */ struct bsc_msc_data *msc; - - /* entry in (struct bsc_sccp_inst)->connections */ - struct rb_node node; - - /* Sigtran connection ID: - * if set: Range (0..SCCP_CONN_ID_MAX) (24 bit) - * if unset: SCCP_CONN_ID_UNSET (-1) if unset */ - uint32_t conn_id; enum subscr_sccp_state state; + struct bscp_sccp_conn_node conn; } sccp; /* for audio handling */ @@ -389,11 +397,8 @@ /* Lb interface to the SMLC: BSSMAP-LE/SCCP connection associated with this subscriber */ struct { - /* Sigtran connection ID: - * if set: Range (0..SCCP_CONN_ID_MAX) (24 bit) - * if unset: SCCP_CONN_ID_UNSET (-1) if unset */ - uint32_t conn_id; enum subscr_sccp_state state; + struct bscp_sccp_conn_node conn; } lb; } lcs; @@ -885,8 +890,8 @@ struct bsc_sccp_inst *bsc_sccp_inst_alloc(void *ctx); uint32_t bsc_sccp_inst_next_conn_id(struct bsc_sccp_inst *bsc_sccp); -int bsc_sccp_inst_register_gscon(struct bsc_sccp_inst *bsc_sccp, struct gsm_subscriber_connection *conn); -void bsc_sccp_inst_unregister_gscon(struct bsc_sccp_inst *bsc_sccp, struct gsm_subscriber_connection *conn); +int bsc_sccp_inst_register_gscon(struct bsc_sccp_inst *bsc_sccp, struct bscp_sccp_conn_node *sccp_conn); +void bsc_sccp_inst_unregister_gscon(struct bsc_sccp_inst *bsc_sccp, struct bscp_sccp_conn_node *sccp_conn); struct gsm_subscriber_connection *bsc_sccp_inst_get_gscon_by_conn_id(const struct bsc_sccp_inst *bsc_sccp, uint32_t conn_id); struct gsm_network { diff --git a/src/osmo-bsc/bsc_sccp.c b/src/osmo-bsc/bsc_sccp.c index 6fa1d4b..323d7fd 100644 --- a/src/osmo-bsc/bsc_sccp.c +++ b/src/osmo-bsc/bsc_sccp.c @@ -27,6 +27,12 @@ #include <osmocom/bsc/bsc_msc_data.h> #include <osmocom/bsc/lb.h> +void bscp_sccp_conn_node_init(struct bscp_sccp_conn_node *sccp_conn, struct gsm_subscriber_connection *gscon) +{ + sccp_conn->conn_id = SCCP_CONN_ID_UNSET; + sccp_conn->gscon = gscon; +} + struct bsc_sccp_inst *bsc_sccp_inst_alloc(void *ctx) { struct bsc_sccp_inst *bsc_sccp; @@ -38,23 +44,21 @@ return bsc_sccp; } -int bsc_sccp_inst_register_gscon(struct bsc_sccp_inst *bsc_sccp, struct gsm_subscriber_connection *conn) +int bsc_sccp_inst_register_gscon(struct bsc_sccp_inst *bsc_sccp, struct bscp_sccp_conn_node *sccp_conn) { struct rb_node **n = &(bsc_sccp->connections.rb_node); struct rb_node *parent = NULL; - uint32_t conn_id = conn->sccp.conn_id; + uint32_t conn_id = sccp_conn->conn_id; OSMO_ASSERT(conn_id != SCCP_CONN_ID_UNSET); while (*n) { - struct gsm_subscriber_connection *it; - - it = container_of(*n, struct gsm_subscriber_connection, sccp.node); + struct bscp_sccp_conn_node *it = container_of(*n, struct bscp_sccp_conn_node, node); parent = *n; - if (conn_id < it->sccp.conn_id) { + if (conn_id < it->conn_id) { n = &((*n)->rb_left); - } else if (conn_id > it->sccp.conn_id) { + } else if (conn_id > it->conn_id) { n = &((*n)->rb_right); } else { LOGP(DMSC, LOGL_ERROR, @@ -63,35 +67,34 @@ } } - rb_link_node(&conn->sccp.node, parent, n); - rb_insert_color(&conn->sccp.node, &bsc_sccp->connections); + rb_link_node(&sccp_conn->node, parent, n); + rb_insert_color(&sccp_conn->node, &bsc_sccp->connections); return 0; } -void bsc_sccp_inst_unregister_gscon(struct bsc_sccp_inst *bsc_sccp, struct gsm_subscriber_connection *conn) +void bsc_sccp_inst_unregister_gscon(struct bsc_sccp_inst *bsc_sccp, struct bscp_sccp_conn_node *sccp_conn) { - OSMO_ASSERT(conn->sccp.conn_id != SCCP_CONN_ID_UNSET); - rb_erase(&conn->sccp.node, &bsc_sccp->connections); + OSMO_ASSERT(sccp_conn->conn_id != SCCP_CONN_ID_UNSET); + rb_erase(&sccp_conn->node, &bsc_sccp->connections); } /* Helper function to Check if the given connection id is already assigned */ struct gsm_subscriber_connection *bsc_sccp_inst_get_gscon_by_conn_id(const struct bsc_sccp_inst *bsc_sccp, uint32_t conn_id) { const struct rb_node *node = bsc_sccp->connections.rb_node; - struct gsm_subscriber_connection *conn; OSMO_ASSERT(conn_id != SCCP_CONN_ID_UNSET); /* Range (0..SCCP_CONN_ID_MAX) expected, see bsc_sccp_inst_next_conn_id() */ OSMO_ASSERT(conn_id <= SCCP_CONN_ID_MAX); while (node) { - conn = container_of(node, struct gsm_subscriber_connection, sccp.node); - if (conn_id < conn->sccp.conn_id) + struct bscp_sccp_conn_node *sccp_conn = container_of(node, struct bscp_sccp_conn_node, node); + if (conn_id < sccp_conn->conn_id) node = node->rb_left; - else if (conn_id > conn->sccp.conn_id) + else if (conn_id > sccp_conn->conn_id) node = node->rb_right; else - return conn; + return sccp_conn->gscon; } return NULL; diff --git a/src/osmo-bsc/bsc_subscr_conn_fsm.c b/src/osmo-bsc/bsc_subscr_conn_fsm.c index 8e21992..de9d4d2 100644 --- a/src/osmo-bsc/bsc_subscr_conn_fsm.c +++ b/src/osmo-bsc/bsc_subscr_conn_fsm.c @@ -769,7 +769,7 @@ mgw_info = (struct mgcp_conn_peer){ .port = port, - .call_id = conn->sccp.conn_id, + .call_id = conn->sccp.conn.conn_id, .ptime = 20, .x_osmo_osmux_use = conn->assignment.req.use_osmux, .x_osmo_osmux_cid = conn->assignment.req.osmux_cid, @@ -1108,13 +1108,13 @@ LOGPFSML(fi, LOGL_DEBUG, "Disconnecting SCCP\n"); struct bsc_msc_data *msc = conn->sccp.msc; /* FIXME: include a proper cause value / error message? */ - osmo_sccp_tx_disconn(msc->a.sccp_user, conn->sccp.conn_id, &msc->a.bsc_addr, 0); + osmo_sccp_tx_disconn(msc->a.sccp_user, conn->sccp.conn.conn_id, &msc->a.bsc_addr, 0); conn->sccp.state = SUBSCR_SCCP_ST_NONE; } - if (conn->sccp.conn_id != SCCP_CONN_ID_UNSET && conn->sccp.msc) { + if (conn->sccp.conn.conn_id != SCCP_CONN_ID_UNSET && conn->sccp.msc) { struct bsc_sccp_inst *bsc_sccp = osmo_sccp_get_priv(conn->sccp.msc->a.sccp); - bsc_sccp_inst_unregister_gscon(bsc_sccp, conn); - conn->sccp.conn_id = SCCP_CONN_ID_UNSET; + bsc_sccp_inst_unregister_gscon(bsc_sccp, &conn->sccp.conn); + conn->sccp.conn.conn_id = SCCP_CONN_ID_UNSET; } if (conn->bsub) { @@ -1231,7 +1231,8 @@ conn->network = net; INIT_LLIST_HEAD(&conn->dtap_queue); INIT_LLIST_HEAD(&conn->hodec2.penalty_timers); - conn->sccp.conn_id = SCCP_CONN_ID_UNSET; + bscp_sccp_conn_node_init(&conn->sccp.conn, conn); + bscp_sccp_conn_node_init(&conn->lcs.lb.conn, conn); /* Default clear cause (on RR translates to GSM48_RR_CAUSE_ABNORMAL_UNSPEC) */ conn->clear_cause = GSM0808_CAUSE_EQUIPMENT_FAILURE; @@ -1404,7 +1405,7 @@ { osmo_fsm_inst_update_id_f(conn->fi, "msc%u-conn%u%s%s", conn->sccp.msc ? conn->sccp.msc->nr : UINT_MAX, - conn->sccp.conn_id, + conn->sccp.conn.conn_id, conn->bsub? "_" : "", conn->bsub? bsc_subscr_id(conn->bsub) : ""); } diff --git a/src/osmo-bsc/bsc_vty.c b/src/osmo-bsc/bsc_vty.c index e860888..8eff8de 100644 --- a/src/osmo-bsc/bsc_vty.c +++ b/src/osmo-bsc/bsc_vty.c @@ -727,7 +727,7 @@ static void dump_one_subscr_conn(struct vty *vty, const struct gsm_subscriber_connection *conn) { vty_out(vty, "conn ID=%u, MSC=%u, hodec2_fail=%d, mgw_ep=%s%s", - conn->sccp.conn_id, conn->sccp.msc->nr, conn->hodec2.failures, + conn->sccp.conn.conn_id, conn->sccp.msc->nr, conn->hodec2.failures, osmo_mgcpc_ep_name(conn->user_plane.mgw_endpoint), VTY_NEWLINE); if (conn->lcls.global_call_ref_len) { vty_out(vty, " LCLS GCR: %s%s", diff --git a/src/osmo-bsc/handover_fsm.c b/src/osmo-bsc/handover_fsm.c index ea07f08..24766a5 100644 --- a/src/osmo-bsc/handover_fsm.c +++ b/src/osmo-bsc/handover_fsm.c @@ -269,7 +269,7 @@ if (conn->fi->id) osmo_fsm_inst_update_id_f(fi, "%s_%s", label, conn->fi->id); else - osmo_fsm_inst_update_id_f(fi, "%s_conn%u", label, conn->sccp.conn_id); + osmo_fsm_inst_update_id_f(fi, "%s_conn%u", label, conn->sccp.conn.conn_id); } static void handover_reset(struct gsm_subscriber_connection *conn) diff --git a/src/osmo-bsc/lb.c b/src/osmo-bsc/lb.c index 6c6f599..72905b8 100644 --- a/src/osmo-bsc/lb.c +++ b/src/osmo-bsc/lb.c @@ -199,6 +199,8 @@ scu_prim->u.disconnect.conn_id); rc = -EINVAL; } else { + bsc_sccp_inst_unregister_gscon(bsc_sccp, &conn->lcs.lb.conn); + conn->lcs.lb.conn.conn_id = SCCP_CONN_ID_UNSET; conn->lcs.lb.state = SUBSCR_SCCP_ST_NONE; if (msgb_l2len(oph->msg) > 0) { rc = lcs_loc_req_rx_bssmap_le(conn, oph->msg); @@ -237,7 +239,11 @@ LOGPFSMSL(conn->fi, DLCS, LOGL_ERROR, "Unable to allocate SCCP Connection ID for BSSMAP-LE to SMLC\n"); return -ENOSPC; } - conn->lcs.lb.conn_id = conn_id; + conn->lcs.lb.conn.conn_id = conn_id; + if (bsc_sccp_inst_register_gscon(bsc_sccp, &conn->lcs.lb.conn) < 0) { + LOGP(DMSC, LOGL_ERROR, "Unable to register Lb SCCP connection (id=%u)\n", conn->lcs.lb.conn.conn_id); + return -1; + } ss7 = osmo_ss7_instance_find(bsc_gsmnet->smlc->cs7_instance); OSMO_ASSERT(ss7); LOGPFSMSL(conn->fi, DLCS, LOGL_INFO, "Opening new SCCP connection (id=%u) to SMLC: %s\n", conn_id, @@ -245,22 +251,35 @@ rc = osmo_sccp_tx_conn_req_msg(bsc_gsmnet->smlc->sccp_user, conn_id, &bsc_gsmnet->smlc->bsc_addr, &bsc_gsmnet->smlc->smlc_addr, msg); - if (rc >= 0) + if (rc >= 0) { rate_ctr_inc(rate_ctr_group_get_ctr(bsc_gsmnet->smlc->ctrs, SMLC_CTR_BSSMAP_LE_TX_SUCCESS)); - else - rate_ctr_inc(rate_ctr_group_get_ctr(bsc_gsmnet->smlc->ctrs, SMLC_CTR_BSSMAP_LE_TX_ERR_SEND)); - if (rc >= 0) conn->lcs.lb.state = SUBSCR_SCCP_ST_WAIT_CONN_CONF; + } else { + rate_ctr_inc(rate_ctr_group_get_ctr(bsc_gsmnet->smlc->ctrs, SMLC_CTR_BSSMAP_LE_TX_ERR_SEND)); + goto failed_unregister_conn_id; + } return rc; + +failed_unregister_conn_id: + bsc_sccp_inst_unregister_gscon(bsc_sccp, &conn->lcs.lb.conn); + conn->lcs.lb.conn.conn_id = SCCP_CONN_ID_UNSET; + return rc; } void lb_close_conn(struct gsm_subscriber_connection *conn) { + struct bsc_sccp_inst *bsc_sccp; if (conn->lcs.lb.state == SUBSCR_SCCP_ST_NONE) return; - osmo_sccp_tx_disconn(bsc_gsmnet->smlc->sccp_user, conn->lcs.lb.conn_id, &bsc_gsmnet->smlc->bsc_addr, 0); + OSMO_ASSERT(conn->lcs.lb.conn.conn_id != SCCP_CONN_ID_UNSET); + + osmo_sccp_tx_disconn(bsc_gsmnet->smlc->sccp_user, conn->lcs.lb.conn.conn_id, &bsc_gsmnet->smlc->bsc_addr, 0); + conn->lcs.lb.state = SUBSCR_SCCP_ST_NONE; + bsc_sccp = osmo_sccp_get_priv(bsc_gsmnet->smlc->sccp); + bsc_sccp_inst_unregister_gscon(bsc_sccp, &conn->lcs.lb.conn); + conn->lcs.lb.conn.conn_id = SCCP_CONN_ID_UNSET; } /* Send data to SMLC, take ownership of *msg */ @@ -293,7 +312,7 @@ } LOGPFSMSL(conn->fi, DLCS, LOGL_DEBUG, "Tx %s\n", osmo_bssap_le_pdu_to_str_c(OTC_SELECT, bssap_le)); - rc = osmo_sccp_tx_data_msg(bsc_gsmnet->smlc->sccp_user, conn->lcs.lb.conn_id, msg); + rc = osmo_sccp_tx_data_msg(bsc_gsmnet->smlc->sccp_user, conn->lcs.lb.conn.conn_id, msg); if (rc >= 0) rate_ctr_inc(rate_ctr_group_get_ctr(bsc_gsmnet->smlc->ctrs, SMLC_CTR_BSSMAP_LE_TX_SUCCESS)); else diff --git a/src/osmo-bsc/lchan_rtp_fsm.c b/src/osmo-bsc/lchan_rtp_fsm.c index c568a66..7e9c31f 100644 --- a/src/osmo-bsc/lchan_rtp_fsm.c +++ b/src/osmo-bsc/lchan_rtp_fsm.c @@ -169,7 +169,7 @@ .x_osmo_osmux_cid = -1, /* -1 is wildcard, .x_osmo_osmux_use set below */ }; if (lchan->conn) { - crcx_info.call_id = lchan->conn->sccp.conn_id; + crcx_info.call_id = lchan->conn->sccp.conn.conn_id; if (lchan->conn->sccp.msc) crcx_info.x_osmo_ign = lchan->conn->sccp.msc->x_osmo_ign; } diff --git a/src/osmo-bsc/osmo_bsc_sigtran.c b/src/osmo-bsc/osmo_bsc_sigtran.c index 1642059..8837330 100644 --- a/src/osmo-bsc/osmo_bsc_sigtran.c +++ b/src/osmo-bsc/osmo_bsc_sigtran.c @@ -170,8 +170,8 @@ if (!conn) return -ENOMEM; conn->sccp.msc = msc; - conn->sccp.conn_id = scu_prim->u.connect.conn_id; - if (bsc_sccp_inst_register_gscon(bsc_sccp, conn) < 0) { + conn->sccp.conn.conn_id = scu_prim->u.connect.conn_id; + if (bsc_sccp_inst_register_gscon(bsc_sccp, &conn->sccp.conn) < 0) { LOGP(DMSC, LOGL_NOTICE, "(calling_addr=%s conn_id=%u) N-CONNECT.ind failed registering conn\n", osmo_sccp_addr_dump(&scu_prim->u.connect.calling_addr), scu_prim->u.connect.conn_id); osmo_fsm_inst_term(conn->fi, OSMO_FSM_TERM_REQUEST, NULL); @@ -308,7 +308,7 @@ OSMO_ASSERT(conn); OSMO_ASSERT(msg); OSMO_ASSERT(conn->sccp.msc); - OSMO_ASSERT(conn->sccp.conn_id == SCCP_CONN_ID_UNSET); + OSMO_ASSERT(conn->sccp.conn.conn_id == SCCP_CONN_ID_UNSET); msc = conn->sccp.msc; @@ -318,16 +318,16 @@ } bsc_sccp = osmo_sccp_get_priv(msc->a.sccp); - conn->sccp.conn_id = conn_id = bsc_sccp_inst_next_conn_id(bsc_sccp); - if (conn->sccp.conn_id == SCCP_CONN_ID_UNSET) { + conn->sccp.conn.conn_id = conn_id = bsc_sccp_inst_next_conn_id(bsc_sccp); + if (conn->sccp.conn.conn_id == SCCP_CONN_ID_UNSET) { LOGP(DMSC, LOGL_ERROR, "Unable to allocate SCCP Connection ID\n"); return -1; } - if (bsc_sccp_inst_register_gscon(bsc_sccp, conn) < 0) { - LOGP(DMSC, LOGL_ERROR, "Unable to register SCCP connection (id=%u)\n", conn->sccp.conn_id); + if (bsc_sccp_inst_register_gscon(bsc_sccp, &conn->sccp.conn) < 0) { + LOGP(DMSC, LOGL_ERROR, "Unable to register SCCP connection (id=%u)\n", conn->sccp.conn.conn_id); return -1; } - LOGP(DMSC, LOGL_DEBUG, "Allocated new connection id: %u\n", conn->sccp.conn_id); + LOGP(DMSC, LOGL_DEBUG, "Allocated new connection id: %u\n", conn->sccp.conn.conn_id); ss7 = osmo_ss7_instance_find(msc->a.cs7_instance); OSMO_ASSERT(ss7); LOGP(DMSC, LOGL_INFO, "Opening new SCCP connection (id=%u) to MSC %d: %s\n", conn_id, @@ -390,7 +390,7 @@ return -EINVAL; } - conn_id = conn->sccp.conn_id; + conn_id = conn->sccp.conn.conn_id; ss7 = osmo_ss7_instance_find(msc->a.cs7_instance); OSMO_ASSERT(ss7); diff --git a/tests/bsc/bsc_test.c b/tests/bsc/bsc_test.c index 62757b4..dda10c3 100644 --- a/tests/bsc/bsc_test.c +++ b/tests/bsc/bsc_test.c @@ -212,7 +212,7 @@ conn = bsc_subscr_con_allocate(net); conn->lchan = lchan; conn->assignment.new_lchan = lchan; - conn->sccp.conn_id = 123; + conn->sccp.conn.conn_id = 123; conn->bsub = bsc_subscr_find_or_create_by_tmsi(net->bsc_subscribers, 0x423, "test"); gscon_update_id(conn); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31940 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If42d93adee71d646766929a09bc01ae92b734ef3 Gerrit-Change-Number: 31940 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0