Attention is currently required from: laforge, pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/31698 ) Change subject: [codecs filter] send + receive SDP via MNCC ...................................................................... Patch Set 7: (1 comment) Patchset: PS7:

Ok, if others are fine with it let's merge it, though I really think this paradigm of having to call […] codec_filter_run() does not log.

I believe the strong opinion is a gut feel that the inputs do not change often, that "filter_run()" sounds expensive, and that the results are not used often. All of these are not accurate impressions. Inputs update more often than results are being used, and codec_filter_run() is not expensive. The amount of us discussing when to call run() far exceeds the significance of this aspect. You've asked about this over an extended period of time and in many different patches. I'm trying to convince you that it is not an important issue, but it seems my responses don't reach home. Important at this point is that it has correct results. There are a number of quite non-trivial aspects of this patch series, IMHO this part is just a bike shed slash premature optimization, rather don't let review get distracted by this marginal aspect. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/31698 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ie0668c0e079ec69da1532b52d00621efe114fc2c Gerrit-Change-Number: 31698 Gerrit-PatchSet: 7 Gerrit-Owner: neels <nhofmeyr@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Sat, 18 Mar 2023 02:03:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge@osmocom.org> Comment-In-Reply-To: pespin <pespin@sysmocom.de> Gerrit-MessageType: comment