March 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-bts[master]: lchan: Improve error path logging in gsm_pchan2chan_nr()
by laforge 17 Mar '23

17 Mar '23

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31963 ) Change subject: lchan: Improve error path logging in gsm_pchan2chan_nr() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31963 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I8d9da8e8433feb1f022dc2f5199f9c15c01e9312 Gerrit-Change-Number: 31963 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 17 Mar 2023 15:49:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-upf[master]: tunmap: ensure assigned chain_id is unused
by laforge 17 Mar '23

17 Mar '23

Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/31483 ) Change subject: tunmap: ensure assigned chain_id is unused ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/31483 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I139b46de0bd15185a7a06109d55f7c759755ec81 Gerrit-Change-Number: 31483 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Fri, 17 Mar 2023 15:49:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-bsc[master]: Fix Lb/A SCCP conn lookup after recent regression in optimization patch
by laforge 17 Mar '23

17 Mar '23

Attention is currently required from: neels, pespin, daniel. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31940 ) Change subject: Fix Lb/A SCCP conn lookup after recent regression in optimization patch ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31940 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If42d93adee71d646766929a09bc01ae92b734ef3 Gerrit-Change-Number: 31940 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Fri, 17 Mar 2023 15:48:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-bts[master]: lchan: Improve error path logging in gsm_pchan2chan_nr()
by fixeria 17 Mar '23

17 Mar '23

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31963 ) Change subject: lchan: Improve error path logging in gsm_pchan2chan_nr() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31963 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I8d9da8e8433feb1f022dc2f5199f9c15c01e9312 Gerrit-Change-Number: 31963 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 17 Mar 2023 15:47:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-bsc[master]: Fix Lb/A SCCP conn lookup after recent regression in optimization patch
by pespin 17 Mar '23

17 Mar '23

Attention is currently required from: neels, laforge, daniel. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31940 ) Change subject: Fix Lb/A SCCP conn lookup after recent regression in optimization patch ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: All BSC_Tests pass with version 3 of this patch, so it can be merged if nothing is found during review. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31940 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If42d93adee71d646766929a09bc01ae92b734ef3 Gerrit-Change-Number: 31940 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Fri, 17 Mar 2023 14:50:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in osmo-bts[master]: cosmetic: bts_trx.h: Fix whitespace
by pespin 17 Mar '23

17 Mar '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/31965 ) Change subject: cosmetic: bts_trx.h: Fix whitespace ...................................................................... cosmetic: bts_trx.h: Fix whitespace Change-Id: Ibcc3578cce23767445e53149796d0bd79f81ead8 --- M include/osmo-bts/bts_trx.h 1 file changed, 11 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/65/31965/1 diff --git a/include/osmo-bts/bts_trx.h b/include/osmo-bts/bts_trx.h index c0dcb1c..ab90cc5 100644 --- a/include/osmo-bts/bts_trx.h +++ b/include/osmo-bts/bts_trx.h @@ -27,8 +27,8 @@ uint16_t arfcn; int nominal_power; /* in dBm */ unsigned int max_power_red; /* in actual dB */ - uint8_t max_power_backoff_8psk; /* in actual dB OC-2G only */ - uint8_t c0_idle_power_red; /* in actual dB OC-2G only */ + uint8_t max_power_backoff_8psk; /* in actual dB OC-2G only */ + uint8_t c0_idle_power_red; /* in actual dB OC-2G only */ uint8_t ta_ctrl_interval; /* 1 step is 2 SACCH periods */ -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31965 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ibcc3578cce23767445e53149796d0bd79f81ead8 Gerrit-Change-Number: 31965 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-bts[master]: Avoid tx RF Resource Ind for disabled TRX
by pespin 17 Mar '23

17 Mar '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/31966 ) Change subject: Avoid tx RF Resource Ind for disabled TRX ...................................................................... Avoid tx RF Resource Ind for disabled TRX Related: SYS#6370 Change-Id: I887e0cb03b2a5654accccf7a55fac51319981bfb --- M src/common/bts_trx.c M src/common/l1sap.c 2 files changed, 21 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/66/31966/1 diff --git a/src/common/bts_trx.c b/src/common/bts_trx.c index fce1d02..280880f 100644 --- a/src/common/bts_trx.c +++ b/src/common/bts_trx.c @@ -227,10 +227,13 @@ osmo_fsm_inst_dispatch(trx->mo.fi, NM_EV_RSL_UP, NULL); osmo_fsm_inst_dispatch(trx->bb_transc.mo.fi, NM_EV_RSL_UP, NULL); - if ((rc = rsl_tx_rf_res(trx)) < 0) - oml_tx_failure_event_rep(&trx->bb_transc.mo, NM_SEVER_MAJOR, OSMO_EVT_MAJ_RSL_FAIL, - "Failed to establish RSL link (%d)", rc); - + if (trx->mo.nm_state.operational == NM_OPSTATE_ENABLED || + trx->bb_transc.mo.nm_state.operational == NM_OPSTATE_ENABLED) { + rc = rsl_tx_rf_res(trx); + if (rc < 0) + oml_tx_failure_event_rep(&trx->bb_transc.mo, NM_SEVER_MAJOR, OSMO_EVT_MAJ_RSL_FAIL, + "Failed to establish RSL link (%d)", rc); + } if (trx == trx->bts->c0) load_timer_start(trx->bts); diff --git a/src/common/l1sap.c b/src/common/l1sap.c index 22b5e8c..24ce880 100644 --- a/src/common/l1sap.c +++ b/src/common/l1sap.c @@ -615,6 +615,10 @@ return; llist_for_each_entry(trx, &bts->trx_list, list) { + + if (trx->mo.nm_state.operational != NM_OPSTATE_ENABLED || + trx->bb_transc.mo.nm_state.operational != NM_OPSTATE_ENABLED) + continue; /* Calculate the average of all received samples */ l1sap_interf_meas_calc_avg(trx); /* Report to the BSC over the A-bis/RSL */ -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31966 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I887e0cb03b2a5654accccf7a55fac51319981bfb Gerrit-Change-Number: 31966 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-bts[master]: cosmetic: gsm_pchan2chan_nr(): Update spec documentation
by pespin 17 Mar '23

17 Mar '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/31964 ) Change subject: cosmetic: gsm_pchan2chan_nr(): Update spec documentation ...................................................................... cosmetic: gsm_pchan2chan_nr(): Update spec documentation Change-Id: If1de230f022c69f3dfce8a7c66d494a984e7f3f9 --- M src/common/lchan.c 1 file changed, 11 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/64/31964/1 diff --git a/src/common/lchan.c b/src/common/lchan.c index 638f30a..8d2b649 100644 --- a/src/common/lchan.c +++ b/src/common/lchan.c @@ -322,7 +322,7 @@ } } -/* See Table 10.5.25 of GSM04.08 */ +/* See 3GPP TS 44.018 Table 10.5.2.5.1 "Channel Description information element" */ static uint8_t gsm_pchan2chan_nr(enum gsm_phys_chan_config pchan, uint8_t ts_nr, uint8_t lchan_nr) { @@ -369,7 +369,7 @@ case GSM_PCHAN_NONE: LOGP(DRSL, LOGL_ERROR, "ts=%u,ss=%u Physical channel %s not expected!\n", ts_nr, lchan_nr, gsm_pchan_name(pchan)); - cbits = 0x00; + cbits = 0x00; /* Reserved */ break; default: LOGP(DRSL, LOGL_ERROR, "ts=%u,ss=%u Physical channel %s (0x%02x) not expected!\n", -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31964 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: If1de230f022c69f3dfce8a7c66d494a984e7f3f9 Gerrit-Change-Number: 31964 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-bts[master]: lchan: Improve error path logging in gsm_pchan2chan_nr()
by pespin 17 Mar '23

17 Mar '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/31963 ) Change subject: lchan: Improve error path logging in gsm_pchan2chan_nr() ...................................................................... lchan: Improve error path logging in gsm_pchan2chan_nr() Change-Id: I8d9da8e8433feb1f022dc2f5199f9c15c01e9312 --- M src/common/lchan.c 1 file changed, 13 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/63/31963/1 diff --git a/src/common/lchan.c b/src/common/lchan.c index 0402c17..638f30a 100644 --- a/src/common/lchan.c +++ b/src/common/lchan.c @@ -367,13 +367,13 @@ cbits = ABIS_RSL_CHAN_NR_CBITS_BCCH; break; case GSM_PCHAN_NONE: - LOGP(DRSL, LOGL_ERROR, "Physical channel %s not expected!\n", - gsm_pchan_name(pchan)); + LOGP(DRSL, LOGL_ERROR, "ts=%u,ss=%u Physical channel %s not expected!\n", + ts_nr, lchan_nr, gsm_pchan_name(pchan)); cbits = 0x00; break; default: - LOGP(DRSL, LOGL_ERROR, "Physical channel %s (0x%02x) not expected!\n", - gsm_pchan_name(pchan), (int)pchan); + LOGP(DRSL, LOGL_ERROR, "ts=%u,ss=%u Physical channel %s (0x%02x) not expected!\n", + ts_nr, lchan_nr, gsm_pchan_name(pchan), (int)pchan); OSMO_ASSERT(0); break; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31963 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I8d9da8e8433feb1f022dc2f5199f9c15c01e9312 Gerrit-Change-Number: 31963 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-ttcn3-hacks[master]: Limit maximum number of open file descriptors to overcome titan bug
by pespin 17 Mar '23

17 Mar '23

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31944 ) Change subject: Limit maximum number of open file descriptors to overcome titan bug ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > BTW, this might be related to https://osmocom.org/issues/4565. I think it's not exactly the same. That message is probably printed because probably under some systems the select() call is being used, which has a FD_SET maximum of 1024 iirc. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31944 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iafa8cfa769386e63e1d879d8cce6e24b244d9a6f Gerrit-Change-Number: 31944 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 17 Mar 2023 13:58:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0