March 2023 - gerrit-log - lists.osmocom.org

[L] Change in osmo-ttcn3-hacks[master]: library: L1CTL: rework GPRS related message definitions
by pespin 20 Mar '23

20 Mar '23

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31974 ) Change subject: library: L1CTL: rework GPRS related message definitions ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31974 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib8f4459480bbe12584a6fa71882f745f03c5055d Gerrit-Change-Number: 31974 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 20 Mar 2023 09:04:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in osmo-ttcn3-hacks[master]: library: L1CTL: merge L1ctl{Ul,Dl}Message into L1ctlMessage
by pespin 20 Mar '23

20 Mar '23

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31973 ) Change subject: library: L1CTL: merge L1ctl{Ul,Dl}Message into L1ctlMessage ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: Maybe it would be great to have a union in L1CTLMessage separating between messages in one direction and another. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31973 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1313068c5f02b65d3dbb05a1341a9d7286225f0c Gerrit-Change-Number: 31973 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 20 Mar 2023 09:01:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmocom-bb[master]: l1gprs: fix NULL pointer dereference in l1gprs_unregister_tbf()
by pespin 20 Mar '23

20 Mar '23

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/31969 ) Change subject: l1gprs: fix NULL pointer dereference in l1gprs_unregister_tbf() ...................................................................... Patch Set 1: (1 comment) File src/shared/l1gprs.c: https://gerrit.osmocom.org/c/osmocom-bb/+/31969/comment/419383dc_f5378fbc PS1, Line 138: "%s(): " LOG_TBF_FMT " not found\n", this is still probably wrong since LOG_TBF_FMT seems to be used with a tbf param? -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/31969 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ie3e7b5a8a205d4410de458dec2fde466493d31ce Gerrit-Change-Number: 31969 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 20 Mar 2023 08:56:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in osmo-msc[master]: do CN CRCX first
by pespin 20 Mar '23

20 Mar '23

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/31740 ) Change subject: do CN CRCX first ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/31740 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ie433db1ba0c46d4b97538a969233c155cefac21c Gerrit-Change-Number: 31740 Gerrit-PatchSet: 5 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 20 Mar 2023 08:54:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in osmo-msc[master]: [codecs filter] send + receive SDP via MNCC
by pespin 20 Mar '23

20 Mar '23

Attention is currently required from: neels, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/31698 ) Change subject: [codecs filter] send + receive SDP via MNCC ...................................................................... Patch Set 8: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/31698 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ie0668c0e079ec69da1532b52d00621efe114fc2c Gerrit-Change-Number: 31698 Gerrit-PatchSet: 8 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 20 Mar 2023 08:53:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-msc[master]: [codecs filter] use filter result in Assignment
by pespin 20 Mar '23

20 Mar '23

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/30126 ) Change subject: [codecs filter] use filter result in Assignment ...................................................................... Patch Set 9: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/30126 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I66e7c8c5e401f4f3a7d3d42b9525b2c6e99691d9 Gerrit-Change-Number: 30126 Gerrit-PatchSet: 9 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 20 Mar 2023 08:52:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-bts[master]: osmo-bts-virtual: properly handle dynamic TS in vbts_set_ts()
by fixeria 20 Mar '23

20 Mar '23

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31977 ) Change subject: osmo-bts-virtual: properly handle dynamic TS in vbts_set_ts() ...................................................................... Patch Set 3: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-bts/+/31977/comment/9cfac355_f95e835e PS3, Line 9: fixes support of dynamic timeslots in osmo-bts-virtual This might sound way too optimistic. It actually fixes a problem that prevents osmo-bts from starting when dynamic timeslots are in use. I'll better rephrase. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31977 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I5db5b7dd6a8e84cf9a0d84f04a650c2ed8a4e368 Gerrit-Change-Number: 31977 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Mon, 20 Mar 2023 08:26:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in osmo-bts[master]: osmo-bts-virtual: properly handle dynamic TS in vbts_set_ts()
by fixeria 19 Mar '23

19 Mar '23

Attention is currently required from: fixeria. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/31977 to look at the new patch set (#3). Change subject: osmo-bts-virtual: properly handle dynamic TS in vbts_set_ts() ...................................................................... osmo-bts-virtual: properly handle dynamic TS in vbts_set_ts() This change fixes support of dynamic timeslots in osmo-bts-virtual. Change-Id: I5db5b7dd6a8e84cf9a0d84f04a650c2ed8a4e368 --- M src/osmo-bts-virtual/bts_model.c 1 file changed, 34 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/77/31977/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31977 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I5db5b7dd6a8e84cf9a0d84f04a650c2ed8a4e368 Gerrit-Change-Number: 31977 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-ttcn3-hacks[master]: BTS_Tests.cfg: set mp_l1_supports_gprs to true
by fixeria 19 Mar '23

19 Mar '23

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31980 ) Change subject: BTS_Tests.cfg: set mp_l1_supports_gprs to true ...................................................................... BTS_Tests.cfg: set mp_l1_supports_gprs to true This parameters enables running additional TC_pcu_* tests. Both trxcon and virtphy now do support GPRS (l1gprs). Change-Id: I68351bf45fa3470a3a25eae2110056abae39af47 --- M bts/BTS_Tests.cfg 1 file changed, 13 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/80/31980/1 diff --git a/bts/BTS_Tests.cfg b/bts/BTS_Tests.cfg index 36d81e2..c6f50ad 100644 --- a/bts/BTS_Tests.cfg +++ b/bts/BTS_Tests.cfg @@ -25,6 +25,7 @@ #BTS_Tests.mp_ctrl_ip := "127.0.0.20" #BTS_Tests_OML.mp_oml_ip := "192.168.102.239" # home #BTS_Tests_OML.mp_oml_port := 3002 +BTS_Tests.mp_l1_supports_gprs := true # real BTS / RF #BTS_Tests.mp_bb_trxc_port := -1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31980 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I68351bf45fa3470a3a25eae2110056abae39af47 Gerrit-Change-Number: 31980 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-ttcn3-hacks[master]: BTS_Tests: keep pchan configuration unchanged in TC_pcu_*
by fixeria 19 Mar '23

19 Mar '23

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31979 ) Change subject: BTS_Tests: keep pchan configuration unchanged in TC_pcu_* ...................................................................... BTS_Tests: keep pchan configuration unchanged in TC_pcu_* Change [1] fixes support of dynamic timeslots in osmo-bts-virtual, so we don't need to change the pchan configuration anymore. Change-Id: I98397ac0fc17ece8f0e41b1ef1c158b47c9de026 Related: [1] osmo-bts.git I5db5b7dd6a8e84cf9a0d84f04a650c2ed8a4e368 --- M bts/BTS_Tests.ttcn 1 file changed, 20 insertions(+), 17 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/79/31979/1 diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn index 70a2137..c36e27d 100644 --- a/bts/BTS_Tests.ttcn +++ b/bts/BTS_Tests.ttcn @@ -5509,7 +5509,7 @@ testcase TC_pcu_data_req_wrong_bts() runs on test_CT { var octetstring data := '0000'O & f_rnd_octstring(21); - f_virtphy_common(); + f_TC_pcu_common(); f_TC_pcu_act_req(0, 0, 7, true); f_TC_pcu_l1ctl_est_pdch(7); @@ -5522,7 +5522,7 @@ testcase TC_pcu_data_req_wrong_trx() runs on test_CT { var octetstring data := '0000'O & f_rnd_octstring(21); - f_virtphy_common(); + f_TC_pcu_common(); f_TC_pcu_act_req(0, 0, 7, true); f_TC_pcu_l1ctl_est_pdch(7); @@ -5535,7 +5535,7 @@ testcase TC_pcu_data_req_wrong_ts() runs on test_CT { var octetstring data := '0000'O & f_rnd_octstring(21); - f_virtphy_common(); + f_TC_pcu_common(); f_TC_pcu_act_req(0, 0, 7, true); f_TC_pcu_l1ctl_est_pdch(7); @@ -5548,7 +5548,7 @@ testcase TC_pcu_data_req_ts_inactive() runs on test_CT { var octetstring data := '0000'O & f_rnd_octstring(21); - f_virtphy_common(); + f_TC_pcu_common(); /* intentionally not calling f_TC_pcu_act_req() */ f_TC_pcu_l1ctl_est_pdch(7); @@ -5593,18 +5593,8 @@ } } -private function f_disable_dynamic_ts() runs on test_CT -{ - f_init_vty_bsc(); - /* I'm not quite sure why we need this with osmo-bts-virtual. Somehow it deosn't seem to - * support dynamic timeslots? But it uses the same scheduler as osmo-bts-trx ?!? */ - f_vty_config2(BSCVTY, {"network", "bts 0", "trx 0", "timeslot 3"}, "phys_chan_config TCH/F"); - f_vty_config2(BSCVTY, {"network", "bts 0", "trx 0", "timeslot 4"}, "phys_chan_config TCH/F"); +private function f_TC_pcu_common() runs on test_CT { f_init_with_pcuif(); -} - -private function f_virtphy_common() runs on test_CT { - f_disable_dynamic_ts(); f_init_l1ctl(); f_l1_tune(L1CTL); } @@ -5612,7 +5602,7 @@ testcase TC_pcu_data_req_pdtch() runs on test_CT { var octetstring data := '0000'O & f_rnd_octstring(21); - f_virtphy_common(); + f_TC_pcu_common(); f_TC_pcu_act_req(0, 0, 7, true); f_TC_pcu_l1ctl_est_pdch(7); @@ -5624,7 +5614,7 @@ testcase TC_pcu_data_req_ptcch() runs on test_CT { var octetstring data := '0000'O & f_rnd_octstring(21); - f_virtphy_common(); + f_TC_pcu_common(); f_TC_pcu_act_req(0, 0, 7, true); f_TC_pcu_l1ctl_est_pdch(7); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31979 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I98397ac0fc17ece8f0e41b1ef1c158b47c9de026 Gerrit-Change-Number: 31979 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0