Attention is currently required from: fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/31969 )
Change subject: l1gprs: fix NULL pointer dereference in l1gprs_unregister_tbf()
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File src/shared/l1gprs.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/31969/comment/99780fc7_7bb861cf
PS1, Line 138: "%s(): " LOG_TBF_FMT " not found\n",
> No, this is correct. I am passing the format string arguments expected by `LOG_TBF_FMT` manually.
Yes but my point is that passing that LOG_TBF_FMT here makes the code more difficult to understand because you are not sure what you pass matches with what you have in the macro until you look at it.
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/31969
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Ie3e7b5a8a205d4410de458dec2fde466493d31ce
Gerrit-Change-Number: 31969
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 20 Mar 2023 09:17:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31980 )
Change subject: BTS_Tests.cfg: set mp_l1_supports_gprs to true
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31980
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I68351bf45fa3470a3a25eae2110056abae39af47
Gerrit-Change-Number: 31980
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 20 Mar 2023 09:15:21 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31976 )
Change subject: scheduler: log pchan value in trx_sched_set_pchan()
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31976
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ia31e53552208a9d57e2fc5473440840d38945d00
Gerrit-Change-Number: 31976
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 20 Mar 2023 09:13:48 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/31969 )
Change subject: l1gprs: fix NULL pointer dereference in l1gprs_unregister_tbf()
......................................................................
Patch Set 1:
(1 comment)
File src/shared/l1gprs.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/31969/comment/1f904146_72c01040
PS1, Line 138: "%s(): " LOG_TBF_FMT " not found\n",
> this is still probably wrong since LOG_TBF_FMT seems to be used with a tbf param?
No, this is correct. I am passing the format string arguments expected by `LOG_TBF_FMT` manually.
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/31969
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Ie3e7b5a8a205d4410de458dec2fde466493d31ce
Gerrit-Change-Number: 31969
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 20 Mar 2023 09:13:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: arehbein.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31972 )
Change subject: gsm_bts_check_ny1: Prevent possible division by zero
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
File src/osmo-bsc/bts.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/31972/comment/9b702b9d_b2cf0d84
PS1, Line 1734: if (!(T3105 * ny1 > GSM_T3124_MAX + GSM_NY1_REQ_DELTA)) {
if Ny1 should always be higher than 0 (GSM_T3124_MAX + GSM_NY1_REQ_DELTA), then T3015 cannot be 0 here (at least it doesn't make sense it can be configured to 0).
Hence, rather than applyig this patch, I'd change the T_def row to have a min_val > 0, eg 1.
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31972
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I1fd0b92ab507a58fed6e9649eaa4770f1ad1cbad
Gerrit-Change-Number: 31972
Gerrit-PatchSet: 1
Gerrit-Owner: arehbein <arehbein(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: arehbein <arehbein(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 20 Mar 2023 09:11:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31978 )
Change subject: BTS_Tests: do L1CTL.clear in f_pcu_to_l1()
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File bts/BTS_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31978/comment/c670a750_b201…
PS1, Line 5574: L1CTL.clear;
you may run into race conditions here clearing stuff and then reading.
Iedally you should discard those messages in the alt statement, with a repeat; to keep reading.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31978
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I57b745bcfc48dc621359658cd43d2ee622fde49b
Gerrit-Change-Number: 31978
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 20 Mar 2023 09:06:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment