February 2023 - gerrit-log - lists.osmocom.org

Change in osmo-bsc[master]: timeslot_fsm: remove duplicate TS_ST_BORKEN from out_state_mask

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30990 ) Change subject: timeslot_fsm: remove duplicate TS_ST_BORKEN from out_state_mask ...................................................................... timeslot_fsm: remove duplicate TS_ST_BORKEN from out_state_mask The stete TS_ST_WAIT_PDCH_DEACT has TS_ST_BORKEN twice in out_state_mask. This is unnecessary. Change-Id: Ib758150ba7074adbb1b59008f0dfb57766763897 --- M src/osmo-bsc/timeslot_fsm.c 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo-bsc/timeslot_fsm.c b/src/osmo-bsc/timeslot_fsm.c index 72db0fa..c7f6130 100644 --- a/src/osmo-bsc/timeslot_fsm.c +++ b/src/osmo-bsc/timeslot_fsm.c @@ -932,7 +932,6 @@ .out_state_mask = 0 | S(TS_ST_IN_USE) | S(TS_ST_UNUSED) - | S(TS_ST_BORKEN) | S(TS_ST_NOT_INITIALIZED) | S(TS_ST_BORKEN) , -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30990 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib758150ba7074adbb1b59008f0dfb57766763897 Gerrit-Change-Number: 30990 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 4 months

1
0
0 0

Change in osmocom-bb[master]: mobile: fix -Wlogical-not-parentheses in gsm48_cc_init()

by laforge

Attention is currently required from: neels, pespin, fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30963 ) Change subject: mobile: fix -Wlogical-not-parentheses in gsm48_cc_init() ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/host/layer23/src/mobile/gsm48_cc.c: https://gerrit.osmocom.org/c/osmocom-bb/+/30963/comment/07a7a93f_6b41cb53 PS1, Line 54: if (cc->mncc_upqueue.next != NULL) > Feel free to merge this patch if you want, but I think we really fix the code to properly initialize […] agreeing with pespin here. we can merged this first and then clean it up properly later. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30963 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ic7ffd3aa25339e24a31bae1b7428f1f93e261858 Gerrit-Change-Number: 30963 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 06 Feb 2023 16:08:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in osmo-gsm-manuals[master]: rate counter: add StatsD note

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/30715 ) Change subject: rate counter: add StatsD note ...................................................................... rate counter: add StatsD note Add passage explaining basic visualisation of stat and rate counter items with Netdata so user can start utilizing them without any special configuration. Related: OS#5671 Change-Id: I124503c3707bbe005abbfb4245abe2829c6ff57c --- M common/chapters/counters-overview.adoc 1 file changed, 6 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/common/chapters/counters-overview.adoc b/common/chapters/counters-overview.adoc index 51cc5ce..b51036f 100644 --- a/common/chapters/counters-overview.adoc +++ b/common/chapters/counters-overview.adoc @@ -124,8 +124,12 @@ <4> IP address of the statsd server. <5> UDP port of the statsd server. Statsd by default listens to port 8125. -Setting up a statsd server and configuring the visualization is beyond the -scope of this document. +You can use Netdata (https://learn.netdata.cloud/) as a statsd server which does not require special configuration +to show rate counters. +By default all the rate counters will be exposed to the StatsD plugin (listening on 127.0.0.1:8125) and displayed on the +Netdata dashboard available via: http://localhost:19999 +The list of available charts which includes all the rate counters reported via statsD is available through: +http://localhost:19999/api/v1/charts === Socket stats -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/30715 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I124503c3707bbe005abbfb4245abe2829c6ff57c Gerrit-Change-Number: 30715 Gerrit-PatchSet: 3 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 4 months

1
0
0 0

Change in osmo-gsm-manuals[master]: rate counter: add StatsD note

by laforge

Attention is currently required from: msuraev. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/30715 ) Change subject: rate counter: add StatsD note ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/30715 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I124503c3707bbe005abbfb4245abe2829c6ff57c Gerrit-Change-Number: 30715 Gerrit-PatchSet: 3 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Mon, 06 Feb 2023 16:07:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in osmo-mgw[master]: update outdated vty copyright statement

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/30395 ) Change subject: update outdated vty copyright statement ...................................................................... update outdated vty copyright statement Change-Id: I7af4bdecddda0b43f98855571942219e8ba00b64 --- M src/osmo-mgw/mgw_main.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo-mgw/mgw_main.c b/src/osmo-mgw/mgw_main.c index cd9d75d..b9a36dd 100644 --- a/src/osmo-mgw/mgw_main.c +++ b/src/osmo-mgw/mgw_main.c @@ -82,7 +82,7 @@ const char *osmomgw_copyright = "Copyright (C) 2009-2010 Holger Freyther and On-Waves\r\n" - "Copyright (C) 2017 by sysmocom s.f.m.c. GmbH <info(a)sysmocom.de>\r\n" + "Copyright (C) 2017-2022 by sysmocom s.f.m.c. GmbH\r\n" "Contributions by Pablo Neira Ayuso, Jacob Erlbeck, Neels Hofmeyr\r\n" "Philipp Maier\r\n\r\n" "License AGPLv3+: GNU AGPL version 3 or later <http://gnu.org/licenses/agpl-3.0.html>\r\n" 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/30395 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I7af4bdecddda0b43f98855571942219e8ba00b64 Gerrit-Change-Number: 30395 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 4 months

1
0
0 0

Change in osmo-ci[master]: ansible: install-poky-sdk: add tag poky to the apt install task

by laforge

Attention is currently required from: lynxis lazus. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/30915 ) Change subject: ansible: install-poky-sdk: add tag poky to the apt install task ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: ping? would be great if acouzens could do a rebase for this series of patches, as this cannot be merged due to merge conflicts. -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30915 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Id8e433a789aff8df241687f1f109a161e725a29a Gerrit-Change-Number: 30915 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 06 Feb 2023 16:06:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in osmo-ci[master]: ansible.cfg: set default remote_user = root

by laforge

Attention is currently required from: lynxis lazus. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/30920 ) Change subject: ansible.cfg: set default remote_user = root ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30920 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Iccd7dce77ac408d1a0d5782b4563a5dfcf112030 Gerrit-Change-Number: 30920 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 06 Feb 2023 16:05:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in osmo-e1-recorder[master]: handle telnet_init_default() error case

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-e1-recorder/+/31183 ) Change subject: handle telnet_init_default() error case ...................................................................... handle telnet_init_default() error case Closes: CID#307532 Change-Id: I0210b535b844529e217fd5d6ffb01f94a262dc9c --- M src/e1_recorder.c 1 file changed, 6 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/e1_recorder.c b/src/e1_recorder.c index 68d4543..996ede4 100644 --- a/src/e1_recorder.c +++ b/src/e1_recorder.c @@ -207,8 +207,12 @@ exit(1); } - /* start telne tafte reading config for vty_get_bind_adr() */ - telnet_init_default(rec_tall_ctx, NULL, 4444); + /* start telnet after reading config */ + rc = telnet_init_default(rec_tall_ctx, NULL, 4444); + if (rc < 0) { + fprintf(stderr, "Cannot open telnet server port: %s\n", strerror(errno)); + exit(1); + } while (1) { osmo_select_main(0); -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-recorder/+/31183 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-recorder Gerrit-Branch: master Gerrit-Change-Id: I0210b535b844529e217fd5d6ffb01f94a262dc9c Gerrit-Change-Number: 31183 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 4 months

1
0
0 0

Change in libgtpnl[master]: fix memleak on del_tunnel() failure

by laforge

Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libgtpnl/+/31158 ) Change subject: fix memleak on del_tunnel() failure ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/31158 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libgtpnl Gerrit-Branch: master Gerrit-Change-Id: Ie29840a7518435447acf48f12e81fc520308a265 Gerrit-Change-Number: 31158 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 06 Feb 2023 16:04:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in osmo-ci[master]: coverity: build osmo-ggsn with --enable-gtp-linux

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/31139 ) Change subject: coverity: build osmo-ggsn with --enable-gtp-linux ...................................................................... coverity: build osmo-ggsn with --enable-gtp-linux Change-Id: I5b240dbfe2369a5a54ab6115a8780cf9cc36b537 --- M coverity/build_Osmocom.sh 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/coverity/build_Osmocom.sh b/coverity/build_Osmocom.sh index d3d11d8..3bf9d4b 100755 --- a/coverity/build_Osmocom.sh +++ b/coverity/build_Osmocom.sh @@ -79,7 +79,9 @@ build_default libosmo-pfcp build_default libosmo-sccp build_default libsmpp34 -build_default osmo-ggsn +build_default libgtpnl +build_default osmo-ggsn \ + --enable-gtp-linux build_default osmo-gbproxy build_default osmo-iuh build_default osmo-pcu \ @@ -126,7 +128,6 @@ build_default osmo-pcap build_default osmo-e1d build_default osmo-e1-recorder -build_default libgtpnl build_default osmo-upf # OS#5886: doesn't build -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/31139 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I5b240dbfe2369a5a54ab6115a8780cf9cc36b537 Gerrit-Change-Number: 31139 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

2 years, 4 months

1
0
0 0

2025

2024

2023

2022

gerrit-log February 2023