February 2023 - gerrit-log - lists.osmocom.org

Change in libosmo-gprs[master]: rlcmac: Introduce lower primitive layer API

by pespin

Attention is currently required from: pespin, fixeria. Hello Jenkins Builder, laforge, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31177 to look at the new patch set (#8). Change subject: rlcmac: Introduce lower primitive layer API ...................................................................... rlcmac: Introduce lower primitive layer API This primitive API allows the application to drive the RLCMAC layer based on a lower L1CTL interface. * RACH req are requested to the lower layers by the RLCMAC through the RACH.req primitive. * Received ImmAss, SI are fed to the RLC/MAC layer through CCCH_DATA.ind * The RLCMAC registers DL and UL TBFs in the lower part (firwmare, L1CTL): ** The lower part will trigger PDCH_RTS.ind in every TS in the "(dl_slotmask|ul_slotmask)" superset, with the received USF. This allows UL uplink to transmit blocks when requested by USF, or UL/DL TBF to answer polls from PCU at a specific N+X FN (RRBP). This also allows the RLCMAC layer to update its GSM clock and trigger internall timeouts. ** The lower part will trigger PDCH_DATA.ind in every TS in the dl_slotmask if either a CTRL block is received or a data block matching the configured dl_tfi is received. ** Upon receival of PDCH_DATA.ind, the RLCMAC layer updates its FN clock and submits PDCH_DATA.req based on USF. This commit only adds the primitive set and API to submit/receive them, but doesn't really implement them yet internally. Related: OS#5500 Change-Id: I3d97425ec75059ceae983de869419230e8c4df01 --- M include/osmocom/gprs/rlcmac/rlcmac_prim.h M include/osmocom/gprs/rlcmac/rlcmac_private.h M src/rlcmac/rlcmac_prim.c M tests/rlcmac/Makefile.am A tests/rlcmac/rlcmac_prim_test.c A tests/rlcmac/rlcmac_prim_test.err A tests/rlcmac/rlcmac_prim_test.ok M tests/testsuite.at 8 files changed, 478 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/77/31177/8 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31177 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I3d97425ec75059ceae983de869419230e8c4df01 Gerrit-Change-Number: 31177 Gerrit-PatchSet: 8 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 4 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: sgsn: Add TC_attach_timeout_after_pdp_act

by pespin

Attention is currently required from: arehbein. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31199 ) Change subject: sgsn: Add TC_attach_timeout_after_pdp_act ...................................................................... Patch Set 1: (5 comments) File sgsn/SGSN_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31199/comment/2fb0a383_67e7… PS1, Line 1020: private function f_TC_attach_timeout_after_pdp_act(charstring id) runs on BSSGP_ConnHdlr { Is there an associated OS# ticket? may be worth adding it on top of the function together with quick explanation of what the test does. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31199/comment/2739d9b4_fcab… PS1, Line 1023: const integer ran_index := 0, gmm_attach_repeats := 5; please in general one variable per line, specially if you are initializing them. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31199/comment/8a7da972_9a6c… PS1, Line 1024: /* Standard T3350 value */ is tha standard as per spec? which one? https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31199/comment/17ed155d_cc58… PS1, Line 1037: attach_req.msgs.gprs_mm.attachRequest.msNetworkCapability.msNetworkCapabilityV.revisionLevelIndicatior := '1'B; do we really need this lines changing capabilities? I don't think so? https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31199/comment/6f05dbe5_9459… PS1, Line 1044: log("Trying to receive ", gmm_attach_repeats, " ATTACH ACCEPTs"); by repeats here I guess you mean retransmits? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31199 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib3e3c021707b707811388616e28d7d7cc22f7b53 Gerrit-Change-Number: 31199 Gerrit-PatchSet: 1 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Comment-Date: Mon, 06 Feb 2023 20:18:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in libosmo-gprs[master]: rlcmac: Introduce lower primitive layer API

by pespin

Attention is currently required from: pespin, fixeria. Hello Jenkins Builder, laforge, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31177 to look at the new patch set (#7). Change subject: rlcmac: Introduce lower primitive layer API ...................................................................... rlcmac: Introduce lower primitive layer API This primitive API allows the application to drive the RLCMAC layer based on a lower L1CTL interface. * RACH req are requested to the lower layers by the RLCMAC through the RACH.req primitive. * Received ImmAss, SI are fed to the RLC/MAC layer through CCCH_DATA.ind * The RLCMAC registers DL and UL TBFs in the lower part (firwmare, L1CTL): ** The lower part will trigger PDCH_RTS.ind in every TS in the "(dl_slotmask|ul_slotmask)" superset, with the received USF. This allows UL uplink to transmit blocks when requested by USF, or UL/DL TBF to answer polls from PCU at a specific N+X FN (RRBP). This also allows the RLCMAC layer to update its GSM clock and trigger internall timeouts. ** The lower part will trigger PDCH_DATA.ind in every TS in the dl_slotmask if either a CTRL block is received or a data block matching the configured dl_tfi is received. ** Upon receival of PDCH_DATA.ind, the RLCMAC layer updates its FN clock and submits PDCH_DATA.req based on USF. This commit only adds the primitive set and API to submit/receive them, but doesn't really implement them yet internally. Related: OS#5500 Change-Id: I3d97425ec75059ceae983de869419230e8c4df01 --- M include/osmocom/gprs/rlcmac/rlcmac_prim.h M include/osmocom/gprs/rlcmac/rlcmac_private.h M src/rlcmac/rlcmac_prim.c M tests/rlcmac/Makefile.am A tests/rlcmac/rlcmac_prim_test.c A tests/rlcmac/rlcmac_prim_test.err A tests/rlcmac/rlcmac_prim_test.ok M tests/testsuite.at 8 files changed, 478 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/77/31177/7 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31177 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I3d97425ec75059ceae983de869419230e8c4df01 Gerrit-Change-Number: 31177 Gerrit-PatchSet: 7 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 4 months

1
0
0 0

Change in libosmo-gprs[master]: rlcmac: Initial implementation of UL TBF assignment and scheduler

by pespin

Attention is currently required from: fixeria. Hello Jenkins Builder, laforge, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31099 to look at the new patch set (#10). Change subject: rlcmac: Initial implementation of UL TBF assignment and scheduler ...................................................................... rlcmac: Initial implementation of UL TBF assignment and scheduler This patch is another towards a working RLC/MAC implementation. It adds: * An initial data model with MS (gprs_rlcmac_entity) and ul_tbf. * A UL_TBF state FSM from initial to FLOW status * A UL_TBF assignemnt FSM, covering both 1phase and 2phase assignments. * Triggering of UL_TBF allocation and assignment FSM when new LLC data is pushed from upper layers. * A scheduler generating some ctrl messages (PktResReq and UlDummyCtrlBlk) when indicated by the network. This patch is pushed as a WIP state since it already contains a considerable amount of code and lots of new files, which can be used/extended at a later point, making parallel contribution easier. Related: OS#5500 Change-Id: I420c57a9d0b63f9c2805a7c2ae8ce85532a48eef --- M include/osmocom/gprs/rlcmac/Makefile.am M include/osmocom/gprs/rlcmac/rlcmac.h A include/osmocom/gprs/rlcmac/rlcmac_enc.h M include/osmocom/gprs/rlcmac/rlcmac_private.h A include/osmocom/gprs/rlcmac/sched.h A include/osmocom/gprs/rlcmac/tbf.h A include/osmocom/gprs/rlcmac/tbf_ul.h A include/osmocom/gprs/rlcmac/tbf_ul_ass_fsm.h A include/osmocom/gprs/rlcmac/tbf_ul_fsm.h A include/osmocom/gprs/rlcmac/types_private.h M src/rlcmac/Makefile.am M src/rlcmac/gre.c M src/rlcmac/misc.c M src/rlcmac/rlcmac.c A src/rlcmac/rlcmac_enc.c M src/rlcmac/rlcmac_prim.c A src/rlcmac/sched.c A src/rlcmac/tbf.c A src/rlcmac/tbf_ul.c A src/rlcmac/tbf_ul_ass_fsm.c A src/rlcmac/tbf_ul_fsm.c M tests/rlcmac/rlcmac_prim_test.c M tests/rlcmac/rlcmac_prim_test.err M tests/rlcmac/rlcmac_prim_test.ok 24 files changed, 1,402 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/99/31099/10 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31099 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I420c57a9d0b63f9c2805a7c2ae8ce85532a48eef Gerrit-Change-Number: 31099 Gerrit-PatchSet: 10 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 4 months

1
0
0 0

Change in libosmo-gprs[master]: rlcmac: Initial ul_tbf data support

by pespin

Attention is currently required from: laforge, fixeria. Hello Jenkins Builder, laforge, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31170 to look at the new patch set (#2). Change subject: rlcmac: Initial ul_tbf data support ...................................................................... rlcmac: Initial ul_tbf data support This is basically an import of relevant code from osmo-pcu.git 08523c2286dfe27402f8e2eb4b98da5a529c7915 which allows encoding LLC frames into RLC/MAC uplink data blocks. A 1-to-1 import was not possible for several reasons: * osmo-pcu uses C++ in some places * osmo-pcu implements encoding of DL data blocks, not UL data blocks * Some osmo-pcu code is still not really polished and stuff is still mixed (for instance rlc_window(_ul).c/h were split into their own files here). Hence this was not a "copy all files and leave as they are" import, but rather looking at the encode path starting on osmo-pcu.git scheduler and see which code had to be pulled in to encode the RLC/MAC blocks. Due to the slightly different requerirements for UL and DL blocks, it is well possible that further work in needed in order to have the code produce correct blocks. This is only a first step to pull in all code so that stuff can be fixed in smallish incremental steps. Related: OS#5500 Change-Id: I0a01d79d16bbfc63aa88e6bb0f432f3772645730 --- M include/osmocom/gprs/rlcmac/Makefile.am A include/osmocom/gprs/rlcmac/coding_scheme.h A include/osmocom/gprs/rlcmac/rlc.h A include/osmocom/gprs/rlcmac/rlc_window.h A include/osmocom/gprs/rlcmac/rlc_window_ul.h M include/osmocom/gprs/rlcmac/rlcmac_enc.h M include/osmocom/gprs/rlcmac/rlcmac_private.h M include/osmocom/gprs/rlcmac/tbf_ul.h M include/osmocom/gprs/rlcmac/tbf_ul_fsm.h M src/rlcmac/Makefile.am A src/rlcmac/coding_scheme.c A src/rlcmac/rlc.c A src/rlcmac/rlc_window.c A src/rlcmac/rlc_window_ul.c M src/rlcmac/rlcmac.c M src/rlcmac/rlcmac_enc.c M src/rlcmac/tbf_ul.c M src/rlcmac/tbf_ul_fsm.c 18 files changed, 2,525 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/70/31170/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31170 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I0a01d79d16bbfc63aa88e6bb0f432f3772645730 Gerrit-Change-Number: 31170 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 4 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: sgsn: Add TC_attach_timeout_after_pdp_act

by arehbein

arehbein has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31199 ) Change subject: sgsn: Add TC_attach_timeout_after_pdp_act ...................................................................... sgsn: Add TC_attach_timeout_after_pdp_act Related: OS#4221 Change-Id: Ib3e3c021707b707811388616e28d7d7cc22f7b53 --- M sgsn/SGSN_Tests.ttcn 1 file changed, 57 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/99/31199/1 diff --git a/sgsn/SGSN_Tests.ttcn b/sgsn/SGSN_Tests.ttcn index f633101..e61d25d 100644 --- a/sgsn/SGSN_Tests.ttcn +++ b/sgsn/SGSN_Tests.ttcn @@ -1017,6 +1017,62 @@ f_cleanup(); } +private function f_TC_attach_timeout_after_pdp_act(charstring id) runs on BSSGP_ConnHdlr { + var PdpActPars apars := valueof(t_PdpActPars(mp_ggsn_ip)); + /* Vars needed for triggering T3350 timeouts */ + const integer ran_index := 0, gmm_attach_repeats := 5; + /* Standard T3350 value */ + const float T3350 := 6.0; + var template PDU_L3_MS_SGSN attach_req; + timer t_receive_GMM_ATTACH_ACCEPT; + var RoutingAreaIdentificationV rai := f_random_RAI(); + + /* First establish PDP context */ + f_TC_attach(id); + f_pdp_ctx_act(apars); + + /* Now, try another GPRS attach procedure. For further code comments up until receiving the attach + * accept from the SGSN, see definition of f_gmm_attach() */ + attach_req := ts_GMM_ATTACH_REQ(f_mi_get_lv(), rai, false, false, omit, omit); + attach_req.msgs.gprs_mm.attachRequest.msNetworkCapability.msNetworkCapabilityV.revisionLevelIndicatior := '1'B; + attach_req.msgs.gprs_mm.attachRequest.msNetworkCapability.msNetworkCapabilityV.solSACapability := '0'B; + f_send_l3(attach_req, ran_index); + f_gmm_auth(false, false, ran_index); + f_gmm_gsup_lu_isd(); + + BSSGP[ran_index].clear; + log("Trying to receive ", gmm_attach_repeats, " ATTACH ACCEPTs"); + for (var integer i := 1; i <= gmm_attach_repeats; i := i+1) { + t_receive_GMM_ATTACH_ACCEPT.start(T3350 + 0.5); + alt { + [] BSSGP[ran_index].receive(tr_GMM_ATTACH_ACCEPT('001'B, ?, ?)) { + t_receive_GMM_ATTACH_ACCEPT.stop; + } + [] t_receive_GMM_ATTACH_ACCEPT.timeout { + setverdict(fail, "Timeout on receiving ", i, "th ATTACH ACCEPT") + } + } + } + log("Have received ", gmm_attach_repeats, " ATTACH ACCEPT messages"); + log("Make sure not more than ", gmm_attach_repeats, " ATTACH ACCEPT messages are sent"); + t_receive_GMM_ATTACH_ACCEPT.start(T3350 + 0.5); + alt { + [] BSSGP[ran_index].receive(tr_GMM_ATTACH_ACCEPT('001'B, ?, ?)) { + setverdict(fail, "Received ", gmm_attach_repeats + 1, "th ATTACH ACCEPT") + } + [] t_receive_GMM_ATTACH_ACCEPT.timeout { } + } + + setverdict(pass); +} + +testcase TC_attach_timeout_after_pdp_act() runs on test_CT { + var BSSGP_ConnHdlr vc_conn; + f_init(); + vc_conn := f_start_handler(refers(f_TC_attach_timeout_after_pdp_act), testcasename(), g_gb, 21); + f_cleanup(); +} + /* MS never responds to ID REQ, expect ATTACH REJECT */ private function f_TC_attach_auth_id_timeout(charstring id) runs on BSSGP_ConnHdlr { var RoutingAreaIdentificationV old_ra := f_random_RAI(); @@ -3630,6 +3686,7 @@ execute( TC_attach_mnc3() ); execute( TC_attach_umts_aka_umts_res() ); execute( TC_attach_umts_aka_gsm_sres() ); + execute( TC_attach_timeout_after_pdp_act() ); execute( TC_attach_auth_id_timeout() ); execute( TC_attach_auth_sai_timeout() ); execute( TC_attach_auth_sai_reject() ); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31199 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib3e3c021707b707811388616e28d7d7cc22f7b53 Gerrit-Change-Number: 31199 Gerrit-PatchSet: 1 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 4 months

1
0
0 0

Change in libosmo-gprs[master]: rlcmac: Fix prim memleak passing GRR-UNITDATA.req

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31198 ) Change subject: rlcmac: Fix prim memleak passing GRR-UNITDATA.req ...................................................................... rlcmac: Fix prim memleak passing GRR-UNITDATA.req Change-Id: I16d737e6691fd964026260f829230106abcc7ef1 --- M src/rlcmac/rlcmac_prim.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/98/31198/1 diff --git a/src/rlcmac/rlcmac_prim.c b/src/rlcmac/rlcmac_prim.c index 23de05d..8d57580 100644 --- a/src/rlcmac/rlcmac_prim.c +++ b/src/rlcmac/rlcmac_prim.c @@ -230,6 +230,7 @@ rlcmac_prim->grr.ll_pdu_len, rlcmac_prim->grr.unitdata_req.sapi, rlcmac_prim->grr.unitdata_req.radio_prio); + msgb_free(rlcmac_prim->oph.msg); return rc; } -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31198 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I16d737e6691fd964026260f829230106abcc7ef1 Gerrit-Change-Number: 31198 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 4 months

1
0
0 0

Change in osmo-pcu[master]: bts: add IMMEDIATE ASSIGNMENT via PCH transmission

by pespin

Attention is currently required from: laforge, fixeria, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31145 ) Change subject: bts: add IMMEDIATE ASSIGNMENT via PCH transmission ...................................................................... Patch Set 7: (1 comment) Patchset: PS6: > but we will always need support for both methods if we want to stay compatible. Not really, just a few years 😊 But we can at least know 99% of the users will be using up to date packages using a well known path instead of having to maintain 2 messages forever. The sooner we deprecate one, the sooner we'll be able to drop it. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31145 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I2a78651593323e8b9627c39918d949a33497b70f Gerrit-Change-Number: 31145 Gerrit-PatchSet: 7 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 06 Feb 2023 19:15:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in osmo-pcu[master]: bts: add IMMEDIATE ASSIGNMENT via PCH transmission

by dexter

Attention is currently required from: laforge, pespin, fixeria. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31145 ) Change subject: bts: add IMMEDIATE ASSIGNMENT via PCH transmission ...................................................................... Patch Set 7: (3 comments) Patchset: PS6: > I still think the entire patches is being done in the wrong perspective. […] I would really, really love to migrate everything so that it uses the TLLI as a reference but we will always need support for both methods if we want to stay compatible. However, we could take care that all patches are merged at the same time then. As far as I know users are required not to mix packages from different releases. File src/bts.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/31145/comment/896c4dac_c8a13d0b PS5, Line 1105: #ifdef ENABLE_ERICSSON_RBS > indeed. […] Ok, I got this. I will adjust everything accordingly. File src/pcu_l1_if.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/31145/comment/6ec4080a_3cf96519 PS6, Line 757: bts->use_dt_confirm = (info_ind->flags & PCU_IF_FLAG_DT); > Use "!!(...)" to convert it to a 0/1. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31145 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I2a78651593323e8b9627c39918d949a33497b70f Gerrit-Change-Number: 31145 Gerrit-PatchSet: 7 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 06 Feb 2023 19:11:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in osmo-pcu[master]: bts: add IMMEDIATE ASSIGNMENT via PCH transmission

by dexter

Attention is currently required from: laforge, pespin, fixeria. Hello Jenkins Builder, laforge, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/31145 to look at the new patch set (#7). Change subject: bts: add IMMEDIATE ASSIGNMENT via PCH transmission ...................................................................... bts: add IMMEDIATE ASSIGNMENT via PCH transmission In situations where the PCU is co-located to the BSC, the MMEDIATE ASSIGNMENT for downlink TBFs must be sent via RSL and the BSC also must instruct the BTS to transmit the IMMEDIATE ASSIGNMENT via PCH instead of AGCH. Eventually the BSC must sent a confirmation message (follow-up patch) where the TLLI is used as an identifer. Change-Id: I2a78651593323e8b9627c39918d949a33497b70f Related: OS#5198 --- M include/osmocom/pcu/pcuif_proto.h M src/bts.cpp M src/bts.h M src/pcu_l1_if.cpp M src/pcu_l1_if.h 5 files changed, 38 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/45/31145/7 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31145 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I2a78651593323e8b9627c39918d949a33497b70f Gerrit-Change-Number: 31145 Gerrit-PatchSet: 7 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 4 months

1
0
0 0

2025

2024

2023

2022

gerrit-log February 2023