January 2023 - gerrit-log - lists.osmocom.org

Change in libosmocore[master]: isdn: Add V.110 encoder/decoder

by Jenkins Builder

Attention is currently required from: laforge. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30762 ) Change subject: isdn: Add V.110 encoder/decoder ...................................................................... Patch Set 3: (3 comments) File src/isdn/v110.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2857): https://gerrit.osmocom.org/c/libosmocore/+/30762/comment/a7a2adef_450e3dc2 PS3, Line 1: /* V.110 frames according to ITU-T V.110 trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2857): https://gerrit.osmocom.org/c/libosmocore/+/30762/comment/a48bca79_a664df47 PS3, Line 82: ra_bits[2*8 +7] = fr->x_bits[0]; need consistent spacing around '+' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2857): https://gerrit.osmocom.org/c/libosmocore/+/30762/comment/90d3e9b0_b16d0ccd PS3, Line 83: ra_bits[7*8 +7] = fr->x_bits[1]; need consistent spacing around '+' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30762 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I1b5fd3847d3bfb0a0f763e0574893962ec699680 Gerrit-Change-Number: 30762 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 18 Jan 2023 20:19:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in libosmocore[master]: create libosmoisdn sub-library

by laforge

Attention is currently required from: laforge. Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/30376 to look at the new patch set (#5). Change subject: create libosmoisdn sub-library ...................................................................... create libosmoisdn sub-library There are some parts of libosmogsm which are not really GSM specific, but rather ISDN bits that were inherited by GSM. This includes the I.460 multiplex as well as the core LAPD protocol. Let's move those bits to its own libosmoisdn library, before we add more ISDN specific bits to the wrong place. Backwards-compatibility is created by making libosmogsm depend on libosmoisdn, and by providing wrapper include files for source compatibility. Change-Id: Ib1a6c762322fd5047be3188b1df22408ef06aa50 --- M .gitignore M Doxyfile.codec.in M Doxyfile.coding.in M Doxyfile.core.in M Doxyfile.ctrl.in M Doxyfile.gb.in M Doxyfile.gsm.in A Doxyfile.isdn.in M Doxyfile.vty.in M Makefile.am M configure.ac M contrib/libosmocore.spec.in M debian/control M debian/copyright M debian/libosmocore.dirs A debian/libosmoisdn-doc.doc-base A debian/libosmoisdn-doc.install A debian/libosmoisdn0.install M debian/rules M include/Makefile.am M include/osmocom/gsm/i460_mux.h M include/osmocom/gsm/lapd_core.h A include/osmocom/isdn/i460_mux.h A include/osmocom/isdn/lapd_core.h M libosmogsm.pc.in A libosmoisdn.pc.in M src/Makefile.am M src/gsm/Makefile.am A src/isdn/Makefile.am R src/isdn/i460_mux.c R src/isdn/lapd_core.c A src/isdn/libosmoisdn.map M tests/Makefile.am M tests/i460_mux/i460_mux_test.c 34 files changed, 2,206 insertions(+), 311 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/76/30376/5 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30376 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib1a6c762322fd5047be3188b1df22408ef06aa50 Gerrit-Change-Number: 30376 Gerrit-PatchSet: 5 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

2 years, 5 months

1
0
0 0

Change in libosmocore[master]: isdn: Add V.110 encoder/decoder

by Jenkins Builder

Attention is currently required from: laforge. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30762 ) Change subject: isdn: Add V.110 encoder/decoder ...................................................................... Patch Set 2: (3 comments) File src/isdn/v110.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2856): https://gerrit.osmocom.org/c/libosmocore/+/30762/comment/84541867_d4cc8735 PS2, Line 1: /* V.110 frames according to ITU-T V.110 trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2856): https://gerrit.osmocom.org/c/libosmocore/+/30762/comment/0ae92df2_5c2d66d2 PS2, Line 82: ra_bits[2*8 +7] = fr->x_bits[0]; need consistent spacing around '+' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2856): https://gerrit.osmocom.org/c/libosmocore/+/30762/comment/51aee926_f58a287c PS2, Line 83: ra_bits[7*8 +7] = fr->x_bits[1]; need consistent spacing around '+' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30762 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I1b5fd3847d3bfb0a0f763e0574893962ec699680 Gerrit-Change-Number: 30762 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 18 Jan 2023 19:59:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in libosmocore[master]: isdndlc: Fix documentation

by Jenkins Builder

Attention is currently required from: laforge. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30761 ) Change subject: isdndlc: Fix documentation ...................................................................... Patch Set 2: (7 comments) File src/core/isdnhdlc.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2855): https://gerrit.osmocom.org/c/libosmocore/+/30761/comment/b3ca4b20_850d00e9 PS2, Line 100: excluding the CRC. please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2855): https://gerrit.osmocom.org/c/libosmocore/+/30761/comment/60f55d8f_4cf01765 PS2, Line 104: returns -OSMO_HDLC_FRAMING_ERROR. please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2855): https://gerrit.osmocom.org/c/libosmocore/+/30761/comment/3530f739_e48e10bf PS2, Line 104: returns -OSMO_HDLC_FRAMING_ERROR. Avoid multiple line dereference - prefer 'CRC.returns' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2855): https://gerrit.osmocom.org/c/libosmocore/+/30761/comment/d066a567_e5b8bbbf PS2, Line 104: returns -OSMO_HDLC_FRAMING_ERROR. need consistent spacing around '-' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2855): https://gerrit.osmocom.org/c/libosmocore/+/30761/comment/3728caef_7ea15c1b PS2, Line 105: If a CRC error is found the function returns -OSMO_HDLC_CRC_ERROR. please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2855): https://gerrit.osmocom.org/c/libosmocore/+/30761/comment/c5cbe466_d6532933 PS2, Line 105: If a CRC error is found the function returns -OSMO_HDLC_CRC_ERROR. Avoid multiple line dereference - prefer 'OSMO_HDLC_FRAMING_ERROR.If' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2855): https://gerrit.osmocom.org/c/libosmocore/+/30761/comment/a8633806_9b30c9d7 PS2, Line 105: If a CRC error is found the function returns -OSMO_HDLC_CRC_ERROR. need consistent spacing around '-' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30761 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib5def2ae3c79f408f2ee0bb4c20fba1437d30c64 Gerrit-Change-Number: 30761 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 18 Jan 2023 19:59:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in libosmocore[master]: isdndlc: Fix documentation

by laforge

Attention is currently required from: laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/30761 to look at the new patch set (#2). Change subject: isdndlc: Fix documentation ...................................................................... isdndlc: Fix documentation The documentation was copied 1:1 from the Linux kernel, where it already was wrong and apparently described an earlier implementation. Change-Id: Ib5def2ae3c79f408f2ee0bb4c20fba1437d30c64 --- M src/core/isdnhdlc.c 1 file changed, 3 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/61/30761/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30761 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib5def2ae3c79f408f2ee0bb4c20fba1437d30c64 Gerrit-Change-Number: 30761 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

2 years, 5 months

1
0
0 0

Change in libosmocore[master]: create libosmoisdn sub-library

by laforge

Attention is currently required from: laforge. Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/30376 to look at the new patch set (#4). Change subject: create libosmoisdn sub-library ...................................................................... create libosmoisdn sub-library There are some parts of libosmogsm which are not really GSM specific, but rather ISDN bits that were inherited by GSM. This includes the I.460 multiplex as well as the core LAPD protocol. Let's move those bits to its own libosmoisdn library, before we add more ISDN specific bits to the wrong place. Backwards-compatibility is created by making libosmogsm depend on libosmoisdn, and by providing wrapper include files for source compatibility. Change-Id: Ib1a6c762322fd5047be3188b1df22408ef06aa50 --- M .gitignore M Doxyfile.codec.in M Doxyfile.coding.in M Doxyfile.core.in M Doxyfile.ctrl.in M Doxyfile.gb.in M Doxyfile.gsm.in A Doxyfile.isdn.in M Doxyfile.vty.in M Makefile.am M configure.ac M contrib/libosmocore.spec.in M debian/control M debian/copyright M debian/libosmocore.dirs A debian/libosmoisdn-doc.doc-base A debian/libosmoisdn-doc.install A debian/libosmoisdn0.install M debian/rules M include/Makefile.am M include/osmocom/gsm/i460_mux.h M include/osmocom/gsm/lapd_core.h A include/osmocom/isdn/i460_mux.h A include/osmocom/isdn/lapd_core.h M libosmogsm.pc.in A libosmoisdn.pc.in M src/Makefile.am M src/gsm/Makefile.am A src/isdn/Makefile.am R src/isdn/i460_mux.c R src/isdn/lapd_core.c A src/isdn/libosmoisdn.map M tests/Makefile.am M tests/i460_mux/i460_mux_test.c 34 files changed, 2,206 insertions(+), 311 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/76/30376/4 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30376 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib1a6c762322fd5047be3188b1df22408ef06aa50 Gerrit-Change-Number: 30376 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

2 years, 5 months

1
0
0 0

Change in libosmocore[master]: Fix all references to config.h

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31018 ) Change subject: Fix all references to config.h ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31018 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ie9ea38bb009bc715b01cde4d66d181f7bec2e7bd Gerrit-Change-Number: 31018 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 18 Jan 2023 19:24:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in libosmocore[master]: Makefile.am: Remove unexsiting all_includes variable

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31017 ) Change subject: Makefile.am: Remove unexsiting all_includes variable ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31017 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I9bc7de6f85558e55265c6cc965bc7fe97a6736ee Gerrit-Change-Number: 31017 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 18 Jan 2023 19:23:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in libosmocore[master]: Split include/Makefile.am content into subdirs

by fixeria

Attention is currently required from: laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31015 ) Change subject: Split include/Makefile.am content into subdirs ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31015 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I785891c2f89114bf8303c799094b637d3d25ac71 Gerrit-Change-Number: 31015 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 18 Jan 2023 19:20:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in libosmocore[master]: Makefile.am: Remove unexsiting all_includes variable

by pespin

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31017 ) Change subject: Makefile.am: Remove unexsiting all_includes variable ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Note: this all_includes variable is also present in some other projects. We may want to remove it from there too. $ ag all_include -l | wc -l 180 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31017 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I9bc7de6f85558e55265c6cc965bc7fe97a6736ee Gerrit-Change-Number: 31017 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Wed, 18 Jan 2023 18:07:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

2025

2024

2023

2022

gerrit-log January 2023