January 2023 - gerrit-log - lists.osmocom.org

Change in libosmocore[master]: Makefile.am: Remove unexsiting all_includes variable

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31017 ) Change subject: Makefile.am: Remove unexsiting all_includes variable ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31017 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I9bc7de6f85558e55265c6cc965bc7fe97a6736ee Gerrit-Change-Number: 31017 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 19 Jan 2023 11:35:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in libosmocore[master]: Split include/Makefile.am content into subdirs

by osmith

Attention is currently required from: laforge, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31015 ) Change subject: Split include/Makefile.am content into subdirs ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31015 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I785891c2f89114bf8303c799094b637d3d25ac71 Gerrit-Change-Number: 31015 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 19 Jan 2023 11:34:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmo-ci[master]: lint: enable BRACES_NOT_NECESSARY check

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/31020 ) Change subject: lint: enable BRACES_NOT_NECESSARY check ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: I thought this was already enabled! -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/31020 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I481d1b24a909173520a544ffd567bb8357729f2a Gerrit-Change-Number: 31020 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 19 Jan 2023 11:18:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmo-hlr[master]: Add vty `reject-cause` to set the reject cause

by pespin

Attention is currently required from: neels, keith, daniel, lynxis lazus. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16808 ) Change subject: Add vty `reject-cause` to set the reject cause ...................................................................... Patch Set 11: (1 comment) Patchset: PS11: I'm not against merging this patch, but I'm raising the topic since we seem to merging a feature which is actually meant only to "do some tests to find out real behavior", so it's not something users will need in the end. If you have a specific case in dGSM where you'd like to change the returned cause based on case "1" or "2" you described, that should be done in the code automatically without need for the user to configure it. I'd like to hear motivations from @lynxis too regarding this patch. If others are fine with merging this then feel free to merge. -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/16808 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: Icea39020c23fbbea9e92847df76af8986fdbf48a Gerrit-Change-Number: 16808 Gerrit-PatchSet: 11 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: keith <keith(a)rhizomatica.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: keith <keith(a)rhizomatica.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 19 Jan 2023 11:15:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in pysim[master]: cards: also program EF.AD under ADF.USIM

by dexter

Attention is currently required from: laforge. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/31004 ) Change subject: cards: also program EF.AD under ADF.USIM ...................................................................... Patch Set 2: (1 comment) File pySim/cards.py: https://gerrit.osmocom.org/c/pysim/+/31004/comment/8994a15c_cd3fe0b4 PS1, Line 1587: > pleaes don't mix tab and space indentation. […] Python really is a pain in that regard, do you use a formatter or can you recommend one? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/31004 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ic9dd4acc8d9a72acbb7376ddf3e2128125d4a8f5 Gerrit-Change-Number: 31004 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 19 Jan 2023 09:34:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in pysim[master]: cards: also program EF.AD under ADF.USIM

by dexter

Attention is currently required from: laforge. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/31004 to look at the new patch set (#2). Change subject: cards: also program EF.AD under ADF.USIM ...................................................................... cards: also program EF.AD under ADF.USIM DF.GSM and ADF.USIM have an EF.AD with nearly the same contents. Usually there is one file physically present and the other is just a link. Apparantly this is not always the case for sysmo-ismi-sja2 cards, so lets program EF.AD in both locations. Change-Id: Ic9dd4acc8d9a72acbb7376ddf3e2128125d4a8f5 Related: OS#5830 --- M pySim/cards.py 1 file changed, 15 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/04/31004/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/31004 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ic9dd4acc8d9a72acbb7376ddf3e2128125d4a8f5 Gerrit-Change-Number: 31004 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

2 years, 5 months

1
0
0 0

Change in osmo-ci[master]: lint: enable BRACES_NOT_NECESSARY check

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/31020 ) Change subject: lint: enable BRACES_NOT_NECESSARY check ...................................................................... lint: enable BRACES_NOT_NECESSARY check As seen in code review here: https://gerrit.osmocom.org/c/libosmocore/+/30934 ... we do care about not using braces for single statement blocks. Let the linter comment on it. src/osmo_io.c:143: WARNING:BRACES_NOT_NECESSARY: braces {} are not necessary for single statement blocks src/osmo_io.c:271: WARNING:BRACES_NOT_NECESSARY: braces {} are not necessary for single statement blocks src/osmo_io.c:306: WARNING:BRACES_NOT_NECESSARY: braces {} are not necessary for single statement blocks src/osmo_io_poll.c:63: WARNING:BRACES_NOT_NECESSARY: braces {} are not necessary for single statement blocks src/osmo_io_poll.c:117: WARNING:BRACES_NOT_NECESSARY: braces {} are not necessary for single statement blocks Change-Id: I481d1b24a909173520a544ffd567bb8357729f2a --- M lint/checkpatch/checkpatch_osmo.sh 1 file changed, 0 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/20/31020/1 diff --git a/lint/checkpatch/checkpatch_osmo.sh b/lint/checkpatch/checkpatch_osmo.sh index bc45f85..86d2fe1 100755 --- a/lint/checkpatch/checkpatch_osmo.sh +++ b/lint/checkpatch/checkpatch_osmo.sh @@ -53,7 +53,6 @@ # * ASSIGN_IN_IF: not followed (e.g. 'if ((u8 = gsup_msg->cause))') # * AVOID_EXTERNS: we do use externs # * BLOCK_COMMENT_STYLE: we don't use a trailing */ on a separate line -# * BRACES_NOT_NECESSARY: not followed # * COMPLEX_MACRO: we don't use parentheses when building macros of strings across multiple lines # * CONSTANT_COMPARISON: not followed: "Comparisons should place the constant on the right side" # * DEEP_INDENTATION: warns about many leading tabs, not useful if changing existing code without refactoring @@ -91,7 +90,6 @@ --ignore ASSIGN_IN_IF \ --ignore AVOID_EXTERNS \ --ignore BLOCK_COMMENT_STYLE \ - --ignore BRACES_NOT_NECESSARY \ --ignore COMPLEX_MACRO \ --ignore CONSTANT_COMPARISON \ --ignore DEEP_INDENTATION \ -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/31020 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I481d1b24a909173520a544ffd567bb8357729f2a Gerrit-Change-Number: 31020 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 5 months

1
0
0 0

Change in libosmocore[master]: isdndlc: Fix documentation

by osmith

Attention is currently required from: laforge. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30761 ) Change subject: isdndlc: Fix documentation ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: regarding the checkpatch comments: it won't interpret the comment block as code when it follows the multi-line comment style where every line begins with a star *. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30761 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib5def2ae3c79f408f2ee0bb4c20fba1437d30c64 Gerrit-Change-Number: 30761 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 19 Jan 2023 08:06:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmo-hlr[master]: Add vty `reject-cause` to set the reject cause

by keith

Attention is currently required from: pespin, lynxis lazus. keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16808 ) Change subject: Add vty `reject-cause` to set the reject cause ...................................................................... Patch Set 11: (1 comment) Patchset: PS11: > Hi @keith, maybe what I'm missing here is the rationale on WHY is this needed. […] Hi @pespin. I my case, I was interested to see how the phones were actually behaving with the different LU Reject reasons. It seems like they don't really behave as in the spec. (TS24.008 4.4.4.7) I got bored of recompiling osmo-msc with hard coded reject causes and then I noticed this patch in CR from @lynxis. Given the patch originally almost made it through CR, and it seems like it was something that lynxis wanted at a c3 event for whatever reason, I decided to fix it up and submit a patchset. It might be interesting to know if lynxis remembers or still has any interest. From my point of view, there is one use case where I might want to configure the LU reject cause at runtime, which has to do with dGSM. If I reject an MS because no HLR responds to a distributed request for a home HLR; this may have happened because, 1) there is no home HLR or 2) the home HLR was offline/unreachable at the moment of the LUR. In the first case, I guess I would like the phone to go away and never LUR again, (at least until T3245 expires), in the second case, I might like it to try again rather soon. Now, as I said, accord the the spec i mentioned above, if I were to send a cause @2 "IMSI unknown in HLR" - which is the current default, I would expect: "The mobile station shall set the update status to ROAMING NOT ALLOWED (and store it in the SIM/USIM and delete any TMSI, stored LAI.... [etc] consider the SIM/USIM as invalid for non-GPRS services until switch-off or the SIM/USIM is removed or the timer T3245 expires as described in subclause 4.1.1.6." Howver, All the ME I tried DON'T do this, but rather they try again every 20 seconds up to 8 times and then continuously on what seems like the T3212 timer. However, with cause #13 the ME seems to NOT retry in the cell again, at least not immediately. Anyway, seems like one might like to do some trial and error with one's own situation in this and therefore being able to configure this via the vty might be "handy" (sorry for unintended bad pun, German speakers) We have some sites that don't have many phones trying to connect, we also have some that have 1000s, so on the busy site, I might prefer to set a cuase then makes them back off, at the expense of loosing the odd "orphan" "roaming" user (until they power cycles/toggle airplane mode) - whereas on the not busy site, I might set a reject cause like CONGESTION that allows that phone to keep trying in the hope their home HLR came back online. @pespin, if you'ld like any of the above in the commit msg for this patchset, please feel free to copy and paste, I also have a series of commits related to dGSM in the works, including documentation update, so I can include some of the above text there also. -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/16808 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: Icea39020c23fbbea9e92847df76af8986fdbf48a Gerrit-Change-Number: 16808 Gerrit-PatchSet: 11 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: keith <keith(a)rhizomatica.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 18 Jan 2023 20:48:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in libosmocore[master]: isdndlc: Fix documentation

by Jenkins Builder

Attention is currently required from: laforge. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30761 ) Change subject: isdndlc: Fix documentation ...................................................................... Patch Set 3: (7 comments) File src/core/isdnhdlc.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2859): https://gerrit.osmocom.org/c/libosmocore/+/30761/comment/152d7397_58920891 PS3, Line 100: excluding the CRC. please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2859): https://gerrit.osmocom.org/c/libosmocore/+/30761/comment/4b9d8d9c_696ad1b3 PS3, Line 104: returns -OSMO_HDLC_FRAMING_ERROR. please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2859): https://gerrit.osmocom.org/c/libosmocore/+/30761/comment/16757f4d_9eb8ee83 PS3, Line 104: returns -OSMO_HDLC_FRAMING_ERROR. Avoid multiple line dereference - prefer 'CRC.returns' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2859): https://gerrit.osmocom.org/c/libosmocore/+/30761/comment/21f8b94c_a50a2d78 PS3, Line 104: returns -OSMO_HDLC_FRAMING_ERROR. need consistent spacing around '-' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2859): https://gerrit.osmocom.org/c/libosmocore/+/30761/comment/92556437_724d57d0 PS3, Line 105: If a CRC error is found the function returns -OSMO_HDLC_CRC_ERROR. please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2859): https://gerrit.osmocom.org/c/libosmocore/+/30761/comment/511b8970_805be2dd PS3, Line 105: If a CRC error is found the function returns -OSMO_HDLC_CRC_ERROR. Avoid multiple line dereference - prefer 'OSMO_HDLC_FRAMING_ERROR.If' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2859): https://gerrit.osmocom.org/c/libosmocore/+/30761/comment/ef148630_f1600a16 PS3, Line 105: If a CRC error is found the function returns -OSMO_HDLC_CRC_ERROR. need consistent spacing around '-' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30761 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib5def2ae3c79f408f2ee0bb4c20fba1437d30c64 Gerrit-Change-Number: 30761 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 18 Jan 2023 20:19:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

2025

2024

2023

2022

gerrit-log January 2023