January 2023 - gerrit-log - lists.osmocom.org

Change in osmo-mgw[master]: mgcp_client: add new clearmode codec

by osmith

Attention is currently required from: osmith. Hello Jenkins Builder, laforge, pespin, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-mgw/+/31059 to look at the new patch set (#3). Change subject: mgcp_client: add new clearmode codec ...................................................................... mgcp_client: add new clearmode codec Set 120 as payload type, as specified in 3GPP TS 48.103 table 5.4.2.2.1. Related: OS#4395 Related: https://www.rfc-editor.org/rfc/rfc4040#section-5 Change-Id: I55f9fe241a405935dbedc3947b0a4f4986acd5cb --- M include/osmocom/mgcp_client/mgcp_client.h M src/libosmo-mgcp-client/mgcp_client.c 2 files changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/59/31059/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/31059 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I55f9fe241a405935dbedc3947b0a4f4986acd5cb Gerrit-Change-Number: 31059 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 5 months

1
0
0 0

Change in pysim[master]: ts_51_011: Support EF.LND

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/31068 ) Change subject: ts_51_011: Support EF.LND ...................................................................... ts_51_011: Support EF.LND This file is a optional file specified by TS 51.011, storing the last numbers dialled. As the EIRENE FFFIS for GSM-R SIM refers to this, we must implement it to have full GSM-R support in pySim. Change-Id: I3b7d6c7e7504b7cc8a1b62f13e8c0ae83a91d0f0 Related: OS#5784 --- M pySim/ts_51_011.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/68/31068/1 diff --git a/pySim/ts_51_011.py b/pySim/ts_51_011.py index ff213f3..b15a7fc 100644 --- a/pySim/ts_51_011.py +++ b/pySim/ts_51_011.py @@ -507,7 +507,7 @@ EF_MSISDN(), EF_SMSP(), EF_SMSS(), - # LND + EF_ADN('6f44', None, 'EF.LND', 'Last Number Dialled', ext=1), EF_ADN('6f49', None, 'EF.SDN', 'Service Dialling Numbers', ext=3), EF_EXT('6f4a', None, 'EF.EXT1', 'Extension1 (ADN/SSC)'), EF_EXT('6f4b', None, 'EF.EXT2', 'Extension2 (FDN/SSC)'), -- To view, visit https://gerrit.osmocom.org/c/pysim/+/31068 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I3b7d6c7e7504b7cc8a1b62f13e8c0ae83a91d0f0 Gerrit-Change-Number: 31068 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

2 years, 5 months

1
0
0 0

Change in pysim[master]: ts_51_011, ts_31_102: point to proper EF_EXTn file

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/31067 ) Change subject: ts_51_011, ts_31_102: point to proper EF_EXTn file ...................................................................... ts_51_011, ts_31_102: point to proper EF_EXTn file We're using a shared class to implement the identical file encoding for EF.{ADN,SDN,MBDN,BDN,FDN,CFIS}. However, they all point to different extension files. Previosly for EF.SDN: "ext1_record_id": 255 Now for EF.SDN: "ext3_record_id": 255 Change-Id: I5301d41225266d35c05e41588811502e5595520d Related: OS#5784 --- M pySim/ts_31_102.py M pySim/ts_51_011.py 2 files changed, 10 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/67/31067/1 diff --git a/pySim/ts_31_102.py b/pySim/ts_31_102.py index 65a2afe..4f7e24d 100644 --- a/pySim/ts_31_102.py +++ b/pySim/ts_31_102.py @@ -1152,12 +1152,12 @@ EF_ECC(), EF_CBMIR(service=16), EF_PSLOCI(), - EF_ADN('6f3b', None, 'EF.FDN', 'Fixed Dialling Numbers', service=[2, 89]), + EF_ADN('6f3b', None, 'EF.FDN', 'Fixed Dialling Numbers', service=[2, 89], ext=2), EF_SMS('6f3c', None, service=10), EF_MSISDN(service=21), EF_SMSP(service=12), EF_SMSS(service=10), - EF_ADN('6f49', None, 'EF.SDN', 'Service Dialling Numbers', service=[4, 89]), + EF_ADN('6f49', None, 'EF.SDN', 'Service Dialling Numbers', service=[4, 89], ext=3), EF_EXT('6f4b', None, 'EF.EXT2', 'Extension2 (FDN)', service=3), EF_EXT('6f4c', None, 'EF.EXT3', 'Extension2 (SDN)', service=5), EF_SMSR(service=11), @@ -1170,7 +1170,7 @@ EF_eMLPP(service=24), EF_AAeM(service=25), # EF_Hiddenkey - EF_ADN('6f4d', None, 'EF.BDN', 'Barred Dialling Numbers', service=6), + EF_ADN('6f4d', None, 'EF.BDN', 'Barred Dialling Numbers', service=6, ext=4), EF_EXT('6f55', None, 'EF.EXT4', 'Extension4 (BDN/SSC)', service=7), EF_CMI(service=6), EF_EST(service=[2, 6, 34, 35]), @@ -1186,11 +1186,11 @@ TransparentEF('6fc4', None, 'EF.NETPAR', 'Network Parameters'), EF_PNN('6fc5', 0x19, service=45), EF_OPL(service=46), - EF_ADN('6fc7', None, 'EF.MBDN', 'Mailbox Dialling Numbers', service=47), + EF_ADN('6fc7', None, 'EF.MBDN', 'Mailbox Dialling Numbers', service=47, ext=6), EF_EXT('6fc8', None, 'EF.EXT6', 'Extension6 (MBDN)'), EF_MBI(service=47), EF_MWIS(service=48), - EF_ADN('6fcb', None, 'EF.CFIS', 'Call Forwarding Indication Status', service=49), + EF_ADN('6fcb', None, 'EF.CFIS', 'Call Forwarding Indication Status', service=49, ext=7), EF_EXT('6fcc', None, 'EF.EXT7', 'Extension7 (CFIS)'), TransparentEF('6fcd', None, 'EF.SPDI', 'Service Provider Display Information', service=51), EF_MMSN(service=52), diff --git a/pySim/ts_51_011.py b/pySim/ts_51_011.py index e61c9a8..ff213f3 100644 --- a/pySim/ts_51_011.py +++ b/pySim/ts_51_011.py @@ -358,14 +358,15 @@ # TS 51.011 Section 10.5.1 class EF_ADN(LinFixedEF): - def __init__(self, fid='6f3a', sfid=None, name='EF.ADN', desc='Abbreviated Dialing Numbers', **kwargs): + def __init__(self, fid='6f3a', sfid=None, name='EF.ADN', desc='Abbreviated Dialing Numbers', ext=1, **kwargs): super().__init__(fid, sfid=sfid, name=name, desc=desc, rec_len=(14, 30), **kwargs) + ext_name = 'ext%u_record_id' % ext self._construct = Struct('alpha_id'/COptional(GsmStringAdapter(Rpad(Bytes(this._.total_len-14)), codec='ascii')), 'len_of_bcd'/Int8ub, 'ton_npi'/TonNpi, 'dialing_nr'/ExtendedBcdAdapter(BcdAdapter(Rpad(Bytes(10)))), 'cap_conf_id'/Int8ub, - 'ext1_record_id'/Int8ub) + ext_name/Int8ub) # TS 51.011 Section 10.5.5 class EF_SMS(LinFixedEF): @@ -497,7 +498,7 @@ super().__init__(fid=fid, name=name, desc=desc, **kwargs) files = [ EF_ADN(), - EF_ADN(fid='6f3b', name='EF.FDN', desc='Fixed dialling numbers'), + EF_ADN(fid='6f3b', name='EF.FDN', desc='Fixed dialling numbers', ext=2), EF_SMS(), LinFixedEF(fid='6f3d', name='EF.CCP', desc='Capability Configuration Parameters', rec_len=(14, 14)), @@ -507,7 +508,7 @@ EF_SMSP(), EF_SMSS(), # LND - EF_ADN('6f49', None, 'EF.SDN', 'Service Dialling Numbers'), + EF_ADN('6f49', None, 'EF.SDN', 'Service Dialling Numbers', ext=3), EF_EXT('6f4a', None, 'EF.EXT1', 'Extension1 (ADN/SSC)'), EF_EXT('6f4b', None, 'EF.EXT2', 'Extension2 (FDN/SSC)'), EF_EXT('6f4c', None, 'EF.EXT3', 'Extension3 (SDN)'), -- To view, visit https://gerrit.osmocom.org/c/pysim/+/31067 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I5301d41225266d35c05e41588811502e5595520d Gerrit-Change-Number: 31067 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

2 years, 5 months

1
0
0 0

Change in pysim[master]: ts_51_011: Support EF.SDN

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/31065 ) Change subject: ts_51_011: Support EF.SDN ...................................................................... ts_51_011: Support EF.SDN DF.TELECOM/EF.SDN (Service Dialling Numbers) is specified in section 10.5.9 of TS 51.011 and required by EIRENE for GSM-R. Let's use the pre-existing EF.ADN decoder to decode this file. Change-Id: If91332b10138096d465a9dccf90744de2c14b2be Related: OS#5784 --- M pySim/ts_51_011.py 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/65/31065/1 diff --git a/pySim/ts_51_011.py b/pySim/ts_51_011.py index c4dbf77..34fd538 100644 --- a/pySim/ts_51_011.py +++ b/pySim/ts_51_011.py @@ -490,7 +490,8 @@ EF_MSISDN(), EF_SMSP(), EF_SMSS(), - # LND, SDN + # LND + EF_ADN('6f49', None, 'EF.SDN', 'Service Dialling Numbers'), EF_EXT('6f4a', None, 'EF.EXT1', 'Extension1 (ADN/SSC)'), EF_EXT('6f4b', None, 'EF.EXT2', 'Extension2 (FDN/SSC)'), EF_EXT('6f4c', None, 'EF.EXT3', 'Extension3 (SDN)'), -- To view, visit https://gerrit.osmocom.org/c/pysim/+/31065 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: If91332b10138096d465a9dccf90744de2c14b2be Gerrit-Change-Number: 31065 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

2 years, 5 months

1
0
0 0

Change in pysim[master]: ts_51_011: Implement Extended BCD Coding

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/31066 ) Change subject: ts_51_011: Implement Extended BCD Coding ...................................................................... ts_51_011: Implement Extended BCD Coding TS 51.011 specifies an "Extended BCD Coding" in Table 12 of Section 10.5.1. It allows to express the '*' and '#' symbols used in GSM SS and/or USSD codes. This improves decoding from "dialing_nr": "a753b1200f", to "dialing_nr": "*753#1200f", Change-Id: Ifcec13e9b296dba7bec34b7872192b7ce185c23c Related: OS#5784 --- M pySim/ts_51_011.py 1 file changed, 17 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/66/31066/1 diff --git a/pySim/ts_51_011.py b/pySim/ts_51_011.py index 34fd538..e61c9a8 100644 --- a/pySim/ts_51_011.py +++ b/pySim/ts_51_011.py @@ -340,6 +340,22 @@ # DF.TELECOM ###################################################################### + +# TS 51.011 Section 10.5.1 / Table 12 +class ExtendedBcdAdapter(Adapter): + """Replace some hex-characters with other ASCII characters""" + # we only translate a=* / b=# as they habe a clear representation + # in terms of USSD / SS service codes + def _decode(self, obj, context, path): + if not isinstance(obj, str): + return obj + return obj.lower().replace("a","*").replace("b","#") + + def _encode(self, obj, context, path): + if not isinstance(obj, str): + return obj + return obj.replace("*","a").replace("#","b") + # TS 51.011 Section 10.5.1 class EF_ADN(LinFixedEF): def __init__(self, fid='6f3a', sfid=None, name='EF.ADN', desc='Abbreviated Dialing Numbers', **kwargs): @@ -347,7 +363,7 @@ self._construct = Struct('alpha_id'/COptional(GsmStringAdapter(Rpad(Bytes(this._.total_len-14)), codec='ascii')), 'len_of_bcd'/Int8ub, 'ton_npi'/TonNpi, - 'dialing_nr'/BcdAdapter(Rpad(Bytes(10))), + 'dialing_nr'/ExtendedBcdAdapter(BcdAdapter(Rpad(Bytes(10)))), 'cap_conf_id'/Int8ub, 'ext1_record_id'/Int8ub) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/31066 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ifcec13e9b296dba7bec34b7872192b7ce185c23c Gerrit-Change-Number: 31066 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

2 years, 5 months

1
0
0 0

Change in pysim[master]: ts_51_011: Fix bit-order in EF.VGCSS and EF.VBSS

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/31064 ) Change subject: ts_51_011: Fix bit-order in EF.VGCSS and EF.VBSS ...................................................................... ts_51_011: Fix bit-order in EF.VGCSS and EF.VBSS Those files contain a bit-mask of active group IDs stored at the respective positions in EV.VGCS and EF.VBS. However, the bit-order of each byte is reversed. Change-Id: I77674c23823aae71c9504b1a85cd75266edadc6f Related: OS#5784 --- M pySim/ts_51_011.py 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/64/31064/1 diff --git a/pySim/ts_51_011.py b/pySim/ts_51_011.py index d16ea72..c4dbf77 100644 --- a/pySim/ts_51_011.py +++ b/pySim/ts_51_011.py @@ -714,8 +714,8 @@ def __init__(self, fid='6fb2', sfid=None, name='EF.VGCSS', size=(7, 7), desc='Voice Group Call Service Status', **kwargs): super().__init__(fid, sfid=sfid, name=name, desc=desc, size=size, **kwargs) - self._construct = BitStruct( - 'flags'/Bit[50], Padding(6, pattern=b'\xff')) + self._construct = BitsSwapped(BitStruct( + 'flags'/Bit[50], Padding(6, pattern=b'\xff'))) # TS 51.011 Section 10.3.24 class EF_eMLPP(TransparentEF): -- To view, visit https://gerrit.osmocom.org/c/pysim/+/31064 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I77674c23823aae71c9504b1a85cd75266edadc6f Gerrit-Change-Number: 31064 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

2 years, 5 months

1
0
0 0

Change in pysim[master]: gsm_r: Fix typo (it's EF.FN, not EF.EN)

by fixeria

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/31050 ) Change subject: gsm_r: Fix typo (it's EF.FN, not EF.EN) ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/31050 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I2c97a02973d2a1eda2cea5412391144726bb0525 Gerrit-Change-Number: 31050 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 24 Jan 2023 17:00:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmo-mgw[master]: mgcp_client: add new clearmode codec

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/31059 ) Change subject: mgcp_client: add new clearmode codec ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File include/osmocom/mgcp_client/mgcp_client.h: https://gerrit.osmocom.org/c/osmo-mgw/+/31059/comment/b5a0f16b_3f95bc86 PS2, Line 53: CODEC_CLEARMODE = 120, You could add a spec reference here: /* 3GPP TS 48.103 table 5.4.2.2.1 */ -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/31059 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I55f9fe241a405935dbedc3947b0a4f4986acd5cb Gerrit-Change-Number: 31059 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 24 Jan 2023 16:59:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: mgw: new test TC_two_crcx_mdcx_and_rtp_clearmode

by fixeria

Attention is currently required from: osmith, neels, keith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31061 ) Change subject: mgw: new test TC_two_crcx_mdcx_and_rtp_clearmode ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31061 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I89c5dfdcd728ab3b50e77c5062f07e1b802b1f01 Gerrit-Change-Number: 31061 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: keith <keith(a)rhizomatica.org> Gerrit-Comment-Date: Tue, 24 Jan 2023 16:57:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: mgw: f_tc_two_crcx_mdcx_and_rtp: add arguments

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31060 ) Change subject: mgw: f_tc_two_crcx_mdcx_and_rtp: add arguments ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31060 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I94d1628470db49c53eda64c29bc0716bcb339798 Gerrit-Change-Number: 31060 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 24 Jan 2023 16:57:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

2025

2024

2023

2022

gerrit-log January 2023