January 2023 - gerrit-log - lists.osmocom.org

Change in libosmocore[master]: ASCI: add VBS/VGCS support to BTS features list

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31046 ) Change subject: ASCI: add VBS/VGCS support to BTS features list ...................................................................... ASCI: add VBS/VGCS support to BTS features list Related: OS#5783 Change-Id: I583a170070c192c6c47fae41ce923a7439561b4f --- M include/osmocom/gsm/bts_features.h M src/gsm/bts_features.c 2 files changed, 4 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/include/osmocom/gsm/bts_features.h b/include/osmocom/gsm/bts_features.h index ae372d3..d6eb246 100644 --- a/include/osmocom/gsm/bts_features.h +++ b/include/osmocom/gsm/bts_features.h @@ -34,6 +34,8 @@ BTS_FEAT_DYN_TS_SDCCH8, /* Osmo Dynamic TS supports configured as SDCCH8 */ BTS_FEAT_ACCH_TEMP_OVP, /* FACCH/SACCH Temporary overpower */ BTS_FEAT_OSMUX, /* Osmux (Osmocom RTP muxing) support */ + BTS_FEAT_VBS, /* Voice Broadcast Service support, 3GPP TS 43.069 */ + BTS_FEAT_VGCS, /* Voice Group Call Service support, 3GPP TS 44.068 */ _NUM_BTS_FEAT }; diff --git a/src/gsm/bts_features.c b/src/gsm/bts_features.c index 6811038..1cc3c26 100644 --- a/src/gsm/bts_features.c +++ b/src/gsm/bts_features.c @@ -44,6 +44,8 @@ { BTS_FEAT_DYN_TS_SDCCH8, "Dynamic Timeslot configuration as SDCCH8" }, { BTS_FEAT_ACCH_TEMP_OVP, "FACCH/SACCH Temporary overpower" }, { BTS_FEAT_OSMUX, "Osmux (Osmocom RTP multiplexing)" }, + { BTS_FEAT_VBS, "Voice Broadcast Service" }, + { BTS_FEAT_VGCS, "Voice Group Call Service" }, { 0, NULL } }; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31046 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I583a170070c192c6c47fae41ce923a7439561b4f Gerrit-Change-Number: 31046 Gerrit-PatchSet: 3 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 5 months

1
0
0 0

Change in libosmocore[master]: SI: add RR short PD message types

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31048 ) Change subject: SI: add RR short PD message types ...................................................................... SI: add RR short PD message types Related: OS#5783 Change-Id: Ifbd0aabe826298fa4715eb4eb2ff8363e765933d --- M include/osmocom/gsm/protocol/gsm_04_08.h M src/gsm/gsm48.c 2 files changed, 38 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve arehbein: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/include/osmocom/gsm/protocol/gsm_04_08.h b/include/osmocom/gsm/protocol/gsm_04_08.h index ea77e76..ff9eb64 100644 --- a/include/osmocom/gsm/protocol/gsm_04_08.h +++ b/include/osmocom/gsm/protocol/gsm_04_08.h @@ -1540,6 +1540,21 @@ #define GSM48_MT_RR_APP_INFO 0x38 +/* 3GPP TS 44.018 Table 10.4.2 */ +#define GSM48_MT_RR_SH_SI10 0x0 +#define GSM48_MT_RR_SH_FACCH 0x1 +#define GSM48_MT_RR_SH_UL_FREE 0x2 +#define GSM48_MT_RR_SH_MEAS_REP 0x4 +#define GSM48_MT_RR_SH_MEAS_INFO 0x5 +#define GSM48_MT_RR_SH_VGCS_RECON 0x6 +#define GSM48_MT_RR_SH_VGCS_RECON2 0x7 +#define GSM48_MT_RR_SH_VGCS_INFO 0x8 +#define GSM48_MT_RR_SH_VGCS_SMS 0x9 +#define GSM48_MT_RR_SH_SI10bis 0xA +#define GSM48_MT_RR_SH_SI10ter 0xB +#define GSM48_MT_RR_SH_VGCS_NEIGH 0xC +#define GSM48_MT_RR_SH_APP_DATA 0xD + /* Table 10.2/3GPP TS 04.08 */ #define GSM48_MT_MM_IMSI_DETACH_IND 0x01 #define GSM48_MT_MM_LOC_UPD_ACCEPT 0x02 diff --git a/src/gsm/gsm48.c b/src/gsm/gsm48.c index c5fe550..6f5c3a3 100644 --- a/src/gsm/gsm48.c +++ b/src/gsm/gsm48.c @@ -419,6 +419,29 @@ return get_value_string(rr_msg_names, msgtype); } +/* 3GPP TS 44.018 Table 10.4.2 */ +static const struct value_string rr_msg_type_short_names[] = { + { GSM48_MT_RR_SH_SI10, "System Information Type 10" }, + { GSM48_MT_RR_SH_FACCH, "Notification/FACCH" }, + { GSM48_MT_RR_SH_UL_FREE, "Uplink Free" }, + { GSM48_MT_RR_SH_MEAS_REP, "Enhanced Measurement Report (uplink)" }, + { GSM48_MT_RR_SH_MEAS_INFO, "Measurement Information (downlink)" }, + { GSM48_MT_RR_SH_VGCS_RECON, "VBS/VGCS Reconfigure" }, + { GSM48_MT_RR_SH_VGCS_RECON2, "VBS/VGCS Reconfigure2" }, + { GSM48_MT_RR_SH_VGCS_INFO, "VGCS Additional Information" }, + { GSM48_MT_RR_SH_VGCS_SMS, "VGCS SMS Information" }, + { GSM48_MT_RR_SH_SI10bis, "System Information Type 10bis" }, + { GSM48_MT_RR_SH_SI10ter, "System Information Type 10ter" }, + { GSM48_MT_RR_SH_VGCS_NEIGH, "VGCS Neighbour Cell Information" }, + { GSM48_MT_RR_SH_APP_DATA, "Notify Application Data" }, + { 0, NULL } +}; + +/*! return string representation of RR Message Type using the RR short protocol discriminator */ +const char *gsm48_rr_msg_type_short_name(uint8_t msgtype) +{ + return get_value_string(rr_msg_type_short_names, msgtype); +} const struct value_string gsm48_chan_mode_names[] = { { GSM48_CMODE_SIGN, "SIGNALLING" }, -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31048 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ifbd0aabe826298fa4715eb4eb2ff8363e765933d Gerrit-Change-Number: 31048 Gerrit-PatchSet: 2 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

2 years, 5 months

1
0
0 0

Change in libosmocore[master]: SI: add RR short PD message types

by fixeria

Attention is currently required from: arehbein, msuraev. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31048 ) Change subject: SI: add RR short PD message types ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31048 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ifbd0aabe826298fa4715eb4eb2ff8363e765933d Gerrit-Change-Number: 31048 Gerrit-PatchSet: 1 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Wed, 25 Jan 2023 08:32:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in libosmocore[master]: ASCI: add VBS/VGCS support to BTS features list

by fixeria

Attention is currently required from: msuraev. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31046 ) Change subject: ASCI: add VBS/VGCS support to BTS features list ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31046 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I583a170070c192c6c47fae41ce923a7439561b4f Gerrit-Change-Number: 31046 Gerrit-PatchSet: 2 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Wed, 25 Jan 2023 08:30:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmo-mgw[master]: mgcp_client: add new clearmode codec

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/31059 ) Change subject: mgcp_client: add new clearmode codec ...................................................................... mgcp_client: add new clearmode codec Set 120 as payload type, as specified in 3GPP TS 48.103 table 5.4.2.2.1. Related: OS#4395 Related: https://www.rfc-editor.org/rfc/rfc4040#section-5 Change-Id: I55f9fe241a405935dbedc3947b0a4f4986acd5cb --- M include/osmocom/mgcp_client/mgcp_client.h M src/libosmo-mgcp-client/mgcp_client.c 2 files changed, 2 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, approved diff --git a/include/osmocom/mgcp_client/mgcp_client.h b/include/osmocom/mgcp_client/mgcp_client.h index b40923d..0fb5dee 100644 --- a/include/osmocom/mgcp_client/mgcp_client.h +++ b/include/osmocom/mgcp_client/mgcp_client.h @@ -50,6 +50,7 @@ CODEC_AMR_8000_1 = 112, CODEC_AMRWB_16000_1 = 113, CODEC_IUFP = 96, + CODEC_CLEARMODE = 120, /* 3GPP TS 48.103 table 5.4.2.2.1 */ }; /* Note: when new codec types are added, the corresponding value strings * in mgcp_client.c (codec_table) must be updated as well. Enumerations diff --git a/src/libosmo-mgcp-client/mgcp_client.c b/src/libosmo-mgcp-client/mgcp_client.c index 6f1ab6b..c3ecc9f 100644 --- a/src/libosmo-mgcp-client/mgcp_client.c +++ b/src/libosmo-mgcp-client/mgcp_client.c @@ -60,6 +60,7 @@ { CODEC_AMR_8000_1, "AMR/8000/1" }, { CODEC_AMRWB_16000_1, "AMR-WB/16000/1" }, { CODEC_IUFP, "VND.3GPP.IUFP/16000" }, + { CODEC_CLEARMODE, "CLEARMODE/8000" }, { 0, NULL }, }; -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/31059 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I55f9fe241a405935dbedc3947b0a4f4986acd5cb Gerrit-Change-Number: 31059 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 5 months

1
0
0 0

Change in osmo-mgw[master]: mgcp_client: add new clearmode codec

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/31059 ) Change subject: mgcp_client: add new clearmode codec ...................................................................... Patch Set 3: Code-Review+2 (1 comment) File include/osmocom/mgcp_client/mgcp_client.h: https://gerrit.osmocom.org/c/osmo-mgw/+/31059/comment/e0181d6a_1229b9e3 PS2, Line 53: CODEC_CLEARMODE = 120, > You could add a spec reference here: /* 3GPP TS 48.103 table 5.4.2.2. […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/31059 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I55f9fe241a405935dbedc3947b0a4f4986acd5cb Gerrit-Change-Number: 31059 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 25 Jan 2023 08:19:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: mgw: f_tc_two_crcx_mdcx_and_rtp: add arguments

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31060 ) Change subject: mgw: f_tc_two_crcx_mdcx_and_rtp: add arguments ...................................................................... mgw: f_tc_two_crcx_mdcx_and_rtp: add arguments Add arguments for codec_name and payload_type. Related: OS#4395 Change-Id: I94d1628470db49c53eda64c29bc0716bcb339798 --- M mgw/MGCP_Test.ttcn 1 file changed, 5 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/mgw/MGCP_Test.ttcn b/mgw/MGCP_Test.ttcn index e8e3ae3..1a21974 100644 --- a/mgw/MGCP_Test.ttcn +++ b/mgw/MGCP_Test.ttcn @@ -1990,7 +1990,9 @@ /* create two local RTP emulations and pass data in both directions */ function f_tc_two_crcx_mdcx_and_rtp(charstring local_ip_a, charstring remote_ip_a, - charstring local_ip_b, charstring remote_ip_b) runs on dummy_CT { + charstring local_ip_b, charstring remote_ip_b, + uint7_t payload_type := 3, + charstring codec_name := "GSM/8000/1") runs on dummy_CT { var RtpFlowData flow[2]; var RtpemStats stats[2]; var MgcpResponse resp; @@ -2002,13 +2004,13 @@ f_init(ep); /* Create the first connection in receive only mode */ - flow[0] := valueof(t_RtpFlow(local_ip_a, remote_ip_a, 3, "GSM/8000/1")); + flow[0] := valueof(t_RtpFlow(local_ip_a, remote_ip_a, payload_type, codec_name)); flow[0].em.portnr := 10000; f_flow_create(RTPEM[0], ep, call_id, "recvonly", flow[0], true); /* Create the second connection. This connection will be also * in receive only mode */ - flow[1] := valueof(t_RtpFlow(local_ip_b, remote_ip_b, 3, "GSM/8000/1")); + flow[1] := valueof(t_RtpFlow(local_ip_b, remote_ip_b, payload_type, codec_name)); flow[1].em.portnr := 20000; f_flow_create(RTPEM[1], ep, call_id, "recvonly", flow[1], true); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31060 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I94d1628470db49c53eda64c29bc0716bcb339798 Gerrit-Change-Number: 31060 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 5 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: mgw: new test TC_two_crcx_mdcx_and_rtp_clearmode

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31061 ) Change subject: mgw: new test TC_two_crcx_mdcx_and_rtp_clearmode ...................................................................... mgw: new test TC_two_crcx_mdcx_and_rtp_clearmode Add a test that uses SDP CLEARMODE towards the MGW. The SDP parameters generated by the test look as expected when compared to RFC 4040 section 5. Related: OS#4395 Related: https://www.rfc-editor.org/rfc/rfc4040#section-5 Change-Id: I89c5dfdcd728ab3b50e77c5062f07e1b802b1f01 --- M mgw/MGCP_Test.ttcn 1 file changed, 9 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve osmith: Looks good to me, approved diff --git a/mgw/MGCP_Test.ttcn b/mgw/MGCP_Test.ttcn index 1a21974..6f25b20 100644 --- a/mgw/MGCP_Test.ttcn +++ b/mgw/MGCP_Test.ttcn @@ -2108,6 +2108,13 @@ mp_local_ipv6, mp_remote_ipv6); } + testcase TC_two_crcx_mdcx_and_rtp_clearmode() runs on dummy_CT { + f_tc_two_crcx_mdcx_and_rtp(mp_local_ipv4, mp_remote_ipv4, + mp_local_ipv4, mp_remote_ipv4, + 120, /* 3GPP TS 48.103 table 5.4.2.2.1 */ + "CLEARMODE/8000"); + } + /* Test what happens when two RTP streams from different sources target * a single connection. Is the unsolicited stream properly ignored? */ testcase TC_two_crcx_and_unsolicited_rtp() runs on dummy_CT { @@ -2992,6 +2999,8 @@ execute(TC_two_crcx_mdcx_and_iuup_rtp()); execute(TC_two_crcx_mdcx_and_iuup_rtp_rfci_unordered()); + execute(TC_two_crcx_mdcx_and_rtp_clearmode()); + /* Note: This testcase will trigger an OSMO_ASSERT() bug in * older versions of osmo-mgw. This eventually leads into * a failure of all subsequent testcases, so it is important -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31061 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I89c5dfdcd728ab3b50e77c5062f07e1b802b1f01 Gerrit-Change-Number: 31061 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 5 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: mgw: new test TC_two_crcx_mdcx_and_rtp_clearmode

by osmith

Attention is currently required from: neels, keith. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31061 ) Change subject: mgw: new test TC_two_crcx_mdcx_and_rtp_clearmode ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Patchset: PS2: 1+1=2 (counting Pau's earlier +1 before changing the payload type and adding the comment) -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31061 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I89c5dfdcd728ab3b50e77c5062f07e1b802b1f01 Gerrit-Change-Number: 31061 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: keith <keith(a)rhizomatica.org> Gerrit-Comment-Date: Wed, 25 Jan 2023 08:18:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmo-ci[master]: lint: enable BRACES_NOT_NECESSARY check

by osmith

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/31020 ) Change subject: lint: enable BRACES_NOT_NECESSARY check ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Not sure if it suits our processes to answer here, but since I didn't see a specific issue for this: […] The checkpatch script we use comes from the linux kernel. So far we've only made adjustments if * it's a trivial change (e.g. of the error string), or * to fix complaints that shouldn't be an error in the Osmocom code bases, e.g. https://gerrit.osmocom.org/c/osmo-ci/+/24918 Other than that we only do config changes to enable / disable existing checks as in this patch. Developing entire new checks is a bit of work and doesn't seem like a good use of time, unless they would save us a lot of trouble down the road. -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/31020 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I481d1b24a909173520a544ffd567bb8357729f2a Gerrit-Change-Number: 31020 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: arehbein <arehbein(a)sysmocom.de> Gerrit-Comment-Date: Wed, 25 Jan 2023 08:10:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: arehbein <arehbein(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

2025

2024

2023

2022

gerrit-log January 2023