lists.osmocom.org
Sign In Sign Up
Manage this list Sign In Sign Up

Keyboard Shortcuts

Thread View

  • j: Next unread message
  • k: Previous unread message
  • j a: Jump to all threads
  • j l: Jump to MailingList overview

gerrit-log

Thread Start a new thread
Download
Threads by month
  • ----- 2026 -----
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2025 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2024 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2023 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2022 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
gerrit-log@lists.osmocom.org

January 2023

  • 1 participants
  • 2205 discussions
Change in osmo-ttcn3-hacks[master]: upf: test Session Mod, test Network Instance
by pespin 11 Jan '23

11 Jan '23
Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30929 ) Change subject: upf: test Session Mod, test Network Instance ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30929 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I440466f1cc9689391869ac2579a4497ef6008adb Gerrit-Change-Number: 30929 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 11 Jan 2023 11:00:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
1 0
0 0
Change in osmo-ttcn3-hacks[master]: PFCP: add support for Network Instance IE
by pespin 11 Jan '23

11 Jan '23
Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30928 ) Change subject: PFCP: add support for Network Instance IE ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: Probably worth improving the qname conversion function so that we can test more complex strings there with dots in it. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30928 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iba8d423cd91e73ea40139a5b58c4e22f1a741dc1 Gerrit-Change-Number: 30928 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 11 Jan 2023 10:57:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
1 0
0 0
Change in osmo-ttcn3-hacks[master]: PFCP: add support for Network Instance IE
by pespin 11 Jan '23

11 Jan '23
Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30928 ) Change subject: PFCP: add support for Network Instance IE ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30928 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iba8d423cd91e73ea40139a5b58c4e22f1a741dc1 Gerrit-Change-Number: 30928 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 11 Jan 2023 10:57:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
1 0
0 0
Change in osmo-ttcn3-hacks[master]: PFCP_Templates: add Session Modification templates
by pespin 11 Jan '23

11 Jan '23
Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30927 ) Change subject: PFCP_Templates: add Session Modification templates ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30927 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id9ca1eff44a4759d25b31f34ededfcc6074517d5 Gerrit-Change-Number: 30927 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 11 Jan 2023 10:56:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
1 0
0 0
Change in osmo-upf[master]: manual: fix broken reference to netinst section
by pespin 11 Jan '23

11 Jan '23
Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/30923 ) Change subject: manual: fix broken reference to netinst section ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/30923 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Ifeee1e90eb2af0e5bff357a000189c047fda03fb Gerrit-Change-Number: 30923 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 11 Jan 2023 10:54:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
1 0
0 0
Change in libosmocore[master]: bitgen test: fix concat macro
by Hoernchen 11 Jan '23

11 Jan '23
Hoernchen has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30691 ) Change subject: bitgen test: fix concat macro ...................................................................... bitgen test: fix concat macro ..compilers might not like concatenating "nothing", and it looks weird. Change-Id: Ibcd49a5c5c4f4fd0406fa1697edfd59307eac6f7 --- M tests/bitgen/bitgen_test.c 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/tests/bitgen/bitgen_test.c b/tests/bitgen/bitgen_test.c index 8657bbe..bd47291 100644 --- a/tests/bitgen/bitgen_test.c +++ b/tests/bitgen/bitgen_test.c @@ -14,17 +14,17 @@ for (at_idx = 0; at_idx < len; at_idx++) { \ uint##SIZE##_t read_val = 0; \ memset(buf, 0, sizeof(buf)); \ - osmo_store##SIZE####BE_LE##_ext(val, &buf[at_idx], len); \ + osmo_store##SIZE##BE_LE##_ext(val, &buf[at_idx], len); \ printf("osmo_store" #SIZE #BE_LE "_ext(0x%" PRIx##SIZE ", &buf[%d], %d) = %s\n", \ val, \ at_idx, len, osmo_hexdump(buf, sizeof(buf))); \ \ - read_val = osmo_load##SIZE####BE_LE##_ext(&buf[at_idx], len); \ + read_val = osmo_load##SIZE##BE_LE##_ext(&buf[at_idx], len); \ printf("osmo_load" #SIZE #BE_LE "_ext(&buf[%d], %d) = 0x%" PRIx##SIZE "\n", \ at_idx, len, read_val); \ \ if (!strcmp(#BE_LE, "be")) { \ - read_val = osmo_load##SIZE####BE_LE##_ext_2(&buf[at_idx], len); \ + read_val = osmo_load##SIZE##BE_LE##_ext_2(&buf[at_idx], len); \ printf("osmo_load" #SIZE #BE_LE "_ext_2(&buf[%d], %d) = 0x%" PRIx##SIZE "\n", \ at_idx, len, read_val); \ } \ -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30691 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibcd49a5c5c4f4fd0406fa1697edfd59307eac6f7 Gerrit-Change-Number: 30691 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged
1 0
0 0
Change in osmo-ttcn3-hacks[master]: upf/PFCP: do not imply f_inet_addr()
by neels 11 Jan '23

11 Jan '23
Attention is currently required from: neels. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30926 to look at the new patch set (#2). Change subject: upf/PFCP: do not imply f_inet_addr() ...................................................................... upf/PFCP: do not imply f_inet_addr() PFCP_Templates.ttcn is not the place to do the conversion between string and OCT4. When I wanted to use an OCT4 address in some ts_PFCP_* template, it dawned on me that it is stupid to convert the OCT4 to a string, just so that the ts_PFCP_* template converts it back to OCT4. Related: SYS#6192 SYS#5599 Change-Id: Ib068831787f4256f70a2189a5f36ca1ea1f40c9e --- M hnbgw/HNBGW_Tests.ttcn M library/PFCP_Templates.ttcn M upf/UPF_Tests.ttcn 3 files changed, 24 insertions(+), 19 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/26/30926/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30926 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib068831787f4256f70a2189a5f36ca1ea1f40c9e Gerrit-Change-Number: 30926 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newpatchset
1 0
0 0
Change in osmo-ttcn3-hacks[master]: upf: tweak f_ruleset_add_GTP_decaps
by neels 11 Jan '23

11 Jan '23
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30925 ) Change subject: upf: tweak f_ruleset_add_GTP_decaps ...................................................................... upf: tweak f_ruleset_add_GTP_decaps Improve function doc. Always use F-TEID = CHOOSE. Related: SYS#6192 SYS#5599 Change-Id: Ic88075001c1a7c3bd724ff8d618cef1dbd7423b7 --- M upf/UPF_Tests.ttcn 1 file changed, 6 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/25/30925/1 diff --git a/upf/UPF_Tests.ttcn b/upf/UPF_Tests.ttcn index 8382943..796dc16 100644 --- a/upf/UPF_Tests.ttcn +++ b/upf/UPF_Tests.ttcn @@ -505,9 +505,10 @@ Create_FAR_list far }; -/* Add to r a rule set that does GTP decapsulation (half of encapsulation/decapsulation) */ -private function f_ruleset_add_GTP_decaps(inout PFCP_Ruleset r, - template F_TEID local_f_teid := omit) { +/* Add to r a rule set that does GTP decapsulation (half of encapsulation/decapsulation): + * Receive GTP on src_iface = ACCESS by a local F-TEID to be chosen by osmo-upf. + * Dispatch GTP payload as plain IP on dest_iface = CORE. */ +private function f_ruleset_add_GTP_decaps(inout PFCP_Ruleset r) { var integer pdr_id := lengthof(r.pdr) + 1; var integer far_id := lengthof(r.far) + 1; @@ -517,7 +518,7 @@ pdr_id, ts_PFCP_PDI( ACCESS, - local_F_TEID := local_f_teid), + local_F_TEID := ts_PFCP_F_TEID_choose_v4()), ts_PFCP_Outer_Header_Removal(GTP_U_UDP_IPV4), far_id ) @@ -633,7 +634,7 @@ private function f_ruleset_tunend(GTP_Action gtp) return PFCP_Ruleset { var PFCP_Ruleset rules := { {}, {} }; - f_ruleset_add_GTP_decaps(rules, ts_PFCP_F_TEID_choose_v4()); + f_ruleset_add_GTP_decaps(rules); f_ruleset_add_GTP_encaps(rules, gtp.core_ip, gtp.teid_access_r, gtp.gtp_access_ip); return rules; } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30925 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic88075001c1a7c3bd724ff8d618cef1dbd7423b7 Gerrit-Change-Number: 30925 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange
1 0
0 0
Change in osmo-ttcn3-hacks[master]: upf/PFCP: do not imply f_inet_addr()
by neels 11 Jan '23

11 Jan '23
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30926 ) Change subject: upf/PFCP: do not imply f_inet_addr() ...................................................................... upf/PFCP: do not imply f_inet_addr() PFCP_Templates.ttcn is not the place to do the conversion between string and OCT4. When I wanted to use an OCT4 address in some ts_PFCP_* template, it dawned on me that it is stupid to convert the OCT4 to a string, just so that the ts_PFCP_* template converts it back to OCT4. Related: SYS#6192 SYS#5599 Change-Id: Ib068831787f4256f70a2189a5f36ca1ea1f40c9e --- M library/PFCP_Templates.ttcn M upf/UPF_Tests.ttcn 2 files changed, 20 insertions(+), 15 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/26/30926/1 diff --git a/library/PFCP_Templates.ttcn b/library/PFCP_Templates.ttcn index d0e8b67..caab09d 100644 --- a/library/PFCP_Templates.ttcn +++ b/library/PFCP_Templates.ttcn @@ -209,14 +209,14 @@ return t; }; -template (value) F_SEID ts_PFCP_F_SEID_ipv4(charstring addr_v4, OCT8 seid) := { +template (value) F_SEID ts_PFCP_F_SEID_ipv4(OCT4 addr_v4, OCT8 seid) := { elementIdentifier := 57, lengthIndicator := 0, v6 := '0'B, v4 := '1'B, spare := '000000'B, seid := seid, - ipv4_address := f_inet_addr(addr_v4), + ipv4_address := addr_v4, ipv6_address := omit } @@ -235,18 +235,18 @@ spare := '0000'B } -template (value) UE_IP_Address ts_PFCP_UE_IP_Address_v4(charstring addr_v4, boolean is_destination := true) := { +template (value) UE_IP_Address ts_PFCP_UE_IP_Address_v4(OCT4 addr_v4, boolean is_destination := true) := { elementIdentifier := 93, lengthIndicator := 0, v6 := '0'B, v4 := '1'B, sd := bool2bit(is_destination), spare := '00000'B, - ipv4_address := f_inet_addr(addr_v4), + ipv4_address := addr_v4, ipv6_address := omit } -template (value) F_TEID ts_PFCP_F_TEID_ipv4(OCT4 teid, charstring addr_v4) := { +template (value) F_TEID ts_PFCP_F_TEID_ipv4(OCT4 teid, OCT4 addr_v4) := { elementIdentifier := 21, lengthIndicator := 0, v4 := '1'B, @@ -255,7 +255,7 @@ chid := '0'B, spare := '0000'B, teid := teid, - ipv4_address := f_inet_addr(addr_v4), + ipv4_address := addr_v4, ipv6_address := omit, choose_id := omit } @@ -325,13 +325,13 @@ spare := '0000'B } -template (value) Outer_Header_Creation ts_PFCP_Outer_Header_Creation_GTP_ipv4(OCT4 remote_teid, charstring remote_addr_v4) := { +template (value) Outer_Header_Creation ts_PFCP_Outer_Header_Creation_GTP_ipv4(OCT4 remote_teid, OCT4 remote_addr_v4) := { elementIdentifier := 84, lengthIndicator := 0, ohc_description_oct5 := '00000001'B, ohc_description_oct6 := '00000000'B, teid := remote_teid, - ipv4 := f_inet_addr(remote_addr_v4), + ipv4 := remote_addr_v4, ipv6 := omit, udp_port := omit } @@ -419,13 +419,16 @@ } } -function ts_PFCP_Session_Est_Req(charstring node_id, OCT8 cp_seid, Create_PDR_list create_pdr, Create_FAR_list create_far) +function ts_PFCP_Session_Est_Req(template (value) Node_ID node_id, + template (value) F_SEID cp_f_seid, + Create_PDR_list create_pdr, + Create_FAR_list create_far) return template (value) PDU_PFCP { var template (value) PDU_PFCP t := ts_PDU_PFCP(); t.message_body := { pfcp_session_establishment_request := { - node_id := ts_PFCP_Node_ID_ipv4(f_inet_addr(node_id)), - CP_F_SEID := ts_PFCP_F_SEID_ipv4(node_id, cp_seid), + node_id := node_id, + CP_F_SEID := cp_f_seid, create_PDR_list := create_pdr, create_FAR_list := create_far, create_URR_list := omit, diff --git a/upf/UPF_Tests.ttcn b/upf/UPF_Tests.ttcn index 796dc16..b5c65d2 100644 --- a/upf/UPF_Tests.ttcn +++ b/upf/UPF_Tests.ttcn @@ -539,7 +539,7 @@ private function f_ruleset_add_GTP_encaps(inout PFCP_Ruleset r, charstring ue_addr_v4 := "192.168.23.42", OCT4 remote_teid, - charstring gtp_dest_addr_v4) { + OCT4 gtp_dest_addr_v4) { var integer pdr_id := lengthof(r.pdr) + 1; var integer far_id := lengthof(r.far) + 1; @@ -550,7 +550,7 @@ pdr_id, ts_PFCP_PDI( CORE, - ue_addr_v4 := ts_PFCP_UE_IP_Address_v4(ue_addr_v4, is_destination := true) + ue_addr_v4 := ts_PFCP_UE_IP_Address_v4(f_inet_addr(ue_addr_v4), is_destination := true) ), far_id := far_id ) @@ -635,14 +635,16 @@ { var PFCP_Ruleset rules := { {}, {} }; f_ruleset_add_GTP_decaps(rules); - f_ruleset_add_GTP_encaps(rules, gtp.core_ip, gtp.teid_access_r, gtp.gtp_access_ip); + f_ruleset_add_GTP_encaps(rules, gtp.core_ip, gtp.teid_access_r, f_inet_addr(gtp.gtp_access_ip)); return rules; } /* Run a PFCP Session Establishment procedure */ private function f_session_est(inout PFCP_session s, PFCP_Ruleset rules) runs on CPF_ConnHdlr { - PFCP.send(ts_PFCP_Session_Est_Req(g_pars.local_addr, s.cp_seid, rules.pdr, rules.far)); + PFCP.send(ts_PFCP_Session_Est_Req(ts_PFCP_Node_ID_ipv4(f_inet_addr(g_pars.local_addr)), + ts_PFCP_F_SEID_ipv4(f_inet_addr(g_pars.local_addr), s.cp_seid), + rules.pdr, rules.far)); var PDU_PFCP pfcp; PFCP.receive(tr_PFCP_Session_Est_Resp(s.cp_seid)) -> value pfcp; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30926 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib068831787f4256f70a2189a5f36ca1ea1f40c9e Gerrit-Change-Number: 30926 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange
1 0
0 0
Change in osmo-ttcn3-hacks[master]: upf: rename tc_session_est to tc_session_est_tunend
by neels 11 Jan '23

11 Jan '23
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30924 ) Change subject: upf: rename tc_session_est to tc_session_est_tunend ...................................................................... upf: rename tc_session_est to tc_session_est_tunend The other use case, tunmap, needs some space next to tunend, too. tunmap tests will be added soon. Related: SYS#6192 SYS#5599 Change-Id: If4a4534aa237e6ff1acb6d50e3738dd4dd6e9dfa --- M upf/UPF_Tests.ttcn 1 file changed, 11 insertions(+), 11 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/24/30924/1 diff --git a/upf/UPF_Tests.ttcn b/upf/UPF_Tests.ttcn index 3dd469b..8382943 100644 --- a/upf/UPF_Tests.ttcn +++ b/upf/UPF_Tests.ttcn @@ -650,7 +650,7 @@ log("established PFCP session: ", s); } -private function f_create_PFCP_session() runs on CPF_ConnHdlr return PFCP_session +private function f_create_PFCP_session_tunend() runs on CPF_ConnHdlr return PFCP_session { var PFCP_session s := { up_seid := -, @@ -668,10 +668,10 @@ return s; } -/* Do a PFCP Session Establishment with default values (see f_create_PFCP_session()) */ -private function f_session_est_default() runs on CPF_ConnHdlr return PFCP_session +/* Do a PFCP Session Establishment with default values (see f_create_PFCP_session_tunend()) */ +private function f_session_est_tunend() runs on CPF_ConnHdlr return PFCP_session { - var PFCP_session s := f_create_PFCP_session(); + var PFCP_session s := f_create_PFCP_session_tunend(); f_session_est(s, f_ruleset_tunend(s.gtp)); return s; } @@ -711,9 +711,9 @@ } /* Verify PFCP Session Establishment and Deletion */ -private function f_tc_session_est(charstring id) runs on CPF_ConnHdlr { +private function f_tc_session_est_tunend(charstring id) runs on CPF_ConnHdlr { f_assoc_setup(); - var PFCP_session s := f_session_est_default(); + var PFCP_session s := f_session_est_tunend(); f_sleep(1.0); f_vty_expect_session_active(UPFVTY, s); f_session_del(s); @@ -722,11 +722,11 @@ f_assoc_release(); setverdict(pass); } -testcase TC_session_est() runs on test_CT { +testcase TC_session_est_tunend() runs on test_CT { var CPF_ConnHdlr vc_conn; f_init(guard_timeout := 15.0); - vc_conn := f_start_handler(refers(f_tc_session_est)); + vc_conn := f_start_handler(refers(f_tc_session_est_tunend)); vc_conn.done; f_shutdown_helper(); } @@ -734,7 +734,7 @@ /* Verify that releasing a PFCP Association also releases all its sessions and GTP actions. */ private function f_tc_session_term_by_assoc_rel(charstring id) runs on CPF_ConnHdlr { f_assoc_setup(); - var PFCP_session s := f_session_est_default(); + var PFCP_session s := f_session_est_tunend(); f_sleep(1.0); f_vty_expect_session_active(UPFVTY, s); f_assoc_release(); @@ -754,7 +754,7 @@ /* Verify that PFCP Sessions with a src-interface other than ACCESS or CORE are ACKed by osmo-upf but have no effect. */ private function f_tc_session_est_noop(charstring id) runs on CPF_ConnHdlr { f_assoc_setup(); - var PFCP_session s := f_create_PFCP_session(); + var PFCP_session s := f_create_PFCP_session_tunend(); f_session_est(s, f_ruleset_noop()); f_sleep(1.0); @@ -778,7 +778,7 @@ control { execute( TC_assoc_node_id_v4() ); execute( TC_assoc_node_id_fqdn() ); - execute( TC_session_est() ); + execute( TC_session_est_tunend() ); execute( TC_session_term_by_assoc_rel() ); execute( TC_session_est_noop() ); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30924 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If4a4534aa237e6ff1acb6d50e3738dd4dd6e9dfa Gerrit-Change-Number: 30924 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange
1 0
0 0
  • ← Newer
  • 1
  • ...
  • 149
  • 150
  • 151
  • 152
  • 153
  • 154
  • 155
  • ...
  • 221
  • Older →

HyperKitty Powered by HyperKitty version 1.3.12.