Attention is currently required from: neels.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30929 )
Change subject: upf: test Session Mod, test Network Instance
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30929
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I440466f1cc9689391869ac2579a4497ef6008adb
Gerrit-Change-Number: 30929
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 11 Jan 2023 11:00:59 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: neels.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30928 )
Change subject: PFCP: add support for Network Instance IE
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
Probably worth improving the qname conversion function so that we can test more complex strings there with dots in it.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30928
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Iba8d423cd91e73ea40139a5b58c4e22f1a741dc1
Gerrit-Change-Number: 30928
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 11 Jan 2023 10:57:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: neels.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30928 )
Change subject: PFCP: add support for Network Instance IE
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30928
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Iba8d423cd91e73ea40139a5b58c4e22f1a741dc1
Gerrit-Change-Number: 30928
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 11 Jan 2023 10:57:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: neels.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30926
to look at the new patch set (#2).
Change subject: upf/PFCP: do not imply f_inet_addr()
......................................................................
upf/PFCP: do not imply f_inet_addr()
PFCP_Templates.ttcn is not the place to do the conversion between string
and OCT4.
When I wanted to use an OCT4 address in some ts_PFCP_* template, it
dawned on me that it is stupid to convert the OCT4 to a string, just so
that the ts_PFCP_* template converts it back to OCT4.
Related: SYS#6192 SYS#5599
Change-Id: Ib068831787f4256f70a2189a5f36ca1ea1f40c9e
---
M hnbgw/HNBGW_Tests.ttcn
M library/PFCP_Templates.ttcn
M upf/UPF_Tests.ttcn
3 files changed, 24 insertions(+), 19 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/26/30926/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30926
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ib068831787f4256f70a2189a5f36ca1ea1f40c9e
Gerrit-Change-Number: 30926
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-MessageType: newpatchset
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30924 )
Change subject: upf: rename tc_session_est to tc_session_est_tunend
......................................................................
upf: rename tc_session_est to tc_session_est_tunend
The other use case, tunmap, needs some space next to tunend, too. tunmap
tests will be added soon.
Related: SYS#6192 SYS#5599
Change-Id: If4a4534aa237e6ff1acb6d50e3738dd4dd6e9dfa
---
M upf/UPF_Tests.ttcn
1 file changed, 11 insertions(+), 11 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/24/30924/1
diff --git a/upf/UPF_Tests.ttcn b/upf/UPF_Tests.ttcn
index 3dd469b..8382943 100644
--- a/upf/UPF_Tests.ttcn
+++ b/upf/UPF_Tests.ttcn
@@ -650,7 +650,7 @@
log("established PFCP session: ", s);
}
-private function f_create_PFCP_session() runs on CPF_ConnHdlr return PFCP_session
+private function f_create_PFCP_session_tunend() runs on CPF_ConnHdlr return PFCP_session
{
var PFCP_session s := {
up_seid := -,
@@ -668,10 +668,10 @@
return s;
}
-/* Do a PFCP Session Establishment with default values (see f_create_PFCP_session()) */
-private function f_session_est_default() runs on CPF_ConnHdlr return PFCP_session
+/* Do a PFCP Session Establishment with default values (see f_create_PFCP_session_tunend()) */
+private function f_session_est_tunend() runs on CPF_ConnHdlr return PFCP_session
{
- var PFCP_session s := f_create_PFCP_session();
+ var PFCP_session s := f_create_PFCP_session_tunend();
f_session_est(s, f_ruleset_tunend(s.gtp));
return s;
}
@@ -711,9 +711,9 @@
}
/* Verify PFCP Session Establishment and Deletion */
-private function f_tc_session_est(charstring id) runs on CPF_ConnHdlr {
+private function f_tc_session_est_tunend(charstring id) runs on CPF_ConnHdlr {
f_assoc_setup();
- var PFCP_session s := f_session_est_default();
+ var PFCP_session s := f_session_est_tunend();
f_sleep(1.0);
f_vty_expect_session_active(UPFVTY, s);
f_session_del(s);
@@ -722,11 +722,11 @@
f_assoc_release();
setverdict(pass);
}
-testcase TC_session_est() runs on test_CT {
+testcase TC_session_est_tunend() runs on test_CT {
var CPF_ConnHdlr vc_conn;
f_init(guard_timeout := 15.0);
- vc_conn := f_start_handler(refers(f_tc_session_est));
+ vc_conn := f_start_handler(refers(f_tc_session_est_tunend));
vc_conn.done;
f_shutdown_helper();
}
@@ -734,7 +734,7 @@
/* Verify that releasing a PFCP Association also releases all its sessions and GTP actions. */
private function f_tc_session_term_by_assoc_rel(charstring id) runs on CPF_ConnHdlr {
f_assoc_setup();
- var PFCP_session s := f_session_est_default();
+ var PFCP_session s := f_session_est_tunend();
f_sleep(1.0);
f_vty_expect_session_active(UPFVTY, s);
f_assoc_release();
@@ -754,7 +754,7 @@
/* Verify that PFCP Sessions with a src-interface other than ACCESS or CORE are ACKed by osmo-upf but have no effect. */
private function f_tc_session_est_noop(charstring id) runs on CPF_ConnHdlr {
f_assoc_setup();
- var PFCP_session s := f_create_PFCP_session();
+ var PFCP_session s := f_create_PFCP_session_tunend();
f_session_est(s, f_ruleset_noop());
f_sleep(1.0);
@@ -778,7 +778,7 @@
control {
execute( TC_assoc_node_id_v4() );
execute( TC_assoc_node_id_fqdn() );
- execute( TC_session_est() );
+ execute( TC_session_est_tunend() );
execute( TC_session_term_by_assoc_rel() );
execute( TC_session_est_noop() );
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30924
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: If4a4534aa237e6ff1acb6d50e3738dd4dd6e9dfa
Gerrit-Change-Number: 30924
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-MessageType: newchange