January 2023 - gerrit-log - lists.osmocom.org

Change in libosmocore[master]: uitils: add floored and euclidian modulo functions

by dexter

dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30933 ) Change subject: uitils: add floored and euclidian modulo functions ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: (The paper I am referring to can be found at: https://www.microsoft.com/en-us/research/wp-content/uploads/2016/02/divmodn…) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30933 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If61cd54f43643325c45f64531c57fe4c5802a9cf Gerrit-Change-Number: 30933 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Wed, 11 Jan 2023 12:38:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in libosmocore[master]: uitils: add floored and euclidian modulo functions

by dexter

Attention is currently required from: dexter. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/30933 to look at the new patch set (#4). Change subject: uitils: add floored and euclidian modulo functions ...................................................................... uitils: add floored and euclidian modulo functions C/C++ only implements a so called "truncated modulo" function. Lets also add a floored and an euclidian modulo function to be more complete. Change-Id: If61cd54f43643325c45f64531c57fe4c5802a9cf --- M include/osmocom/core/utils.h M tests/utils/utils_test.c M tests/utils/utils_test.ok 3 files changed, 102 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/33/30933/4 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30933 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If61cd54f43643325c45f64531c57fe4c5802a9cf Gerrit-Change-Number: 30933 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 5 months

1
0
0 0

Change in libosmocore[master]: uitils: add floored and euclidian modulo functions

by dexter

Attention is currently required from: dexter. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/30933 to look at the new patch set (#3). Change subject: uitils: add floored and euclidian modulo functions ...................................................................... uitils: add floored and euclidian modulo functions C/C++ only implements a so called "truncated modulo" function. Lets also add a floored and an euclidian modulo function to be more complete. Change-Id: If61cd54f43643325c45f64531c57fe4c5802a9cf --- M include/osmocom/core/utils.h M tests/utils/utils_test.c M tests/utils/utils_test.ok 3 files changed, 102 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/33/30933/3 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30933 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If61cd54f43643325c45f64531c57fe4c5802a9cf Gerrit-Change-Number: 30933 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 5 months

1
0
0 0

Change in libosmocore[master]: uitils: add floored and euclidian modulo functions

by Jenkins Builder

Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30933 ) Change subject: uitils: add floored and euclidian modulo functions ...................................................................... Patch Set 2: (3 comments) File tests/utils/utils_test.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2601): https://gerrit.osmocom.org/c/libosmocore/+/30933/comment/744f3f15_73eb9b4e PS2, Line 773: printf(" %i mod %i = %i = %i\n", x, y, result, expected_result); Use %d instead of %i Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2601): https://gerrit.osmocom.org/c/libosmocore/+/30933/comment/df39132f_57e5c72d PS2, Line 781: printf(" %i mod_flr %i = %i = %i\n", x, y, result, expected_result); Use %d instead of %i Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2601): https://gerrit.osmocom.org/c/libosmocore/+/30933/comment/919cc5df_450a985c PS2, Line 789: printf(" %i mod_euc %i = %i = %i\n", x, y, result, expected_result); Use %d instead of %i -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30933 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If61cd54f43643325c45f64531c57fe4c5802a9cf Gerrit-Change-Number: 30933 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Wed, 11 Jan 2023 12:18:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in libosmocore[master]: uitils: add floored and euclidian modulo functions

by Jenkins Builder

Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30933 ) Change subject: uitils: add floored and euclidian modulo functions ...................................................................... Patch Set 1: (3 comments) File tests/utils/utils_test.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2600): https://gerrit.osmocom.org/c/libosmocore/+/30933/comment/cc21fbc8_49b7f811 PS1, Line 773: printf(" %i mod %i = %i = %i\n", x, y, result, expected_result); Use %d instead of %i Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2600): https://gerrit.osmocom.org/c/libosmocore/+/30933/comment/db7fd405_afb9aeef PS1, Line 781: printf(" %i mod_flr %i = %i = %i\n", x, y, result, expected_result); Use %d instead of %i Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2600): https://gerrit.osmocom.org/c/libosmocore/+/30933/comment/ed28d50b_eacba4fa PS1, Line 789: printf(" %i mod_euc %i = %i = %i\n", x, y, result, expected_result); Use %d instead of %i -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30933 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If61cd54f43643325c45f64531c57fe4c5802a9cf Gerrit-Change-Number: 30933 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Wed, 11 Jan 2023 12:18:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in libosmocore[master]: uitils: add floored and euclidian modulo functions

by dexter

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/30933 ) Change subject: uitils: add floored and euclidian modulo functions ...................................................................... uitils: add floored and euclidian modulo functions C/C++ only implements a so called "truncated modulo" function. Lets also add a floored and an euclidian modulo function to be more complete. Change-Id: If61cd54f43643325c45f64531c57fe4c5802a9cf --- M include/osmocom/core/utils.h M tests/utils/utils_test.c M tests/utils/utils_test.ok 3 files changed, 102 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/33/30933/1 diff --git a/include/osmocom/core/utils.h b/include/osmocom/core/utils.h index d0e2e9b..5623552 100644 --- a/include/osmocom/core/utils.h +++ b/include/osmocom/core/utils.h @@ -182,6 +182,18 @@ uint32_t osmo_isqrt32(uint32_t x); +/*! Floored Modulo (See also: Daan Leijen, Division and Modulus for Computer Scientists). + * \param[in] x dividend. + * \param[in] y divisor. + * \returns remainder of x divided by y. */ +#define OSMO_MOD_FLR(x, y) (x > 0 && y < 0 || x < 0 && y > 0 ? x % y + y : x % y) + +/*! Euclidean Modulo (See also: Daan Leijen, Division and Modulus for Computer Scientists). + * \param[in] x dividend. + * \param[in] y divisor. + * \returns remainder of x divided by y. */ +#define OSMO_MOD_EUC(x, y) (x % y < 0 ? y > 0 ? x % y + y : x % y - y : x % y) + char osmo_luhn(const char* in, int in_len); /*! State for OSMO_STRBUF_APPEND() and OSMO_STRBUF_PRINTF(). See there for examples. */ diff --git a/tests/utils/utils_test.c b/tests/utils/utils_test.c index 9ddae65..79030f9 100644 --- a/tests/utils/utils_test.c +++ b/tests/utils/utils_test.c @@ -766,6 +766,65 @@ } } +static void mod_test_mod(int x, int y, int expected_result) +{ + int result; + result = x % y; + printf(" %i mod %i = %i = %i\n", x, y, result, expected_result); + OSMO_ASSERT(result == expected_result); +} + +static void mod_test_mod_flr(int x, int y, int expected_result) +{ + int result; + result = OSMO_MOD_FLR(x, y); + printf(" %i mod_flr %i = %i = %i\n", x, y, result, expected_result); + OSMO_ASSERT(result == expected_result); +} + +static void mod_test_mod_euc(int x, int y, int expected_result) +{ + int result; + result = OSMO_MOD_EUC(x, y); + printf(" %i mod_euc %i = %i = %i\n", x, y, result, expected_result); + OSMO_ASSERT(result == expected_result); +} + +static void mod_test(void) +{ + /* See also: Daan Leijen, Division and Modulus for Computer + * Scientists, section 1.3 */ + + printf("\nTesting built in truncated modulo for comparison:\n"); + mod_test_mod(8, 3, 2); + mod_test_mod(8, -3, 2); + mod_test_mod(-8, 3, -2); + mod_test_mod(-8, -3, -2); + mod_test_mod(1, 2, 1); + mod_test_mod(1, -2, 1); + mod_test_mod(-1, 2, -1); + mod_test_mod(-1, -2, -1); + + printf("\nTesting OSMO_MOD_FLR():\n"); + mod_test_mod_flr(8, 3, 2); + mod_test_mod_flr(8, -3, -1); + mod_test_mod_flr(-8, 3, 1); + mod_test_mod_flr(-8, -3, -2); + mod_test_mod_flr(1, 2, 1); + mod_test_mod_flr(1, -2, -1); + mod_test_mod_flr(-1, 2, 1); + mod_test_mod_flr(-1, -2, -1); + + printf("\nTesting OSMO_MOD_EUC():\n"); + mod_test_mod_euc(8, 3, 2); + mod_test_mod_euc(8, -3, 2); + mod_test_mod_euc(-8, 3, 1); + mod_test_mod_euc(-8, -3, 1); + mod_test_mod_euc(1, 2, 1); + mod_test_mod_euc(1, -2, 1); + mod_test_mod_euc(-1, 2, 1); + mod_test_mod_euc(-1, -2, 1); +} struct osmo_sockaddr_to_str_and_uint_test_case { uint16_t port; @@ -2088,6 +2147,7 @@ str_escape3_test(); str_quote3_test(); isqrt_test(); + mod_test(); osmo_sockaddr_to_str_and_uint_test(); osmo_str_tolowupper_test(); strbuf_test(); diff --git a/tests/utils/utils_test.ok b/tests/utils/utils_test.ok index 1409d81..3f453e9 100644 --- a/tests/utils/utils_test.ok +++ b/tests/utils/utils_test.ok @@ -354,6 +354,36 @@ Testing integer square-root +Testing built in truncated modulo for comparison: + 8 mod 3 = 2 = 2 + 8 mod -3 = 2 = 2 + -8 mod 3 = -2 = -2 + -8 mod -3 = -2 = -2 + 1 mod 2 = 1 = 1 + 1 mod -2 = 1 = 1 + -1 mod 2 = -1 = -1 + -1 mod -2 = -1 = -1 + +Testing OSMO_MOD_FLR(): + 8 mod_flr 3 = 2 = 2 + 8 mod_flr -3 = -1 = -1 + -8 mod_flr 3 = 1 = 1 + -8 mod_flr -3 = -2 = -2 + 1 mod_flr 2 = 1 = 1 + 1 mod_flr -2 = -1 = -1 + -1 mod_flr 2 = 1 = 1 + -1 mod_flr -2 = -1 = -1 + +Testing OSMO_MOD_EUC(): + 8 mod_euc 3 = 2 = 2 + 8 mod_euc -3 = 2 = 2 + -8 mod_euc 3 = 1 = 1 + -8 mod_euc -3 = 1 = 1 + 1 mod_euc 2 = 1 = 1 + 1 mod_euc -2 = 1 = 1 + -1 mod_euc 2 = 1 = 1 + -1 mod_euc -2 = 1 = 1 + osmo_sockaddr_to_str_and_uint_test [0] [0.0.0.0]:0 addr_len=20 --> [0.0.0.0]:0 rc=7 [1] [255.255.255.255]:65535 addr_len=20 --> [255.255.255.255]:65535 rc=15 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30933 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If61cd54f43643325c45f64531c57fe4c5802a9cf Gerrit-Change-Number: 30933 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 5 months

1
0
0 0

Change in osmo-sgsn[master]: Fix extra whitespace in pdpctx_ctr_description

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/30932 ) Change subject: Fix extra whitespace in pdpctx_ctr_description ...................................................................... Fix extra whitespace in pdpctx_ctr_description Change-Id: I4d9145c681e725b709fde38f6e9b4516d37b4d8c --- M src/sgsn/pdpctx.c 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/32/30932/1 diff --git a/src/sgsn/pdpctx.c b/src/sgsn/pdpctx.c index 70fba20..e779420 100644 --- a/src/sgsn/pdpctx.c +++ b/src/sgsn/pdpctx.c @@ -40,10 +40,10 @@ #include <osmocom/sgsn/gtp.h> static const struct rate_ctr_desc pdpctx_ctr_description[] = { - { "udata:packets:in", "User Data Messages ( In)" }, - { "udata:packets:out", "User Data Messages (Out)" }, - { "udata:bytes:in", "User Data Bytes ( In)" }, - { "udata:bytes:out", "User Data Bytes (Out)" }, + { "udata:packets:in", "User Data Messages ( In)" }, + { "udata:packets:out", "User Data Messages (Out)" }, + { "udata:bytes:in", "User Data Bytes ( In)" }, + { "udata:bytes:out", "User Data Bytes (Out)" }, }; static const struct rate_ctr_group_desc pdpctx_ctrg_desc = { -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/30932 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I4d9145c681e725b709fde38f6e9b4516d37b4d8c Gerrit-Change-Number: 30932 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 5 months

1
0
0 0

Change in osmo-sgsn[master]: Drop extern declarations of global sgsn_instance in source files

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/30931 ) Change subject: Drop extern declarations of global sgsn_instance in source files ...................................................................... Drop extern declarations of global sgsn_instance in source files There's an extern declaration already in sgsn.h. Change-Id: I2375e13c8436a069e8fe60136c8e1759a9adc2d1 --- M src/sgsn/gprs_gmm.c M src/sgsn/gprs_sgsn.c M src/sgsn/sgsn_cdr.c 3 files changed, 0 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/31/30931/1 diff --git a/src/sgsn/gprs_gmm.c b/src/sgsn/gprs_gmm.c index 5505ba9..b12102e 100644 --- a/src/sgsn/gprs_gmm.c +++ b/src/sgsn/gprs_gmm.c @@ -67,8 +67,6 @@ #define PTMSI_ALLOC -extern struct sgsn_instance *sgsn; - static const struct tlv_definition gsm48_gmm_att_tlvdef = { .def = { [GSM48_IE_GMM_CIPH_CKSN] = { TLV_TYPE_FIXED, 1 }, diff --git a/src/sgsn/gprs_sgsn.c b/src/sgsn/gprs_sgsn.c index 9a3e983..c911b6a 100644 --- a/src/sgsn/gprs_sgsn.c +++ b/src/sgsn/gprs_sgsn.c @@ -61,7 +61,6 @@ #define GPRS_LLME_CHECK_TICK 30 -extern struct sgsn_instance *sgsn; extern struct osmo_tdef sgsn_T_defs[]; LLIST_HEAD(sgsn_mm_ctxts); diff --git a/src/sgsn/sgsn_cdr.c b/src/sgsn/sgsn_cdr.c index ac0a6fd..c22a6ac 100644 --- a/src/sgsn/sgsn_cdr.c +++ b/src/sgsn/sgsn_cdr.c @@ -39,9 +39,6 @@ #include <stdio.h> #include <inttypes.h> -/* TODO...avoid going through a global */ -extern struct sgsn_instance *sgsn; - /** * The CDR module will generate an entry like: * -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/30931 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I2375e13c8436a069e8fe60136c8e1759a9adc2d1 Gerrit-Change-Number: 30931 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 5 months

1
0
0 0

Change in osmo-sgsn[master]: Move extern declarations of tall_sgsn_ctx to sgsn.h

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/30930 ) Change subject: Move extern declarations of tall_sgsn_ctx to sgsn.h ...................................................................... Move extern declarations of tall_sgsn_ctx to sgsn.h Change-Id: Ifbd54b2e92db8d4a0e0cd1c569cfd83dd85165b8 --- M include/osmocom/sgsn/sgsn.h M src/gprs/sgsn_ares.c M src/sgsn/apn.c M src/sgsn/gprs_gmm.c M src/sgsn/gprs_sgsn.c M src/sgsn/gprs_sm.c M src/sgsn/gprs_subscriber.c M src/sgsn/gtp_mme.c M src/sgsn/sgsn_vty.c 9 files changed, 1 insertion(+), 14 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/30/30930/1 diff --git a/include/osmocom/sgsn/sgsn.h b/include/osmocom/sgsn/sgsn.h index 0bc88a9..4326846 100644 --- a/include/osmocom/sgsn/sgsn.h +++ b/include/osmocom/sgsn/sgsn.h @@ -159,6 +159,7 @@ }; extern struct sgsn_instance *sgsn; +extern void *tall_sgsn_ctx; /* sgsn_vty.c */ diff --git a/src/gprs/sgsn_ares.c b/src/gprs/sgsn_ares.c index 87314f1..81ab835 100644 --- a/src/gprs/sgsn_ares.c +++ b/src/gprs/sgsn_ares.c @@ -24,8 +24,6 @@ #include <netdb.h> -extern void *tall_sgsn_ctx; - struct cares_event_fd { struct llist_head head; struct osmo_fd fd; diff --git a/src/sgsn/apn.c b/src/sgsn/apn.c index 8ed523e..a89d158 100644 --- a/src/sgsn/apn.c +++ b/src/sgsn/apn.c @@ -27,8 +27,6 @@ #include <osmocom/sgsn/apn.h> #include <osmocom/sgsn/sgsn.h> -extern void *tall_sgsn_ctx; - static struct apn_ctx *sgsn_apn_ctx_alloc(const char *ap_name, const char *imsi_prefix) { struct apn_ctx *actx; diff --git a/src/sgsn/gprs_gmm.c b/src/sgsn/gprs_gmm.c index b385ff1..5505ba9 100644 --- a/src/sgsn/gprs_gmm.c +++ b/src/sgsn/gprs_gmm.c @@ -68,7 +68,6 @@ #define PTMSI_ALLOC extern struct sgsn_instance *sgsn; -extern void *tall_sgsn_ctx; static const struct tlv_definition gsm48_gmm_att_tlvdef = { .def = { diff --git a/src/sgsn/gprs_sgsn.c b/src/sgsn/gprs_sgsn.c index 8c2734b..9a3e983 100644 --- a/src/sgsn/gprs_sgsn.c +++ b/src/sgsn/gprs_sgsn.c @@ -62,7 +62,6 @@ #define GPRS_LLME_CHECK_TICK 30 extern struct sgsn_instance *sgsn; -extern void *tall_sgsn_ctx; extern struct osmo_tdef sgsn_T_defs[]; LLIST_HEAD(sgsn_mm_ctxts); diff --git a/src/sgsn/gprs_sm.c b/src/sgsn/gprs_sm.c index 184350d..3177a70 100644 --- a/src/sgsn/gprs_sm.c +++ b/src/sgsn/gprs_sm.c @@ -44,8 +44,6 @@ #include <osmocom/sgsn/gprs_ranap.h> #include <osmocom/sgsn/gtp.h> -extern void *tall_sgsn_ctx; - /* 3GPP TS 04.08 sec 6.1.3.4.3(.a) "Abnormal cases" */ #define T339X_MAX_RETRANS 4 diff --git a/src/sgsn/gprs_subscriber.c b/src/sgsn/gprs_subscriber.c index 943fbc3..416e6a4 100644 --- a/src/sgsn/gprs_subscriber.c +++ b/src/sgsn/gprs_subscriber.c @@ -48,8 +48,6 @@ (gsup)->imsi, \ ## args) -extern void *tall_sgsn_ctx; - LLIST_HEAD(_gprs_subscribers); struct llist_head * const gprs_subscribers = &_gprs_subscribers; diff --git a/src/sgsn/gtp_mme.c b/src/sgsn/gtp_mme.c index 948e8e8..b96c90d 100644 --- a/src/sgsn/gtp_mme.c +++ b/src/sgsn/gtp_mme.c @@ -26,8 +26,6 @@ #include <osmocom/sgsn/gtp_mme.h> #include <osmocom/sgsn/sgsn.h> -extern void *tall_sgsn_ctx; - static bool _eutran_tai_equal(const struct osmo_eutran_tai *t1, const struct osmo_eutran_tai *t2) { return t1->mcc == t2->mcc && diff --git a/src/sgsn/sgsn_vty.c b/src/sgsn/sgsn_vty.c index 3d3e8cd..2313a9a 100644 --- a/src/sgsn/sgsn_vty.c +++ b/src/sgsn/sgsn_vty.c @@ -63,8 +63,6 @@ #include <osmocom/ranap/iu_client.h> #endif -extern void *tall_sgsn_ctx; - static struct sgsn_config *g_cfg = NULL; const struct value_string sgsn_auth_pol_strs[] = { -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/30930 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ifbd54b2e92db8d4a0e0cd1c569cfd83dd85165b8 Gerrit-Change-Number: 30930 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 5 months

1
0
0 0

Change in osmo-sgsn[master]: gtp_{ggsn,mme}: Allocate contexts under struct sgsn_instance

by pespin

Attention is currently required from: lynxis lazus. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/30890 to look at the new patch set (#2). Change subject: gtp_{ggsn,mme}: Allocate contexts under struct sgsn_instance ...................................................................... gtp_{ggsn,mme}: Allocate contexts under struct sgsn_instance This way apns are managed by the lifcycle of the main global struct sgsn_instance automatically. Change-Id: Ie65d59632a368c6957c33dca64e856ace792b2c6 --- M include/osmocom/sgsn/gtp_ggsn.h M src/sgsn/gprs_sgsn.c M src/sgsn/gprs_sm.c M src/sgsn/gtp_ggsn.c M src/sgsn/gtp_mme.c M src/sgsn/sgsn_libgtp.c M src/sgsn/sgsn_vty.c M tests/sgsn/sgsn_test.c 8 files changed, 25 insertions(+), 26 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/90/30890/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/30890 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ie65d59632a368c6957c33dca64e856ace792b2c6 Gerrit-Change-Number: 30890 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: newpatchset

2 years, 5 months

1
0
0 0

2025

2024

2023

2022

gerrit-log January 2023