August 2022 - gerrit-log - lists.osmocom.org

Change in osmo-hnbgw[master]: manual: update IuCS/IuPS protocol stack chart

by dexter

Attention is currently required from: neels. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29093 ) Change subject: manual: update IuCS/IuPS protocol stack chart ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: Did we ever use SUA? -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29093 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I4496a6ffdda511875208bebbe68dbc9e69541fc0 Gerrit-Change-Number: 29093 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 17 Aug 2022 14:44:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in libosmocore[master]: use_count: Return if uc is NULL

by dexter

Attention is currently required from: neels, daniel. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/29121 ) Change subject: use_count: Return if uc is NULL ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/29121 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I792563696860a3100e95cafdd5fe57511819ef56 Gerrit-Change-Number: 29121 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Wed, 17 Aug 2022 14:34:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in osmo-hnbgw[master]: optimize: decode PS msgs only when PFCP is enabled

by neels

neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29003 ) Change subject: optimize: decode PS msgs only when PFCP is enabled ...................................................................... optimize: decode PS msgs only when PFCP is enabled For the benefit of skipping decoding of all PS RANAP and RUA messages, introduce code dup: decode CS and PS separately. Related: SYS#5895 Change-Id: Ifb57bad6a0d5ff263e4c6c3facc51620e110e7d2 --- M src/osmo-hnbgw/hnbgw_cn.c M src/osmo-hnbgw/hnbgw_rua.c 2 files changed, 48 insertions(+), 26 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve neels: Looks good to me, approved daniel: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/osmo-hnbgw/hnbgw_cn.c b/src/osmo-hnbgw/hnbgw_cn.c index 893ee2a..7cbfcec 100644 --- a/src/osmo-hnbgw/hnbgw_cn.c +++ b/src/osmo-hnbgw/hnbgw_cn.c @@ -373,11 +373,12 @@ } /* Intercept RAB Assignment Request, to map RTP and GTP between access and core */ - message = talloc_zero(map, ranap_message); - rc = ranap_ran_rx_co_decode(map, message, msgb_l2(oph->msg), msgb_l2len(oph->msg)); - if (rc == 0) { - if (!map->is_ps) { - /* Circuit-Switched. Set up mapping of RTP ports via MGW */ + if (!map->is_ps) { + /* Circuit-Switched. Set up mapping of RTP ports via MGW */ + message = talloc_zero(map, ranap_message); + rc = ranap_ran_rx_co_decode(map, message, msgb_l2(oph->msg), msgb_l2len(oph->msg)); + + if (rc == 0) { switch (message->procedureCode) { case RANAP_ProcedureCode_id_RAB_Assignment: /* mgw_fsm_alloc_and_handle_rab_ass_req() takes ownership of (ranap) message */ @@ -388,10 +389,18 @@ mgw_fsm_release(map); break; } + ranap_ran_rx_co_free(message); + } + + talloc_free(message); #if ENABLE_PFCP - } else { - struct hnb_gw *hnb_gw = cnlink->gw; - /* Packet-Switched. Set up mapping of GTP ports via UPF */ + } else { + struct hnb_gw *hnb_gw = cnlink->gw; + /* Packet-Switched. Set up mapping of GTP ports via UPF */ + message = talloc_zero(map, ranap_message); + rc = ranap_ran_rx_co_decode(map, message, msgb_l2(oph->msg), msgb_l2len(oph->msg)); + + if (rc == 0) { switch (message->procedureCode) { case RANAP_ProcedureCode_id_RAB_Assignment: @@ -408,16 +417,17 @@ break; case RANAP_ProcedureCode_id_Iu_Release: - /* An IU Release will terminate the PFCP sessions for all RABs (ps_rab FSM instances). - * Terminate all RABs and forward the IU Release directly by rua_tx_dt() below. */ + /* Any IU Release will terminate the MGW FSM, the message itsself is not passed to the + * FSM code. It is just forwarded normally by the rua_tx_dt() call below. */ hnbgw_gtpmap_release(map); break; } -#endif + ranap_ran_rx_co_free(message); } - ranap_ran_rx_co_free(message); + + talloc_free(message); +#endif } - talloc_free(message); return rua_tx_dt(map->hnb_ctx, map->is_ps, map->rua_ctx_id, msgb_l2(oph->msg), msgb_l2len(oph->msg)); diff --git a/src/osmo-hnbgw/hnbgw_rua.c b/src/osmo-hnbgw/hnbgw_rua.c index 9234ac4..7d5492f 100644 --- a/src/osmo-hnbgw/hnbgw_rua.c +++ b/src/osmo-hnbgw/hnbgw_rua.c @@ -276,25 +276,37 @@ /* If there is data, see if it is a RAB Assignment message where we need to change the user plane information, * for RTP mapping via MGW (soon also GTP mapping via UPF). */ if (data && len && map && !release_context_map) { - message = talloc_zero(map, ranap_message); - rc = ranap_cn_rx_co_decode(map, message, msgb_l2(prim->oph.msg), msgb_l2len(prim->oph.msg)); + if (!map->is_ps) { + message = talloc_zero(map, ranap_message); + rc = ranap_cn_rx_co_decode(map, message, msgb_l2(prim->oph.msg), msgb_l2len(prim->oph.msg)); - if (rc == 0) { - switch (message->procedureCode) { - case RANAP_ProcedureCode_id_RAB_Assignment: - if (!map->is_ps) { + if (rc == 0) { + switch (message->procedureCode) { + case RANAP_ProcedureCode_id_RAB_Assignment: /* mgw_fsm_handle_rab_ass_resp() takes ownership of prim->oph and (ranap) message */ return mgw_fsm_handle_rab_ass_resp(map, &prim->oph, message); } -#if ENABLE_PFCP - /* ps_rab_ass_fsm takes ownership of prim->oph and RANAP message */ - return hnbgw_gtpmap_rx_rab_ass_resp(map, &prim->oph, message); -#endif + ranap_cn_rx_co_free(message); } - ranap_cn_rx_co_free(message); - } - talloc_free(message); + talloc_free(message); +#if ENABLE_PFCP + } else { + message = talloc_zero(map, ranap_message); + rc = ranap_cn_rx_co_decode(map, message, msgb_l2(prim->oph.msg), msgb_l2len(prim->oph.msg)); + + if (rc == 0) { + switch (message->procedureCode) { + case RANAP_ProcedureCode_id_RAB_Assignment: + /* ps_rab_ass_fsm takes ownership of prim->oph and RANAP message */ + return hnbgw_gtpmap_rx_rab_ass_resp(map, &prim->oph, message); + } + ranap_cn_rx_co_free(message); + } + + talloc_free(message); +#endif + } } rc = osmo_sccp_user_sap_down(cn->sccp_user, &prim->oph); -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29003 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ifb57bad6a0d5ff263e4c6c3facc51620e110e7d2 Gerrit-Change-Number: 29003 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 10 months

1
0
0 0

Change in osmo-hnbgw[master]: ps_rab_fsm: check use cb success

by neels

neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29072 ) Change subject: ps_rab_fsm: check use cb success ...................................................................... ps_rab_fsm: check use cb success Related: CID#275413 CID#275410 CID#275409 Related: SYS#5895 Change-Id: Idcb3d6796326b059280b0e552eb36067ba15b3ac --- M src/osmo-hnbgw/ps_rab_fsm.c 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve neels: Looks good to me, approved daniel: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/osmo-hnbgw/ps_rab_fsm.c b/src/osmo-hnbgw/ps_rab_fsm.c index 8578561..dcc18ca 100644 --- a/src/osmo-hnbgw/ps_rab_fsm.c +++ b/src/osmo-hnbgw/ps_rab_fsm.c @@ -106,7 +106,7 @@ }; fi->priv = rab; - osmo_use_count_get_put(&rab->use_count, PS_RAB_USE_ACTIVE, 1); + OSMO_ASSERT(osmo_use_count_get_put(&rab->use_count, PS_RAB_USE_ACTIVE, 1) == 0); llist_add_tail(&rab->entry, &map->ps_rabs); return rab; @@ -139,7 +139,7 @@ m->ctx.session_fi = rab->fi; m->ctx.session_use_count = &rab->use_count; m->ctx.session_use_token = "PFCP_MSG"; - osmo_use_count_get_put(m->ctx.session_use_count, m->ctx.session_use_token, 1); + OSMO_ASSERT(osmo_use_count_get_put(m->ctx.session_use_count, m->ctx.session_use_token, 1) == 0); } static struct osmo_pfcp_msg *ps_rab_new_pfcp_msg_req(struct ps_rab *rab, enum osmo_pfcp_message_type msg_type) @@ -663,7 +663,7 @@ static void ps_rab_fsm_wait_use_count_onenter(struct osmo_fsm_inst *fi, uint32_t prev_state) { struct ps_rab *rab = fi->priv; - osmo_use_count_get_put(&rab->use_count, PS_RAB_USE_ACTIVE, -1); + OSMO_ASSERT(osmo_use_count_get_put(&rab->use_count, PS_RAB_USE_ACTIVE, -1) == 0); } static void ps_rab_fsm_allstate_action(struct osmo_fsm_inst *fi, uint32_t event, void *data) -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29072 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Idcb3d6796326b059280b0e552eb36067ba15b3ac Gerrit-Change-Number: 29072 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 10 months

1
0
0 0

Change in osmo-ci[master]: obs: meaningful error if debian/changelog is empty

by daniel

Attention is currently required from: osmith, neels, fixeria. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29097 ) Change subject: obs: meaningful error if debian/changelog is empty ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29097 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I294d844ccccfa12599b6ba1def087e4a32d289e7 Gerrit-Change-Number: 29097 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 17 Aug 2022 14:29:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in osmo-hnbgw[master]: optimize: decode PS msgs only when PFCP is enabled

by neels

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29003 ) Change subject: optimize: decode PS msgs only when PFCP is enabled ...................................................................... Patch Set 3: Code-Review+2 (1 comment) Patchset: PS3: combine votes -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29003 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ifb57bad6a0d5ff263e4c6c3facc51620e110e7d2 Gerrit-Change-Number: 29003 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 17 Aug 2022 14:25:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in osmo-hnbgw[master]: ps_rab_fsm: check use cb success

by neels

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29072 ) Change subject: ps_rab_fsm: check use cb success ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: combine votes -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29072 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Idcb3d6796326b059280b0e552eb36067ba15b3ac Gerrit-Change-Number: 29072 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 17 Aug 2022 14:25:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in osmo-pcu[master]: Migrate to libosmocsn1 and libosmo-gprs-rlcmac

by daniel

Attention is currently required from: fixeria. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/28972 ) Change subject: Migrate to libosmocsn1 and libosmo-gprs-rlcmac ...................................................................... Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/28972 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Icba62ad8649e78acab711392dfd74fe571474381 Gerrit-Change-Number: 28972 Gerrit-PatchSet: 6 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 17 Aug 2022 14:21:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in osmo-ci[master]: osmocom-list-commits: use proper git clone urls

by daniel

Attention is currently required from: osmith, fixeria. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29119 ) Change subject: osmocom-list-commits: use proper git clone urls ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29119 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I2acb9880be57411f11805a2195076b514156aaf3 Gerrit-Change-Number: 29119 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 17 Aug 2022 14:15:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in libosmocore[master]: use_count: Return if uc is NULL

by daniel

daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/29121 ) Change subject: use_count: Return if uc is NULL ...................................................................... use_count: Return if uc is NULL The documentation for osmo_use_count_get_put states the return value is "Negative on range violations or USE_LIST == NULL, the use_cb()'s return value, or 0 on success" However, the code in _osmo_use_count_get_put doesn't check if uc is NULL - instead it would crash in osmo_use_count_find() where it is dereferenced. Add a check for uc and return -EINVAL if it is NULL. Change-Id: I792563696860a3100e95cafdd5fe57511819ef56 Related: SYS#5895 --- M src/use_count.c 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/21/29121/1 diff --git a/src/use_count.c b/src/use_count.c index 6c52899..9714403 100644 --- a/src/use_count.c +++ b/src/use_count.c @@ -235,6 +235,8 @@ { struct osmo_use_count_entry *e; int32_t old_use_count; + if (!uc) + return -EINVAL; if (!change) return 0; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/29121 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I792563696860a3100e95cafdd5fe57511819ef56 Gerrit-Change-Number: 29121 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 10 months

1
0
0 0

2025

2024

2023

2022

gerrit-log August 2022